This is an archive of the discontinued LLVM Phabricator instance.

[MIR] Fix CFI_INSTRUCTION escape printing
ClosedPublic

Authored by scott.linder on Jun 24 2020, 9:45 AM.

Details

Summary

The printer seems to intend to not print the trailing comma but has a
copy-paste error for the last value in the escape, and the parser
enforces having no trailing comma, but somehow a test was never included
to actually confirm it.

Diff Detail

Unit TestsFailed

Event Timeline

scott.linder created this revision.Jun 24 2020, 9:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2020, 9:45 AM
arsenm added a subscriber: arsenm.Jun 24 2020, 9:49 AM
arsenm added inline comments.
llvm/test/CodeGen/MIR/Generic/cfi-escape.mir
1–2

Don't think you need the intermediate file

9

Don't need the IR section

scott.linder marked 2 inline comments as done.

Simplify test

arsenm accepted this revision.Jun 24 2020, 11:57 AM
This revision is now accepted and ready to land.Jun 24 2020, 11:57 AM
thegameg accepted this revision.Jun 24 2020, 1:24 PM
This revision was automatically updated to reflect the committed changes.