This patch adds support for constrained conversion operation (uitofp/sitofp) on PowerPC.
Details
- Reviewers
nemanjai jsji kbarton kpn steven.zhang uweigand - Group Reviewers
Restricted Project - Commits
- rGa5b7b8cce022: [PowerPC] Support constrained scalar sitofp/uitofp
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
Reflect changes after strict conversion for SPE and enable-ppc-quad-precision's removal.
A few comments inline, otherwise this looks good.
llvm/lib/Target/PowerPC/PPCISelLowering.cpp | ||
---|---|---|
8304 | Shouldn't you pass an empty chain to convertIntToFP for non-strict operations? | |
llvm/lib/Target/PowerPC/PPCInstr64Bit.td | ||
1587 | Is there any reason for not just matching them in the original patterns via PPCany_... operators like elsewhere? Also, need to verify the mayRaiseFPException flags for those patterns. | |
llvm/lib/Target/PowerPC/PPCInstrVSX.td | ||
2440 | Same comment as above. |
- Use PPCany_* to restructure tblgen file
- Add mayRaiseFPException flag to fcfid*
- Add default argument to convertIntToFp
Thanks for patient comments!
You don't need to have two overloaded functions, but with one to have an array of ops.