Page MenuHomePhabricator

[Clang][OpenMP][OMPBuilder] (3/4) Privatize `parallel` for `OMPBuilder`
Needs ReviewPublic

Authored by fghanim on Jun 9 2020, 10:06 AM.

Details

Reviewers
jdoerfert
Summary

Adding support / implementation for copyin in OMPBuilder's
implementation of omp parallel

Diff Detail

Unit TestsFailed

TimeTest
1,420 msClang.OpenMP::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang/llvm-project/build/bin/clang -cc1 -internal-isystem /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang/llvm-project/build/lib/clang/11.0.0/include -nostdsysteminc -verify -fopenmp -fnoopenmp-use-tls -x c++ -triple x86_64-linux -emit-llvm /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang/llvm-project/clang/test/OpenMP/parallel_copyin_codegen.cpp -o - | /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang/llvm-project/clang/test/OpenMP/parallel_copyin_codegen.cpp -check-prefixes=ALL,CHECK
810 msClang.OpenMP::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; c:\ws\prod\llvm-project\build\bin\clang.exe -cc1 -internal-isystem c:\ws\prod\llvm-project\build\lib\clang\11.0.0\include -nostdsysteminc -verify -fopenmp -fnoopenmp-use-tls -x c++ -triple x86_64-linux -emit-llvm C:\ws\prod\llvm-project\clang\test\OpenMP\parallel_copyin_codegen.cpp -o - | c:\ws\prod\llvm-project\build\bin\filecheck.exe C:\ws\prod\llvm-project\clang\test\OpenMP\parallel_copyin_codegen.cpp -check-prefixes=ALL,CHECK

Event Timeline

fghanim created this revision.Jun 9 2020, 10:06 AM
fghanim marked 3 inline comments as done.Jun 9 2020, 10:23 AM
fghanim added inline comments.
clang/lib/CodeGen/CGStmtOpenMP.cpp
1554

Note to reviewers:
This keeps most of old implementation of copyin clause, except it uses part of the OMPBuilder now. Changes are noted below.

1582

added following few lines

1600

Wherever needed - changed the following section to use OMPBuilder