This is an archive of the discontinued LLVM Phabricator instance.

Differential D80871

[Object] Add DF_1_PIE
ClosedPublic

Authored by MaskRay on May 30 2020, 10:42 AM.

Details

Reviewers
grimar
jhenderson
• espindola
Commits
rGd9943e7f0ce8: [Object] Add DF_1_PIE
Summary

This flag (and the whole field DT_FLAGS_1) originated from Solaris. I intend to use it in an LLD patch D80872.

Diff Detail

Event Timeline

MaskRay created this revision.May 30 2020, 10:42 AM
Herald added a reviewer: • espindola. · View Herald TranscriptMay 30 2020, 10:42 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, rupprecht, fedor.sergeev, emaste. · View Herald Transcript
MaskRay edited the summary of this revision. (Show Details)May 30 2020, 10:43 AM
Harbormaster failed remote builds in B58545: Diff 267463!May 30 2020, 12:11 PM
emaste added a comment.May 30 2020, 1:16 PM

LGTM

jhenderson accepted this revision.Jun 1 2020, 1:50 AM

LGTM.

llvm/include/llvm/BinaryFormat/ELF.h
1299–1300

There's an obvious gap here: what is 0x04000000? Should we support that too?

This revision is now accepted and ready to land.Jun 1 2020, 1:50 AM
MaskRay marked an inline comment as done.Jun 1 2020, 8:44 AM
MaskRay added inline comments.
llvm/include/llvm/BinaryFormat/ELF.h
1299–1300

0x04000000 is DF_1_STUB, stub object https://docs.oracle.com/cd/E36784_01/html/E36857/chapter2-22.html#scrolltoc

binutils does not use it. I leave it out because it is not clear it is useful. (Bazel has an interface shared object which may use the flag.)

Closed by commit rGd9943e7f0ce8: [Object] Add DF_1_PIE (authored by MaskRay). · Explain WhyJun 1 2020, 9:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
include/
llvm/
BinaryFormat/
3 lines
test/
tools/
llvm-readobj/
ELF/
8 lines
tools/
llvm-readobj/
3 lines

Diff 267643

llvm/include/llvm/BinaryFormat/ELF.h

Show First 20 Lines • Show All 1,290 Lines • ▼ Show 20 Linesenum {
DF_1_NODIRECT = 0x00020000, // Object has no-direct binding. DF_1_NODIRECT = 0x00020000, // Object has no-direct binding.
DF_1_IGNMULDEF = 0x00040000, DF_1_IGNMULDEF = 0x00040000,
DF_1_NOKSYMS = 0x00080000, DF_1_NOKSYMS = 0x00080000,
DF_1_NOHDR = 0x00100000, DF_1_NOHDR = 0x00100000,
DF_1_EDITED = 0x00200000, // Object is modified after built. DF_1_EDITED = 0x00200000, // Object is modified after built.
DF_1_NORELOC = 0x00400000, DF_1_NORELOC = 0x00400000,
DF_1_SYMINTPOSE = 0x00800000, // Object has individual interposers. DF_1_SYMINTPOSE = 0x00800000, // Object has individual interposers.
DF_1_GLOBAUDIT = 0x01000000, // Global auditing required. DF_1_GLOBAUDIT = 0x01000000, // Global auditing required.
DF_1_SINGLETON = 0x02000000 // Singleton symbols are used. DF_1_SINGLETON = 0x02000000, // Singleton symbols are used.
DF_1_PIE = 0x08000000, // Object is a position-independent executable.
jhendersonUnsubmitted
Not Done
ReplyInline Actions

There's an obvious gap here: what is 0x04000000? Should we support that too?

jhenderson: There's an obvious gap here: what is `0x04000000`? Should we support that too?
MaskRayAuthorUnsubmitted
Done
ReplyInline Actions

0x04000000 is DF_1_STUB, stub object https://docs.oracle.com/cd/E36784_01/html/E36857/chapter2-22.html#scrolltoc

binutils does not use it. I leave it out because it is not clear it is useful. (Bazel has an interface shared object which may use the flag.)

MaskRay: 0x04000000 is DF_1_STUB, stub object https://docs.oracle.com/cd/E36784_01/html/E36857/chapter2…
}; };
// DT_MIPS_FLAGS values. // DT_MIPS_FLAGS values.
enum { enum {
RHF_NONE = 0x00000000, // No flags. RHF_NONE = 0x00000000, // No flags.
RHF_QUICKSTART = 0x00000001, // Uses shortcut pointers. RHF_QUICKSTART = 0x00000001, // Uses shortcut pointers.
RHF_NOTPOT = 0x00000002, // Hash size is not a power of two. RHF_NOTPOT = 0x00000002, // Hash size is not a power of two.
RHS_NO_LIBRARY_REPLACEMENT = 0x00000004, // Ignore LD_LIBRARY_PATH. RHS_NO_LIBRARY_REPLACEMENT = 0x00000004, // Ignore LD_LIBRARY_PATH.
▲ Show 20 Lines • Show All 273 Lines • Show Last 20 Lines

llvm/test/tools/llvm-readobj/ELF/dynamic-tags.test

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Lines
# LLVM64-NEXT: 0x000000006FFFE000 ANDROID_RELR 0x1000 # LLVM64-NEXT: 0x000000006FFFE000 ANDROID_RELR 0x1000
# LLVM64-NEXT: 0x000000006FFFE001 ANDROID_RELRSZ 0x10 # LLVM64-NEXT: 0x000000006FFFE001 ANDROID_RELRSZ 0x10
# LLVM64-NEXT: 0x000000006FFFE003 ANDROID_RELRENT 0x1234 # LLVM64-NEXT: 0x000000006FFFE003 ANDROID_RELRENT 0x1234
# LLVM64-NEXT: 0x000000006FFFFEF5 GNU_HASH 0x1000 # LLVM64-NEXT: 0x000000006FFFFEF5 GNU_HASH 0x1000
# LLVM64-NEXT: 0x000000006FFFFEF6 TLSDESC_PLT 0x1000 # LLVM64-NEXT: 0x000000006FFFFEF6 TLSDESC_PLT 0x1000
# LLVM64-NEXT: 0x000000006FFFFEF7 TLSDESC_GOT 0x1000 # LLVM64-NEXT: 0x000000006FFFFEF7 TLSDESC_GOT 0x1000
# LLVM64-NEXT: 0x000000006FFFFFF9 RELACOUNT 0 # LLVM64-NEXT: 0x000000006FFFFFF9 RELACOUNT 0
# LLVM64-NEXT: 0x000000006FFFFFFA RELCOUNT 0 # LLVM64-NEXT: 0x000000006FFFFFFA RELCOUNT 0
# LLVM64-NEXT: 0x000000006FFFFFFB FLAGS_1 NOW GLOBAL GROUP NODELETE LOADFLTR INITFIRST NOOPEN ORIGIN DIRECT TRANS INTERPOSE NODEFLIB NODUMP CONFALT ENDFILTEE DISPRELDNE DISPRELPND NODIRECT IGNMULDEF NOKSYMS NOHDR EDITED NORELOC SYMINTPOSE GLOBAUDIT SINGLETON {{$}} # LLVM64-NEXT: 0x000000006FFFFFFB FLAGS_1 NOW GLOBAL GROUP NODELETE LOADFLTR INITFIRST NOOPEN ORIGIN DIRECT TRANS INTERPOSE NODEFLIB NODUMP CONFALT ENDFILTEE DISPRELDNE DISPRELPND NODIRECT IGNMULDEF NOKSYMS NOHDR EDITED NORELOC SYMINTPOSE GLOBAUDIT SINGLETON PIE {{$}}
# LLVM64-NEXT: 0x000000006FFFFFF0 VERSYM 0x1000 # LLVM64-NEXT: 0x000000006FFFFFF0 VERSYM 0x1000
# LLVM64-NEXT: 0x000000006FFFFFFC VERDEF 0x1000 # LLVM64-NEXT: 0x000000006FFFFFFC VERDEF 0x1000
# LLVM64-NEXT: 0x000000006FFFFFFD VERDEFNUM 0 # LLVM64-NEXT: 0x000000006FFFFFFD VERDEFNUM 0
# LLVM64-NEXT: 0x000000006FFFFFFE VERNEED 0x1000 # LLVM64-NEXT: 0x000000006FFFFFFE VERNEED 0x1000
# LLVM64-NEXT: 0x000000006FFFFFFF VERNEEDNUM 0 # LLVM64-NEXT: 0x000000006FFFFFFF VERNEEDNUM 0
# LLVM64-NEXT: 0x000000007FFFFFFD AUXILIARY Auxiliary library: [D] # LLVM64-NEXT: 0x000000007FFFFFFD AUXILIARY Auxiliary library: [D]
# LLVM64-NEXT: 0x000000007FFFFFFE USED Not needed object: [U] # LLVM64-NEXT: 0x000000007FFFFFFE USED Not needed object: [U]
# LLVM64-NEXT: 0x000000007FFFFFFF FILTER Filter library: [U] # LLVM64-NEXT: 0x000000007FFFFFFF FILTER Filter library: [U]
▲ Show 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
# GNU64-NEXT: 0x000000006fffe000 (ANDROID_RELR) 0x1000 # GNU64-NEXT: 0x000000006fffe000 (ANDROID_RELR) 0x1000
# GNU64-NEXT: 0x000000006fffe001 (ANDROID_RELRSZ) 0x10 # GNU64-NEXT: 0x000000006fffe001 (ANDROID_RELRSZ) 0x10
# GNU64-NEXT: 0x000000006fffe003 (ANDROID_RELRENT) 0x1234 # GNU64-NEXT: 0x000000006fffe003 (ANDROID_RELRENT) 0x1234
# GNU64-NEXT: 0x000000006ffffef5 (GNU_HASH) 0x1000 # GNU64-NEXT: 0x000000006ffffef5 (GNU_HASH) 0x1000
# GNU64-NEXT: 0x000000006ffffef6 (TLSDESC_PLT) 0x1000 # GNU64-NEXT: 0x000000006ffffef6 (TLSDESC_PLT) 0x1000
# GNU64-NEXT: 0x000000006ffffef7 (TLSDESC_GOT) 0x1000 # GNU64-NEXT: 0x000000006ffffef7 (TLSDESC_GOT) 0x1000
# GNU64-NEXT: 0x000000006ffffff9 (RELACOUNT) 0 # GNU64-NEXT: 0x000000006ffffff9 (RELACOUNT) 0
# GNU64-NEXT: 0x000000006ffffffa (RELCOUNT) 0 # GNU64-NEXT: 0x000000006ffffffa (RELCOUNT) 0
# GNU64-NEXT: 0x000000006ffffffb (FLAGS_1) NOW GLOBAL GROUP NODELETE LOADFLTR INITFIRST NOOPEN ORIGIN DIRECT TRANS INTERPOSE NODEFLIB NODUMP CONFALT ENDFILTEE DISPRELDNE DISPRELPND NODIRECT IGNMULDEF NOKSYMS NOHDR EDITED NORELOC SYMINTPOSE GLOBAUDIT SINGLETON {{$}} # GNU64-NEXT: 0x000000006ffffffb (FLAGS_1) NOW GLOBAL GROUP NODELETE LOADFLTR INITFIRST NOOPEN ORIGIN DIRECT TRANS INTERPOSE NODEFLIB NODUMP CONFALT ENDFILTEE DISPRELDNE DISPRELPND NODIRECT IGNMULDEF NOKSYMS NOHDR EDITED NORELOC SYMINTPOSE GLOBAUDIT SINGLETON PIE {{$}}
# GNU64-NEXT: 0x000000006ffffff0 (VERSYM) 0x1000 # GNU64-NEXT: 0x000000006ffffff0 (VERSYM) 0x1000
# GNU64-NEXT: 0x000000006ffffffc (VERDEF) 0x1000 # GNU64-NEXT: 0x000000006ffffffc (VERDEF) 0x1000
# GNU64-NEXT: 0x000000006ffffffd (VERDEFNUM) 0 # GNU64-NEXT: 0x000000006ffffffd (VERDEFNUM) 0
# GNU64-NEXT: 0x000000006ffffffe (VERNEED) 0x1000 # GNU64-NEXT: 0x000000006ffffffe (VERNEED) 0x1000
# GNU64-NEXT: 0x000000006fffffff (VERNEEDNUM) 0 # GNU64-NEXT: 0x000000006fffffff (VERNEEDNUM) 0
# GNU64-NEXT: 0x000000007ffffffd (AUXILIARY) Auxiliary library: [D] # GNU64-NEXT: 0x000000007ffffffd (AUXILIARY) Auxiliary library: [D]
# GNU64-NEXT: 0x000000007ffffffe (USED) Not needed object: [U] # GNU64-NEXT: 0x000000007ffffffe (USED) Not needed object: [U]
# GNU64-NEXT: 0x000000007fffffff (FILTER) Filter library: [U] # GNU64-NEXT: 0x000000007fffffff (FILTER) Filter library: [U]
▲ Show 20 Lines • Show All 208 Lines • ▼ Show 20 Lines
# LLVM32-NEXT: 0x6FFFE000 ANDROID_RELR 0x1000 # LLVM32-NEXT: 0x6FFFE000 ANDROID_RELR 0x1000
# LLVM32-NEXT: 0x6FFFE001 ANDROID_RELRSZ 0x10 # LLVM32-NEXT: 0x6FFFE001 ANDROID_RELRSZ 0x10
# LLVM32-NEXT: 0x6FFFE003 ANDROID_RELRENT 0x1234 # LLVM32-NEXT: 0x6FFFE003 ANDROID_RELRENT 0x1234
# LLVM32-NEXT: 0x6FFFFEF5 GNU_HASH 0x1000 # LLVM32-NEXT: 0x6FFFFEF5 GNU_HASH 0x1000
# LLVM32-NEXT: 0x6FFFFEF6 TLSDESC_PLT 0x1000 # LLVM32-NEXT: 0x6FFFFEF6 TLSDESC_PLT 0x1000
# LLVM32-NEXT: 0x6FFFFEF7 TLSDESC_GOT 0x1000 # LLVM32-NEXT: 0x6FFFFEF7 TLSDESC_GOT 0x1000
# LLVM32-NEXT: 0x6FFFFFF9 RELACOUNT 0 # LLVM32-NEXT: 0x6FFFFFF9 RELACOUNT 0
# LLVM32-NEXT: 0x6FFFFFFA RELCOUNT 0 # LLVM32-NEXT: 0x6FFFFFFA RELCOUNT 0
# LLVM32-NEXT: 0x6FFFFFFB FLAGS_1 NOW GLOBAL GROUP NODELETE LOADFLTR INITFIRST NOOPEN ORIGIN DIRECT TRANS INTERPOSE NODEFLIB NODUMP CONFALT ENDFILTEE DISPRELDNE DISPRELPND NODIRECT IGNMULDEF NOKSYMS NOHDR EDITED NORELOC SYMINTPOSE GLOBAUDIT SINGLETON {{$}} # LLVM32-NEXT: 0x6FFFFFFB FLAGS_1 NOW GLOBAL GROUP NODELETE LOADFLTR INITFIRST NOOPEN ORIGIN DIRECT TRANS INTERPOSE NODEFLIB NODUMP CONFALT ENDFILTEE DISPRELDNE DISPRELPND NODIRECT IGNMULDEF NOKSYMS NOHDR EDITED NORELOC SYMINTPOSE GLOBAUDIT SINGLETON PIE {{$}}
# LLVM32-NEXT: 0x6FFFFFF0 VERSYM 0x1000 # LLVM32-NEXT: 0x6FFFFFF0 VERSYM 0x1000
# LLVM32-NEXT: 0x6FFFFFFC VERDEF 0x1000 # LLVM32-NEXT: 0x6FFFFFFC VERDEF 0x1000
# LLVM32-NEXT: 0x6FFFFFFD VERDEFNUM 0 # LLVM32-NEXT: 0x6FFFFFFD VERDEFNUM 0
# LLVM32-NEXT: 0x6FFFFFFE VERNEED 0x1000 # LLVM32-NEXT: 0x6FFFFFFE VERNEED 0x1000
# LLVM32-NEXT: 0x6FFFFFFF VERNEEDNUM 0 # LLVM32-NEXT: 0x6FFFFFFF VERNEEDNUM 0
# LLVM32-NEXT: 0x7FFFFFFD AUXILIARY Auxiliary library: [D] # LLVM32-NEXT: 0x7FFFFFFD AUXILIARY Auxiliary library: [D]
# LLVM32-NEXT: 0x7FFFFFFE USED Not needed object: [U] # LLVM32-NEXT: 0x7FFFFFFE USED Not needed object: [U]
# LLVM32-NEXT: 0x7FFFFFFF FILTER Filter library: [U] # LLVM32-NEXT: 0x7FFFFFFF FILTER Filter library: [U]
▲ Show 20 Lines • Show All 48 Lines • ▼ Show 20 Lines
# GNU32-NEXT: 0x6fffe000 (ANDROID_RELR) 0x1000 # GNU32-NEXT: 0x6fffe000 (ANDROID_RELR) 0x1000
# GNU32-NEXT: 0x6fffe001 (ANDROID_RELRSZ) 0x10 # GNU32-NEXT: 0x6fffe001 (ANDROID_RELRSZ) 0x10
# GNU32-NEXT: 0x6fffe003 (ANDROID_RELRENT) 0x1234 # GNU32-NEXT: 0x6fffe003 (ANDROID_RELRENT) 0x1234
# GNU32-NEXT: 0x6ffffef5 (GNU_HASH) 0x1000 # GNU32-NEXT: 0x6ffffef5 (GNU_HASH) 0x1000
# GNU32-NEXT: 0x6ffffef6 (TLSDESC_PLT) 0x1000 # GNU32-NEXT: 0x6ffffef6 (TLSDESC_PLT) 0x1000
# GNU32-NEXT: 0x6ffffef7 (TLSDESC_GOT) 0x1000 # GNU32-NEXT: 0x6ffffef7 (TLSDESC_GOT) 0x1000
# GNU32-NEXT: 0x6ffffff9 (RELACOUNT) 0 # GNU32-NEXT: 0x6ffffff9 (RELACOUNT) 0
# GNU32-NEXT: 0x6ffffffa (RELCOUNT) 0 # GNU32-NEXT: 0x6ffffffa (RELCOUNT) 0
# GNU32-NEXT: 0x6ffffffb (FLAGS_1) NOW GLOBAL GROUP NODELETE LOADFLTR INITFIRST NOOPEN ORIGIN DIRECT TRANS INTERPOSE NODEFLIB NODUMP CONFALT ENDFILTEE DISPRELDNE DISPRELPND NODIRECT IGNMULDEF NOKSYMS NOHDR EDITED NORELOC SYMINTPOSE GLOBAUDIT SINGLETON {{$}} # GNU32-NEXT: 0x6ffffffb (FLAGS_1) NOW GLOBAL GROUP NODELETE LOADFLTR INITFIRST NOOPEN ORIGIN DIRECT TRANS INTERPOSE NODEFLIB NODUMP CONFALT ENDFILTEE DISPRELDNE DISPRELPND NODIRECT IGNMULDEF NOKSYMS NOHDR EDITED NORELOC SYMINTPOSE GLOBAUDIT SINGLETON PIE {{$}}
# GNU32-NEXT: 0x6ffffff0 (VERSYM) 0x1000 # GNU32-NEXT: 0x6ffffff0 (VERSYM) 0x1000
# GNU32-NEXT: 0x6ffffffc (VERDEF) 0x1000 # GNU32-NEXT: 0x6ffffffc (VERDEF) 0x1000
# GNU32-NEXT: 0x6ffffffd (VERDEFNUM) 0 # GNU32-NEXT: 0x6ffffffd (VERDEFNUM) 0
# GNU32-NEXT: 0x6ffffffe (VERNEED) 0x1000 # GNU32-NEXT: 0x6ffffffe (VERNEED) 0x1000
# GNU32-NEXT: 0x6fffffff (VERNEEDNUM) 0 # GNU32-NEXT: 0x6fffffff (VERNEEDNUM) 0
# GNU32-NEXT: 0x7ffffffd (AUXILIARY) Auxiliary library: [D] # GNU32-NEXT: 0x7ffffffd (AUXILIARY) Auxiliary library: [D]
# GNU32-NEXT: 0x7ffffffe (USED) Not needed object: [U] # GNU32-NEXT: 0x7ffffffe (USED) Not needed object: [U]
# GNU32-NEXT: 0x7fffffff (FILTER) Filter library: [U] # GNU32-NEXT: 0x7fffffff (FILTER) Filter library: [U]
▲ Show 20 Lines • Show All 214 Lines • Show Last 20 Lines

llvm/tools/llvm-readobj/ELFDumper.cpp

Show First 20 Lines • Show All 2,344 Lines • ▼ Show 20 Linesstatic const EnumEntry<unsigned> ElfDynamicDTFlags1[] = {
LLVM_READOBJ_DT_FLAG_ENT(DF_1, NODIRECT), LLVM_READOBJ_DT_FLAG_ENT(DF_1, NODIRECT),
LLVM_READOBJ_DT_FLAG_ENT(DF_1, IGNMULDEF), LLVM_READOBJ_DT_FLAG_ENT(DF_1, IGNMULDEF),
LLVM_READOBJ_DT_FLAG_ENT(DF_1, NOKSYMS), LLVM_READOBJ_DT_FLAG_ENT(DF_1, NOKSYMS),
LLVM_READOBJ_DT_FLAG_ENT(DF_1, NOHDR), LLVM_READOBJ_DT_FLAG_ENT(DF_1, NOHDR),
LLVM_READOBJ_DT_FLAG_ENT(DF_1, EDITED), LLVM_READOBJ_DT_FLAG_ENT(DF_1, EDITED),
LLVM_READOBJ_DT_FLAG_ENT(DF_1, NORELOC), LLVM_READOBJ_DT_FLAG_ENT(DF_1, NORELOC),
LLVM_READOBJ_DT_FLAG_ENT(DF_1, SYMINTPOSE), LLVM_READOBJ_DT_FLAG_ENT(DF_1, SYMINTPOSE),
LLVM_READOBJ_DT_FLAG_ENT(DF_1, GLOBAUDIT), LLVM_READOBJ_DT_FLAG_ENT(DF_1, GLOBAUDIT),
LLVM_READOBJ_DT_FLAG_ENT(DF_1, SINGLETON) LLVM_READOBJ_DT_FLAG_ENT(DF_1, SINGLETON),
LLVM_READOBJ_DT_FLAG_ENT(DF_1, PIE),
}; };
static const EnumEntry<unsigned> ElfDynamicDTMipsFlags[] = { static const EnumEntry<unsigned> ElfDynamicDTMipsFlags[] = {
LLVM_READOBJ_DT_FLAG_ENT(RHF, NONE), LLVM_READOBJ_DT_FLAG_ENT(RHF, NONE),
LLVM_READOBJ_DT_FLAG_ENT(RHF, QUICKSTART), LLVM_READOBJ_DT_FLAG_ENT(RHF, QUICKSTART),
LLVM_READOBJ_DT_FLAG_ENT(RHF, NOTPOT), LLVM_READOBJ_DT_FLAG_ENT(RHF, NOTPOT),
LLVM_READOBJ_DT_FLAG_ENT(RHS, NO_LIBRARY_REPLACEMENT), LLVM_READOBJ_DT_FLAG_ENT(RHS, NO_LIBRARY_REPLACEMENT),
LLVM_READOBJ_DT_FLAG_ENT(RHF, NO_MOVE), LLVM_READOBJ_DT_FLAG_ENT(RHF, NO_MOVE),
▲ Show 20 Lines • Show All 4,510 Lines • Show Last 20 Lines