Page MenuHomePhabricator
Differential D80689

[MLIR][OpenMP] Defined master operation in OpenMP Dialect
ClosedPublic
Actions

Authored by anchu-rajendran on May 27 2020, 10:50 PM.

Details

Reviewers
jdoerfert
kiranchandramohan
mehdi_amini
DavidTruby
ftynse
Commits
rGdbb5979d158c: [MLIR][OpenMP] Defined master operation in OpenMP Dialect
Summary

Implemented the basic changes for defining master operation in OpenMP.
It uses the generic parser and printer.

Diff Detail

Event Timeline

anchu-rajendran created this revision.May 27 2020, 10:50 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptMay 27 2020, 10:50 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, sstefan1, jurahul and 17 others. · View Herald Transcript
Harbormaster failed remote builds in B58164: Diff 266744!May 27 2020, 10:53 PM
anchu-rajendran added reviewers: kiranchandramohan, DavidTruby, ftynse, kiranktp.May 27 2020, 10:57 PM
anchu-rajendran updated this revision to Diff 266748.May 27 2020, 11:02 PM

Formatting changes : removed an extra newline

Harbormaster failed remote builds in B58165: Diff 266748!May 27 2020, 11:24 PM
anchu-rajendran added a project: Restricted Project.May 27 2020, 11:45 PM
anchu-rajendran added a reviewer: mehdi_amini.
SouraVX added a subscriber: SouraVX.May 28 2020, 2:14 AM
kiranchandramohan added a comment.May 28 2020, 10:25 AM

It uses the custom parser and printer.

Do you mean the generic parser and printer?

anchu-rajendran updated this revision to Diff 267116.May 28 2020, 8:41 PM
anchu-rajendran edited the summary of this revision. (Show Details)
anchu-rajendran removed reviewers: kiranchandramohan, DavidTruby, ftynse, kiranktp, mehdi_amini.
anchu-rajendran removed a project: Restricted Project.
anchu-rajendran removed a subscriber: SouraVX.

Summary of the change is modified.

anchu-rajendran added a subscriber: kiranchandramohan.May 28 2020, 8:42 PM
In D80689#2060706, @kiranchandramohan wrote:

It uses the custom parser and printer.

Do you mean the generic parser and printer?

Hi, Yes, I have meant to state that. Thank You! I have modified the summary.

anchu-rajendran added reviewers: kiranchandramohan, mehdi_amini, DavidTruby, ftynse.May 28 2020, 8:44 PM
anchu-rajendran added a project: Restricted Project.May 28 2020, 9:24 PM
anchu-rajendran added a subscriber: SouraVX.
Harbormaster completed remote builds in B58370: Diff 267116.May 28 2020, 9:55 PM
ftynse accepted this revision.May 29 2020, 3:11 AM
This revision is now accepted and ready to land.May 29 2020, 3:11 AM
kiranchandramohan accepted this revision.May 29 2020, 7:18 AM

LGTM.

Closed by commit rGdbb5979d158c: [MLIR][OpenMP] Defined master operation in OpenMP Dialect (authored by anchu-rajendran). · Explain WhyMay 29 2020, 10:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
OpenMP/
19 lines
test/
Dialect/
OpenMP/
11 lines

Diff 266744

View Options

mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td

Loading...
View Options

mlir/test/Dialect/OpenMP/ops.mlir

Loading...