Looks good to me!

LGTM :). Thanks!

The change looks good to me. Thanks!

ping @klausler. If there are further improvements to be made, can you please suggest those. I have raised a few concerns related to questions which you have posted before.

In D80689#2060706, @kiranchandramohan wrote:

It uses the custom parser and printer.

Do you mean the generic parser and printer?

Summary of the change is modified.

Formatting changes : removed an extra newline

ping!

Added a test with derived type for C876 checking the object should not be in blank COMMON

Updated IsAutomaticObject to return false if the symbol is an allocatable or a pointer and test cases are added to data04.f90

Removed the err variable while handling Component

Reduced the use of state variables while handling component
Added code to check constraints on subscripts and restricted pointers inside subscript.

Ping @klausler . Can you please take another look and let me know if any concerns need to be addressed. I have tried to address your comments.

Made changes to update the variable symbolCheckStatus correctly.

• Addressed the review comments
• Modified IsAutomaticArray to check all automatic objects as described in 3.11
• Added extra checks to emit error if right most pointer reference in a component is subscripted (C877)

@klausler , Thank you for the review comments! I have made the suggested changes.

In D78424#2002860, @klausler wrote:

https://reviews.llvm.org/D78834 contains the patch that reworks check-data.{h,cpp} to check typed expressions rather than the raw parse tree. Please adjust this change to do the same, if possible.

In D78424#2002860, @klausler wrote:

https://reviews.llvm.org/D78834 contains the patch that reworks check-data.{h,cpp} to check typed expressions rather than the raw parse tree. Please adjust this change to do the same, if possible.

In D78424#1999895, @klausler wrote:

In D78424#1998443, @anchu-rajendran wrote:

In D78424#1993281, @kiranchandramohan wrote:

Thanks for addressing the comments.

Also check the following.

type t1
 integer, allocatable :: arr(:)
end type
type(t1) d1
data d1/t1((/0,1/))/

The current revision does not catch this error. I dont think this case is covered under the Constraint C876 (or C877)
C876 says a variable whose designator appears as a data-stmt-object shall not be an allocatable variable . This means d1 cannot be an allocatable (and it does not say anything about the fields of d1). In this case, d1 is not.

The code is in error because the structure constructor is not a constant expression in the sense of 10.1.12. I have a fix for this in my rework of DATA statement semantics in progress.

In D78424#1993281, @kiranchandramohan wrote:

Thanks for addressing the comments.

Also check the following.

type t1
 integer, allocatable :: arr(:)
end type
type(t1) d1
data d1/t1((/0,1/))/

Removed inline specifier from IsAutomaticArray

In D78424#1993281, @kiranchandramohan wrote:

Thanks for addressing the comments.

Also check the following.

type t1
 integer, allocatable :: arr(:)
end type
type(t1) d1
data d1/t1((/0,1/))/

Besides the constraints for the data statement, there are several other points mentioned in the data statement section. Like point 8 in 8.6.7 (test below) which says that the number of variables and data-statement-constants shall be the same. Are these outside the scope of your work? If so, please create a ticket somewhere so that we can come back to it later.

program mn
  character(len=3) :: n1, n2
  data n1, n2 / 'f18' /
end

Fixed a few corner cases:
Implemented a function: GetFirstName

• Abstracted the code to IsAutomaticArray Function.
• Added implementation to catch semantic bugs related to fields of derived type variables.
• Made the changes suggested.

@klausler, Current implementation of C877 may change and may depend on the modifications which will be made by you. I will make changes accordingly after your changes are merged.

In D78008#1989233, @klausler wrote:

I think you should just merge the code you have so I can clean it up here.

Changes in formatting

Fixed the formatting issues

Fixed the clang format problems