Page MenuHomePhabricator

Map -O to -O1 instead of -O2
ClosedPublic

Authored by MaskRay on Wed, May 13, 5:32 PM.

Details

Summary

rL82131 changed -O from -O1 to -O2, because -O1 was not different from
-O2 at that time.

GCC treats -O as -O1 and there is now work to make -O1 meaningful.
We can change -O back to -O1 again.

Diff Detail

Event Timeline

MaskRay created this revision.Wed, May 13, 5:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptWed, May 13, 5:32 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Actually it was http://llvm.org/r82131 that mapped -O to -O2 (I just refactored it). Originally it seems it was mapped to -O1.

Because this seems to have done quite intentionally, I'm a little vary of changing it back. I'm not sure who would be a good person to have insights here though.

+echristo maybe?

MaskRay updated this revision to Diff 264029.Thu, May 14, 10:49 AM
MaskRay edited the summary of this revision. (Show Details)

Update description

echristo accepted this revision.Fri, May 15, 4:57 PM
echristo added a reviewer: dexonsmith.

I'm totally down, but you knew that already :)

Duncan: Do you have any concerns? I doubt it, but just checking.

This revision is now accepted and ready to land.Fri, May 15, 4:57 PM

I'm totally down, but you knew that already :)

Duncan: Do you have any concerns? I doubt it, but just checking.

Xcode doesn't use -O. There could be some internal users, but I doubt it, and we can probably migrate them if this causes a problem. @arphaman, WDYT?

@Gerolf, I don't imagine you have any concerns, but thought I should double-check.

dexonsmith accepted this revision.Fri, May 15, 5:37 PM
dexonsmith added reviewers: arphaman, Gerolf.

IOW, this LGTM if Alex and Gerolf are happy.

arphaman accepted this revision.Mon, May 18, 3:42 PM

IOW, this LGTM if Alex and Gerolf are happy.

LGTM

IOW, this LGTM if Alex and Gerolf are happy.

Gerolf told me he has no concerns.

IOW, this LGTM if Alex and Gerolf are happy.

Gerolf told me he has no concerns.

Thanks! (I was just about to ask whether you have a quick channel to Gerolf :)

I'll re-test and commit.

This revision was automatically updated to reflect the committed changes.