[MachineVerifier] Use the for Range loop to instead llvm::any_of

[ZhangKang]

Summary

In the patch https://reviews.llvm.org/D78849, it uses llvm::any_of to instead of for loop to simplify the function addRequired ():
Below function

bool addRequired(const RegSet &RS) {
   bool changed = false;
   for (RegSet::const_iterator I = RS.begin(), E = RS.end(); I != E; ++I)
     if (addRequired(*I))
       changed = true;
   return changed;
}

will be simplified to:

bool addRequired(const RegSet &RS) {
     return llvm::any_of(
         RS, [this](unsigned Reg) { return this->addRequired(Reg); });
}

It's obvious that above code is not a NFC conversion. Because any_of will return if any addRequired(Reg) is true immediately, but we want all element to call addRequired(Reg).

This bug has caused 248 cases error for the Machine Verfication of LiveVariable pass.
This patch uses for range loop to fix llvm::any_of bug.

[MaskRay]

llvm/lib/CodeGen/MachineVerifier.cpp

172

s/const auto &/unsigned/

[nickdesaulniers]

My mistake. Thanks for the fix.

[ZhangKang]

Modify const auto &I to unsigned Reg.

[ZhangKang]

llvm/lib/CodeGen/MachineVerifier.cpp

172

Done.

[MaskRay]

Thanks!

[nickdesaulniers]

This bug has caused 248 cases error for the Machine Verfication of LiveVariable pass.

It might be good to add a test case that exercising this code.

[ZhangKang]

In D79872#2034453, @nickdesaulniers wrote:

This bug has caused 248 cases error for the Machine Verfication of LiveVariable pass.

It might be good to add a test case that exercising this code.

The existed bug will exposed if we use EXPENSIVE_CHECKS and enable the machine verification for LiveVariable pass.
Unfortunately, we can't enable machine verification for LiveVariable pass now, because this machine verification pass has other bugs.
This is why we didn't find this bug before, so there is no case until we fix all bug of machine verification for LiveVariable pass and enable it.

[ZhangKang]

Fix the format.

[ZhangKang]

This comment was removed by ZhangKang.

llvm/lib/CodeGen/MachineVerifier.cpp

struct BBInfo {
           return false;
         if (regsLiveOut.count(Reg))
           return false;
         return vregsRequired.insert(Reg).second;
       }
 
       // Same for a full set.
       bool addRequired(const RegSet &RS) {
-        return llvm::any_of(
-            RS, [this](unsigned Reg) { return this->addRequired(Reg); });
+        bool Changed = false;
+        for (unsigned Reg : RS)
+          Changed |= addRequired(Reg);
+        return Changed;
       }
 
       // Same for a full map.
       bool addRequired(const RegMap &RM) {
-        return llvm::any_of(
-            RM, [this](const auto &P) { return this->addRequired(P.first); });
+        bool Changed = false;
+        for (const auto &I : RM)
+          Changed |= addRequired(I.first);
+        return Changed;
       }
 
       // Live-out registers are either in regsLiveOut or vregsPassed.
       bool isLiveOut(unsigned Reg) const {
         return regsLiveOut.count(Reg) || vregsPassed.count(Reg);
       }
     };