Page MenuHomePhabricator

[MachineVerifier] retrofit iterators with range for. NFC
ClosedPublic

Authored by nickdesaulniers on Apr 24 2020, 6:30 PM.

Details

Summary

Reviewing failures identified in D78586, I was finding the identifiers
for these iterators hard to read.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptApr 24 2020, 6:30 PM
MaskRay accepted this revision.Apr 27 2020, 10:51 AM

Thanks!

This revision is now accepted and ready to land.Apr 27 2020, 10:51 AM
This revision was automatically updated to reflect the committed changes.
llvm/lib/CodeGen/MachineVerifier.cpp
178

build failures look like:

llvm/llvm/lib/CodeGen/MachineVerifier.cpp:178:70: error: cannot call member function ‘bool {anonymous}::MachineVerifier::BBInfo::addRequired(unsigned int)’ without object

error: void value not ignored as it ought to be

Not sure why I don't see these locally? Does the lambda need this->addRequired?

llvm/lib/CodeGen/MachineVerifier.cpp
178

g++ specific bug?
https://stackoverflow.com/questions/32097759/calling-this-member-function-from-generic-lambda-clang-vs-gcc
Are these builders using g++ to build clang? Logs say:
/usr/bin/c++

llvm/lib/CodeGen/MachineVerifier.cpp
178

I'm building clang with clang locally, so maybe that's it?