Page MenuHomePhabricator

Revert "[TLI] Per-function fveclib for math library used for vectorization"
ClosedPublic

Authored by mehdi_amini on Apr 10 2020, 6:03 PM.

Details

Summary

This reverts commit 60c642e74be6af86906d9f3d982728be7bd4329f.

This patch is making the TLI "closed" for a predefined set of VecLib
while at the moment it is extensible for anyone to customize when using
LLVM as a library.
Reverting while we figure out a way to re-land it without losing the
generality of the current API.

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 10 2020, 6:03 PM
This revision is now accepted and ready to land.Apr 10 2020, 6:05 PM
This revision was automatically updated to reflect the committed changes.
wenlei added a comment.Sat, May 2, 8:32 AM

@mehdi_amini @tejohnson When can we re-land this (with tweaks)? I'm under the impression that a test case demonstrating the 3rd party usage will be added very soon after this revert, then we can tweak the original patch to accommodate that usage, and re-land asap. Or am I missing something there? I'd like to get this unblocked asap. Currently we have to keep this as a private patch on our end which is a bit cumbersome, and I think this one can be useful for others too. Thanks..

Herald added a project: Restricted Project. · View Herald TranscriptSat, May 2, 8:32 AM

@mehdi_amini @tejohnson When can we re-land this (with tweaks)? I'm under the impression that a test case demonstrating the 3rd party usage will be added very soon after this revert, then we can tweak the original patch to accommodate that usage, and re-land asap. Or am I missing something there? I'd like to get this unblocked asap. Currently we have to keep this as a private patch on our end which is a bit cumbersome, and I think this one can be useful for others too. Thanks..

@bkramer can you work with Wenlei on this (original patch is D77632).

@wenlei, in the meantime you can see the use case here:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/compiler/xla/service/cpu/compiler_functor.cc#L198
for revising the patch.