This is a series of "fixes" for missing FileCheck directive colons found by https://reviews.llvm.org/D77227 that ended up breaking the offending test. More diagnosis definitely needed.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Thank you both!
For my own reference later:
c7e1fc8496dc2c6289c803f89d7a9eae9c2cbd01
f22445bf57606ffc9914777c228936d4b3f8140d
Comment Actions
@jroelofs Please can you rebase again? I think I've dealt with all the low hanging fruit now, so you will probably have to git blame to find code owners to help fix the remaining issues.
Comment Actions
@atanasyan there's one more case of this in llvm/test/CodeGen/Mips/ci2.ll. Looks like the constant has been de-duplicated since that test was written. Mind checking whether that's correct behavior for your target? (it does seem better, but I don't want to assume).
diff --git a/llvm/test/CodeGen/Mips/ci2.ll b/llvm/test/CodeGen/Mips/ci2.ll index 5e6b7814d5e..1b07df371eb 100644 --- a/llvm/test/CodeGen/Mips/ci2.ll +++ b/llvm/test/CodeGen/Mips/ci2.ll @@ -1,4 +1,4 @@ -; RUN: llc -mtriple=mipsel-linux-gnu -march=mipsel -mattr=mips16 -mattr=+soft-float -mips16-hard-float -relocation-model=static -mips16-constant-islands < %s | FileCheck %s -check-prefix=constisle +; RUN: llc -mtriple=mipsel-linux-gnu -march=mipsel -mattr=mips16 -mattr=+soft-float -mips16-hard-float -relocation-model=static -mips16-constant-islands < %s | FileCheck %s -check-prefix=CONSTISLE @i = common global i32 0, align 4 @b = common global i32 0, align 4 @@ -24,13 +24,11 @@ if.end: ; preds = %if.else, %if.then call void asm sideeffect ".space 100000", ""() #1, !srcloc !1 store i32 305419896, i32* @l, align 4 ret void -; constisle: $CPI0_1: -; constisle .4byte 305419896 # 0x12345678 -; constisle #APP -; constisle .space 100000 -; constisle #NO_APP -; constisle $CPI0_0: -; constisle .4byte 305419896 # 0x12345678 +; CONSTISLE: $CPI0_1: +; CONSTISLE: .4byte 305419896 # 0x12345678 +; CONSTISLE: #APP +; CONSTISLE: .space 100000 +; CONSTISLE: #NO_APP } attributes #0 = { nounwind "less-precise-fpmad"="false" "frame-pointer"="all" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="false" }