[DO NOT MERGE] added FileCheck colons that broke things

[jroelofs]

Summary

This is a series of "fixes" for missing FileCheck directive colons found by https://reviews.llvm.org/D77227 that ended up breaking the offending test. More diagnosis definitely needed.

[foad]

I have fixed some of the obvious mistakes in CodeGen/AMDGPU.

[atanasyan]

I have fixed MIPS-related mistakes at rGf22445b. Thanks for finding them.

[jroelofs]

In D77354#1959175, @foad wrote:

I have fixed some of the obvious mistakes in CodeGen/AMDGPU.

In D77354#1959542, @atanasyan wrote:

I have fixed MIPS-related mistakes at rGf22445b. Thanks for finding them.

Thank you both!

For my own reference later:

c7e1fc8496dc2c6289c803f89d7a9eae9c2cbd01
f22445bf57606ffc9914777c228936d4b3f8140d

[RKSimon]

@jroelofs please can you rebase to see what test are still broken?

[jroelofs]

Rebased

[RKSimon]

@jroelofs Please can you rebase again? I think I've dealt with all the low hanging fruit now, so you will probably have to git blame to find code owners to help fix the remaining issues.

[jroelofs]

rebased

Thanks for all the fixes everyone!

[jroelofs]

@atanasyan there's one more case of this in llvm/test/CodeGen/Mips/ci2.ll. Looks like the constant has been de-duplicated since that test was written. Mind checking whether that's correct behavior for your target? (it does seem better, but I don't want to assume).

diff --git a/llvm/test/CodeGen/Mips/ci2.ll b/llvm/test/CodeGen/Mips/ci2.ll
index 5e6b7814d5e..1b07df371eb 100644
--- a/llvm/test/CodeGen/Mips/ci2.ll
+++ b/llvm/test/CodeGen/Mips/ci2.ll
@@ -1,4 +1,4 @@
-; RUN: llc -mtriple=mipsel-linux-gnu -march=mipsel -mattr=mips16 -mattr=+soft-float -mips16-hard-float -relocation-model=static -mips16-constant-islands   < %s | FileCheck %s -check-prefix=constisle
+; RUN: llc -mtriple=mipsel-linux-gnu -march=mipsel -mattr=mips16 -mattr=+soft-float -mips16-hard-float -relocation-model=static -mips16-constant-islands   < %s | FileCheck %s -check-prefix=CONSTISLE
 
 @i = common global i32 0, align 4
 @b = common global i32 0, align 4
@@ -24,13 +24,11 @@ if.end:                                           ; preds = %if.else, %if.then
   call void asm sideeffect ".space 100000", ""() #1, !srcloc !1
   store i32 305419896, i32* @l, align 4
   ret void
-; constisle: $CPI0_1:
-; constisle	.4byte	305419896               # 0x12345678
-; constisle	#APP
-; constisle	.space 100000
-; constisle	#NO_APP
-; constisle $CPI0_0:
-; constisle	.4byte	305419896               # 0x12345678
+; CONSTISLE: $CPI0_1:
+; CONSTISLE:    .4byte    305419896               # 0x12345678
+; CONSTISLE:    #APP
+; CONSTISLE:    .space 100000
+; CONSTISLE:    #NO_APP
 }
 
 attributes #0 = { nounwind "less-precise-fpmad"="false" "frame-pointer"="all" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="false" }

llvm/test/Transforms/SampleProfile/gcc-simple.ll

 
 for.end.6:                                        ; preds = %for.cond
   %6 = load i64, i64* %sum, align 8, !dbg !69
   %cmp7 = icmp sgt i64 %6, 0, !dbg !70
   %cond = select i1 %cmp7, i32 0, i32 1, !dbg !69
   ret i32 %cond, !dbg !71
 }
 
-; CHECK ![[EC1]] = !{!"function_entry_count", i64 24108}
-; CHECK ![[PROF1]] = !{!"branch_weights", i32 1, i32 30124}
-; CHECK ![[PROF2]] = !{!"branch_weights", i32 30177, i32 29579}
-; CHECK ![[EC2]] = !{!"function_entry_count", i64 0}
-; CHECK ![[PROF3]] = !{!"branch_weights", i32 1, i32 1}
-; CHECK ![[PROF4]] = !{!"branch_weights", i32 1, i32 20238}
+; CHECK: ![[EC1]] = !{!"function_entry_count", i64 24108}
+; CHECK: ![[PROF1]] = !{!"branch_weights", i32 1, i32 30124}
+; CHECK: ![[PROF2]] = !{!"branch_weights", i32 30177, i32 29579}
+; CHECK: ![[EC2]] = !{!"function_entry_count", i64 0}
+; CHECK: ![[PROF3]] = !{!"branch_weights", i32 1, i32 1}
+; CHECK: ![[PROF4]] = !{!"branch_weights", i32 1, i32 20238}
 
 attributes #0 = { nounwind uwtable "disable-tail-calls"="false" "less-precise-fpmad"="false" "frame-pointer"="all" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+sse,+sse2" "unsafe-fp-math"="false" "use-soft-float"="false" }
 attributes #1 = { nounwind readnone }
 attributes #2 = { nounwind "disable-tail-calls"="false" "less-precise-fpmad"="false" "frame-pointer"="all" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+sse,+sse2" "unsafe-fp-math"="false" "use-soft-float"="false" }
 attributes #3 = { nounwind }
 
 !llvm.dbg.cu = !{!0}
 !llvm.module.flags = !{!13, !14}

llvm/test/tools/dsymutil/X86/modules.m

 // CHECK:     DW_TAG_variable
 // CHECK-NOT:   DW_TAG
 // CHECK:       DW_AT_name{{.*}}"foo"
 // CHECK-NOT:   DW_TAG
 // CHECK:       DW_AT_type {{.*}}{0x{{0*}}[[PTR:.*]]}
 //
 // CHECK: 0x{{0*}}[[PTR]]: DW_TAG_pointer_type
 // FIXME: The next line doesn't work.
-// CHECK-NEXT   DW_AT_type [DW_FORM_ref_addr] {0x{{0*}}[[INTERFACE]]
+// CHECK-NEXT:  DW_AT_type [DW_FORM_ref_addr] {0x{{0*}}[[INTERFACE]]
 extern int odr_violation;
 
 @import Foo;
 int main(int argc, char **argv) {
   Bar bar;
   Foo *foo = 0;
   bar.value = odr_violation;
   return bar.value;