Findtypes -gmodules fix

[jankratochvil]

Summary

A little fixup so that D77327 can be called NFC.

[kwk]

Could you explain, why this was done please?

[jankratochvil]

In D77336#1959094, @kwk wrote:

Could you explain, why this was done please?

As D77327 removes num_die_matches as now it is a callback so one cannot use it anymore after D77327. Exact replacement would be to count the number of times the callback was called. But that would keep it buggy, apparently the intention was to copy the condition above:

if (types.GetSize() >= max_matches)
  break;

So that if the iteration stopped because of too many matches we do not add even more matches in this Clang modules block downward.
It was implemented by: SymbolFileDWARF: Unconditionally scan through clang modules. NFCish

[aprantl]

Thanks for catching this!

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

for (size_t i = 0; i < num_die_matches; ++i) {
     types.InsertUnique(matching_type->shared_from_this());
     if (types.GetSize() >= max_matches)
       break;
   }
 
   // Next search through the reachable Clang modules. This only applies for
   // DWARF objects compiled with -gmodules that haven't been processed by
   // dsymutil.
-  if (num_die_matches < max_matches) {
+  if (types.GetSize() < max_matches) {
     UpdateExternalModuleListIfNeeded();
 
     for (const auto &pair : m_external_type_modules)
       if (ModuleSP external_module_sp = pair.second) 
         if (SymbolFile *sym_file = external_module_sp->GetSymbolFile())
           sym_file->FindTypes(name, parent_decl_ctx, max_matches,
                               searched_symbol_files, types);
   }