Remove usages of asserting vector getters in Type in preparation for the
VectorType refactor. The existence of these functions complicates the
refactor while adding little value.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp | ||
---|---|---|
1597 | is the cast to unsigned needed? |
mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp | ||
---|---|---|
1597 | VectorType::getNumElements() returns uint64_t, where Type::getVectorNumElements() returned unsigned. At least in visual studio, this results in an error due to a narrowing conversion. I have no idea why this is, I can't imagine that we'd need 64 bits to express the number of vector lanes. |
mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp | ||
---|---|---|
1597 | Actually, I'm pretty sure it's actually "SequentalType::getNumElements()" returns a uint64_t. We could consider changing that once I land the patch to kill SequentialType. |
is the cast to unsigned needed?