Set SupportsDebugUnwindInformation in AMDGPUMCAsmInfo.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/CodeGen/AMDGPU/branch-relaxation.ll | ||
---|---|---|
257 | When we say we are ExceptionHandling::DwarfCFI we are saying that we want an .eh_frame for any functions which are not nounwind (i.e. anything that can throw) and that we want a .debug_frame section for anything else that has debug info enabled. We never need the .eh_frame case, and these tests are agnostic to it anyway, so it seemed nicer to just update all tests to be nounwind than to add CFI noise to them all. There is currently no way for a target to say "I only ever want CFI for debugging purposes, because I don't support exceptions anyway". I didn't go about adding one because we always mark functions nounwind anyway, and if we ever stopped it would likely be because we intend to support EH and would want the .eh_frame to start being generated. | |
llvm/test/DebugInfo/AMDGPU/cfi.ll | ||
22 | This test could use a bit of cleanup, I don't think it depends on this attribute anyway. I'll trim it down to just what is actually relevant. | |
llvm/test/MC/ELF/AMDGPU/lit.local.cfg | ||
2 | I think this X86 is actually correct here, the root llvm/test/MC/ELF dir is already predicated (there is no X86 subdir). |
Rather than lie about supporting exceptions to get unwind information, add an
option to support debug-only unwind information.
Add tests to ensure we are generating CU and CIE augmentation strings.
llvm/test/MC/ELF/AMDGPU/cfi.s | ||
---|---|---|
21 | Consider llvm-readelf if llvm-readobj output is too long. lld/test/ELF has some examples, e.g. # RO: Name Type Address Off Size ES Flg Lk Inf Al # RO-NEXT: NULL 0000000000000000 000000 000000 00 0 0 0 # RO-NEXT: .data PROGBITS 0000000000000000 {{.*}} 00000c 00 WA 0 0 8 `` |
llvm/test/MC/ELF/AMDGPU/cfi.s | ||
---|---|---|
2 | Most assembly tests can use # (shorter than //) |
- Use -COUNT-N form
- Use '#' comment character
- Use llvm-readelf for more compact tests
- Refactor lit config test
llvm/test/DebugInfo/AMDGPU/cfi.ll | ||
---|---|---|
14 | Thank you, done! |
llvm/test/MC/ELF/AMDGPU/cfi.s | ||
---|---|---|
14 | Are these intended to be fixed before merge or is the test just nothing something should be fixed? If the latter, perhaps we need an XFAIL test for it? But maybe it's not worth it. |
llvm/test/MC/ELF/AMDGPU/cfi.s | ||
---|---|---|
14 | Currently the AsmParser is not skipping the '\n' i.e. EndOfStatement at the end while parsing the asm directives and hence the extra new line is being generated for that '\n'. And the above behavior is not a result of any of the patch in this patch series. |
Why does it matter in any of these cases?