Page MenuHomePhabricator

RamNalamothu (Venkata Ramanaiah Nalamothu)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 25 2020, 6:50 PM (116 w, 4 d)

Recent Activity

Wed, May 18

RamNalamothu added a comment to D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Ping

Wed, May 18, 7:12 AM · Restricted Project, debug-info, Restricted Project

Thu, May 5

RamNalamothu added a comment to D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Ping.

Thu, May 5, 2:39 AM · Restricted Project, debug-info, Restricted Project

Apr 7 2022

RamNalamothu added a comment to D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Ping

Apr 7 2022, 6:36 AM · Restricted Project, debug-info, Restricted Project

Mar 22 2022

RamNalamothu added a comment to D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

@djtodoro thanks for the quick response

Mar 22 2022, 7:13 AM · Restricted Project, debug-info, Restricted Project
RamNalamothu updated the diff for D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Address feedback.

Mar 22 2022, 6:49 AM · Restricted Project, debug-info, Restricted Project
RamNalamothu added a comment to D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Could someone review/comment/approve this revision?

Mar 22 2022, 2:13 AM · Restricted Project, debug-info, Restricted Project
RamNalamothu updated the summary of D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.
Mar 22 2022, 2:05 AM · Restricted Project, debug-info, Restricted Project
RamNalamothu updated the diff for D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Rebase onto ToT.

Mar 22 2022, 2:04 AM · Restricted Project, debug-info, Restricted Project

Mar 8 2022

RamNalamothu committed rG04fff547e281: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved… (authored by RamNalamothu).
[AMDGPU] Move call clobbered return address registers s[30:31] to callee saved…
Mar 8 2022, 10:48 PM · Restricted Project
RamNalamothu closed D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Mar 8 2022, 10:48 PM · Restricted Project, Restricted Project
RamNalamothu added a comment to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.

I'm not sure I understand why a separate isPhysRegUsed check is needed since ultimately that's what IPRA is doing, but I don't see how it could hurt

Mar 8 2022, 8:43 AM · Restricted Project, Restricted Project
RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Mar 8 2022, 2:39 AM · Restricted Project, Restricted Project
RamNalamothu updated the diff for D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.

Address review feedback.

Mar 8 2022, 2:35 AM · Restricted Project, Restricted Project

Mar 7 2022

RamNalamothu updated the diff for D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.

Fixed the blender application failure seen in the downstream testing.

Mar 7 2022, 4:48 PM · Restricted Project, Restricted Project
RamNalamothu committed rGe1069c1288d1: [AMDGPU] Ensure return address is save/restored if clobbered or when function… (authored by RamNalamothu).
[AMDGPU] Ensure return address is save/restored if clobbered or when function…
Mar 7 2022, 8:32 AM · Restricted Project
RamNalamothu closed D120922: [AMDGPU] Ensure return address is save/restored if clobbered or when function has calls.
Mar 7 2022, 8:31 AM · Restricted Project, Restricted Project
RamNalamothu added a comment to D120922: [AMDGPU] Ensure return address is save/restored if clobbered or when function has calls.

An artificial test with high pressure would be more reliable long term. Branches on constants could be fragile

Mar 7 2022, 7:07 AM · Restricted Project, Restricted Project

Mar 3 2022

RamNalamothu requested review of D120922: [AMDGPU] Ensure return address is save/restored if clobbered or when function has calls.
Mar 3 2022, 10:47 AM · Restricted Project, Restricted Project

Feb 21 2022

RamNalamothu updated the diff for D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Rebase and ping.

Feb 21 2022, 11:15 AM · Restricted Project, debug-info, Restricted Project

Jan 14 2022

RamNalamothu updated the diff for D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.

Fixed an issue exposed by OpenMP LIT test failures.

Jan 14 2022, 11:22 AM · Restricted Project, Restricted Project
RamNalamothu reopened D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Jan 14 2022, 11:21 AM · Restricted Project, Restricted Project
RamNalamothu closed D117243: [AMDGPU] Ensure return address is save/restored around the call with IPRA enabled/disabled.
Jan 14 2022, 11:20 AM · Restricted Project
RamNalamothu reopened D117243: [AMDGPU] Ensure return address is save/restored around the call with IPRA enabled/disabled.
Jan 14 2022, 11:17 AM · Restricted Project

Jan 13 2022

RamNalamothu committed rG0bcd9f60cd0d: [AMDGPU] Ensure return address is save/restored around the call with IPRA… (authored by RamNalamothu).
[AMDGPU] Ensure return address is save/restored around the call with IPRA…
Jan 13 2022, 1:39 PM
RamNalamothu closed D117243: [AMDGPU] Ensure return address is save/restored around the call with IPRA enabled/disabled.
Jan 13 2022, 1:39 PM · Restricted Project
RamNalamothu added a comment to D117243: [AMDGPU] Ensure return address is save/restored around the call with IPRA enabled/disabled.

This test will be used to verify the fix that will be added to https://reviews.llvm.org/D114652 for resolving the OpenMP LIT failures.

Jan 13 2022, 12:43 PM · Restricted Project
RamNalamothu requested review of D117243: [AMDGPU] Ensure return address is save/restored around the call with IPRA enabled/disabled.
Jan 13 2022, 12:38 PM · Restricted Project
RamNalamothu added a comment to D117064: AMDGPU/GlobalISel: Fix not adding return address use to tail calls.

This looks like it was fixed by D114652, but that got reverted?

Jan 13 2022, 7:07 AM · Restricted Project

Dec 22 2021

RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Dec 22 2021, 7:24 AM · Restricted Project, Restricted Project
RamNalamothu committed rG9075009d1fd5: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved… (authored by RamNalamothu).
[AMDGPU] Move call clobbered return address registers s[30:31] to callee saved…
Dec 22 2021, 7:21 AM
RamNalamothu closed D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Dec 22 2021, 7:21 AM · Restricted Project, Restricted Project

Dec 20 2021

RamNalamothu added a comment to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.

I think I have addressed all the outstanding feedback. Is this good to go now?

Dec 20 2021, 5:58 AM · Restricted Project, Restricted Project
RamNalamothu updated the diff for D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.

Rebase onto ToT and use copyImplicitOps.

Dec 20 2021, 5:52 AM · Restricted Project, Restricted Project

Dec 15 2021

RamNalamothu updated the diff for D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.

Rebase onto ToT and also made the following changes to address review feedback.

Dec 15 2021, 3:36 AM · Restricted Project, Restricted Project

Dec 6 2021

RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Dec 6 2021, 6:20 AM · Restricted Project, Restricted Project

Dec 2 2021

RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Dec 2 2021, 7:53 AM · Restricted Project, Restricted Project
RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Dec 2 2021, 6:35 AM · Restricted Project, Restricted Project
RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Dec 2 2021, 2:36 AM · Restricted Project, Restricted Project

Dec 1 2021

RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Dec 1 2021, 9:19 AM · Restricted Project, Restricted Project
RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Dec 1 2021, 8:41 AM · Restricted Project, Restricted Project
RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Dec 1 2021, 6:23 AM · Restricted Project, Restricted Project
RamNalamothu updated the diff for D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.

Rebase and fix tests in llvm/test/CodeGen/AMDGPU/callee-frame-setup.ll.

Dec 1 2021, 6:05 AM · Restricted Project, Restricted Project

Nov 26 2021

RamNalamothu added inline comments to D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Nov 26 2021, 8:42 PM · Restricted Project, Restricted Project
RamNalamothu requested review of D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range.
Nov 26 2021, 10:37 AM · Restricted Project, Restricted Project
RamNalamothu committed rG7f05ff8be481: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command (authored by ramana-nvr).
[Bug 49018][lldb] Fix incorrect help text for 'memory write' command
Nov 26 2021, 5:45 AM
RamNalamothu closed D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command.
Nov 26 2021, 5:44 AM · Restricted Project
RamNalamothu updated the diff for D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command.

Re-use the existing constexpr option table.

Nov 26 2021, 5:05 AM · Restricted Project
RamNalamothu added inline comments to D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command.
Nov 26 2021, 4:58 AM · Restricted Project

Nov 25 2021

RamNalamothu updated the diff for D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command.

Remove the unnecessary if {} gaurding around range for loop.

Nov 25 2021, 11:42 PM · Restricted Project
RamNalamothu updated the diff for D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command.

Address review comments.

Nov 25 2021, 2:39 PM · Restricted Project
RamNalamothu added a comment to D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command.

Not sure if you're a regular contributor and already know this but in case not, I tend to use https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting for doing clang-format stuff. It'll format only the lines you've changed.

Nov 25 2021, 12:55 PM · Restricted Project
RamNalamothu added a comment to D114544: [lldb] Fix 'memory write' to not allow specifying values when writing file contents.

Thanks for the comments.

Nov 25 2021, 9:23 AM · Restricted Project
RamNalamothu updated the diff for D114544: [lldb] Fix 'memory write' to not allow specifying values when writing file contents.

Address review comments.

Nov 25 2021, 9:18 AM · Restricted Project

Nov 24 2021

RamNalamothu requested review of D114544: [lldb] Fix 'memory write' to not allow specifying values when writing file contents.
Nov 24 2021, 10:20 AM · Restricted Project

Nov 23 2021

RamNalamothu updated the summary of D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command.
Nov 23 2021, 9:16 AM · Restricted Project
RamNalamothu requested review of D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command.
Nov 23 2021, 9:03 AM · Restricted Project

Nov 19 2021

RamNalamothu committed rG18f935122348: [AMDGPU] Do not generate ELF symbols for the local branch target labels (authored by RamNalamothu).
[AMDGPU] Do not generate ELF symbols for the local branch target labels
Nov 19 2021, 9:03 PM
RamNalamothu closed D114273: [AMDGPU] Do not generate ELF symbols for the local branch target labels.
Nov 19 2021, 9:02 PM · Restricted Project
RamNalamothu requested review of D114273: [AMDGPU] Do not generate ELF symbols for the local branch target labels.
Nov 19 2021, 12:42 PM · Restricted Project

Nov 16 2021

RamNalamothu updated the diff for D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Rebase on to the ToT.

Nov 16 2021, 1:56 AM · Restricted Project, debug-info, Restricted Project

Nov 3 2021

RamNalamothu committed rG539f500e78ad: [AMDGPU] Do not add debug locations to the code inside prologue (authored by RamNalamothu).
[AMDGPU] Do not add debug locations to the code inside prologue
Nov 3 2021, 7:33 PM
RamNalamothu closed D113100: [AMDGPU] Do not add debug locations to the code inside prologue.
Nov 3 2021, 7:32 PM · Restricted Project
RamNalamothu requested review of D113100: [AMDGPU] Do not add debug locations to the code inside prologue.
Nov 3 2021, 6:11 AM · Restricted Project

Sep 16 2021

RamNalamothu committed rG6403f716f129: [NFC][MachineRegisterInfo] Fix typo in comments of getLiveInVirtReg() function (authored by RamNalamothu).
[NFC][MachineRegisterInfo] Fix typo in comments of getLiveInVirtReg() function
Sep 16 2021, 9:12 PM
RamNalamothu closed D109743: [NFC][MachineRegisterInfo] Fix typo in comments of getLiveInVirtReg() function.
Sep 16 2021, 9:09 PM · Restricted Project

Sep 14 2021

RamNalamothu requested review of D109743: [NFC][MachineRegisterInfo] Fix typo in comments of getLiveInVirtReg() function.
Sep 14 2021, 12:03 AM · Restricted Project

Sep 13 2021

RamNalamothu committed rG726b5d341671: [RegScavenger][NFC] Refer to the already initialized local variable for spill… (authored by RamNalamothu).
[RegScavenger][NFC] Refer to the already initialized local variable for spill…
Sep 13 2021, 9:26 AM
RamNalamothu closed D109501: [RegScavenger][NFC] Refer to the already initialized local variable for spill slot index.
Sep 13 2021, 9:25 AM · Restricted Project
RamNalamothu committed rG0fc3ebb70a2d: [SelectionDAG][NFC] Fix typo in VerifyDAGDiverence() function name (authored by RamNalamothu).
[SelectionDAG][NFC] Fix typo in VerifyDAGDiverence() function name
Sep 13 2021, 8:18 AM
RamNalamothu closed D109674: [SelectionDAG][NFC] Fix typo in VerifyDAGDiverence() function name.
Sep 13 2021, 8:18 AM · Restricted Project
RamNalamothu requested review of D109674: [SelectionDAG][NFC] Fix typo in VerifyDAGDiverence() function name.
Sep 13 2021, 1:24 AM · Restricted Project

Sep 12 2021

RamNalamothu added reviewers for D109501: [RegScavenger][NFC] Refer to the already initialized local variable for spill slot index: arsenm, efriedma.
Sep 12 2021, 9:50 PM · Restricted Project

Sep 9 2021

RamNalamothu requested review of D109501: [RegScavenger][NFC] Refer to the already initialized local variable for spill slot index.
Sep 9 2021, 4:30 AM · Restricted Project

Aug 26 2021

RamNalamothu committed rG9b9e7f6f4e05: [docs, AMDGPU] Fix typo in dwarf register number mapping (authored by RamNalamothu).
[docs, AMDGPU] Fix typo in dwarf register number mapping
Aug 26 2021, 11:26 AM
RamNalamothu closed D108557: [docs, AMDGPU] Fix typo in dwarf register number mapping.
Aug 26 2021, 11:25 AM · Restricted Project
RamNalamothu committed rGbe19aee4b26e: [DWARFLinker] Prefix debug section names with '.' in the comments. NFC. (authored by RamNalamothu).
[DWARFLinker] Prefix debug section names with '.' in the comments. NFC.
Aug 26 2021, 9:59 AM
RamNalamothu closed D108519: [DWARFLinker] Prefix debug section names with '.' in the comments. NFC..
Aug 26 2021, 9:59 AM · Restricted Project
RamNalamothu added a comment to D108557: [docs, AMDGPU] Fix typo in dwarf register number mapping.

Ping.

Aug 26 2021, 7:54 AM · Restricted Project
RamNalamothu added a comment to D108519: [DWARFLinker] Prefix debug section names with '.' in the comments. NFC..

If there are no concerns on standardizing the DWARF section names on the dot forms, can somebody approve these changes?

Aug 26 2021, 7:53 AM · Restricted Project

Aug 23 2021

RamNalamothu requested review of D108557: [docs, AMDGPU] Fix typo in dwarf register number mapping.
Aug 23 2021, 7:33 AM · Restricted Project

Aug 22 2021

RamNalamothu added a comment to D108519: [DWARFLinker] Prefix debug section names with '.' in the comments. NFC..

I think it would be better to not add any prefixes to section names. On Darwin, section names have "__" prefix. So using "." looks a bit incompatible. It seems, it is better always use section names without prefixes.

Aug 22 2021, 10:46 AM · Restricted Project
RamNalamothu added a reviewer for D108519: [DWARFLinker] Prefix debug section names with '.' in the comments. NFC.: scott.linder.
Aug 22 2021, 10:18 AM · Restricted Project
RamNalamothu updated the summary of D108519: [DWARFLinker] Prefix debug section names with '.' in the comments. NFC..
Aug 22 2021, 10:17 AM · Restricted Project
RamNalamothu requested review of D108519: [DWARFLinker] Prefix debug section names with '.' in the comments. NFC..
Aug 22 2021, 10:09 AM · Restricted Project

Jul 27 2021

RamNalamothu committed rG1a8c57179a12: [AMDGPU] We would need FP if there is call and caller save VGPR spills (authored by RamNalamothu).
[AMDGPU] We would need FP if there is call and caller save VGPR spills
Jul 27 2021, 10:43 PM
RamNalamothu closed D106758: [AMDGPU] We would need FP if there is call and caller save VGPR spills.
Jul 27 2021, 10:43 PM · Restricted Project
RamNalamothu updated the diff for D106758: [AMDGPU] We would need FP if there is call and caller save VGPR spills.

LGTM except the test is using dead code. I also think we ought to be able to remove VGPRReservedForSGPRSpill now that SGPR and VGPR allocation are split

I think that's out of the scope for this review.

Yes, but would be a good follow up change.

Jul 27 2021, 11:28 AM · Restricted Project
RamNalamothu added a comment to D106758: [AMDGPU] We would need FP if there is call and caller save VGPR spills.

LGTM except the test is using dead code. I also think we ought to be able to remove VGPRReservedForSGPRSpill now that SGPR and VGPR allocation are split

I think that's out of the scope for this review.

Yes, but would be a good follow up change.

This test looks nearly identical to test/CodeGen/AMDGPU/need-fp-from-csr-vgpr-spill.ll. Can the two be merged? I don't actually see why the existing test didn't catch this and isn't changed.

Jul 27 2021, 9:24 AM · Restricted Project
RamNalamothu added a comment to D106758: [AMDGPU] We would need FP if there is call and caller save VGPR spills.

LGTM except the test is using dead code. I also think we ought to be able to remove VGPRReservedForSGPRSpill now that SGPR and VGPR allocation are split

Jul 27 2021, 5:37 AM · Restricted Project
RamNalamothu updated the diff for D106758: [AMDGPU] We would need FP if there is call and caller save VGPR spills.

Address review comments.

Jul 27 2021, 4:41 AM · Restricted Project

Jul 24 2021

RamNalamothu requested review of D106758: [AMDGPU] We would need FP if there is call and caller save VGPR spills.
Jul 24 2021, 2:11 PM · Restricted Project

Jun 13 2021

RamNalamothu committed rG167e7afcd52b: Implement DW_CFA_LLVM_* for Heterogeneous Debugging (authored by RamNalamothu).
Implement DW_CFA_LLVM_* for Heterogeneous Debugging
Jun 13 2021, 8:22 PM
RamNalamothu closed D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.
Jun 13 2021, 8:22 PM · debug-info, Restricted Project
RamNalamothu added a comment to D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

No problem.

Jun 13 2021, 6:41 PM · debug-info, Restricted Project

Jun 10 2021

RamNalamothu added a comment to D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

ping

Jun 10 2021, 12:16 PM · debug-info, Restricted Project

Jun 5 2021

RamNalamothu added a comment to D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

Thank you @clayborg.

Jun 5 2021, 8:25 AM · debug-info, Restricted Project

Jun 2 2021

RamNalamothu added a comment to D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

I am ok with all of the DWARF unwind changes. Someone else should give the ok for the MC stuff.

ping: this revision (and the patch series) is under review since March-2020 and would appreciate if someone could review the overall changes and approve.

Jun 2 2021, 5:03 AM · debug-info, Restricted Project

May 27 2021

RamNalamothu added a comment to D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

I am ok with all of the DWARF unwind changes. Someone else should give the ok for the MC stuff.

May 27 2021, 12:19 PM · debug-info, Restricted Project
RamNalamothu updated the diff for D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

Rename few lit test filenames to match with the downstream.

May 27 2021, 12:11 PM · debug-info, Restricted Project

May 26 2021

RamNalamothu added inline comments to D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.
May 26 2021, 6:29 AM · debug-info, Restricted Project