Page MenuHomePhabricator

RamNalamothu (Venkata Ramanaiah Nalamothu)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 25 2020, 6:50 PM (67 w, 5 d)

Recent Activity

Yesterday

RamNalamothu committed rG167e7afcd52b: Implement DW_CFA_LLVM_* for Heterogeneous Debugging (authored by RamNalamothu).
Implement DW_CFA_LLVM_* for Heterogeneous Debugging
Sun, Jun 13, 8:22 PM
RamNalamothu closed D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.
Sun, Jun 13, 8:22 PM · debug-info, Restricted Project
RamNalamothu added a comment to D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

No problem.

Sun, Jun 13, 6:41 PM · debug-info, Restricted Project

Thu, Jun 10

RamNalamothu added a comment to D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

ping

Thu, Jun 10, 12:16 PM · debug-info, Restricted Project

Sat, Jun 5

RamNalamothu added a comment to D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

Thank you @clayborg.

Sat, Jun 5, 8:25 AM · debug-info, Restricted Project

Wed, Jun 2

RamNalamothu added a comment to D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

I am ok with all of the DWARF unwind changes. Someone else should give the ok for the MC stuff.

ping: this revision (and the patch series) is under review since March-2020 and would appreciate if someone could review the overall changes and approve.

Wed, Jun 2, 5:03 AM · debug-info, Restricted Project

Thu, May 27

RamNalamothu added a comment to D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

I am ok with all of the DWARF unwind changes. Someone else should give the ok for the MC stuff.

Thu, May 27, 12:19 PM · debug-info, Restricted Project
RamNalamothu updated the diff for D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

Rename few lit test filenames to match with the downstream.

Thu, May 27, 12:11 PM · debug-info, Restricted Project

Wed, May 26

RamNalamothu added inline comments to D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.
Wed, May 26, 6:29 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

Removed RegPlusOffsetInAddrSpace.

Wed, May 26, 6:10 AM · debug-info, Restricted Project

Fri, May 21

RamNalamothu updated the diff for D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

Moved the AddrSpace into UnwindLocation.

Fri, May 21, 5:14 AM · debug-info, Restricted Project

Wed, May 19

RamNalamothu added a comment to D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

ping; is there anyone be able to take a look at the complete patch?

Wed, May 19, 7:01 AM · debug-info, Restricted Project

Tue, May 18

RamNalamothu updated the diff for D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

Addressed the feedback.

Tue, May 18, 2:40 AM · debug-info, Restricted Project

Mon, May 17

RamNalamothu added inline comments to D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.
Mon, May 17, 7:52 AM · debug-info, Restricted Project

May 12 2021

RamNalamothu added a comment to D102220: [NFC, CFI] Use unsigned type for CFI register values in parser/streamer code.

the interfacing code in parsers and streamers are using both signed and unsigned type in different parts.

Where is uint64_t used? Most places use int64_t.

For instance in AsmParser::parseRegisterOrRegisterNumber() and type cast in MCStreamer::emitCFIDefCfaRegister().

Anyway, I have changed the summary as the above scenarios are minor in the entire changes.

Both AsmParser::parseRegisterOrRegisterNumber() and MCStreamer::emitCFIDefCfaRegister() uses int64_t.

May 12 2021, 9:06 PM · Restricted Project
RamNalamothu added a comment to D102220: [NFC, CFI] Use unsigned type for CFI register values in parser/streamer code.

the interfacing code in parsers and streamers are using both signed and unsigned type in different parts.

Where is uint64_t used? Most places use int64_t.

May 12 2021, 6:58 PM · Restricted Project
RamNalamothu updated the summary of D102220: [NFC, CFI] Use unsigned type for CFI register values in parser/streamer code.
May 12 2021, 6:57 PM · Restricted Project
RamNalamothu updated the diff for D102220: [NFC, CFI] Use unsigned type for CFI register values in parser/streamer code.

Add virtual method parseAbsoluteExpression(uint64_t) to MCAsmParser.

May 12 2021, 9:56 AM · Restricted Project
RamNalamothu added inline comments to D102220: [NFC, CFI] Use unsigned type for CFI register values in parser/streamer code.
May 12 2021, 9:21 AM · Restricted Project
RamNalamothu updated the diff for D102220: [NFC, CFI] Use unsigned type for CFI register values in parser/streamer code.

Missed changes in the previous update(s).

May 12 2021, 6:19 AM · Restricted Project
RamNalamothu added a comment to D102220: [NFC, CFI] Use unsigned type for CFI register values in parser/streamer code.

Would it be reasonable to just clean up all the types in these functions? I noted the ones I identified.

May 12 2021, 1:57 AM · Restricted Project
RamNalamothu updated the diff for D102220: [NFC, CFI] Use unsigned type for CFI register values in parser/streamer code.

Address the review comments.

May 12 2021, 1:47 AM · Restricted Project

May 11 2021

RamNalamothu updated the summary of D102220: [NFC, CFI] Use unsigned type for CFI register values in parser/streamer code.
May 11 2021, 1:37 AM · Restricted Project
RamNalamothu added a reviewer for D102220: [NFC, CFI] Use unsigned type for CFI register values in parser/streamer code: MaskRay.
May 11 2021, 1:25 AM · Restricted Project
RamNalamothu requested review of D102220: [NFC, CFI] Use unsigned type for CFI register values in parser/streamer code.
May 11 2021, 1:19 AM · Restricted Project

May 7 2021

RamNalamothu committed rG223852d76fcc: [DebugInfo] UnwindTable::create() should not add empty rows to CFI unwind table (authored by RamNalamothu).
[DebugInfo] UnwindTable::create() should not add empty rows to CFI unwind table
May 7 2021, 9:49 PM
RamNalamothu closed D101892: [DebugInfo] UnwindTable::create() should not add empty rows to CFI unwind table.
May 7 2021, 9:49 PM · Restricted Project

May 6 2021

RamNalamothu updated the summary of D101892: [DebugInfo] UnwindTable::create() should not add empty rows to CFI unwind table.
May 6 2021, 7:58 AM · Restricted Project
RamNalamothu updated the diff for D101892: [DebugInfo] UnwindTable::create() should not add empty rows to CFI unwind table.

Handle the scenario when the CIE or FDE has only DW_CFA_nop instructions.

May 6 2021, 7:50 AM · Restricted Project

May 5 2021

RamNalamothu added a comment to D101892: [DebugInfo] UnwindTable::create() should not add empty rows to CFI unwind table.

Does this look good now for commit?

May 5 2021, 4:29 PM · Restricted Project
RamNalamothu committed rG41f8b8e8075b: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling (authored by RamNalamothu).
[MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling
May 5 2021, 4:24 PM
RamNalamothu closed D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling.
May 5 2021, 4:24 PM · debug-info, Restricted Project
RamNalamothu added a comment to D101892: [DebugInfo] UnwindTable::create() should not add empty rows to CFI unwind table.

Thank you.

May 5 2021, 4:08 PM · Restricted Project
RamNalamothu updated the diff for D101892: [DebugInfo] UnwindTable::create() should not add empty rows to CFI unwind table.

Made the suggested code changes.

May 5 2021, 4:06 PM · Restricted Project
RamNalamothu updated the diff for D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling.

Update llvm/test/CodeGen/AMDGPU/debug_frame.ll test.

May 5 2021, 12:18 PM · debug-info, Restricted Project
RamNalamothu added a comment to D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling.

If there are no further comments, I will commit this once the build is completed.

May 5 2021, 11:22 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling.

Address feedback on LIT tests.

May 5 2021, 11:17 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling.

Fix llvm/test/CodeGen/AMDGPU/ptr-arg-dbg-value.ll failure on Windows.

May 5 2021, 9:58 AM · debug-info, Restricted Project
RamNalamothu added a comment to D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling.

Does it look good now?

May 5 2021, 7:57 AM · debug-info, Restricted Project
RamNalamothu retitled D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling from [AsmPrinter] Fix emitting CFI for debug when exceptions are not supported to [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling.
May 5 2021, 7:44 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling.

Fix couple of WebAsembly debug info LIT tests, as we now emit .debug_frame when no exceptions.

Hmm - was this intended to change the behavior of WebAssembly? Could you get someone with some WebAssembly context to double check this is desirable behavior?

Not intended but probably the LIT test updates are expected for WebAssembly. Adding @aheejin as well to review those.
Please note that those LIT tests are not explicitly checking for either presence/non-presense of .eh_frame or .debug_frame and might have just tried to match the compiler output back then.

However, while I still feel the current usesCFIForDebug() approach is in the right direction, please let me know if the preferred approach is a target configurable option and if yes, I can update this review with https://reviews.llvm.org/D101592 changes (not meant to be reviewed there).

I am not very familiar with these tests. Perhaps any of @aardappel @sbc100 @yurydelendik would know.

May 5 2021, 7:34 AM · debug-info, Restricted Project
RamNalamothu added a comment to D101892: [DebugInfo] UnwindTable::create() should not add empty rows to CFI unwind table.

I found this case while working on https://reviews.llvm.org/D76877.

May 5 2021, 5:01 AM · Restricted Project
RamNalamothu updated the summary of D101892: [DebugInfo] UnwindTable::create() should not add empty rows to CFI unwind table.
May 5 2021, 4:45 AM · Restricted Project
RamNalamothu requested review of D101892: [DebugInfo] UnwindTable::create() should not add empty rows to CFI unwind table.
May 5 2021, 4:06 AM · Restricted Project

Apr 29 2021

RamNalamothu added a reviewer for D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling: aheejin.

Fix couple of WebAsembly debug info LIT tests, as we now emit .debug_frame when no exceptions.

Hmm - was this intended to change the behavior of WebAssembly? Could you get someone with some WebAssembly context to double check this is desirable behavior?

Apr 29 2021, 7:04 PM · debug-info, Restricted Project

Apr 27 2021

RamNalamothu committed rG63cfab4f4039: [NFC] Refactor how CFI section types are represented in AsmPrinter (authored by RamNalamothu).
[NFC] Refactor how CFI section types are represented in AsmPrinter
Apr 27 2021, 8:34 PM
RamNalamothu closed D76519: [NFC] Refactor how CFI section types are represented in AsmPrinter.
Apr 27 2021, 8:34 PM · Restricted Project
RamNalamothu updated the diff for D76519: [NFC] Refactor how CFI section types are represented in AsmPrinter.

Implemented the suggested improvement.

Apr 27 2021, 1:06 PM · Restricted Project
RamNalamothu added inline comments to D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling.
Apr 27 2021, 12:29 PM · debug-info, Restricted Project
RamNalamothu updated the diff for D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling.

Fix couple of WebAsembly debug info LIT tests, as we now emit .debug_frame when no exceptions.

Apr 27 2021, 7:31 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76519: [NFC] Refactor how CFI section types are represented in AsmPrinter.

Address review comments.

Apr 27 2021, 4:09 AM · Restricted Project

Apr 26 2021

RamNalamothu updated subscribers of D101339: [DebugInfo] Add tests that we emit .eh_frame instead of .debug_frame.
Apr 26 2021, 9:27 PM · Restricted Project
RamNalamothu added inline comments to D76519: [NFC] Refactor how CFI section types are represented in AsmPrinter.
Apr 26 2021, 8:56 PM · Restricted Project
RamNalamothu added a comment to D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling.

@dblaikie wrote:
Sorry, paging this all back in. Why is this necessary? THis looks like the sort of change that would be necessary to allow /both/ eh_frame and debug_frame to be emitted at the same time. Is that what this is about? That doesn't seem to line up with my reading of the patch description, which seems to be about being able to emit debug_frame even when not using exceptions - but wouldn't require anything to say "I want eh_frame and debug_frame at the same time" I think?

Apr 26 2021, 8:38 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling.

Remove the changes that were committed seperately in https://reviews.llvm.org/D76519.

Apr 26 2021, 8:29 AM · debug-info, Restricted Project
RamNalamothu commandeered D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling.
Apr 26 2021, 8:23 AM · debug-info, Restricted Project
RamNalamothu retitled D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling from [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo to [AsmPrinter] Fix emitting CFI for debug when exceptions are not supported.
Apr 26 2021, 8:22 AM · debug-info, Restricted Project

Apr 24 2021

RamNalamothu committed rG0ce723cb228b: [NFC] Refactor how CFI section types are represented in AsmPrinter (authored by RamNalamothu).
[NFC] Refactor how CFI section types are represented in AsmPrinter
Apr 24 2021, 11:00 AM
RamNalamothu closed D76519: [NFC] Refactor how CFI section types are represented in AsmPrinter.
Apr 24 2021, 11:00 AM · Restricted Project
RamNalamothu retitled D76519: [NFC] Refactor how CFI section types are represented in AsmPrinter from [NFC] Refactor how CFI move sections are represented in AsmPrinter to [NFC] Refactor how CFI section types are represented in AsmPrinter.
Apr 24 2021, 8:39 AM · Restricted Project
RamNalamothu updated subscribers of D76519: [NFC] Refactor how CFI section types are represented in AsmPrinter.

Refactor how CFI move sections

Since 'move' is coined term which is not accurate, just avoid using it.

Apr 24 2021, 8:22 AM · Restricted Project
RamNalamothu updated the diff for D76519: [NFC] Refactor how CFI section types are represented in AsmPrinter.

Address review comments.

Apr 24 2021, 7:59 AM · Restricted Project

Apr 23 2021

RamNalamothu added a comment to D76519: [NFC] Refactor how CFI section types are represented in AsmPrinter.

Does it look better now, after the renaming?

Apr 23 2021, 10:39 PM · Restricted Project
RamNalamothu updated the diff for D76519: [NFC] Refactor how CFI section types are represented in AsmPrinter.

Renaming the state variables for better representation.

Apr 23 2021, 9:31 PM · Restricted Project
RamNalamothu commandeered D76519: [NFC] Refactor how CFI section types are represented in AsmPrinter.

Scott, I will take this forward. Hope that is fine.

Apr 23 2021, 9:28 PM · Restricted Project
RamNalamothu committed rG4e87fdd78643: [NFC] Delete the redundant member 'shouldEmitMoves' from DwarfCFIException class (authored by RamNalamothu).
[NFC] Delete the redundant member 'shouldEmitMoves' from DwarfCFIException class
Apr 23 2021, 6:06 PM
RamNalamothu closed D101155: [NFC] Delete the redundant member 'shouldEmitMoves' from DwarfCFIException class.
Apr 23 2021, 6:06 PM · Restricted Project
RamNalamothu updated the summary of D101155: [NFC] Delete the redundant member 'shouldEmitMoves' from DwarfCFIException class.
Apr 23 2021, 5:35 AM · Restricted Project
RamNalamothu added reviewers for D101155: [NFC] Delete the redundant member 'shouldEmitMoves' from DwarfCFIException class: MaskRay, dblaikie, scott.linder.
Apr 23 2021, 4:27 AM · Restricted Project
RamNalamothu requested review of D101155: [NFC] Delete the redundant member 'shouldEmitMoves' from DwarfCFIException class.
Apr 23 2021, 4:22 AM · Restricted Project

Apr 1 2021

RamNalamothu updated the diff for D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling.

Rebase and ping

Apr 1 2021, 5:40 AM · debug-info, Restricted Project

Mar 16 2021

RamNalamothu committed rG43f2d269b383: [AMDGPU, NFC] Refactor FP/BP spill index code in emitPrologue/emitEpilogue (authored by RamNalamothu).
[AMDGPU, NFC] Refactor FP/BP spill index code in emitPrologue/emitEpilogue
Mar 16 2021, 6:50 AM
RamNalamothu closed D98617: [AMDGPU, NFC] Refactor FP/BP spill index code in emitPrologue/emitEpilogue.
Mar 16 2021, 6:50 AM · Restricted Project
RamNalamothu added a comment to D98617: [AMDGPU, NFC] Refactor FP/BP spill index code in emitPrologue/emitEpilogue.

Incorporated the suggestions. Thank you.

Mar 16 2021, 4:01 AM · Restricted Project
RamNalamothu updated the diff for D98617: [AMDGPU, NFC] Refactor FP/BP spill index code in emitPrologue/emitEpilogue.

Address feedback as suggested.

Mar 16 2021, 3:59 AM · Restricted Project
RamNalamothu updated the diff for D98617: [AMDGPU, NFC] Refactor FP/BP spill index code in emitPrologue/emitEpilogue.

Address review comments.

Mar 16 2021, 2:59 AM · Restricted Project

Mar 14 2021

RamNalamothu requested review of D98617: [AMDGPU, NFC] Refactor FP/BP spill index code in emitPrologue/emitEpilogue.
Mar 14 2021, 10:22 PM · Restricted Project

Mar 9 2021

RamNalamothu added a comment to D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling.

I think I have addressed the feedback. Could you please take a look now?

Mar 9 2021, 1:21 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling.

Rebase onto ToT.

Mar 9 2021, 1:01 AM · debug-info, Restricted Project
RamNalamothu retitled D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling from [AMDGPU] Add SupportsDebugUnwindInformation to MCAsmInfo to [AMDGPU] Add SupportsDebugOnlyCFI to MCAsmInfo.
Mar 9 2021, 12:56 AM · debug-info, Restricted Project

Mar 5 2021

RamNalamothu committed rG3998a8e79761: [AMDGPU] Do not attempt sgpr spills to vgpr, when it is disabled (authored by RamNalamothu).
[AMDGPU] Do not attempt sgpr spills to vgpr, when it is disabled
Mar 5 2021, 9:18 AM
RamNalamothu closed D98013: [AMDGPU] Do not attempt sgpr spills to vgpr, when it is disabled.
Mar 5 2021, 9:17 AM · Restricted Project
RamNalamothu requested review of D98013: [AMDGPU] Do not attempt sgpr spills to vgpr, when it is disabled.
Mar 5 2021, 12:26 AM · Restricted Project

Feb 12 2021

RamNalamothu updated the diff for D76884: [AMDGPU] Implement -amdgpu-spill-cfi-saved-regs.

Rebase onto LLVM trunk and couple of bug fixes where we need to save FP due to CFI register spills but did not save it.

Feb 12 2021, 2:24 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76883: [AMDGPU] Implement CFI for CSR spills.

Rebase onto LLVM trunk.

Feb 12 2021, 2:19 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76882: [AMDGPU] Implement CFI for non-kernel functions.

Rebase onto LLVM trunk.

Feb 12 2021, 2:17 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76880: [AMDGPU] Emit entry function CFI.

Rebase onto LLVM trunk.

Feb 12 2021, 2:15 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76878: Implement DW_{OP,AT}_LLVM_* for Heterogeneous Debugging.

Rebase and ping.

Feb 12 2021, 2:13 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging.

Rebase and extend the patch to cover https://reviews.llvm.org/rGf8122d35325d9a5d3db7d4c0d40bcdeae15bee5a.

Feb 12 2021, 2:10 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling.

Rebase and ping

Feb 12 2021, 2:06 AM · debug-info, Restricted Project

Jan 31 2021

RamNalamothu accepted D95768: [AMDGPU] Fix crash with sgpr spills to vgpr disabled.

LGTM

Jan 31 2021, 8:44 PM · Restricted Project

Jan 21 2021

RamNalamothu committed rGb6c3a59c3f55: [AMDGPU] Test case demonstrating issues with generation of .debug_frame (authored by RamNalamothu).
[AMDGPU] Test case demonstrating issues with generation of .debug_frame
Jan 21 2021, 6:09 PM
RamNalamothu closed D94801: [AMDGPU] Test case demonstrating issues with generation of .debug_frame.
Jan 21 2021, 6:09 PM · Restricted Project

Jan 15 2021

RamNalamothu updated the diff for D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling.

How does it look now, with some renaming I did?

Jan 15 2021, 10:26 AM · debug-info, Restricted Project
RamNalamothu requested review of D94801: [AMDGPU] Test case demonstrating issues with generation of .debug_frame.
Jan 15 2021, 9:27 AM · Restricted Project

Dec 18 2020

RamNalamothu added a comment to D76519: [NFC] Refactor how CFI section types are represented in AsmPrinter.

As a potential follow-up, I do want the CFIMoveTypes concept to be better documented and probably rename it if it does not convey the intended meaning to readers.

Dec 18 2020, 3:59 AM · Restricted Project

Dec 10 2020

RamNalamothu added a comment to D78778: [MCAsmInfo] Support UsesCFIForDebug for targets with no exception handling.

(I'm probably not the best person to review this - just chimed in on the patch structure/testing issues, but here are some naive questions)

I haven't touched the streamer side of AsmPrinter in a long time, but...
On PS4 we default to -fno-exceptions and while the section ends up named .eh_frame instead of .debug_frame the content is fine; we've had no complaints from our debugger folks. Aside from the introduction of the .cfi directives (which you do want), I'm not aware that there's any codegen consequence to this combination.
So, I'm not clear why a special streamer is really necessary.

A special streamer is a straight forward and minimal changes approach we could arrive at as a means to solve the following concerns observed with the current implementation.

  1. Today, with -fno-exceptions, the command line option --force-dwarf-frame-section of llc doesn't do what it should as per D67216 i.e. a .debug_frame is not generated

Does this change address (1)? Should there be a test for --force-dwarf-frame-section to demonstrate this fix? (what cases did D67216 address? that are distinct from this case that it misses)

Dec 10 2020, 8:47 AM · debug-info, Restricted Project

Oct 27 2020

RamNalamothu updated the diff for D76884: [AMDGPU] Implement -amdgpu-spill-cfi-saved-regs.

Rebase onto LLVM master and address feedback

Oct 27 2020, 7:58 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76883: [AMDGPU] Implement CFI for CSR spills.

Rebase onto LLVM master and address feedback

Oct 27 2020, 7:56 AM · debug-info, Restricted Project
RamNalamothu updated the diff for D76882: [AMDGPU] Implement CFI for non-kernel functions.

Rebase onto LLVM master and address feedback

Oct 27 2020, 7:54 AM · debug-info, Restricted Project