This is an archive of the discontinued LLVM Phabricator instance.

[Attributor][NFC] Split AbstractAttribute subclasses out of Attributor.cpp
ClosedPublic

Authored by jdoerfert on Mar 26 2020, 11:21 AM.

Details

Summary

Attributor.cpp became quite big and we need to start provide structure.
The Attributor code is now in Attributor.cpp and the AbstractAttribute
subclasses are in AttributorAttributes.cpp. Minor changes were required
but no intended functional changes. We also minimized includes.

Depends on D76870.

Diff Detail

Event Timeline

jdoerfert created this revision.Mar 26 2020, 11:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2020, 11:21 AM

Improve documentation

I think this looks fine and makes sense. I'll give others a chance to read/comment before accepting.

baziotis added a comment.EditedMar 29 2020, 1:27 PM

Personally I don't have problem with big files, sometimes they're more easy to use. But I definitely agree that we should start thinking about structure and splitting into files can help.

I think we'll benefit from more structure and this is only one step in that direction. If there is no argument against I'd like to land this now as we have little attributor patches in the pipeline.

baziotis accepted this revision.Apr 4 2020, 5:38 PM

I think we'll benefit from more structure and this is only one step in that direction. If there is no argument against I'd like to land this now as we have little attributor patches in the pipeline.

Of course, LGTM.

This revision is now accepted and ready to land.Apr 4 2020, 5:38 PM
This revision was automatically updated to reflect the committed changes.
llvm/include/llvm/Transforms/IPO/Attributor.h