Page MenuHomePhabricator

[Attributor][NFC] Split AbstractAttribute subclasses out of Attributor.cpp
Needs ReviewPublic

Authored by jdoerfert on Thu, Mar 26, 11:21 AM.

Details

Summary

Attributor.cpp became quite big and we need to start provide structure.
The Attributor code is now in Attributor.cpp and the AbstractAttribute
subclasses are in AttributorAttributes.cpp. Minor changes were required
but no intended functional changes. We also minimized includes.

Depends on D76870.

Diff Detail

Event Timeline

jdoerfert created this revision.Thu, Mar 26, 11:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Mar 26, 11:21 AM

Improve documentation

I think this looks fine and makes sense. I'll give others a chance to read/comment before accepting.

baziotis added a comment.EditedSun, Mar 29, 1:27 PM

Personally I don't have problem with big files, sometimes they're more easy to use. But I definitely agree that we should start thinking about structure and splitting into files can help.