This is an archive of the discontinued LLVM Phabricator instance.

[Attributor] Use the proper context instruction in genericValueTraversal
ClosedPublic

Authored by jdoerfert on Mar 26 2020, 10:48 AM.

Details

Summary

There was a TODO in genericValueTraversal to provide the context
instruction and due to the lack of it users that wanted one just used
something available. Unfortunately, using a fixed instruction is wrong
in the presence of PHIs so we need to update the context instruction
properly.

Diff Detail

Event Timeline

jdoerfert created this revision.Mar 26 2020, 10:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2020, 10:48 AM
uenoku accepted this revision.Mar 29 2020, 7:48 AM

LGTM

This revision is now accepted and ready to land.Mar 29 2020, 7:48 AM
This revision was automatically updated to reflect the committed changes.