Page MenuHomePhabricator

[lldb/DWARF] Use DW_AT_call_pc to determine artificial frame address
ClosedPublic

Authored by vsk on Mar 17 2020, 6:08 PM.

Details

Summary

lldb currently guesses the address to use when creating an artificial
frame (i.e., a frame constructed by determining the sequence of (tail)
calls which must have happened).

Guessing the address creates problems -- use the actual address provided
by the DW_AT_call_pc attribute instead.

Depends on D76336.

rdar://60307600

Diff Detail

Event Timeline

vsk created this revision.Mar 17 2020, 6:08 PM

Nice fix, this looks good to me but I haven't been following this area of code too closely before now.

vsk added a comment.Mar 24 2020, 11:37 AM

I'll land this shortly if there aren't any objections.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 24 2020, 12:22 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2020, 12:22 PM