Page MenuHomePhabricator
Differential D75886

[mlir][NFC] Move the interfaces and traits for side effects out of IR/ to Interfaces/
ClosedPublic
Actions

Authored by rriddle on Mar 9 2020, 6:09 PM.

Details

Reviewers
jpienaar
mehdi_amini
mravishankar
antiagainst
nicolasvasilache
herhut
aartbik
Commits
rG153720a0a567: [mlir][NFC] Move the interfaces and traits for side effects out of IR/ to…
Summary

Interfaces/ is the designated directory for these types of interfaces, and also removes the need for including them directly in IR/.

Depends On D75867

Diff Detail

Event Timeline

rriddle created this revision.Mar 9 2020, 6:09 PM
Herald added a reviewer: mravishankar. · View Herald TranscriptMar 9 2020, 6:09 PM
Herald added a reviewer: antiagainst. · View Herald Transcript
Herald added a reviewer: nicolasvasilache. · View Herald Transcript
Herald added a reviewer: herhut. · View Herald Transcript
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, bader, Joonsoo and 12 others. · View Herald Transcript
jpienaar accepted this revision.Mar 9 2020, 6:27 PM
This revision is now accepted and ready to land.Mar 9 2020, 6:27 PM
Harbormaster failed remote builds in B48626: Diff 249260!Mar 9 2020, 6:54 PM
rriddle added a child revision: D75888: [mlir][SideEffects] Mark the CFG only terminator operations as NoSideEffect.Mar 9 2020, 7:01 PM
mehdi_amini accepted this revision.Mar 9 2020, 8:04 PM
rriddle updated this revision to Diff 249471.Mar 10 2020, 12:21 PM

Rebase

Harbormaster failed remote builds in B48735: Diff 249471!Mar 10 2020, 1:06 PM
Closed by commit rG153720a0a567: [mlir][NFC] Move the interfaces and traits for side effects out of IR/ to… (authored by rriddle). · Explain WhyMar 10 2020, 1:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
mlir/
examples/
toy/
Ch2/
1 line
include/
toy/
1 line
Ch3/
1 line
include/
toy/
1 line
Ch4/
1 line
include/
toy/
1 line
Ch5/
1 line
include/
toy/
1 line
Ch6/
1 line
include/
toy/
1 line
Ch7/
1 line
include/
toy/
1 line
include/
mlir/
Dialect/
AffineOps/
1 line
FxpMathOps/
1 line
GPU/
1 line
LLVMIR/
1 line
2 lines
1 line
Linalg/
IR/
1 line
LoopOps/
1 line
QuantOps/
1 line
SPIRV/
1 line
Shape/
IR/
1 line
StandardOps/
IR/
1 line
2 lines
VectorOps/
1 line
IR/
5 lines
212 lines
Interfaces/
5 lines
230 lines
Interfaces/
IR/
6 lines
lib/
Dialect/
AffineOps/
1 line
FxpMathOps/
1 line
GPU/
1 line
LLVMIR/
3 lines
Linalg/
IR/
1 line
LoopOps/
1 line
QuantOps/
1 line
SPIRV/
1 line
Shape/
1 line
StandardOps/
1 line
VectorOps/
1 line
IR/
1 line
11 lines
Interfaces/
15 lines
27 lines
Transforms/
1 line
test/
lib/
TestDialect/
1 line
2 lines
mlir-tblgen/
2 lines

Diff 249481

View Options

mlir/examples/toy/Ch2/CMakeLists.txt

Loading...
View Options

mlir/examples/toy/Ch2/include/toy/Dialect.h

Loading...
View Options

mlir/examples/toy/Ch3/CMakeLists.txt

Loading...
View Options

mlir/examples/toy/Ch3/include/toy/Dialect.h

Loading...
View Options

mlir/examples/toy/Ch4/CMakeLists.txt

Loading...
View Options

mlir/examples/toy/Ch4/include/toy/Dialect.h

Loading...
View Options

mlir/examples/toy/Ch5/CMakeLists.txt

Loading...
View Options

mlir/examples/toy/Ch5/include/toy/Dialect.h

Loading...
View Options

mlir/examples/toy/Ch6/CMakeLists.txt

Loading...
View Options

mlir/examples/toy/Ch6/include/toy/Dialect.h

Loading...
View Options

mlir/examples/toy/Ch7/CMakeLists.txt

Loading...
View Options

mlir/examples/toy/Ch7/include/toy/Dialect.h

Loading...
View Options

mlir/include/mlir/Dialect/AffineOps/AffineOps.h

Loading...
View Options

mlir/include/mlir/Dialect/FxpMathOps/FxpMathOps.h

Loading...
View Options

mlir/include/mlir/Dialect/GPU/GPUDialect.h

Loading...
View Options

mlir/include/mlir/Dialect/LLVMIR/LLVMDialect.h

Loading...
View Options

mlir/include/mlir/Dialect/LLVMIR/NVVMDialect.h

Loading...
View Options

mlir/include/mlir/Dialect/LLVMIR/ROCDLDialect.h

Loading...
View Options

mlir/include/mlir/Dialect/Linalg/IR/LinalgOps.h

Loading...
View Options

mlir/include/mlir/Dialect/LoopOps/LoopOps.h

Loading...
View Options

mlir/include/mlir/Dialect/QuantOps/QuantOps.h

Loading...
View Options

mlir/include/mlir/Dialect/SPIRV/SPIRVOps.h

Loading...
View Options

mlir/include/mlir/Dialect/Shape/IR/Shape.h

Loading...
View Options

mlir/include/mlir/Dialect/StandardOps/IR/Ops.h

Loading...
View Options

mlir/include/mlir/Dialect/StandardOps/IR/Ops.td

Loading...
View Options

mlir/include/mlir/Dialect/VectorOps/VectorOps.h

Loading...
View Options

mlir/include/mlir/IR/CMakeLists.txt

Loading...
View Options

mlir/include/mlir/IR/OpDefinition.h

Loading...
View Options

mlir/include/mlir/IR/SideEffects.td

Loading...
View Options

mlir/include/mlir/Interfaces/CMakeLists.txt

Loading...
View Options

mlir/include/mlir/Interfaces/SideEffects.h

Loading...
View Options

mlir/include/mlir/Interfaces/SideEffects.td

Loading...
View Options

mlir/lib/Dialect/AffineOps/CMakeLists.txt

Loading...
View Options

mlir/lib/Dialect/FxpMathOps/CMakeLists.txt

Loading...
View Options

mlir/lib/Dialect/GPU/CMakeLists.txt

Loading...
View Options

mlir/lib/Dialect/LLVMIR/CMakeLists.txt

Loading...
View Options

mlir/lib/Dialect/Linalg/IR/CMakeLists.txt

Loading...
View Options

mlir/lib/Dialect/LoopOps/CMakeLists.txt

Loading...
View Options

mlir/lib/Dialect/QuantOps/CMakeLists.txt

Loading...
View Options

mlir/lib/Dialect/SPIRV/CMakeLists.txt

Loading...
View Options

mlir/lib/Dialect/Shape/CMakeLists.txt

Loading...
View Options

mlir/lib/Dialect/StandardOps/CMakeLists.txt

Loading...
View Options

mlir/lib/Dialect/VectorOps/CMakeLists.txt

Loading...
View Options

mlir/lib/IR/CMakeLists.txt

Loading...
View Options

mlir/lib/IR/Operation.cpp

Loading...
View Options

mlir/lib/Interfaces/CMakeLists.txt

Loading...
View Options

mlir/lib/Interfaces/SideEffects.cpp

Loading...
View Options

mlir/lib/Transforms/LoopInvariantCodeMotion.cpp

Loading...
View Options

mlir/test/lib/TestDialect/TestDialect.h

Loading...
View Options

mlir/test/lib/TestDialect/TestOps.td

Loading...
View Options

mlir/test/mlir-tblgen/op-side-effects.td

Loading...