Page MenuHomePhabricator

[mlir][NFC] Move the definition of AffineApplyOp to ODS
ClosedPublic

Authored by rriddle on Mar 11 2020, 11:45 AM.

Details

Summary

This has been a long standing cleanup TODO.

Depends On D75968

Diff Detail

Event Timeline

rriddle created this revision.Mar 11 2020, 11:45 AM
jpienaar accepted this revision.Mar 12 2020, 10:31 AM
jpienaar marked an inline comment as done.

Looks good, keeping it mostly mechanical is good :)

mlir/include/mlir/Dialect/AffineOps/AffineOps.td
87

These could be derived attributes :-)

This revision is now accepted and ready to land.Mar 12 2020, 10:31 AM
bondhugula accepted this revision.Mar 12 2020, 11:13 AM
bondhugula added inline comments.
mlir/include/mlir/Dialect/AffineOps/AffineOps.td
49

-> the affine mapping has to be one-dimensional, and so the affine.apply operation always returns one value.

?

67

? This doesn't appear clear to me.

mlir/lib/Dialect/AffineOps/AffineOps.cpp
247

AffineApplyOp::getOperationName() while at this.

rriddle updated this revision to Diff 250005.Mar 12 2020, 11:48 AM
rriddle marked 3 inline comments as done.

Resolve comments

This revision was automatically updated to reflect the committed changes.