This is an archive of the discontinued LLVM Phabricator instance.

Differential D75613

[Sema] Reword -Wrange-loop-analysis warning messages
ClosedPublic

Authored by aaronpuchert on Mar 4 2020, 8:10 AM.

Details

Reviewers
aaron.ballman
Mordante
rtrieu
Commits
rG33bb32bbc674: [Sema] Reword -Wrange-loop-analysis warning messages
Summary

The messages for two of the warnings are misleading:

  • warn_for_range_const_reference_copy suggests that the initialization of the loop variable results in a copy. But that's not always true, we just know that some conversion happens, potentially invoking a constructor or conversion operator. The constructor might copy, as in the example that lead to this message [1], but it might also not. However, the constructed object is bound to a reference, which is potentially misleading, so we rewrite the message to emphasize that. We also make sure that we print the reference type into the warning message to clarify that this warning only appears when operator* returns a reference.
  • warn_for_range_variable_always_copy suggests that a reference type loop variable initialized from a temporary "is always a copy". But we don't know this, the range might just return temporary objects which aren't copies of anything. (Assuming RVO a copy constructor might never have been called.)

The message for warn_for_range_copy is a bit repetitive: the type of a
VarDecl and its initialization Expr are the same up to cv-qualifiers,
because Sema will insert implicit casts or constructor calls to make
them match.

[1] https://bugs.llvm.org/show_bug.cgi?id=32823

Diff Detail

Event Timeline

aaronpuchert created this revision.Mar 4 2020, 8:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2020, 8:10 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aaronpuchert added a comment.EditedMar 4 2020, 8:16 AM

This addresses my earlier comment D73007#1853563.

Harbormaster completed remote builds in B48050: Diff 248179.Mar 4 2020, 9:00 AM
Mordante added a comment.Mar 4 2020, 12:00 PM

Thanks for the patch! I've some minor nits, but other then that it looks fine.

clang/include/clang/Basic/DiagnosticSemaKinds.td
2427

I'd like to change this name to reflect the changed diagnostic.

2434

I'd like to change this name to reflect the changed diagnostic.

aaronpuchert updated this revision to Diff 248325.Mar 4 2020, 2:44 PM
  • Change diagnostic names to reflect the changed messages.
  • Also change the wording of note_use_type_or_non_reference.
  • The warning that was warn_for_range_const_reference_copy is only emitted if the operator* call returns a reference, so we should also print a reference type in the warning message. Otherwise this would be confusing.
aaronpuchert edited the summary of this revision. (Show Details)Mar 4 2020, 2:46 PM
aaronpuchert marked 2 inline comments as done.
aaronpuchert updated this revision to Diff 248332.Mar 4 2020, 2:53 PM

Drop SpelledAsLValue = false, which seems to be wrong.

Harbormaster completed remote builds in B48116: Diff 248325.Mar 4 2020, 3:46 PM
Harbormaster completed remote builds in B48120: Diff 248332.
aaron.ballman accepted this revision.Mar 5 2020, 1:48 PM

LGTM!

This revision is now accepted and ready to land.Mar 5 2020, 1:48 PM
Closed by commit rG33bb32bbc674: [Sema] Reword -Wrange-loop-analysis warning messages (authored by aaronpuchert). · Explain WhyMar 6 2020, 6:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
include/
clang/
Basic/
15 lines
lib/
Sema/
28 lines
test/
SemaCXX/
8 lines
86 lines

Diff 248325

clang/include/clang/Basic/DiagnosticSemaKinds.td

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 2,418 Lines • ▼ Show 20 Linesdef err_range_on_array_parameter : Error<
"parameter with array type %1 is treated as pointer type %2">; "parameter with array type %1 is treated as pointer type %2">;
def err_for_range_dereference : Error< def err_for_range_dereference : Error<
"invalid range expression of type %0; did you mean to dereference it " "invalid range expression of type %0; did you mean to dereference it "
"with '*'?">; "with '*'?">;
def note_for_range_invalid_iterator : Note < def note_for_range_invalid_iterator : Note <
"in implicit call to 'operator%select{!=|*|++}0' for iterator of type %1">; "in implicit call to 'operator%select{!=|*|++}0' for iterator of type %1">;
def note_for_range_begin_end : Note< def note_for_range_begin_end : Note<
"selected '%select{begin|end}0' %select{function|template }1%2 with iterator type %3">; "selected '%select{begin|end}0' %select{function|template }1%2 with iterator type %3">;
def warn_for_range_const_reference_copy : Warning< def warn_for_range_const_ref_binds_temp_built_from_ref : Warning<
MordanteUnsubmitted
Done
ReplyInline Actions

I'd like to change this name to reflect the changed diagnostic.

Mordante: I'd like to change this name to reflect the changed diagnostic.
"loop variable %0 " "loop variable %0 "
"%diff{has type $ but is initialized with type $" "%diff{of type $ binds to a temporary constructed from type $"
"|is initialized with a value of a different type}1,2 resulting in a copy">, "|binds to a temporary constructed from a different type}1,2">,
InGroup<RangeLoopConstruct>, DefaultIgnore; InGroup<RangeLoopConstruct>, DefaultIgnore;
def note_use_type_or_non_reference : Note< def note_use_type_or_non_reference : Note<
"use non-reference type %0 to keep the copy or type %1 to prevent copying">; "use non-reference type %0 to make construction explicit or type %1 to prevent copying">;
def warn_for_range_variable_always_copy : Warning< def warn_for_range_ref_binds_ret_temp : Warning<
MordanteUnsubmitted
Done
ReplyInline Actions

I'd like to change this name to reflect the changed diagnostic.

Mordante: I'd like to change this name to reflect the changed diagnostic.
"loop variable %0 is always a copy because the range of type %1 does not " "loop variable %0 binds to a temporary value produced by a range of type %1">,
"return a reference">,
InGroup<RangeLoopBindReference>, DefaultIgnore; InGroup<RangeLoopBindReference>, DefaultIgnore;
def note_use_non_reference_type : Note<"use non-reference type %0">; def note_use_non_reference_type : Note<"use non-reference type %0">;
def warn_for_range_copy : Warning< def warn_for_range_copy : Warning<
"loop variable %0 of type %1 creates a copy from type %2">, "loop variable %0 creates a copy from type %1">,
InGroup<RangeLoopConstruct>, DefaultIgnore; InGroup<RangeLoopConstruct>, DefaultIgnore;
def note_use_reference_type : Note<"use reference type %0 to prevent copying">; def note_use_reference_type : Note<"use reference type %0 to prevent copying">;
def err_objc_for_range_init_stmt : Error< def err_objc_for_range_init_stmt : Error<
"initialization statement is not supported when iterating over Objective-C " "initialization statement is not supported when iterating over Objective-C "
"collection">; "collection">;
// C++11 constexpr // C++11 constexpr
def warn_cxx98_compat_constexpr : Warning< def warn_cxx98_compat_constexpr : Warning<
▲ Show 20 Lines • Show All 8,168 Lines • Show Last 20 Lines

clang/lib/Sema/SemaStmt.cpp

Show First 20 Lines • Show All 2,735 Lines • ▼ Show 20 Lines if (const CXXConstructExpr *CCE = dyn_cast<CXXConstructExpr>(E)) {
E = ME->getBase(); E = ME->getBase();
} else { } else {
const MaterializeTemporaryExpr *MTE = cast<MaterializeTemporaryExpr>(E); const MaterializeTemporaryExpr *MTE = cast<MaterializeTemporaryExpr>(E);
E = MTE->getSubExpr(); E = MTE->getSubExpr();
} }
E = E->IgnoreImpCasts(); E = E->IgnoreImpCasts();
} }
bool ReturnsReference = false; QualType ReferenceReturnType;
if (isa<UnaryOperator>(E)) { if (isa<UnaryOperator>(E)) {
ReturnsReference = true; ReferenceReturnType =
SemaRef.Context.getLValueReferenceType(E->getType(), false);
} else { } else {
const CXXOperatorCallExpr *Call = cast<CXXOperatorCallExpr>(E); const CXXOperatorCallExpr *Call = cast<CXXOperatorCallExpr>(E);
const FunctionDecl *FD = Call->getDirectCallee(); const FunctionDecl *FD = Call->getDirectCallee();
QualType ReturnType = FD->getReturnType(); QualType ReturnType = FD->getReturnType();
ReturnsReference = ReturnType->isReferenceType(); if (ReturnType->isReferenceType())
ReferenceReturnType = ReturnType;
} }
if (ReturnsReference) { if (!ReferenceReturnType.isNull()) {
// Loop variable creates a temporary. Suggest either to go with // Loop variable creates a temporary. Suggest either to go with
// non-reference loop variable to indicate a copy is made, or // non-reference loop variable to indicate a copy is made, or
// the correct time to bind a const reference. // the correct type to bind a const reference.
SemaRef.Diag(VD->getLocation(), diag::warn_for_range_const_reference_copy) SemaRef.Diag(VD->getLocation(),
<< VD << VariableType << E->getType(); diag::warn_for_range_const_ref_binds_temp_built_from_ref)
<< VD << VariableType << ReferenceReturnType;
QualType NonReferenceType = VariableType.getNonReferenceType(); QualType NonReferenceType = VariableType.getNonReferenceType();
NonReferenceType.removeLocalConst(); NonReferenceType.removeLocalConst();
QualType NewReferenceType = QualType NewReferenceType =
SemaRef.Context.getLValueReferenceType(E->getType().withConst()); SemaRef.Context.getLValueReferenceType(E->getType().withConst());
SemaRef.Diag(VD->getBeginLoc(), diag::note_use_type_or_non_reference) SemaRef.Diag(VD->getBeginLoc(), diag::note_use_type_or_non_reference)
<< NonReferenceType << NewReferenceType << VD->getSourceRange() << NonReferenceType << NewReferenceType << VD->getSourceRange()
<< FixItHint::CreateRemoval(VD->getTypeSpecEndLoc()); << FixItHint::CreateRemoval(VD->getTypeSpecEndLoc());
} else if (!VariableType->isRValueReferenceType()) { } else if (!VariableType->isRValueReferenceType()) {
// The range always returns a copy, so a temporary is always created. // The range always returns a copy, so a temporary is always created.
// Suggest removing the reference from the loop variable. // Suggest removing the reference from the loop variable.
// If the type is a rvalue reference do not warn since that changes the // If the type is a rvalue reference do not warn since that changes the
// semantic of the code. // semantic of the code.
SemaRef.Diag(VD->getLocation(), diag::warn_for_range_variable_always_copy) SemaRef.Diag(VD->getLocation(), diag::warn_for_range_ref_binds_ret_temp)
<< VD << RangeInitType; << VD << RangeInitType;
QualType NonReferenceType = VariableType.getNonReferenceType(); QualType NonReferenceType = VariableType.getNonReferenceType();
NonReferenceType.removeLocalConst(); NonReferenceType.removeLocalConst();
SemaRef.Diag(VD->getBeginLoc(), diag::note_use_non_reference_type) SemaRef.Diag(VD->getBeginLoc(), diag::note_use_non_reference_type)
<< NonReferenceType << VD->getSourceRange() << NonReferenceType << VD->getSourceRange()
<< FixItHint::CreateRemoval(VD->getTypeSpecEndLoc()); << FixItHint::CreateRemoval(VD->getTypeSpecEndLoc());
} }
} }
Show All 35 Linesstatic void DiagnoseForRangeConstVariableCopies(Sema &SemaRef,
if (Ctx.getTypeSize(VariableType) <= 64 * 8 && if (Ctx.getTypeSize(VariableType) <= 64 * 8 &&
(VariableType.isTriviallyCopyableType(Ctx) || (VariableType.isTriviallyCopyableType(Ctx) ||
hasTrivialABIAttr(VariableType))) hasTrivialABIAttr(VariableType)))
return; return;
// Suggest changing from a const variable to a const reference variable // Suggest changing from a const variable to a const reference variable
// if doing so will prevent a copy. // if doing so will prevent a copy.
SemaRef.Diag(VD->getLocation(), diag::warn_for_range_copy) SemaRef.Diag(VD->getLocation(), diag::warn_for_range_copy)
<< VD << VariableType << InitExpr->getType(); << VD << VariableType;
SemaRef.Diag(VD->getBeginLoc(), diag::note_use_reference_type) SemaRef.Diag(VD->getBeginLoc(), diag::note_use_reference_type)
<< SemaRef.Context.getLValueReferenceType(VariableType) << SemaRef.Context.getLValueReferenceType(VariableType)
<< VD->getSourceRange() << VD->getSourceRange()
<< FixItHint::CreateInsertion(VD->getLocation(), "&"); << FixItHint::CreateInsertion(VD->getLocation(), "&");
} }
/// DiagnoseForRangeVariableCopies - Diagnose three cases and fixes for them. /// DiagnoseForRangeVariableCopies - Diagnose three cases and fixes for them.
/// 1) for (const foo &x : foos) where foos only returns a copy. Suggest /// 1) for (const foo &x : foos) where foos only returns a copy. Suggest
/// using "const foo x" to show that a copy is made /// using "const foo x" to show that a copy is made
/// 2) for (const bar &x : foos) where bar is a temporary initialized by bar. /// 2) for (const bar &x : foos) where bar is a temporary initialized by bar.
/// Suggest either "const bar x" to keep the copying or "const foo& x" to /// Suggest either "const bar x" to keep the copying or "const foo& x" to
/// prevent the copy. /// prevent the copy.
/// 3) for (const foo x : foos) where x is constructed from a reference foo. /// 3) for (const foo x : foos) where x is constructed from a reference foo.
/// Suggest "const foo &x" to prevent the copy. /// Suggest "const foo &x" to prevent the copy.
static void DiagnoseForRangeVariableCopies(Sema &SemaRef, static void DiagnoseForRangeVariableCopies(Sema &SemaRef,
const CXXForRangeStmt *ForStmt) { const CXXForRangeStmt *ForStmt) {
if (SemaRef.inTemplateInstantiation()) if (SemaRef.inTemplateInstantiation())
return; return;
if (SemaRef.Diags.isIgnored(diag::warn_for_range_const_reference_copy, if (SemaRef.Diags.isIgnored(
diag::warn_for_range_const_ref_binds_temp_built_from_ref,
ForStmt->getBeginLoc()) && ForStmt->getBeginLoc()) &&
SemaRef.Diags.isIgnored(diag::warn_for_range_variable_always_copy, SemaRef.Diags.isIgnored(diag::warn_for_range_ref_binds_ret_temp,
ForStmt->getBeginLoc()) && ForStmt->getBeginLoc()) &&
SemaRef.Diags.isIgnored(diag::warn_for_range_copy, SemaRef.Diags.isIgnored(diag::warn_for_range_copy,
ForStmt->getBeginLoc())) { ForStmt->getBeginLoc())) {
return; return;
} }
const VarDecl *VD = ForStmt->getLoopVariable(); const VarDecl *VD = ForStmt->getLoopVariable();
if (!VD) if (!VD)
▲ Show 20 Lines • Show All 1,612 Lines • Show Last 20 Lines

clang/test/SemaCXX/warn-range-loop-analysis-trivially-copyable.cpp

Show All 10 Lines for (const auto r : records)
(void)r; (void)r;
} }
void test_POD_65_bytes() { void test_POD_65_bytes() {
struct Record { struct Record {
char a[65]; char a[65];
}; };
// expected-warning@+3 {{loop variable 'r' of type 'const Record' creates a copy from type 'const Record'}} // expected-warning@+3 {{loop variable 'r' creates a copy from type 'const Record'}}
// expected-note@+2 {{use reference type 'const Record &' to prevent copying}} // expected-note@+2 {{use reference type 'const Record &' to prevent copying}}
Record records[8]; Record records[8];
for (const auto r : records) for (const auto r : records)
(void)r; (void)r;
} }
void test_TriviallyCopyable_64_bytes() { void test_TriviallyCopyable_64_bytes() {
struct Record { struct Record {
Record() {} Record() {}
char a[64]; char a[64];
}; };
Record records[8]; Record records[8];
for (const auto r : records) for (const auto r : records)
(void)r; (void)r;
} }
void test_TriviallyCopyable_65_bytes() { void test_TriviallyCopyable_65_bytes() {
struct Record { struct Record {
Record() {} Record() {}
char a[65]; char a[65];
}; };
// expected-warning@+3 {{loop variable 'r' of type 'const Record' creates a copy from type 'const Record'}} // expected-warning@+3 {{loop variable 'r' creates a copy from type 'const Record'}}
// expected-note@+2 {{use reference type 'const Record &' to prevent copying}} // expected-note@+2 {{use reference type 'const Record &' to prevent copying}}
Record records[8]; Record records[8];
for (const auto r : records) for (const auto r : records)
(void)r; (void)r;
} }
void test_NonTriviallyCopyable() { void test_NonTriviallyCopyable() {
struct Record { struct Record {
Record() {} Record() {}
~Record() {} ~Record() {}
volatile int a; volatile int a;
int b; int b;
}; };
// expected-warning@+3 {{loop variable 'r' of type 'const Record' creates a copy from type 'const Record'}} // expected-warning@+3 {{loop variable 'r' creates a copy from type 'const Record'}}
// expected-note@+2 {{use reference type 'const Record &' to prevent copying}} // expected-note@+2 {{use reference type 'const Record &' to prevent copying}}
Record records[8]; Record records[8];
for (const auto r : records) for (const auto r : records)
(void)r; (void)r;
} }
void test_TrivialABI_64_bytes() { void test_TrivialABI_64_bytes() {
struct [[clang::trivial_abi]] Record { struct [[clang::trivial_abi]] Record {
Show All 9 Lines
void test_TrivialABI_65_bytes() { void test_TrivialABI_65_bytes() {
struct [[clang::trivial_abi]] Record { struct [[clang::trivial_abi]] Record {
Record() {} Record() {}
~Record() {} ~Record() {}
char a[65]; char a[65];
}; };
// expected-warning@+3 {{loop variable 'r' of type 'const Record' creates a copy from type 'const Record'}} // expected-warning@+3 {{loop variable 'r' creates a copy from type 'const Record'}}
// expected-note@+2 {{use reference type 'const Record &' to prevent copying}} // expected-note@+2 {{use reference type 'const Record &' to prevent copying}}
Record records[8]; Record records[8];
for (const auto r : records) for (const auto r : records)
(void)r; (void)r;
} }

clang/test/SemaCXX/warn-range-loop-analysis.cpp

Show First 20 Lines • Show All 65 Lines • ▼ Show 20 Lines
// Bar => int // Bar => int
void test0() { void test0() {
Container<int> int_non_ref_container; Container<int> int_non_ref_container;
Container<int&> int_container; Container<int&> int_container;
Container<Bar&> bar_container; Container<Bar&> bar_container;
for (const int &x : int_non_ref_container) {} for (const int &x : int_non_ref_container) {}
// expected-warning@-1 {{loop variable 'x' is always a copy because the range of type 'Container<int>' does not return a reference}} // expected-warning@-1 {{loop variable 'x' binds to a temporary value produced by a range of type 'Container<int>'}}
// expected-note@-2 {{use non-reference type 'int'}} // expected-note@-2 {{use non-reference type 'int'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:""
for (const double &x : int_container) {} for (const double &x : int_container) {}
// expected-warning@-1 {{loop variable 'x' has type 'const double &' but is initialized with type 'int' resulting in a copy}} // expected-warning@-1 {{loop variable 'x' of type 'const double &' binds to a temporary constructed from type 'int &'}}
// expected-note@-2 {{use non-reference type 'double' to keep the copy or type 'const int &' to prevent copying}} // expected-note@-2 {{use non-reference type 'double' to make construction explicit or type 'const int &' to prevent copying}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:21-[[@LINE-3]]:22}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:21-[[@LINE-3]]:22}:""
for (const Bar x : bar_container) {} for (const Bar x : bar_container) {}
// expected-warning@-1 {{loop variable 'x' of type 'const Bar' creates a copy from type 'const Bar'}} // expected-warning@-1 {{loop variable 'x' creates a copy from type 'const Bar'}}
// expected-note@-2 {{use reference type 'const Bar &' to prevent copying}} // expected-note@-2 {{use reference type 'const Bar &' to prevent copying}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:18}:"&" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:18}:"&"
} }
void test1() { void test1() {
Container<int> A; Container<int> A;
for (const int &&x : A) {} for (const int &&x : A) {}
// No warning, rvalue-reference to the temporary // No warning, rvalue-reference to the temporary
for (const int &x : A) {} for (const int &x : A) {}
// expected-warning@-1 {{always a copy}} // expected-warning@-1 {{binds to a temporary value produced by a range}}
// expected-note@-2 {{'int'}} // expected-note@-2 {{'int'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:""
for (const int x : A) {} for (const int x : A) {}
// No warning, non-reference type indicates copy is made // No warning, non-reference type indicates copy is made
for (int&& x : A) {} for (int&& x : A) {}
// No warning, rvalue-reference to the temporary // No warning, rvalue-reference to the temporary
//for (int &x : A) {} //for (int &x : A) {}
// Binding error // Binding error
for (int x : A) {} for (int x : A) {}
// No warning, non-reference type indicates copy is made // No warning, non-reference type indicates copy is made
for (const double &&x : A) {} for (const double &&x : A) {}
// No warning, rvalue-reference to the temporary // No warning, rvalue-reference to the temporary
for (const double &x : A) {} for (const double &x : A) {}
// expected-warning@-1 {{always a copy}} // expected-warning@-1 {{binds to a temporary value produced by a range}}
// expected-note@-2 {{'double'}} // expected-note@-2 {{'double'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:21-[[@LINE-3]]:22}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:21-[[@LINE-3]]:22}:""
for (const double x : A) {} for (const double x : A) {}
// No warning, non-reference type indicates copy is made // No warning, non-reference type indicates copy is made
for (double &&x : A) {} for (double &&x : A) {}
// No warning, rvalue-reference to the temporary // No warning, rvalue-reference to the temporary
//for (double &x : A) {} //for (double &x : A) {}
// Binding error // Binding error
for (double x : A) {} for (double x : A) {}
// No warning, non-reference type indicates copy is made // No warning, non-reference type indicates copy is made
for (const Bar &&x : A) {} for (const Bar &&x : A) {}
// No warning, rvalue-reference to the temporary // No warning, rvalue-reference to the temporary
for (const Bar &x : A) {} for (const Bar &x : A) {}
// expected-warning@-1 {{always a copy}} // expected-warning@-1 {{binds to a temporary value produced by a range}}
// expected-note@-2 {{'Bar'}} // expected-note@-2 {{'Bar'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:""
for (const Bar x : A) {} for (const Bar x : A) {}
// No warning, non-reference type indicates copy is made // No warning, non-reference type indicates copy is made
for (Bar &&x : A) {} for (Bar &&x : A) {}
// No warning, rvalue-reference to the temporary // No warning, rvalue-reference to the temporary
//for (Bar &x : A) {} //for (Bar &x : A) {}
// Binding error // Binding error
Show All 13 Linesvoid test2() {
//for (int &x : B) {} //for (int &x : B) {}
// Binding error // Binding error
for (int &x : B) {} for (int &x : B) {}
// No warning // No warning
for (int x : B) {} for (int x : B) {}
// No warning // No warning
for (const double &&x : B) {} for (const double &&x : B) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'double'{{.*}}'const int &'}} // expected-note-re@-2 {{'double'{{.*}}'const int &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:21-[[@LINE-3]]:23}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:21-[[@LINE-3]]:23}:""
for (const double &x : B) {} for (const double &x : B) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'double'{{.*}}'const int &'}} // expected-note-re@-2 {{'double'{{.*}}'const int &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:21-[[@LINE-3]]:22}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:21-[[@LINE-3]]:22}:""
for (const double x : B) {} for (const double x : B) {}
for (double &&x : B) {} for (double &&x : B) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'double'{{.*}}'const int &'}} // expected-note-re@-2 {{'double'{{.*}}'const int &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:15-[[@LINE-3]]:17}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:15-[[@LINE-3]]:17}:""
//for (double &x : B) {} //for (double &x : B) {}
// Binding error // Binding error
for (double x : B) {} for (double x : B) {}
// No warning // No warning
for (const Bar &&x : B) {} for (const Bar &&x : B) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note@-2 {{'Bar'}} // expected-note@-2 {{'Bar'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:20}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:20}:""
for (const Bar &x : B) {} for (const Bar &x : B) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note@-2 {{'Bar'}} // expected-note@-2 {{'Bar'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:""
for (const Bar x : B) {} for (const Bar x : B) {}
for (Bar &&x : B) {} for (Bar &&x : B) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note@-2 {{'Bar'}} // expected-note@-2 {{'Bar'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:12-[[@LINE-3]]:14}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:12-[[@LINE-3]]:14}:""
//for (Bar &x : B) {} //for (Bar &x : B) {}
// Binding error // Binding error
for (Bar x : B) {} for (Bar x : B) {}
// No warning // No warning
} }
void test3() { void test3() {
Container<Bar> C; Container<Bar> C;
for (const Bar &&x : C) {} for (const Bar &&x : C) {}
// No warning, rvalue-reference to the temporary // No warning, rvalue-reference to the temporary
for (const Bar &x : C) {} for (const Bar &x : C) {}
// expected-warning@-1 {{always a copy}} // expected-warning@-1 {{binds to a temporary value produced by a range}}
// expected-note@-2 {{'Bar'}} // expected-note@-2 {{'Bar'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:""
for (const Bar x : C) {} for (const Bar x : C) {}
// No warning, non-reference type indicates copy is made // No warning, non-reference type indicates copy is made
for (Bar &&x : C) {} for (Bar &&x : C) {}
// No warning, rvalue-reference to the temporary // No warning, rvalue-reference to the temporary
//for (Bar &x : C) {} //for (Bar &x : C) {}
// Binding error // Binding error
for (Bar x : C) {} for (Bar x : C) {}
// No warning, non-reference type indicates copy is made // No warning, non-reference type indicates copy is made
for (const int &&x : C) {} for (const int &&x : C) {}
// No warning, rvalue-reference to the temporary // No warning, rvalue-reference to the temporary
for (const int &x : C) {} for (const int &x : C) {}
// expected-warning@-1 {{always a copy}} // expected-warning@-1 {{binds to a temporary value produced by a range}}
// expected-note@-2 {{'int'}} // expected-note@-2 {{'int'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:""
for (const int x : C) {} for (const int x : C) {}
// No warning, copy made // No warning, copy made
for (int &&x : C) {} for (int &&x : C) {}
// No warning, rvalue-reference to the temporary // No warning, rvalue-reference to the temporary
//for (int &x : C) {} //for (int &x : C) {}
// Binding error // Binding error
Show All 15 Linesvoid test4() {
//for (Bar &&x : D) {} //for (Bar &&x : D) {}
// Binding error // Binding error
for (Bar &x : D) {} for (Bar &x : D) {}
// No warning // No warning
for (Bar x : D) {} for (Bar x : D) {}
// No warning // No warning
for (const int &&x : D) {} for (const int &&x : D) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'int'{{.*}}'const Bar &'}} // expected-note-re@-2 {{'int'{{.*}}'const Bar &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:20}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:20}:""
for (const int &x : D) {} for (const int &x : D) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'int'{{.*}}'const Bar &'}} // expected-note-re@-2 {{'int'{{.*}}'const Bar &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:""
for (const int x : D) {} for (const int x : D) {}
// No warning // No warning
for (int &&x : D) {} for (int &&x : D) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'int'{{.*}}'const Bar &'}} // expected-note-re@-2 {{'int'{{.*}}'const Bar &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:12-[[@LINE-3]]:14}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:12-[[@LINE-3]]:14}:""
//for (int &x : D) {} //for (int &x : D) {}
// Binding error // Binding error
for (int x : D) {} for (int x : D) {}
// No warning // No warning
} }
void test5() { void test5() {
Container<Foo> E; Container<Foo> E;
for (const Bar &&x : E) {} for (const Bar &&x : E) {}
// No warning, rvalue-reference to the temporary // No warning, rvalue-reference to the temporary
for (const Bar &x : E) {} for (const Bar &x : E) {}
// expected-warning@-1 {{always a copy}} // expected-warning@-1 {{binds to a temporary value produced by a range}}
// expected-note@-2 {{'Bar'}} // expected-note@-2 {{'Bar'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:""
for (const Bar x : E) {} for (const Bar x : E) {}
// No warning, non-reference type indicates copy is made // No warning, non-reference type indicates copy is made
for (Bar &&x : E) {} for (Bar &&x : E) {}
// No warning, rvalue-reference to the temporary // No warning, rvalue-reference to the temporary
//for (Bar &x : E) {} //for (Bar &x : E) {}
// Binding error // Binding error
for (Bar x : E) {} for (Bar x : E) {}
// No warning, non-reference type indicates copy is made // No warning, non-reference type indicates copy is made
} }
void test6() { void test6() {
Container<Foo&> F; Container<Foo&> F;
for (const Bar &&x : F) {} for (const Bar &&x : F) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'Bar'{{.*}}'const Foo &'}} // expected-note-re@-2 {{'Bar'{{.*}}'const Foo &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:20}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:20}:""
for (const Bar &x : F) {} for (const Bar &x : F) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'Bar'{{.*}}'const Foo &'}} // expected-note-re@-2 {{'Bar'{{.*}}'const Foo &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:""
for (const Bar x : F) {} for (const Bar x : F) {}
// No warning. // No warning.
for (Bar &&x : F) {} for (Bar &&x : F) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'Bar'{{.*}}'const Foo &'}} // expected-note-re@-2 {{'Bar'{{.*}}'const Foo &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:12-[[@LINE-3]]:14}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:12-[[@LINE-3]]:14}:""
//for (Bar &x : F) {} //for (Bar &x : F) {}
// Binding error // Binding error
for (Bar x : F) {} for (Bar x : F) {}
// No warning // No warning
} }
Show All 9 Linesvoid test7() {
//for (double &&x : G) {} //for (double &&x : G) {}
// Binding error // Binding error
for (double &x : G) {} for (double &x : G) {}
// No warning // No warning
for (double x : G) {} for (double x : G) {}
// No warning // No warning
for (const int &&x : G) {} for (const int &&x : G) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'int'{{.*}}'const double &'}} // expected-note-re@-2 {{'int'{{.*}}'const double &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:20}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:20}:""
for (const int &x : G) {} for (const int &x : G) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'int'{{.*}}'const double &'}} // expected-note-re@-2 {{'int'{{.*}}'const double &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:""
for (const int x : G) {} for (const int x : G) {}
// No warning // No warning
for (int &&x : G) {} for (int &&x : G) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'int'{{.*}}'const double &'}} // expected-note-re@-2 {{'int'{{.*}}'const double &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:12-[[@LINE-3]]:14}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:12-[[@LINE-3]]:14}:""
//for (int &x : G) {} //for (int &x : G) {}
// Binding error // Binding error
for (int x : G) {} for (int x : G) {}
// No warning // No warning
for (const Bar &&x : G) {} for (const Bar &&x : G) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'Bar'{{.*}}'const double &'}} // expected-note-re@-2 {{'Bar'{{.*}}'const double &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:20}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:20}:""
for (const Bar &x : G) {} for (const Bar &x : G) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'Bar'{{.*}}'const double &'}} // expected-note-re@-2 {{'Bar'{{.*}}'const double &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:""
for (const Bar x : G) {} for (const Bar x : G) {}
// No warning // No warning
for (Bar &&x : G) {} for (Bar &&x : G) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'Bar'{{.*}}'const double &'}} // expected-note-re@-2 {{'Bar'{{.*}}'const double &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:12-[[@LINE-3]]:14}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:12-[[@LINE-3]]:14}:""
//for (Bar &x : G) {} //for (Bar &x : G) {}
// Binding error // Binding error
for (Bar x : G) {} for (Bar x : G) {}
// No warning // No warning
} }
Show All 9 Linesvoid test8() {
//for (Foo &&x : H) {} //for (Foo &&x : H) {}
// Binding error // Binding error
for (Foo &x : H) {} for (Foo &x : H) {}
// No warning // No warning
for (Foo x : H) {} for (Foo x : H) {}
// No warning // No warning
for (const Bar &&x : H) {} for (const Bar &&x : H) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'Bar'{{.*}}'const Foo &'}} // expected-note-re@-2 {{'Bar'{{.*}}'const Foo &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:20}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:20}:""
for (const Bar &x : H) {} for (const Bar &x : H) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'Bar'{{.*}}'const Foo &'}} // expected-note-re@-2 {{'Bar'{{.*}}'const Foo &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:""
for (const Bar x : H) {} for (const Bar x : H) {}
// No warning // No warning
for (Bar &&x: H) {} for (Bar &&x: H) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'Bar'{{.*}}'const Foo &'}} // expected-note-re@-2 {{'Bar'{{.*}}'const Foo &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:12-[[@LINE-3]]:14}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:12-[[@LINE-3]]:14}:""
//for (Bar &x: H) {} //for (Bar &x: H) {}
// Binding error // Binding error
for (Bar x: H) {} for (Bar x: H) {}
// No warning // No warning
} }
Show All 11 Linesvoid test9() {
//for (Bar &&x : I) {} //for (Bar &&x : I) {}
// Binding error // Binding error
for (Bar &x : I) {} for (Bar &x : I) {}
// No warning // No warning
for (Bar x : I) {} for (Bar x : I) {}
// No warning // No warning
for (const int &&x : I) {} for (const int &&x : I) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'int'{{.*}}'const Bar &'}} // expected-note-re@-2 {{'int'{{.*}}'const Bar &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:20}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:20}:""
for (const int &x : I) {} for (const int &x : I) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'int'{{.*}}'const Bar &'}} // expected-note-re@-2 {{'int'{{.*}}'const Bar &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:""
for (const int x : I) {} for (const int x : I) {}
// No warning // No warning
for (int &&x : I) {} for (int &&x : I) {}
// expected-warning@-1 {{resulting in a copy}} // expected-warning@-1 {{binds to a temporary constructed from}}
// expected-note-re@-2 {{'int'{{.*}}'const Bar &'}} // expected-note-re@-2 {{'int'{{.*}}'const Bar &'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:12-[[@LINE-3]]:14}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:12-[[@LINE-3]]:14}:""
//for (int &x : I) {} //for (int &x : I) {}
// Binding error // Binding error
for (int x : I) {} for (int x : I) {}
// No warning // No warning
} }
void test10() { void test10() {
Container<Bar> C; Container<Bar> C;
for (const Bar &x : C) {} for (const Bar &x : C) {}
// expected-warning@-1 {{always a copy}} // expected-warning@-1 {{binds to a temporary value produced by a range}}
// expected-note@-2 {{'Bar'}} // expected-note@-2 {{'Bar'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:""
for (const Bar& x : C) {} for (const Bar& x : C) {}
// expected-warning@-1 {{always a copy}} // expected-warning@-1 {{binds to a temporary value produced by a range}}
// expected-note@-2 {{'Bar'}} // expected-note@-2 {{'Bar'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:17-[[@LINE-3]]:18}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:17-[[@LINE-3]]:18}:""
for (const Bar & x : C) {} for (const Bar & x : C) {}
// expected-warning@-1 {{always a copy}} // expected-warning@-1 {{binds to a temporary value produced by a range}}
// expected-note@-2 {{'Bar'}} // expected-note@-2 {{'Bar'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:20}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:20}:""
for (const Bar&x : C) {} for (const Bar&x : C) {}
// expected-warning@-1 {{always a copy}} // expected-warning@-1 {{binds to a temporary value produced by a range}}
// expected-note@-2 {{'Bar'}} // expected-note@-2 {{'Bar'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:17-[[@LINE-3]]:18}:" " // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:17-[[@LINE-3]]:18}:" "
} }
template <class T> template <class T>
void test_template_function() { void test_template_function() {
// In a template instantiation the diagnostics should not be emitted for // In a template instantiation the diagnostics should not be emitted for
// loops with dependent types. // loops with dependent types.
Container<Bar> C; Container<Bar> C;
for (const Bar &x : C) {} for (const Bar &x : C) {}
// expected-warning@-1 {{always a copy}} // expected-warning@-1 {{binds to a temporary value produced by a range}}
// expected-note@-2 {{'Bar'}} // expected-note@-2 {{'Bar'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:18-[[@LINE-3]]:19}:""
Container<T> Dependent; Container<T> Dependent;
for (const T &x : Dependent) {} for (const T &x : Dependent) {}
} }
template void test_template_function<Bar>(); template void test_template_function<Bar>();
template <class T> template <class T>
struct test_template_struct { struct test_template_struct {
static void static_member() { static void static_member() {
Container<Bar> C; Container<Bar> C;
for (const Bar &x : C) {} for (const Bar &x : C) {}
// expected-warning@-1 {{always a copy}} // expected-warning@-1 {{binds to a temporary value produced by a range}}
// expected-note@-2 {{'Bar'}} // expected-note@-2 {{'Bar'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:20-[[@LINE-3]]:21}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:20-[[@LINE-3]]:21}:""
Container<T> Dependent; Container<T> Dependent;
for (const T &x : Dependent) {} for (const T &x : Dependent) {}
} }
void member() { void member() {
Container<Bar> C; Container<Bar> C;
for (const Bar &x : C) {} for (const Bar &x : C) {}
// expected-warning@-1 {{always a copy}} // expected-warning@-1 {{binds to a temporary value produced by a range}}
// expected-note@-2 {{'Bar'}} // expected-note@-2 {{'Bar'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:20-[[@LINE-3]]:21}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:20-[[@LINE-3]]:21}:""
Container<T> Dependent; Container<T> Dependent;
for (const T &x : Dependent) {} for (const T &x : Dependent) {}
} }
}; };
template struct test_template_struct<Bar>; template struct test_template_struct<Bar>;
struct test_struct_with_templated_member { struct test_struct_with_templated_member {
void member() { void member() {
Container<Bar> C; Container<Bar> C;
for (const Bar &x : C) {} for (const Bar &x : C) {}
// expected-warning@-1 {{always a copy}} // expected-warning@-1 {{binds to a temporary value produced by a range}}
// expected-note@-2 {{'Bar'}} // expected-note@-2 {{'Bar'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:20-[[@LINE-3]]:21}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:20-[[@LINE-3]]:21}:""
} }
template <class T> template <class T>
void template_member() { void template_member() {
Container<Bar> C; Container<Bar> C;
for (const Bar &x : C) {} for (const Bar &x : C) {}
// expected-warning@-1 {{always a copy}} // expected-warning@-1 {{binds to a temporary value produced by a range}}
// expected-note@-2 {{'Bar'}} // expected-note@-2 {{'Bar'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:20-[[@LINE-3]]:21}:"" // CHECK: fix-it:"{{.*}}":{[[@LINE-3]]:20-[[@LINE-3]]:21}:""
Container<T> Dependent; Container<T> Dependent;
for (const T &x : Dependent) {} for (const T &x : Dependent) {}
} }
}; };
template void test_struct_with_templated_member::template_member<Bar>(); template void test_struct_with_templated_member::template_member<Bar>();
#define TEST_MACRO \ #define TEST_MACRO \
void test_macro() { \ void test_macro() { \
Container<Bar> C; \ Container<Bar> C; \
for (const Bar &x : C) {} \ for (const Bar &x : C) {} \
} }
TEST_MACRO TEST_MACRO