Page MenuHomePhabricator

rtrieu (Richard Trieu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 11 2012, 7:44 PM (558 w, 1 d)

Recent Activity

Jan 13 2023

rtrieu added inline comments to D140184: Fix crash with lambda and variadic template.
Jan 13 2023, 6:20 PM · Restricted Project

Dec 27 2022

rtrieu added inline comments to D139189: [libc++] Granularize <type_traits> includes in <concepts>.
Dec 27 2022, 4:29 PM · Restricted Project, Restricted Project
rtrieu committed rG0c6e74fa744b: [libc++] Remove self-include from header file NFC (authored by rtrieu).
[libc++] Remove self-include from header file NFC
Dec 27 2022, 3:59 PM · Restricted Project, Restricted Project

Dec 21 2022

rtrieu added inline comments to D138914: Make evaluation of nested requirement consistent with requires expr..
Dec 21 2022, 6:36 PM · Restricted Project, Restricted Project

Dec 15 2022

rtrieu updated the summary of D140184: Fix crash with lambda and variadic template.
Dec 15 2022, 6:56 PM · Restricted Project
rtrieu requested review of D140184: Fix crash with lambda and variadic template.
Dec 15 2022, 6:43 PM · Restricted Project

Nov 1 2022

rtrieu committed rGcbdb81e60b45: Fix DenseMap with APInt keys (authored by rtrieu).
Fix DenseMap with APInt keys
Nov 1 2022, 4:50 PM · Restricted Project, Restricted Project
rtrieu closed D135741: Change DenseMap keys for APInt to avoid collision with valid APIint.
Nov 1 2022, 4:50 PM · Restricted Project, Restricted Project

Oct 27 2022

rtrieu added a comment to D136564: [clang] Instantiate NTTPs and template default arguments with sugar.

I noticed some build failures after your commit. I'm trying to get a standalone reproducer.

Oct 27 2022, 9:04 PM · Restricted Project, Restricted Project

Oct 11 2022

rtrieu requested review of D135741: Change DenseMap keys for APInt to avoid collision with valid APIint.
Oct 11 2022, 8:44 PM · Restricted Project, Restricted Project

Sep 22 2022

rtrieu added inline comments to D133586: [clang] initialize type qualifiers for FunctionNoProtoType.
Sep 22 2022, 9:18 PM · Restricted Project, Restricted Project

Sep 9 2022

rtrieu added a comment to D133586: [clang] initialize type qualifiers for FunctionNoProtoType.

Do you have a test case for this?

Was struggling to think of a good one. How about a test that repeatedly generates a pcm for a func decl with no params and checks if the DECL_FUNCTION record is the same?

Sep 9 2022, 2:40 PM · Restricted Project, Restricted Project
rtrieu added a comment to D133586: [clang] initialize type qualifiers for FunctionNoProtoType.

Do you have a test case for this?

Sep 9 2022, 1:30 PM · Restricted Project, Restricted Project

Aug 17 2022

rtrieu added a comment to D130510: Missing tautological compare warnings due to unary operators.

This patch has been moving back and forth between IsIntegerLiteralConstantExpr and getIntegerLiteralSubexpressionValue. The first function is preexisting and the second one is a new function. The final patch seems to settle on using just getIntegerLiteralSubexpressionValue. Can you explain why the existing function does not meet your needs? It wasn't clear from the update messages why you went that way.

The existing function returns whether the expression is an ICE (sort of), the replacement function calculates the actual value and returns an optional APInt so you can perform operations on it directly. That said, a future refactoring could probably remove IsIntegerLiteralConstantExpr() and replace it with getIntegerLiteralSubexpressionValue(), but the only caller of IsIntegerLiteralConstantExpr() doesn't actually need the value at that point.

Aug 17 2022, 12:24 PM · Restricted Project, Restricted Project

Aug 16 2022

rtrieu added a comment to D130510: Missing tautological compare warnings due to unary operators.

This patch has been moving back and forth between IsIntegerLiteralConstantExpr and getIntegerLiteralSubexpressionValue. The first function is preexisting and the second one is a new function. The final patch seems to settle on using just getIntegerLiteralSubexpressionValue. Can you explain why the existing function does not meet your needs? It wasn't clear from the update messages why you went that way.

Aug 16 2022, 1:28 PM · Restricted Project, Restricted Project

Aug 10 2022

rtrieu accepted D131532: [Sema] Avoid isNullPointerConstant invocation.

I think this is a reasonable step for improving compile times. I put some suggestions for more descriptive names below (he said, after suggesting those names in the first place).

Aug 10 2022, 9:00 PM · Restricted Project, Restricted Project

Aug 4 2022

rtrieu added a comment to D130510: Missing tautological compare warnings due to unary operators.
void foo(long x) {
  if ((x & 1) == 1L) return;  // bad always false warning here
  static_assert(sizeof(int) < sizeof(long), "long is bigger than int");
  static_assert((long(15) & 1) == 1L, "proof that condition can be true");
}

I found this false positive case when testing your new patch. The condition is fine, but it gives an always false warning. When fixed, this would be another good test case to include.

Aug 4 2022, 3:03 PM · Restricted Project, Restricted Project

Aug 3 2022

rtrieu added a comment to D130510: Missing tautological compare warnings due to unary operators.

Can you add my earlier test case or something like it to SemaCXX/warn-bitwise-compare.cpp ?

Aug 3 2022, 8:12 PM · Restricted Project, Restricted Project

Aug 2 2022

rtrieu added a comment to D130510: Missing tautological compare warnings due to unary operators.

Because of this, warnings should treat dependent expressions as non-constant even when they can be evaluated, so only b3 should get a warning. This is causing the warning to be emitted on code heavy in template meta-programming, such as array libraries. Please revert or fix.

Yeah, I agree. Unfortunately, the CFG makes this exceptionally difficult because it walks over the instantiated code, so we've lost that the original expression was dependent by the time we get to checking the binary expressions. The original code worked by virtue of overfitting to *just* integer literals.

Not being able to detect when expressions are dependent inside template instantiations has been a pain for warnings since forever.

I believe that evaluating the expression would make this warning too broad and would need more testing that what was included here. Only handling UnaryOperator with IntegerLiteral sub-expression makes more sense for the warning, and adding in any new cases if we find them.

I agree that the warning is too broad right now and that's unintentional. However, manually handling every single case in the CFG as something special is fragile and what got us this bug in the first place. We have a constant expression evaluator (two, actually) and we shouldn't have to reimplement it a third time in the CFG. However, asking a GSoC mentee to address that is well beyond the scope of what they should be working on. So for now I'm going to revert this change, reopen the issue, and we'll discuss the next steps off-list with Usman.

Aug 2 2022, 12:51 PM · Restricted Project, Restricted Project

Aug 1 2022

rtrieu reopened D130510: Missing tautological compare warnings due to unary operators.

This warning is now flagging some code which I believe is a false positive. In particular, when template arguments are involved, their values can be calculated during template instantiation, but they should be treated as variables instead of constants. For example:

Aug 1 2022, 11:04 PM · Restricted Project, Restricted Project

Jul 29 2022

rtrieu added inline comments to D112374: [clang] Implement ElaboratedType sugaring for types written bare.
Jul 29 2022, 9:49 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rtrieu committed rGfb7fa27f92ca: Preserve qualifiers when getting fully qualified type (authored by rtrieu).
Preserve qualifiers when getting fully qualified type
Jul 29 2022, 7:48 PM · Restricted Project, Restricted Project

Jul 26 2022

rtrieu committed rG1f8ae9d7e7e4: Inline function calls. (authored by rtrieu).
Inline function calls.
Jul 26 2022, 9:15 PM · Restricted Project, Restricted Project

Jul 25 2022

rtrieu committed rGde43f93a8242: [bazel] Add new rule for c60b897d22b2feab3282c4fc2b390bc87560c7de (authored by rtrieu).
[bazel] Add new rule for c60b897d22b2feab3282c4fc2b390bc87560c7de
Jul 25 2022, 8:31 PM · Restricted Project

Jun 1 2022

rtrieu added a comment to D123532: [clang] Introduce while and do..while condition checks.

I wrote the original for loop warning. I did try to extend it to while loops, but due to the different usage of these types of loops, there was a higher false positive rate for while loops that in for loops. For loops are generally self-contained, so checking only the loop and loop body is a good way to determine if the condition is changed. However, while loops are also used in things like multi-threaded code and the while loop is used as a wait.

Jun 1 2022, 5:34 PM · Restricted Project, Restricted Project

May 3 2022

rtrieu committed rG5afd20806d4e: [riscv] Mark function as used to avoid unused warning. (authored by rtrieu).
[riscv] Mark function as used to avoid unused warning.
May 3 2022, 6:59 PM · Restricted Project, Restricted Project
rtrieu committed rG3dd00461f9cb: [trace][intelpt] Fix out-of-bounds access. (authored by rtrieu).
[trace][intelpt] Fix out-of-bounds access.
May 3 2022, 4:21 PM · Restricted Project
rtrieu committed rG0e86cddf9880: [psuedo] Fix for unused warning by moving code into debug macro. (authored by rtrieu).
[psuedo] Fix for unused warning by moving code into debug macro.
May 3 2022, 4:21 PM · Restricted Project, Restricted Project

May 2 2022

rtrieu committed rG32eb7b863e49: [Driver][test] Remove clang{{.*}} when testing -cc1 command lines (authored by rtrieu).
[Driver][test] Remove clang{{.*}} when testing -cc1 command lines
May 2 2022, 5:29 PM · Restricted Project, Restricted Project

Apr 18 2022

rtrieu added a comment to D119136: [clang] Implement Change scope of lambda trailing-return-type.

This seems to be acting weird in template instantations. Here's an example where the lambda only errors inside a template.

Apr 18 2022, 10:03 AM · Restricted Project, Restricted Project

Feb 11 2022

rtrieu committed rGd5c314cdf43a: [Clang][OpaquePtr] Remove deprecated Address constructor calls (authored by rtrieu).
[Clang][OpaquePtr] Remove deprecated Address constructor calls
Feb 11 2022, 1:06 PM
rtrieu closed D119496: [Clang][OpaquePtr] Remove calls to deprecated Address constructor.
Feb 11 2022, 1:06 PM · Restricted Project

Feb 10 2022

rtrieu requested review of D119496: [Clang][OpaquePtr] Remove calls to deprecated Address constructor.
Feb 10 2022, 3:52 PM · Restricted Project

Jan 28 2022

rtrieu committed rGbe2147db054e: Remove reference type when checking const structs (authored by rtrieu).
Remove reference type when checking const structs
Jan 28 2022, 1:22 PM
rtrieu closed D117376: Remove reference type when checking const structs.
Jan 28 2022, 1:22 PM · Restricted Project

Jan 14 2022

rtrieu requested review of D117376: Remove reference type when checking const structs.
Jan 14 2022, 5:34 PM · Restricted Project

Dec 1 2021

rtrieu added inline comments to D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function.
Dec 1 2021, 2:15 AM · Restricted Project, Restricted Project

Nov 23 2021

rtrieu added a comment to D112603: tsan: new runtime (v3).

This was causing some issues in tests.
I've reverted this in 1150f02c77b81adca4d0c67afdef23321e93db89
and sent @dvyukov details to reproduce the problem I saw.

Nov 23 2021, 6:41 PM · Restricted Project
rtrieu added a reverting change for rGebd47b0fb78f: tsan: new runtime (v3): rG1150f02c77b8: Revert "tsan: new runtime (v3)".
Nov 23 2021, 6:40 PM
rtrieu committed rG1150f02c77b8: Revert "tsan: new runtime (v3)" (authored by rtrieu).
Revert "tsan: new runtime (v3)"
Nov 23 2021, 6:40 PM
rtrieu added a reverting change for D112603: tsan: new runtime (v3): rG1150f02c77b8: Revert "tsan: new runtime (v3)".
Nov 23 2021, 6:40 PM · Restricted Project

Sep 2 2021

rtrieu accepted D109191: [clang] fix error recovery ICE on copy elision when returing invalid variable.
Sep 2 2021, 8:22 PM · Restricted Project
rtrieu accepted D108794: Fully qualify template template parameters when printing.

Ping

It looks like a strict improvement on printing and most callers using the default args won't need to be updated.

There's one more function call that should be updated:
https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clangd/DumpAST.cpp#L298

Fixing that and the comment and this should be good to go in.

Ah, thanks for catching that (just running check-clang doesn't catch this, and it doesn't seem like there's a check-clang-tools-extra - any idea if there's something narrower than check-all that would run clang-tools-extra tests?). Updated that caller to preserve the existing unqualified behavior.

Sep 2 2021, 2:04 PM · Restricted Project, Restricted Project

Aug 31 2021

rtrieu added a comment to D108794: Fully qualify template template parameters when printing.

It looks like a strict improvement on printing and most callers using the default args won't need to be updated.

Aug 31 2021, 8:10 PM · Restricted Project, Restricted Project

Aug 17 2021

rtrieu committed rG02e73d4b57b9: Simplify testcase from c411c1b (authored by rtrieu).
Simplify testcase from c411c1b
Aug 17 2021, 12:43 PM

Aug 16 2021

rtrieu committed rGc411c1bd7f7d: Fix missing qualifier in template type diffing (authored by rtrieu).
Fix missing qualifier in template type diffing
Aug 16 2021, 6:38 PM

Jun 9 2021

rtrieu added a comment to D73607: [X86] Custom lower ISD::FROUND with SSE4.1 to avoid a libcall..

Thanks for the quick fix. I've verified that it fixes my full test case.

Jun 9 2021, 2:10 PM · Restricted Project

Jun 8 2021

rtrieu added a comment to D73607: [X86] Custom lower ISD::FROUND with SSE4.1 to avoid a libcall..

I ran across a llvm_unreachable that points to this commit. Repro instructions below:

Jun 8 2021, 7:07 PM · Restricted Project

Apr 27 2021

rtrieu added a comment to D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion.

@rtrieu Do we have a way appending arbitrary messages to a diagnostic template?

Apr 27 2021, 6:54 PM · Restricted Project

Apr 6 2021

rtrieu committed rG401826800ef1: Add missing CHECK lines in test (authored by rtrieu).
Add missing CHECK lines in test
Apr 6 2021, 6:01 PM

Aug 12 2020

rtrieu accepted D85778: More accurately compute the ranges of possible values for +, -, *, &, %..

LGTM

Aug 12 2020, 7:01 PM · Restricted Project

Aug 10 2020

rtrieu accepted D85574: [Sema] Fix missing warning on initializer lists on field initializers with overloaded operators.

LGTM

Aug 10 2020, 7:01 PM · Restricted Project
rtrieu added inline comments to D85574: [Sema] Fix missing warning on initializer lists on field initializers with overloaded operators.
Aug 10 2020, 6:02 PM · Restricted Project

Aug 6 2020

rtrieu added a comment to D85287: Extend -Wtautological-bitwise-compare "bitwise or with non-zero value" warnings.

Also, have you tried running warning over a codebase?

As I wrote: "At least building LibreOffice with this change caused no false positives." (Or maybe I misunderstand your question.)

Aug 6 2020, 7:10 PM · Restricted Project
rtrieu updated subscribers of D85287: Extend -Wtautological-bitwise-compare "bitwise or with non-zero value" warnings.

I looked back on the commits and while I did commit, I did it on the behalf of Anders Rönnholm, who did not have commit access at the time. I haven't seen activity from Anders in a while, but added to subscribers just in case.

Aug 6 2020, 4:46 AM · Restricted Project
rtrieu accepted D85256: Add -Wtautological-value-range-compare warning..

LGTM

Aug 6 2020, 4:17 AM · Restricted Project

Jun 19 2020

rtrieu committed rGd5f9c4a3d10d: [ODRHash] Remove use of 'whitelist'. (authored by rtrieu).
[ODRHash] Remove use of 'whitelist'.
Jun 19 2020, 7:00 PM

May 7 2020

rtrieu committed rG4ae537c2220f: Fix false positive with -Wnon-c-typedef-for-linkage (authored by rtrieu).
Fix false positive with -Wnon-c-typedef-for-linkage
May 7 2020, 8:05 PM
rtrieu closed D79548: Fix false positive with warning -Wnon-c-typedef-for-linkage.
May 7 2020, 8:04 PM · Restricted Project

May 6 2020

rtrieu created D79548: Fix false positive with warning -Wnon-c-typedef-for-linkage.
May 6 2020, 10:08 PM · Restricted Project

Apr 27 2020

rtrieu abandoned D60169: Proposed refactoring for lib/Target/X86 to remove layering issue.
Apr 27 2020, 5:48 PM

Mar 31 2020

rtrieu committed rGf93aed66f22f: Fix diagnostics where _Atomic can't be applied (authored by rtrieu).
Fix diagnostics where _Atomic can't be applied
Mar 31 2020, 5:40 PM

Jan 30 2020

rtrieu created D73762: [clang] New warning for for-loops where the iteration does not match the loop condition.
Jan 30 2020, 6:41 PM · Restricted Project

Jan 24 2020

rtrieu committed rG9f69157bf4a0: Fix header includes after 0697bcb66f1d82f2fd447e9d13b74d141c3ce085 (authored by rtrieu).
Fix header includes after 0697bcb66f1d82f2fd447e9d13b74d141c3ce085
Jan 24 2020, 6:34 PM

Jan 23 2020

rtrieu committed rGfe5f233a938f: Fix assert that doesn't check anything. (authored by rtrieu).
Fix assert that doesn't check anything.
Jan 23 2020, 7:16 PM
rtrieu added a comment to D73007: [Sema] Avoid Wrange-loop-analysis false positives.

I'm in favor of splitting the warning into subgroups, then deciding which ones should be in -Wall. We've done this with other warnings such as the conversion warnings and tautological compare warnings, with only a subset of them in -Wall.

Jan 23 2020, 5:00 PM · Restricted Project

Jan 21 2020

rtrieu added inline comments to D72552: [Concepts] Constraint Satisfaction Caching.
Jan 21 2020, 5:53 PM · Restricted Project

Jan 14 2020

rtrieu added a comment to D71734: [ODRHash] Hash `RecordDecl` and diagnose discovered mismatches..

Heads up in case it affects you refactoring work:
While looking through this code, I found a bug I previously made. I fixed it with a small change, but that lies in the middle of your refactoring during FieldDecl handling. The change is here:

Jan 14 2020, 10:08 PM · Restricted Project, Restricted Project
rtrieu committed rGa60e89272970: [ODRHash] Fix wrong error message with bitfields and mutable. (authored by rtrieu).
[ODRHash] Fix wrong error message with bitfields and mutable.
Jan 14 2020, 9:31 PM

Jan 10 2020

rtrieu created D72551: Warn when a string literal is used in a range-based for-loop.
Jan 10 2020, 6:46 PM
rtrieu added inline comments to D71734: [ODRHash] Hash `RecordDecl` and diagnose discovered mismatches..
Jan 10 2020, 6:18 PM · Restricted Project, Restricted Project

Jan 9 2020

rtrieu added inline comments to D71734: [ODRHash] Hash `RecordDecl` and diagnose discovered mismatches..
Jan 9 2020, 6:53 PM · Restricted Project, Restricted Project

Jan 8 2020

rtrieu added inline comments to D72212: [Sema] Improve -Wrange-loop-analysis warnings.
Jan 8 2020, 7:10 PM · Restricted Project

Dec 16 2019

rtrieu updated the diff for D71503: New warning on for-loops that never run because condition is false on the first iteration.
Dec 16 2019, 3:57 PM
rtrieu added a comment to D71503: New warning on for-loops that never run because condition is false on the first iteration.

Thank you for working on this!
This seems to be missing tests.

Dec 16 2019, 3:57 PM

Dec 13 2019

rtrieu created D71503: New warning on for-loops that never run because condition is false on the first iteration.
Dec 13 2019, 7:04 PM

Nov 15 2019

rtrieu added a comment to D69292: Proposal to add -Wtautological-compare to -Wall.

Sorry I'm late to the party; I've been traveling for 3+ weeks.
I would like to be reassured that the following code will not warn:

`
long foo = ...; // some calculation
if (foo < std::numeric_limits<int>::min() || foo > std::numeric_limits<int>::max()) .....

This is important for systems where sizeof(int) == sizeof(long)

Nov 15 2019, 4:09 PM · Restricted Project

Nov 12 2019

rtrieu committed rG9740f9f0b6e5: Add -Wtautological-compare to -Wall (authored by rtrieu).
Add -Wtautological-compare to -Wall
Nov 12 2019, 2:50 PM
rtrieu closed D69292: Proposal to add -Wtautological-compare to -Wall.
Nov 12 2019, 2:50 PM · Restricted Project

Nov 7 2019

rtrieu updated the diff for D69292: Proposal to add -Wtautological-compare to -Wall.

Add -Wall tests to check that certain warning groups are active with it and a test to check all warning groups that are turned on by -Wall.

Nov 7 2019, 9:23 PM · Restricted Project

Nov 6 2019

rtrieu added a comment to D68577: [LV] Apply sink-after & interleave-groups as VPlan transformations (NFC).

The recommited patch is hitting an assert. See message and reduced test case below:

Nov 6 2019, 8:23 PM · Restricted Project

Oct 25 2019

rtrieu added a comment to D69292: Proposal to add -Wtautological-compare to -Wall.

Abstractly this lgtm. Do you have any data on true / false positive rates?

Oct 25 2019, 5:42 PM · Restricted Project

Oct 21 2019

rtrieu added a comment to D66046: Add new tautological compare warning for bitwise-or with a non-zero constant.

Mr Trieu, what do you think about adding some or all of the Wtautological-compare warnings to Wall

Oct 21 2019, 8:04 PM · Restricted Project
rtrieu created D69292: Proposal to add -Wtautological-compare to -Wall.
Oct 21 2019, 7:45 PM · Restricted Project

Oct 18 2019

rtrieu committed rG637af4cc3780: Add -Wbitwise-conditional-parentheses to warn on mixing '|' and '&' with "?:" (authored by rtrieu).
Add -Wbitwise-conditional-parentheses to warn on mixing '|' and '&' with "?:"
Oct 18 2019, 6:52 PM
rtrieu closed D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:").
Oct 18 2019, 6:52 PM · Restricted Project
rtrieu committed rL375326: Add -Wbitwise-conditional-parentheses to warn on mixing '|' and '&' with "?:".
Add -Wbitwise-conditional-parentheses to warn on mixing '|' and '&' with "?:"
Oct 18 2019, 6:52 PM
rtrieu committed rG8b0d14a8f0cc: New tautological warning for bitwise-or with non-zero constant always true. (authored by rtrieu).
New tautological warning for bitwise-or with non-zero constant always true.
Oct 18 2019, 5:57 PM
rtrieu committed rL375318: New tautological warning for bitwise-or with non-zero constant always true..
New tautological warning for bitwise-or with non-zero constant always true.
Oct 18 2019, 5:57 PM
rtrieu closed D66046: Add new tautological compare warning for bitwise-or with a non-zero constant.
Oct 18 2019, 5:57 PM · Restricted Project

Oct 10 2019

rtrieu added a comment to D66046: Add new tautological compare warning for bitwise-or with a non-zero constant.
Oct 10 2019, 8:59 PM · Restricted Project

Oct 4 2019

rtrieu added inline comments to rL373614: [Diagnostics] Bitwise negation of a boolean expr always evaluates to true; warn….
Oct 4 2019, 5:07 PM

Oct 1 2019

rtrieu committed rGe3887253165c: Revert r368237 - Update fix-it hints for std::move warnings. (authored by rtrieu).
Revert r368237 - Update fix-it hints for std::move warnings.
Oct 1 2019, 7:33 PM
rtrieu committed rL373421: Revert r368237 - Update fix-it hints for std::move warnings..
Revert r368237 - Update fix-it hints for std::move warnings.
Oct 1 2019, 7:30 PM

Sep 20 2019

rtrieu committed rG77297f0761d2: Fix bad APInt compare. (authored by rtrieu).
Fix bad APInt compare.
Sep 20 2019, 9:20 PM
rtrieu committed rL372454: Fix bad APInt compare..
Fix bad APInt compare.
Sep 20 2019, 9:17 PM
rtrieu committed rG4c05de8c1d15: Merge and improve code that detects same value in comparisons. (authored by rtrieu).
Merge and improve code that detects same value in comparisons.
Sep 20 2019, 8:05 PM
rtrieu committed rL372453: Merge and improve code that detects same value in comparisons..
Merge and improve code that detects same value in comparisons.
Sep 20 2019, 8:04 PM
rtrieu closed D66045: Improve detection of same value in comparisons.
Sep 20 2019, 8:04 PM · Restricted Project
rtrieu committed rG6541c7988b83: Improve -Wtautological-overlap-compare (authored by rtrieu).
Improve -Wtautological-overlap-compare
Sep 20 2019, 7:37 PM