User Details
- User Since
- Jul 11 2012, 7:44 PM (519 w, 3 d)
Wed, Jun 1
I wrote the original for loop warning. I did try to extend it to while loops, but due to the different usage of these types of loops, there was a higher false positive rate for while loops that in for loops. For loops are generally self-contained, so checking only the loop and loop body is a good way to determine if the condition is changed. However, while loops are also used in things like multi-threaded code and the while loop is used as a wait.
May 3 2022
May 2 2022
Apr 18 2022
This seems to be acting weird in template instantations. Here's an example where the lambda only errors inside a template.
Feb 11 2022
Feb 10 2022
Jan 28 2022
Jan 14 2022
Dec 1 2021
Nov 23 2021
This was causing some issues in tests.
I've reverted this in 1150f02c77b81adca4d0c67afdef23321e93db89
and sent @dvyukov details to reproduce the problem I saw.
Sep 2 2021
Aug 31 2021
It looks like a strict improvement on printing and most callers using the default args won't need to be updated.
Aug 17 2021
Aug 16 2021
Jun 9 2021
Thanks for the quick fix. I've verified that it fixes my full test case.
Jun 8 2021
I ran across a llvm_unreachable that points to this commit. Repro instructions below:
Apr 27 2021
Apr 6 2021
Aug 12 2020
LGTM
Aug 10 2020
LGTM
Aug 6 2020
I looked back on the commits and while I did commit, I did it on the behalf of Anders Rönnholm, who did not have commit access at the time. I haven't seen activity from Anders in a while, but added to subscribers just in case.
LGTM
Jun 19 2020
May 7 2020
May 6 2020
Apr 27 2020
Mar 31 2020
Jan 30 2020
Jan 24 2020
Jan 23 2020
I'm in favor of splitting the warning into subgroups, then deciding which ones should be in -Wall. We've done this with other warnings such as the conversion warnings and tautological compare warnings, with only a subset of them in -Wall.
Jan 21 2020
Jan 14 2020
Heads up in case it affects you refactoring work:
While looking through this code, I found a bug I previously made. I fixed it with a small change, but that lies in the middle of your refactoring during FieldDecl handling. The change is here:
Jan 10 2020
Jan 9 2020
Jan 8 2020
Dec 16 2019
Dec 13 2019
Nov 15 2019
Nov 12 2019
Nov 7 2019
Add -Wall tests to check that certain warning groups are active with it and a test to check all warning groups that are turned on by -Wall.
Nov 6 2019
The recommited patch is hitting an assert. See message and reduced test case below:
Oct 25 2019
Oct 21 2019
Oct 18 2019
Oct 10 2019
Oct 4 2019
Oct 1 2019
Sep 20 2019
Sep 6 2019
Add more test cases and split new warnings into a separate warning group, but still under -Wparentheses
Aug 28 2019
Aug 27 2019
Aug 26 2019
I have reverted this in r370006.
Aug 19 2019
Aug 13 2019
Better handling of arrays in self compares.
Aug 12 2019
Update comments to explain why bitwise-xor is treated as a logical operator.
Check array accesses.