Page MenuHomePhabricator

rtrieu (Richard Trieu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 11 2012, 7:44 PM (353 w, 3 d)

Recent Activity

Yesterday

rtrieu added a comment to D60169: Proposed refactoring for lib/Target/X86 to remove layering issue.
In D60169#1473057, @rnk wrote:

The change to merge them is quite large. I wonder if it would be simpler to handle this like we handle clang/Sema+Parse. Aren't those also circularly dependent?

Fri, Apr 19, 3:40 PM

Wed, Apr 17

rtrieu committed rG7b6192025e8f: Fix bad compare function over FusionCandidate. (authored by rtrieu).
Fix bad compare function over FusionCandidate.
Wed, Apr 17, 6:38 PM
rtrieu committed rL358636: Fix bad compare function over FusionCandidate..
Fix bad compare function over FusionCandidate.
Wed, Apr 17, 6:38 PM

Fri, Apr 12

rtrieu added a comment to D60597: Fix lib/Target/* layering issues by merging InstPrinter into MCTargetDesc.

Phabricator is being too smart for its own good. The main discussion of this change was over on https://reviews.llvm.org/D60169 I was creating this as a separate diff so people can see different solutions to the problem.

Fri, Apr 12, 2:57 PM

Thu, Apr 11

rtrieu added a comment to D60169: Proposed refactoring for lib/Target/X86 to remove layering issue.

This is following Craig's suggestion to merge InstPrinter into MCTargetDesc, which Hexagon already does. Do people like this solution better?

Thu, Apr 11, 8:35 PM
rtrieu created D60597: Fix lib/Target/* layering issues by merging InstPrinter into MCTargetDesc.
Thu, Apr 11, 8:30 PM

Wed, Apr 10

rtrieu added a comment to D60169: Proposed refactoring for lib/Target/X86 to remove layering issue.

That's correct, SystemZ doesn't appear to have a dependency problem. Any changes to it will be for maintaining consistency across backends.

Wed, Apr 10, 8:48 PM

Mon, Apr 8

rtrieu added a comment to D60169: Proposed refactoring for lib/Target/X86 to remove layering issue.

I think having a project that has a clean dependency graph is a worthwhile goal in itself. The circular dependency here is small, and I'm not aware of a build system that can't handle it, but some do complain about it.
The other goal is consistency of the backends. As Craig mentioned, Hexagon has a small break from the other backends by merging InstPrinter and MCTargetDesc. Having the same library rules across backends would make it less confusing.

Mon, Apr 8, 11:16 PM
rtrieu added a comment to D60169: Proposed refactoring for lib/Target/X86 to remove layering issue.

I had assumed that there was some reason to have a library separation between InstPrinter and MCTargetDesc. Merging libraries together would fix the circular dependency, although I would like to know if there is a good reason to keep these two apart.

Mon, Apr 8, 10:38 PM

Fri, Apr 5

rtrieu added a comment to D60169: Proposed refactoring for lib/Target/X86 to remove layering issue.

I doubt most targets have a Utils library that you can sink a header into. What is the plan for other targets?

Fri, Apr 5, 3:43 PM

Tue, Apr 2

rtrieu created D60169: Proposed refactoring for lib/Target/X86 to remove layering issue.
Tue, Apr 2, 6:22 PM

Mar 14 2019

rtrieu committed rGef1e06df6ff1: Remove an assert in template pack deduction during nested instantiation. (authored by rtrieu).
Remove an assert in template pack deduction during nested instantiation.
Mar 14 2019, 9:28 PM
rtrieu committed rL356231: Remove an assert in template pack deduction during nested instantiation..
Remove an assert in template pack deduction during nested instantiation.
Mar 14 2019, 9:27 PM
rtrieu committed rC356231: Remove an assert in template pack deduction during nested instantiation..
Remove an assert in template pack deduction during nested instantiation.
Mar 14 2019, 9:27 PM

Feb 27 2019

rtrieu committed rGb37a70f40e12: Fix IR/Analysis layering issue with OptBisect (authored by rtrieu).
Fix IR/Analysis layering issue with OptBisect
Feb 27 2019, 8:01 PM
rtrieu committed rL355068: Fix IR/Analysis layering issue with OptBisect.
Fix IR/Analysis layering issue with OptBisect
Feb 27 2019, 8:00 PM
rtrieu closed D58406: Fix IR/Analysis layering issue in OptBisect.
Feb 27 2019, 8:00 PM · Restricted Project
rtrieu added a comment to D58406: Fix IR/Analysis layering issue in OptBisect.

Sounds like this is good with a comment on the IRDescription. I'll commit this for now and leave the suggestions for follow-ups. There's two follow-ups if any is interested in perusing:

Feb 27 2019, 7:52 PM · Restricted Project

Feb 26 2019

rtrieu updated the diff for D58406: Fix IR/Analysis layering issue in OptBisect.

Removed the virtual function from Pass. Use OptPassGate::isEnabled to gate the construction of the strings on the caller side.

Feb 26 2019, 9:15 PM · Restricted Project

Feb 22 2019

rtrieu added inline comments to D58555: [NFC][Sanitizer] Add argument checks to BufferedStackTrace::Unwind* functions.
Feb 22 2019, 9:50 PM · Restricted Project, Restricted Project
rtrieu committed rG1bf3a09b3d81: Remove overly broad assert from r354717. (authored by rtrieu).
Remove overly broad assert from r354717.
Feb 22 2019, 9:49 PM
rtrieu committed rL354720: Remove overly broad assert from r354717..
Remove overly broad assert from r354717.
Feb 22 2019, 9:48 PM
rtrieu committed rCRT354720: Remove overly broad assert from r354717..
Remove overly broad assert from r354717.
Feb 22 2019, 9:48 PM
rtrieu added inline comments to D58555: [NFC][Sanitizer] Add argument checks to BufferedStackTrace::Unwind* functions.
Feb 22 2019, 7:35 PM · Restricted Project, Restricted Project

Feb 20 2019

rtrieu updated the diff for D58406: Fix IR/Analysis layering issue in OptBisect.

Change void pointers to llvm::Any. Update some functions to fix const issues.

Feb 20 2019, 8:55 PM · Restricted Project
rtrieu added a comment to D58406: Fix IR/Analysis layering issue in OptBisect.

Last time, this was brought up, passing strings was deemed too expensive since it would cause a string to be created every time:
http://lists.llvm.org/pipermail/llvm-dev/2018-March/122032.html

Feb 20 2019, 8:53 PM · Restricted Project
rtrieu committed rG14bab09e1111: Fix unused variable warning. (authored by rtrieu).
Fix unused variable warning.
Feb 20 2019, 4:36 PM
rtrieu committed rL354535: Fix unused variable warning..
Fix unused variable warning.
Feb 20 2019, 4:35 PM
rtrieu committed rLLD354535: Fix unused variable warning..
Fix unused variable warning.
Feb 20 2019, 4:35 PM

Feb 19 2019

rtrieu created D58406: Fix IR/Analysis layering issue in OptBisect.
Feb 19 2019, 2:09 PM · Restricted Project

Feb 12 2019

rtrieu accepted D58122: Restore Check for Unreachable Exit Block in -Winfinite-recursion.

LGTM

Feb 12 2019, 4:16 PM · Restricted Project, Restricted Project

Feb 5 2019

rtrieu committed rG5f436fc57a2d: Move DomTreeUpdater from IR to Analysis (authored by rtrieu).
Move DomTreeUpdater from IR to Analysis
Feb 5 2019, 6:53 PM
rtrieu committed rL353265: Move DomTreeUpdater from IR to Analysis.
Move DomTreeUpdater from IR to Analysis
Feb 5 2019, 6:53 PM

Feb 4 2019

rtrieu committed rGa9354b2f3373: Fix narrowing issue from r353129 (authored by rtrieu).
Fix narrowing issue from r353129
Feb 4 2019, 6:26 PM
rtrieu committed rL353134: Fix narrowing issue from r353129.
Fix narrowing issue from r353129
Feb 4 2019, 6:26 PM

Jan 31 2019

rtrieu committed rL352802: [Hexagon] Rename textually included file from .h to .inc.
[Hexagon] Rename textually included file from .h to .inc
Jan 31 2019, 1:58 PM

Jan 30 2019

rtrieu committed rL352725: Add namespace to some types..
Add namespace to some types.
Jan 30 2019, 8:33 PM

Jan 10 2019

rtrieu committed rL350913: Fix header issues..
Fix header issues.
Jan 10 2019, 5:37 PM
rtrieu committed rC350913: Fix header issues..
Fix header issues.
Jan 10 2019, 5:36 PM

Jan 9 2019

rtrieu committed rCTE350797: Remove unnecessary include..
Remove unnecessary include.
Jan 9 2019, 8:57 PM
rtrieu committed rL350797: Remove unnecessary include..
Remove unnecessary include.
Jan 9 2019, 8:56 PM
rtrieu committed rL350792: Refactor declarations of ASTContext allocate functions into its own header..
Refactor declarations of ASTContext allocate functions into its own header.
Jan 9 2019, 7:28 PM
rtrieu committed rC350792: Refactor declarations of ASTContext allocate functions into its own header..
Refactor declarations of ASTContext allocate functions into its own header.
Jan 9 2019, 7:28 PM

Jan 3 2019

rtrieu committed rL350379: [WebAssembly] Split the checking from the sorting logic..
[WebAssembly] Split the checking from the sorting logic.
Jan 3 2019, 10:53 PM

Dec 28 2018

rtrieu committed rC350143: Add vtable anchor to classes..
Add vtable anchor to classes.
Dec 28 2018, 6:06 PM
rtrieu committed rL350143: Add vtable anchor to classes..
Add vtable anchor to classes.
Dec 28 2018, 6:06 PM
rtrieu committed rL350142: Add vtable anchor to classes..
Add vtable anchor to classes.
Dec 28 2018, 6:06 PM

Dec 14 2018

rtrieu committed rL349237: Fix includes and dependencies for libclang.
Fix includes and dependencies for libclang
Dec 14 2018, 8:28 PM
rtrieu committed rC349237: Fix includes and dependencies for libclang.
Fix includes and dependencies for libclang
Dec 14 2018, 8:28 PM
rtrieu committed rL349230: Move static analyzer core diagnostics to common..
Move static analyzer core diagnostics to common.
Dec 14 2018, 6:33 PM
rtrieu committed rC349230: Move static analyzer core diagnostics to common..
Move static analyzer core diagnostics to common.
Dec 14 2018, 6:33 PM

Dec 13 2018

rtrieu committed rLLDB349128: Remove unused variable..
Remove unused variable.
Dec 13 2018, 9:43 PM
rtrieu committed rL349128: Remove unused variable..
Remove unused variable.
Dec 13 2018, 9:43 PM
rtrieu committed rL349125: Fix up diagnostics..
Fix up diagnostics.
Dec 13 2018, 7:38 PM
rtrieu committed rC349125: Fix up diagnostics..
Fix up diagnostics.
Dec 13 2018, 7:38 PM

Dec 11 2018

rtrieu committed rC348907: Move PCHContainerOperations from Frontend to Serialization.
Move PCHContainerOperations from Frontend to Serialization
Dec 11 2018, 6:57 PM
rtrieu committed rL348907: Move PCHContainerOperations from Frontend to Serialization.
Move PCHContainerOperations from Frontend to Serialization
Dec 11 2018, 6:57 PM

Dec 10 2018

rtrieu committed rC348827: Move CodeGenOptions from Frontend to Basic.
Move CodeGenOptions from Frontend to Basic
Dec 10 2018, 7:22 PM
rtrieu committed rL348827: Move CodeGenOptions from Frontend to Basic.
Move CodeGenOptions from Frontend to Basic
Dec 10 2018, 7:22 PM

Dec 7 2018

rtrieu committed rC348685: Move diagnostic enums into Basic..
Move diagnostic enums into Basic.
Dec 7 2018, 9:08 PM
rtrieu committed rL348685: Move diagnostic enums into Basic..
Move diagnostic enums into Basic.
Dec 7 2018, 9:08 PM

Dec 5 2018

rtrieu committed rL348459: Remove unnecessary include..
Remove unnecessary include.
Dec 5 2018, 10:36 PM
rtrieu committed rC348459: Remove unnecessary include..
Remove unnecessary include.
Dec 5 2018, 10:36 PM
rtrieu committed rC348458: Remove CodeGen dependencies on Sema..
Remove CodeGen dependencies on Sema.
Dec 5 2018, 10:15 PM
rtrieu committed rL348458: Remove CodeGen dependencies on Sema..
Remove CodeGen dependencies on Sema.
Dec 5 2018, 10:15 PM

Dec 3 2018

rtrieu committed rL348238: Remove unnecessary include..
Remove unnecessary include.
Dec 3 2018, 8:56 PM
rtrieu committed rC348238: Remove unnecessary include..
Remove unnecessary include.
Dec 3 2018, 8:56 PM

Nov 27 2018

rtrieu committed rL347728: Move LoopHint.h from Sema to Parse.
Move LoopHint.h from Sema to Parse
Nov 27 2018, 8:39 PM
rtrieu committed rC347728: Move LoopHint.h from Sema to Parse.
Move LoopHint.h from Sema to Parse
Nov 27 2018, 8:39 PM
rtrieu committed rL347727: [CodeGen] Fix included headers..
[CodeGen] Fix included headers.
Nov 27 2018, 8:18 PM
rtrieu committed rC347727: [CodeGen] Fix included headers..
[CodeGen] Fix included headers.
Nov 27 2018, 8:18 PM
rtrieu committed rC347726: [diagtool] Remove unneeded header includes..
[diagtool] Remove unneeded header includes.
Nov 27 2018, 8:02 PM
rtrieu committed rL347726: [diagtool] Remove unneeded header includes..
[diagtool] Remove unneeded header includes.
Nov 27 2018, 8:02 PM

Oct 30 2018

rtrieu committed rL345691: Revert r345676 due to test failure..
Revert r345676 due to test failure.
Oct 30 2018, 7:13 PM
rtrieu committed rC345691: Revert r345676 due to test failure..
Revert r345676 due to test failure.
Oct 30 2018, 7:13 PM
rtrieu committed rC345669: Silence unused variable warnings. NFC.
Silence unused variable warnings. NFC
Oct 30 2018, 4:04 PM
rtrieu committed rL345669: Silence unused variable warnings. NFC.
Silence unused variable warnings. NFC
Oct 30 2018, 4:04 PM

Oct 24 2018

rtrieu committed rL345228: [Sema] Fix -Wcomma for C89.
[Sema] Fix -Wcomma for C89
Oct 24 2018, 6:10 PM
rtrieu committed rC345228: [Sema] Fix -Wcomma for C89.
[Sema] Fix -Wcomma for C89
Oct 24 2018, 6:10 PM

Oct 23 2018

rtrieu committed rL345111: [Sema] Fix -Wcomma in dependent context.
[Sema] Fix -Wcomma in dependent context
Oct 23 2018, 7:10 PM
rtrieu committed rC345111: [Sema] Fix -Wcomma in dependent context.
[Sema] Fix -Wcomma in dependent context
Oct 23 2018, 7:10 PM

Oct 22 2018

rtrieu committed rC344987: [CodeGen] Attach InlineHint to more functions.
[CodeGen] Attach InlineHint to more functions
Oct 22 2018, 6:28 PM
rtrieu committed rL344987: [CodeGen] Attach InlineHint to more functions.
[CodeGen] Attach InlineHint to more functions
Oct 22 2018, 6:28 PM

Oct 19 2018

rtrieu committed rC344828: Make -Wfor-loop-analysis work with C++17.
Make -Wfor-loop-analysis work with C++17
Oct 19 2018, 7:18 PM
rtrieu committed rL344828: Make -Wfor-loop-analysis work with C++17.
Make -Wfor-loop-analysis work with C++17
Oct 19 2018, 7:18 PM

Oct 11 2018

rtrieu committed rL344308: Inline variable into assert to avoid unused variable warning..
Inline variable into assert to avoid unused variable warning.
Oct 11 2018, 3:45 PM

Oct 9 2018

rtrieu added a comment to D52863: LLVM Cleanup for -Wdeprecated-copy.

Looking through other classes, I see that it is common to use an anchor() method as the vtable anchor. I think having it that way makes it more clear what the purpose of the out-of-line function definition is.

Oct 9 2018, 7:57 PM

Oct 4 2018

rtrieu added a comment to D52863: LLVM Cleanup for -Wdeprecated-copy.

Well, learned something new today. I'll follow up with something that doesn't mess with the vtable anchors.

Oct 4 2018, 10:31 PM

Oct 3 2018

rtrieu created D52864: Clang cleanup for -Wdeprecated-copy.
Oct 3 2018, 10:31 PM
rtrieu created D52863: LLVM Cleanup for -Wdeprecated-copy.
Oct 3 2018, 10:31 PM
rtrieu created D52860: Create new warning group -Wdeprecated-copy.
Oct 3 2018, 7:06 PM

Sep 21 2018

rtrieu committed rC342794: Update smart pointer detection for thread safety analysis..
Update smart pointer detection for thread safety analysis.
Sep 21 2018, 6:54 PM
rtrieu committed rL342794: Update smart pointer detection for thread safety analysis..
Update smart pointer detection for thread safety analysis.
Sep 21 2018, 6:54 PM
rtrieu committed rC342774: Make compare function in r342648 have strict weak ordering..
Make compare function in r342648 have strict weak ordering.
Sep 21 2018, 2:22 PM
rtrieu committed rL342774: Make compare function in r342648 have strict weak ordering..
Make compare function in r342648 have strict weak ordering.
Sep 21 2018, 2:22 PM

Sep 17 2018

rtrieu created D52218: Warn on self-initializations.
Sep 17 2018, 7:42 PM

Sep 13 2018

rtrieu committed rL342199: [ODRHash] Fix early exit that skipped code..
[ODRHash] Fix early exit that skipped code.
Sep 13 2018, 6:16 PM
rtrieu committed rC342199: [ODRHash] Fix early exit that skipped code..
[ODRHash] Fix early exit that skipped code.
Sep 13 2018, 6:16 PM

Sep 5 2018

rtrieu committed rC341498: Remove unnecessary options from test RUN lines..
Remove unnecessary options from test RUN lines.
Sep 5 2018, 3:16 PM
rtrieu committed rL341498: Remove unnecessary options from test RUN lines..
Remove unnecessary options from test RUN lines.
Sep 5 2018, 3:16 PM