Page MenuHomePhabricator

rtrieu (Richard Trieu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 11 2012, 7:44 PM (370 w, 6 d)

Recent Activity

Yesterday

rtrieu committed rG8f9e489a6658: Fix typo. "piont" => "point" (authored by rtrieu).
Fix typo. "piont" => "point"
Mon, Aug 19, 5:34 PM
rtrieu committed rL369316: Fix typo. "piont" => "point".
Fix typo. "piont" => "point"
Mon, Aug 19, 5:34 PM

Tue, Aug 13

rtrieu added a comment to D66044: Extend -Wtautological-overlap-compare to accept negative values and integer conversions.
In D66044#1626008, @NoQ wrote:

Looks great, thanks! I'd appreciate direct CFG tests for the part that changes the CFG (cf. test/Analysis/cfg.cpp), but i don't insist. Let's make sure @jfb is happy and commit :)

Tue, Aug 13, 8:12 PM
rtrieu updated the diff for D66044: Extend -Wtautological-overlap-compare to accept negative values and integer conversions.
Tue, Aug 13, 8:08 PM
rtrieu added inline comments to D66045: Improve detection of same value in comparisons.
Tue, Aug 13, 6:33 PM
rtrieu updated the diff for D66045: Improve detection of same value in comparisons.
Tue, Aug 13, 6:20 PM
rtrieu updated the diff for D66048: Combined patch for new warning work.

Better handling of arrays in self compares.

Tue, Aug 13, 4:40 PM
rtrieu added inline comments to D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:").
Tue, Aug 13, 4:09 PM

Mon, Aug 12

rtrieu updated the diff for D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:").

Update comments to explain why bitwise-xor is treated as a logical operator.

Mon, Aug 12, 7:38 PM
rtrieu added inline comments to D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:").
Mon, Aug 12, 7:38 PM
rtrieu added inline comments to D66045: Improve detection of same value in comparisons.
Mon, Aug 12, 7:29 PM
rtrieu updated the diff for D66045: Improve detection of same value in comparisons.

Check array accesses.

Mon, Aug 12, 7:25 PM
rtrieu added inline comments to D66045: Improve detection of same value in comparisons.
Mon, Aug 12, 4:40 PM
rtrieu added inline comments to D66046: Add new tautological compare warning for bitwise-or with a non-zero constant.
Mon, Aug 12, 4:23 PM
rtrieu updated the diff for D66046: Add new tautological compare warning for bitwise-or with a non-zero constant.

Create new function isIntOrEnumConstantZero to use instead of EvaluateAsInt

Mon, Aug 12, 4:19 PM
rtrieu updated the summary of D66046: Add new tautological compare warning for bitwise-or with a non-zero constant.
Mon, Aug 12, 3:29 PM
rtrieu added inline comments to D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:").
Mon, Aug 12, 3:29 PM
rtrieu added a comment to D66045: Improve detection of same value in comparisons.
In D66045#1624389, @jfb wrote:

Does this work for unions as well?

Mon, Aug 12, 3:17 PM
rtrieu added inline comments to D66046: Add new tautological compare warning for bitwise-or with a non-zero constant.
Mon, Aug 12, 2:52 PM
rtrieu added inline comments to D66044: Extend -Wtautological-overlap-compare to accept negative values and integer conversions.
Mon, Aug 12, 2:40 PM
rtrieu added inline comments to D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:").
Mon, Aug 12, 2:28 PM

Fri, Aug 9

rtrieu added a reviewer for D66045: Improve detection of same value in comparisons: cfe-commits.
Fri, Aug 9, 7:04 PM
rtrieu added a reviewer for D66046: Add new tautological compare warning for bitwise-or with a non-zero constant: cfe-commits.
Fri, Aug 9, 7:04 PM
rtrieu added a reviewer for D66044: Extend -Wtautological-overlap-compare to accept negative values and integer conversions: cfe-commits.
Fri, Aug 9, 7:04 PM
rtrieu added a reviewer for D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:"): cfe-commits.
Fri, Aug 9, 7:04 PM
rtrieu created D66048: Combined patch for new warning work.
Fri, Aug 9, 7:04 PM
rtrieu created D66045: Improve detection of same value in comparisons.
Fri, Aug 9, 6:55 PM
rtrieu created D66046: Add new tautological compare warning for bitwise-or with a non-zero constant.
Fri, Aug 9, 6:55 PM
rtrieu created D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:").
Fri, Aug 9, 6:55 PM
rtrieu created D66044: Extend -Wtautological-overlap-compare to accept negative values and integer conversions.
Fri, Aug 9, 6:55 PM

Wed, Aug 7

rtrieu committed rG07e6798baf9a: Inline diagnostic text into .td file. NFC. (authored by rtrieu).
Inline diagnostic text into .td file. NFC.
Wed, Aug 7, 6:47 PM
rtrieu committed rL368244: Inline diagnostic text into .td file. NFC..
Inline diagnostic text into .td file. NFC.
Wed, Aug 7, 6:47 PM
rtrieu committed rG155b8d02c363: Update fix-it hints for std::move warnings. (authored by rtrieu).
Update fix-it hints for std::move warnings.
Wed, Aug 7, 5:17 PM
rtrieu committed rL368237: Update fix-it hints for std::move warnings..
Update fix-it hints for std::move warnings.
Wed, Aug 7, 5:12 PM

Tue, Jul 30

rtrieu committed rG33cdbff2a78a: Change '|' to '&' in conditional. (authored by rtrieu).
Change '|' to '&' in conditional.
Tue, Jul 30, 9:42 PM
rtrieu committed rL367386: Change '|' to '&' in conditional..
Change '|' to '&' in conditional.
Tue, Jul 30, 9:40 PM

Mon, Jul 22

rtrieu committed rG3a52c3857feb: Inline function call into assert to fix unused variable warning. (authored by rtrieu).
Inline function call into assert to fix unused variable warning.
Mon, Jul 22, 8:11 PM
rtrieu committed rL366774: Inline function call into assert to fix unused variable warning..
Inline function call into assert to fix unused variable warning.
Mon, Jul 22, 8:11 PM
rtrieu committed rG81a5045cd632: Move variable out from debug only section. (authored by rtrieu).
Move variable out from debug only section.
Mon, Jul 22, 8:00 PM
rtrieu committed rL366773: Move variable out from debug only section..
Move variable out from debug only section.
Mon, Jul 22, 8:00 PM

Jul 10 2019

rtrieu committed rG9066e5f832bf: Increase the number of parser diagnostics. (authored by rtrieu).
Increase the number of parser diagnostics.
Jul 10 2019, 7:56 PM
rtrieu committed rL365727: Increase the number of parser diagnostics..
Increase the number of parser diagnostics.
Jul 10 2019, 7:54 PM

Jun 27 2019

rtrieu accepted D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots..

LGTM

Jun 27 2019, 8:52 PM · Restricted Project, Restricted Project

Jun 26 2019

rtrieu added inline comments to D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots..
Jun 26 2019, 2:36 PM · Restricted Project, Restricted Project

Jun 25 2019

rtrieu added inline comments to D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots..
Jun 25 2019, 6:45 PM · Restricted Project, Restricted Project

Jun 21 2019

rtrieu committed rG82df97ca8e69: [ODRHash] Skip some typedef types. (authored by rtrieu).
[ODRHash] Skip some typedef types.
Jun 21 2019, 5:33 PM
rtrieu committed rL364119: [ODRHash] Skip some typedef types..
[ODRHash] Skip some typedef types.
Jun 21 2019, 5:33 PM

Jun 10 2019

rtrieu added a comment to rL290920: Extend -Wtautological-overlap-compare to more cases..

Hello,

do you know why this warning is not on by default? :/

Jun 10 2019, 8:42 PM

May 31 2019

rtrieu committed rG4e875464df0f: Inline variable into assert to fix unused variable warning. (authored by rtrieu).
Inline variable into assert to fix unused variable warning.
May 31 2019, 8:30 PM
rtrieu committed rL362285: Inline variable into assert to fix unused variable warning..
Inline variable into assert to fix unused variable warning.
May 31 2019, 8:30 PM

May 30 2019

rtrieu committed rG30935ef0bcdc: Fix problem with r362192 (authored by rtrieu).
Fix problem with r362192
May 30 2019, 10:54 PM
rtrieu committed rL362194: Fix problem with r362192.
Fix problem with r362192
May 30 2019, 10:52 PM
rtrieu committed rGc9e27be58558: Fix off-by-one error. (authored by rtrieu).
Fix off-by-one error.
May 30 2019, 10:05 PM
rtrieu committed rL362192: Fix off-by-one error..
Fix off-by-one error.
May 30 2019, 10:04 PM
rtrieu committed rG20b80fc4842d: Fix bad go bindings test. (authored by rtrieu).
Fix bad go bindings test.
May 30 2019, 8:45 PM
rtrieu committed rL362189: Fix bad go bindings test..
Fix bad go bindings test.
May 30 2019, 8:45 PM
rtrieu committed rGd2f53af605ab: Redirect test output to /dev/null (authored by rtrieu).
Redirect test output to /dev/null
May 30 2019, 7:23 PM
rtrieu committed rL362187: Redirect test output to /dev/null.
Redirect test output to /dev/null
May 30 2019, 7:22 PM

May 29 2019

rtrieu committed rGc8f2efe065c2: Use correct format specifier to silence -Wformat warning. (authored by rtrieu).
Use correct format specifier to silence -Wformat warning.
May 29 2019, 2:23 PM
rtrieu committed rL362035: Use correct format specifier to silence -Wformat warning..
Use correct format specifier to silence -Wformat warning.
May 29 2019, 2:23 PM
rtrieu committed rLLDB362035: Use correct format specifier to silence -Wformat warning..
Use correct format specifier to silence -Wformat warning.
May 29 2019, 2:23 PM

May 28 2019

rtrieu committed rGc77aff7e170a: Inline a variable into debug section to fix unused variable warning. (authored by rtrieu).
Inline a variable into debug section to fix unused variable warning.
May 28 2019, 9:10 PM
rtrieu committed rL361927: Inline a variable into debug section to fix unused variable warning..
Inline a variable into debug section to fix unused variable warning.
May 28 2019, 9:09 PM
rtrieu committed rGe8698ead9dd1: Inline value into debug statement to avoid unused variable warning. (authored by rtrieu).
Inline value into debug statement to avoid unused variable warning.
May 28 2019, 8:42 PM
rtrieu committed rL361924: Inline value into debug statement to avoid unused variable warning..
Inline value into debug statement to avoid unused variable warning.
May 28 2019, 8:40 PM

May 16 2019

rtrieu committed rGa9a92653a303: Fix broken test case. (authored by rtrieu).
Fix broken test case.
May 16 2019, 6:16 PM
rtrieu committed rL360969: Fix broken test case..
Fix broken test case.
May 16 2019, 6:15 PM

May 14 2019

rtrieu committed rG5f7d4ab5f975: [XCore] Create a TargetInfo header. NFC (authored by rtrieu).
[XCore] Create a TargetInfo header. NFC
May 14 2019, 6:28 PM
rtrieu committed rL360738: [XCore] Create a TargetInfo header. NFC.
[XCore] Create a TargetInfo header. NFC
May 14 2019, 6:28 PM
rtrieu committed rG011638545235: [X86] Create a TargetInfo header. NFC (authored by rtrieu).
[X86] Create a TargetInfo header. NFC
May 14 2019, 6:16 PM
rtrieu committed rL360736: [X86] Create a TargetInfo header. NFC.
[X86] Create a TargetInfo header. NFC
May 14 2019, 6:16 PM
rtrieu committed rGc6c421379dd1: [WebAssembly] Create a TargetInfo header. NFC (authored by rtrieu).
[WebAssembly] Create a TargetInfo header. NFC
May 14 2019, 6:03 PM
rtrieu committed rL360735: [WebAssembly] Create a TargetInfo header. NFC.
[WebAssembly] Create a TargetInfo header. NFC
May 14 2019, 6:02 PM
rtrieu committed rG1e6f98b89dbe: [SystemZ] Create a TargetInfo header. NFC (authored by rtrieu).
[SystemZ] Create a TargetInfo header. NFC
May 14 2019, 5:46 PM
rtrieu committed rL360734: [SystemZ] Create a TargetInfo header. NFC.
[SystemZ] Create a TargetInfo header. NFC
May 14 2019, 5:45 PM
rtrieu committed rGcf82d4a483f8: [Sparc] Create a TargetInfo header. NFC (authored by rtrieu).
[Sparc] Create a TargetInfo header. NFC
May 14 2019, 5:35 PM
rtrieu committed rL360733: [Sparc] Create a TargetInfo header. NFC.
[Sparc] Create a TargetInfo header. NFC
May 14 2019, 5:35 PM
rtrieu committed rG51fc56d603b1: [RISCV] Create a TargetInfo header. NFC (authored by rtrieu).
[RISCV] Create a TargetInfo header. NFC
May 14 2019, 5:24 PM
rtrieu committed rL360732: [RISCV] Create a TargetInfo header. NFC.
[RISCV] Create a TargetInfo header. NFC
May 14 2019, 5:22 PM
rtrieu committed rGee6ced196dda: [PowerPC] Create a TargetInfo header. NFC (authored by rtrieu).
[PowerPC] Create a TargetInfo header. NFC
May 14 2019, 5:08 PM
rtrieu committed rL360731: [PowerPC] Create a TargetInfo header. NFC.
[PowerPC] Create a TargetInfo header. NFC
May 14 2019, 5:08 PM
rtrieu committed rGe8f83befd5bf: [NVPTX] Create a TargetInfo header. NFC (authored by rtrieu).
[NVPTX] Create a TargetInfo header. NFC
May 14 2019, 4:57 PM
rtrieu committed rL360729: [NVPTX] Create a TargetInfo header. NFC.
[NVPTX] Create a TargetInfo header. NFC
May 14 2019, 4:54 PM
rtrieu committed rGa57ce32effdc: [MSP430] Create a TargetInfo header. NFC (authored by rtrieu).
[MSP430] Create a TargetInfo header. NFC
May 14 2019, 4:45 PM
rtrieu committed rL360728: [MSP430] Create a TargetInfo header. NFC.
[MSP430] Create a TargetInfo header. NFC
May 14 2019, 4:45 PM
rtrieu committed rG313b78150cec: [Mips] Create a TargetInfo header. NFC (authored by rtrieu).
[Mips] Create a TargetInfo header. NFC
May 14 2019, 4:35 PM
rtrieu committed rL360727: [Mips] Create a TargetInfo header. NFC.
[Mips] Create a TargetInfo header. NFC
May 14 2019, 4:32 PM
rtrieu committed rG2e50dc78c5e2: [Lanai] Create a TargetInfo header. NFC (authored by rtrieu).
[Lanai] Create a TargetInfo header. NFC
May 14 2019, 4:16 PM
rtrieu committed rL360726: [Lanai] Create a TargetInfo header. NFC.
[Lanai] Create a TargetInfo header. NFC
May 14 2019, 4:15 PM
rtrieu committed rG7ef172998bfd: [Hexagon] Create a TargetInfo header. NFC (authored by rtrieu).
[Hexagon] Create a TargetInfo header. NFC
May 14 2019, 4:05 PM
rtrieu committed rL360724: [Hexagon] Create a TargetInfo header. NFC.
[Hexagon] Create a TargetInfo header. NFC
May 14 2019, 4:05 PM
rtrieu committed rGa68ee931e647: [BPF] Create a TargetInfo header. NFC (authored by rtrieu).
[BPF] Create a TargetInfo header. NFC
May 14 2019, 3:54 PM
rtrieu committed rL360722: [BPF] Create a TargetInfo header. NFC.
[BPF] Create a TargetInfo header. NFC
May 14 2019, 3:54 PM
rtrieu committed rGe982b42003cb: [AVR] Create a TargetInfo header. NFC (authored by rtrieu).
[AVR] Create a TargetInfo header. NFC
May 14 2019, 3:40 PM
rtrieu committed rL360721: [AVR] Create a TargetInfo header. NFC.
[AVR] Create a TargetInfo header. NFC
May 14 2019, 3:39 PM
rtrieu committed rGf3011b9b106b: [ARM] Create a TargetInfo header. NFC (authored by rtrieu).
[ARM] Create a TargetInfo header. NFC
May 14 2019, 3:28 PM
rtrieu committed rL360718: [ARM] Create a TargetInfo header. NFC.
[ARM] Create a TargetInfo header. NFC
May 14 2019, 3:27 PM
rtrieu committed rG7f9a008a2db2: [ARC] Create a TargetInfo header. NFC (authored by rtrieu).
[ARC] Create a TargetInfo header. NFC
May 14 2019, 3:07 PM
rtrieu committed rL360716: [ARC] Create a TargetInfo header. NFC.
[ARC] Create a TargetInfo header. NFC
May 14 2019, 3:03 PM
rtrieu committed rG8ce2ee9d5626: [AMDGPU] Create a TargetInfo header. NFC (authored by rtrieu).
[AMDGPU] Create a TargetInfo header. NFC
May 14 2019, 2:53 PM