rtrieu (Richard Trieu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 11 2012, 7:44 PM (301 w, 5 d)

Recent Activity

Fri, Apr 13

rtrieu committed rL330074: [ODRHash] Support pointer and reference types..
[ODRHash] Support pointer and reference types.
Fri, Apr 13, 3:38 PM
rtrieu committed rC330074: [ODRHash] Support pointer and reference types..
[ODRHash] Support pointer and reference types.
Fri, Apr 13, 3:38 PM

Wed, Apr 11

rtrieu committed rC329869: [ODRHash] Skip more types hashing TypedefType.
[ODRHash] Skip more types hashing TypedefType
Wed, Apr 11, 7:30 PM
rtrieu committed rL329869: [ODRHash] Skip more types hashing TypedefType.
[ODRHash] Skip more types hashing TypedefType
Wed, Apr 11, 7:30 PM

Wed, Mar 28

rtrieu committed rL328763: Refactor some code for a warning. NFC..
Refactor some code for a warning. NFC.
Wed, Mar 28, 10:17 PM
rtrieu committed rC328763: Refactor some code for a warning. NFC..
Refactor some code for a warning. NFC.
Wed, Mar 28, 10:17 PM

Tue, Mar 27

rtrieu committed rC328688: Fix some handling of AST nodes with diagnostics..
Fix some handling of AST nodes with diagnostics.
Tue, Mar 27, 9:19 PM
rtrieu committed rL328688: Fix some handling of AST nodes with diagnostics..
Fix some handling of AST nodes with diagnostics.
Tue, Mar 27, 9:19 PM

Mar 23 2018

rtrieu added a comment to D43696: Reduce hash collisions for reference and pointer types.

r328404 has been committed to support references and pointers.

Mar 23 2018, 6:30 PM
rtrieu committed rL328404: [ODRHash] Support pointer and reference types..
[ODRHash] Support pointer and reference types.
Mar 23 2018, 5:56 PM
rtrieu committed rC328404: [ODRHash] Support pointer and reference types..
[ODRHash] Support pointer and reference types.
Mar 23 2018, 5:56 PM

Mar 21 2018

rtrieu accepted D43737: Improve -Winfinite-recursion.

Looks good. Ready to commit.

Mar 21 2018, 4:05 PM

Mar 14 2018

rtrieu committed rL327598: Refactoring code around move/copy initialization. NFC..
Refactoring code around move/copy initialization. NFC.
Mar 14 2018, 8:06 PM
rtrieu committed rC327598: Refactoring code around move/copy initialization. NFC..
Refactoring code around move/copy initialization. NFC.
Mar 14 2018, 8:06 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Mar 14 2018, 8:06 PM
rtrieu committed rL327593: [CFG] Allow CallExpr's to be looked up in CFG's.
[CFG] Allow CallExpr's to be looked up in CFG's
Mar 14 2018, 5:13 PM
rtrieu committed rC327593: [CFG] Allow CallExpr's to be looked up in CFG's.
[CFG] Allow CallExpr's to be looked up in CFG's
Mar 14 2018, 5:13 PM
rtrieu added a comment to D43737: Improve -Winfinite-recursion.

Two more changes, then everything is good to commit.

Mar 14 2018, 2:00 PM

Mar 13 2018

rtrieu added a comment to D43898: Preliminary refactoring in service of -Wreturn-std-move. NFC..

Everything looks good and ready for commit.

Mar 13 2018, 4:00 PM

Mar 12 2018

rtrieu added a comment to D43737: Improve -Winfinite-recursion.
I believe you were around this code last, so can you remember why it was there?

Yes, that's an early exit to speed up the check. You can remove that check and add a test case for it.

Mar 12 2018, 8:23 PM

Mar 9 2018

rtrieu added inline comments to D40731: Integrate CHash into CLang.
Mar 9 2018, 7:31 PM
rtrieu added inline comments to D43898: Preliminary refactoring in service of -Wreturn-std-move. NFC..
Mar 9 2018, 5:01 PM

Feb 28 2018

rtrieu added inline comments to D43696: Reduce hash collisions for reference and pointer types.
Feb 28 2018, 8:29 PM

Feb 27 2018

rtrieu added inline comments to D43737: Improve -Winfinite-recursion.
Feb 27 2018, 9:45 PM
rtrieu added a comment to D43737: Improve -Winfinite-recursion.

Can you explain the new algorithm for checking recursive calls?

Feb 27 2018, 9:39 PM
rtrieu added a comment to D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency.

I have one very minor nit that I don't know how to fix:

warn-return-std-move.cpp:220:12: warning: local variable 'd' will be copied
      despite being returned by name [-Wreturn-std-move]
    return (d);  // e17
           ^
warn-return-std-move.cpp:220:12: note: call 'std::move' explicitly to avoid copying
    return (d);  // e17
           ^~~
           std::move(d)

The warning places a caret directly under the (, when I wish it would place ^~~ under the entire expression, the way the fixit does.

You can add extra tildes to any diagnostic by passing a SourceRange to Diag() calls the same way you pass FixitHints.

Feb 27 2018, 9:17 PM · Restricted Project

Feb 23 2018

rtrieu added inline comments to D43696: Reduce hash collisions for reference and pointer types.
Feb 23 2018, 5:04 PM

Feb 21 2018

rtrieu committed rC325742: [ODRHash] Fix hashing for friend functions..
[ODRHash] Fix hashing for friend functions.
Feb 21 2018, 9:54 PM
rtrieu committed rL325742: [ODRHash] Fix hashing for friend functions..
[ODRHash] Fix hashing for friend functions.
Feb 21 2018, 9:54 PM
rtrieu committed rC325741: [ODRHash] Handle some template weirdness..
[ODRHash] Handle some template weirdness.
Feb 21 2018, 9:37 PM
rtrieu committed rL325741: [ODRHash] Handle some template weirdness..
[ODRHash] Handle some template weirdness.
Feb 21 2018, 9:37 PM

Feb 13 2018

rtrieu committed rL325040: Update StmtProfile.cpp to handle zero template arguments..
Update StmtProfile.cpp to handle zero template arguments.
Feb 13 2018, 11:56 AM
rtrieu committed rC325040: Update StmtProfile.cpp to handle zero template arguments..
Update StmtProfile.cpp to handle zero template arguments.
Feb 13 2018, 11:56 AM

Feb 5 2018

rtrieu committed rL324308: Fix crash on invalid..
Fix crash on invalid.
Feb 5 2018, 7:00 PM
rtrieu committed rC324308: Fix crash on invalid..
Fix crash on invalid.
Feb 5 2018, 7:00 PM

Jan 26 2018

rtrieu committed rL323569: Inline variable only used within assert..
Inline variable only used within assert.
Jan 26 2018, 1:56 PM

Jan 23 2018

rtrieu committed rC323267: Fix test Driver/solaris-ld.c.
Fix test Driver/solaris-ld.c
Jan 23 2018, 2:02 PM
rtrieu committed rL323267: Fix test Driver/solaris-ld.c.
Fix test Driver/solaris-ld.c
Jan 23 2018, 2:02 PM

Jan 19 2018

rtrieu committed rL322984: Allow BlockDecl in CXXRecord scope to have no access specifier..
Allow BlockDecl in CXXRecord scope to have no access specifier.
Jan 19 2018, 12:49 PM
rtrieu committed rC322984: Allow BlockDecl in CXXRecord scope to have no access specifier..
Allow BlockDecl in CXXRecord scope to have no access specifier.
Jan 19 2018, 12:49 PM

Jan 17 2018

rtrieu committed rL322813: Fix Scope::dump().
Fix Scope::dump()
Jan 17 2018, 8:32 PM
rtrieu committed rC322813: Fix Scope::dump().
Fix Scope::dump()
Jan 17 2018, 8:31 PM

Jan 16 2018

rtrieu committed rC322593: Add context to why test was disabled on Windows.
Add context to why test was disabled on Windows
Jan 16 2018, 11:54 AM
rtrieu committed rL322593: Add context to why test was disabled on Windows.
Add context to why test was disabled on Windows
Jan 16 2018, 11:54 AM

Jan 12 2018

rtrieu committed rL322420: Try to suppress Windows testing again..
Try to suppress Windows testing again.
Jan 12 2018, 3:15 PM
rtrieu committed rC322420: Try to suppress Windows testing again..
Try to suppress Windows testing again.
Jan 12 2018, 3:14 PM
rtrieu committed rC322405: Disable test for Windows to fix Windows buildbots..
Disable test for Windows to fix Windows buildbots.
Jan 12 2018, 1:50 PM
rtrieu committed rL322405: Disable test for Windows to fix Windows buildbots..
Disable test for Windows to fix Windows buildbots.
Jan 12 2018, 1:50 PM

Jan 11 2018

rtrieu committed rL322350: [ODRHash] Don't hash friend functions..
[ODRHash] Don't hash friend functions.
Jan 11 2018, 8:43 PM
rtrieu committed rC322350: [ODRHash] Don't hash friend functions..
[ODRHash] Don't hash friend functions.
Jan 11 2018, 8:43 PM

Jan 5 2018

rtrieu committed rC321924: Test case for r321396.
Test case for r321396
Jan 5 2018, 7:22 PM
rtrieu committed rL321924: Test case for r321396.
Test case for r321396
Jan 5 2018, 7:22 PM

Dec 22 2017

rtrieu committed rC321396: [ODRHash] Disable hashing on methods..
[ODRHash] Disable hashing on methods.
Dec 22 2017, 5:36 PM
rtrieu committed rL321396: [ODRHash] Disable hashing on methods..
[ODRHash] Disable hashing on methods.
Dec 22 2017, 5:36 PM
rtrieu committed rC321395: [ODRHash] Support ODR violation detection in functions..
[ODRHash] Support ODR violation detection in functions.
Dec 22 2017, 4:42 PM
rtrieu committed rL321395: [ODRHash] Support ODR violation detection in functions..
[ODRHash] Support ODR violation detection in functions.
Dec 22 2017, 4:41 PM

Dec 21 2017

rtrieu committed rL321319: [ODRHash] Canonicalize Decl's before processing..
[ODRHash] Canonicalize Decl's before processing.
Dec 21 2017, 2:39 PM
rtrieu committed rC321319: [ODRHash] Canonicalize Decl's before processing..
[ODRHash] Canonicalize Decl's before processing.
Dec 21 2017, 2:39 PM

Dec 11 2017

rtrieu committed rL320429: Revert r318704 - [Sparc] efficient pattern for UINT_TO_FP conversion.
Revert r318704 - [Sparc] efficient pattern for UINT_TO_FP conversion
Dec 11 2017, 2:25 PM

Dec 8 2017

rtrieu committed rC320239: Revert r320230 to fix buildbots..
Revert r320230 to fix buildbots.
Dec 8 2017, 7:03 PM
rtrieu committed rL320239: Revert r320230 to fix buildbots..
Revert r320230 to fix buildbots.
Dec 8 2017, 7:03 PM
rtrieu committed rC320230: [ODRHash] Support ODR violation detection in functions..
[ODRHash] Support ODR violation detection in functions.
Dec 8 2017, 5:30 PM
rtrieu committed rL320230: [ODRHash] Support ODR violation detection in functions..
[ODRHash] Support ODR violation detection in functions.
Dec 8 2017, 5:30 PM

Nov 21 2017

rtrieu committed rL318811: [OpenMP] Fix tests after r318789.
[OpenMP] Fix tests after r318789
Nov 21 2017, 2:53 PM

Nov 20 2017

rtrieu committed rL318724: Add default values for member functions..
Add default values for member functions.
Nov 20 2017, 5:47 PM
rtrieu committed rL318710: Revert r318678 to fix Clang test.
Revert r318678 to fix Clang test
Nov 20 2017, 4:12 PM

Nov 10 2017

rtrieu committed rL317957: Handle lambda captures of variable length arrays in profiling and printing..
Handle lambda captures of variable length arrays in profiling and printing.
Nov 10 2017, 4:55 PM

Nov 3 2017

rtrieu committed rL317394: Update ODR hashing tests.
Update ODR hashing tests
Nov 3 2017, 6:21 PM

Oct 31 2017

rtrieu committed rL317073: Change assertion to quick exit from checking function..
Change assertion to quick exit from checking function.
Oct 31 2017, 8:58 PM

Sep 29 2017

rtrieu committed rL314581: [ODRHash] Add base classes to hashing CXXRecordDecl..
[ODRHash] Add base classes to hashing CXXRecordDecl.
Sep 29 2017, 7:21 PM

Sep 25 2017

rtrieu committed rL314035: Fix unused variable warning in non-debug builds..
Fix unused variable warning in non-debug builds.
Sep 25 2017, 5:06 AM

Sep 21 2017

rtrieu committed rL313942: Fix unused variable warning..
Fix unused variable warning.
Sep 21 2017, 4:49 PM

Sep 8 2017

rtrieu committed rL312842: Catch more cases with -Wenum-compare.
Catch more cases with -Wenum-compare
Sep 8 2017, 5:26 PM

Sep 7 2017

rtrieu committed rL312758: Revert r312318, r312325, r312424, r312489.
Revert r312318, r312325, r312424, r312489
Sep 7 2017, 4:22 PM

Aug 22 2017

rtrieu committed rL311519: [ODRHash] Diagnose differing template parameters..
[ODRHash] Diagnose differing template parameters.
Aug 22 2017, 7:45 PM

Aug 8 2017

rtrieu committed rL310435: Allow operator delete to be an invalid Decl..
Allow operator delete to be an invalid Decl.
Aug 8 2017, 7:04 PM

Aug 4 2017

rtrieu committed rL310158: [ODRHash] Treat some non-templated classes as templated..
[ODRHash] Treat some non-templated classes as templated.
Aug 4 2017, 5:55 PM

Jul 21 2017

rtrieu committed rL308783: Inline variable into assert to fix unused warning..
Inline variable into assert to fix unused warning.
Jul 21 2017, 2:30 PM
rtrieu committed rL308777: Fix tblgen error.
Fix tblgen error
Jul 21 2017, 1:32 PM

Jul 20 2017

rtrieu committed rL308714: Fix tblgen error..
Fix tblgen error.
Jul 20 2017, 9:58 PM

Jul 14 2017

rtrieu committed rL308077: [ODRHash] Revert r307743 which reverted r307720.
[ODRHash] Revert r307743 which reverted r307720
Jul 14 2017, 7:55 PM

Jul 13 2017

rtrieu committed rL307986: [ODRHash] Avoid taking the types of FunctionDecl's.
[ODRHash] Avoid taking the types of FunctionDecl's
Jul 13 2017, 6:37 PM

Jul 11 2017

rtrieu committed rL307743: [ODRHash] Revert r307720 to fix buildbot..
[ODRHash] Revert r307720 to fix buildbot.
Jul 11 2017, 5:38 PM
rtrieu committed rL307720: [ODRHash] Support more method types..
[ODRHash] Support more method types.
Jul 11 2017, 3:11 PM

Jul 9 2017

rtrieu committed rL307458: [ODRHash] Support FriendDecl.
[ODRHash] Support FriendDecl
Jul 9 2017, 6:19 AM

Jun 30 2017

rtrieu committed rL306926: [ODRHash] Revert r305104 - Skip inline namespaces when hashing..
[ODRHash] Revert r305104 - Skip inline namespaces when hashing.
Jun 30 2017, 7:00 PM
rtrieu committed rL306904: [ODRHash] Support Type TemplateArgument.
[ODRHash] Support Type TemplateArgument
Jun 30 2017, 3:41 PM

Jun 29 2017

rtrieu committed rL306753: [ODRHash] Improve typedef handling..
[ODRHash] Improve typedef handling.
Jun 29 2017, 3:53 PM
rtrieu added a comment to D34810: [Sema] -Wcomma should not warn for expressions that return void.

Reid is correct, the whitelisted expressions was greatly reduced during code review so only casts to void would disable the warning. While the last review did not have the description updated to reflect this, the committed code does have an accurate description. What is the reason to exclude void expressions now? For the function case, it is more consistent to warn on all function calls since we can't determine if a function returns void just by looking at the call site.

Jun 29 2017, 3:06 PM

Jun 20 2017

rtrieu committed rL305872: [ODRHash] Supply more information when generic error message is emitted..
[ODRHash] Supply more information when generic error message is emitted.
Jun 20 2017, 6:43 PM

Jun 15 2017

rtrieu committed rL305543: [ODRHash] Hash VarDecl members..
[ODRHash] Hash VarDecl members.
Jun 15 2017, 7:45 PM

Jun 14 2017

rtrieu committed rL305440: [ODRHash] Hash TemplateArgument::Pack and TemplateTypeParmType.
[ODRHash] Hash TemplateArgument::Pack and TemplateTypeParmType
Jun 14 2017, 6:35 PM

Jun 13 2017

rtrieu committed rL305362: [ODRHash] Remove debugging code from r305361.
[ODRHash] Remove debugging code from r305361
Jun 13 2017, 8:20 PM
rtrieu committed rL305361: [ODRHash] Hash Template and TemplateExpansion in TemplateArgument..
[ODRHash] Hash Template and TemplateExpansion in TemplateArgument.
Jun 13 2017, 8:18 PM
rtrieu committed rL305360: [ODRHash] Hash Expr for TemplateArgument::Expression.
[ODRHash] Hash Expr for TemplateArgument::Expression
Jun 13 2017, 6:45 PM
rtrieu committed rL305328: [ODRHash] Add TemplateArgument kind to hash..
[ODRHash] Add TemplateArgument kind to hash.
Jun 13 2017, 3:22 PM

Jun 12 2017

rtrieu committed rL305238: [ODRHash] Add diagnostic messages for typedef and type alias..
[ODRHash] Add diagnostic messages for typedef and type alias.
Jun 12 2017, 2:59 PM

Jun 9 2017

rtrieu committed rL305130: Revert r305110 to fix buildbot.
Revert r305110 to fix buildbot
Jun 9 2017, 4:04 PM
rtrieu committed rL305110: [ODRHash] Add support for TemplateArgument types..
[ODRHash] Add support for TemplateArgument types.
Jun 9 2017, 2:00 PM
rtrieu committed rL305104: [ODRHash] Skip inline namespaces when hashing..
[ODRHash] Skip inline namespaces when hashing.
Jun 9 2017, 1:12 PM