Page MenuHomePhabricator
People rtrieu

rtrieu (Richard Trieu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 11 2012, 7:44 PM (379 w, 5 d)

Recent Activity
View All

Today

rtrieu added a comment to D66046: Add new tautological compare warning for bitwise-or with a non-zero constant.
In D66046#1717229, @thakis wrote:

Mr Trieu, what do you think about adding some or all of the Wtautological-compare warnings to Wall

Mon, Oct 21, 8:04 PM · Restricted Project
rtrieu created D69292: Proposal to add -Wtautological-compare to -Wall.
Mon, Oct 21, 7:45 PM

Fri, Oct 18

rtrieu committed rG637af4cc3780: Add -Wbitwise-conditional-parentheses to warn on mixing '|' and '&' with "?:" (authored by rtrieu).
Add -Wbitwise-conditional-parentheses to warn on mixing '|' and '&' with "?:"
Fri, Oct 18, 6:52 PM
rtrieu closed D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:").
Fri, Oct 18, 6:52 PM · Restricted Project
rtrieu committed rL375326: Add -Wbitwise-conditional-parentheses to warn on mixing '|' and '&' with "?:".
Add -Wbitwise-conditional-parentheses to warn on mixing '|' and '&' with "?:"
Fri, Oct 18, 6:52 PM
rtrieu committed rG8b0d14a8f0cc: New tautological warning for bitwise-or with non-zero constant always true. (authored by rtrieu).
New tautological warning for bitwise-or with non-zero constant always true.
Fri, Oct 18, 5:57 PM
rtrieu committed rL375318: New tautological warning for bitwise-or with non-zero constant always true..
New tautological warning for bitwise-or with non-zero constant always true.
Fri, Oct 18, 5:57 PM
rtrieu closed D66046: Add new tautological compare warning for bitwise-or with a non-zero constant.
Fri, Oct 18, 5:57 PM · Restricted Project

Thu, Oct 10

rtrieu added a comment to D66046: Add new tautological compare warning for bitwise-or with a non-zero constant.
In D66046#1696785, @xbolva00 wrote:

Could this patch solve https://bugs.llvm.org/show_bug.cgi?id=43573?

Thu, Oct 10, 8:59 PM · Restricted Project

Fri, Oct 4

rtrieu added inline comments to rL373614: [Diagnostics] Bitwise negation of a boolean expr always evaluates to true; warn….
Fri, Oct 4, 5:07 PM

Tue, Oct 1

rtrieu committed rGe3887253165c: Revert r368237 - Update fix-it hints for std::move warnings. (authored by rtrieu).
Revert r368237 - Update fix-it hints for std::move warnings.
Tue, Oct 1, 7:33 PM
rtrieu committed rL373421: Revert r368237 - Update fix-it hints for std::move warnings..
Revert r368237 - Update fix-it hints for std::move warnings.
Tue, Oct 1, 7:30 PM

Sep 20 2019

rtrieu committed rG77297f0761d2: Fix bad APInt compare. (authored by rtrieu).
Fix bad APInt compare.
Sep 20 2019, 9:20 PM
rtrieu committed rL372454: Fix bad APInt compare..
Fix bad APInt compare.
Sep 20 2019, 9:17 PM
rtrieu committed rG4c05de8c1d15: Merge and improve code that detects same value in comparisons. (authored by rtrieu).
Merge and improve code that detects same value in comparisons.
Sep 20 2019, 8:05 PM
rtrieu committed rL372453: Merge and improve code that detects same value in comparisons..
Merge and improve code that detects same value in comparisons.
Sep 20 2019, 8:04 PM
rtrieu closed D66045: Improve detection of same value in comparisons.
Sep 20 2019, 8:04 PM · Restricted Project
rtrieu committed rG6541c7988b83: Improve -Wtautological-overlap-compare (authored by rtrieu).
Improve -Wtautological-overlap-compare
Sep 20 2019, 7:37 PM
rtrieu committed rL372448: Improve -Wtautological-overlap-compare.
Improve -Wtautological-overlap-compare
Sep 20 2019, 7:37 PM
rtrieu closed D66044: Extend -Wtautological-overlap-compare to accept negative values and integer conversions.
Sep 20 2019, 7:37 PM · Restricted Project

Sep 6 2019

rtrieu updated the diff for D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:").

Add more test cases and split new warnings into a separate warning group, but still under -Wparentheses

Sep 6 2019, 6:55 PM · Restricted Project

Aug 28 2019

rtrieu committed rGe4a7f0182d40: Add requirement to test. (authored by rtrieu).
Add requirement to test.
Aug 28 2019, 5:47 PM
rtrieu committed rL370279: Add requirement to test..
Add requirement to test.
Aug 28 2019, 5:47 PM

Aug 27 2019

rtrieu committed rG1709f4847e0c: Revert r370105 - Update two x86 datalayouts for r370083, looks like racing… (authored by rtrieu).
Revert r370105 - Update two x86 datalayouts for r370083, looks like racing…
Aug 27 2019, 6:56 PM
rtrieu committed rL370147: Revert r370105 - Update two x86 datalayouts for r370083, looks like racing….
Revert r370105 - Update two x86 datalayouts for r370083, looks like racing…
Aug 27 2019, 6:55 PM

Aug 26 2019

rtrieu committed rG58e67b8aa38c: Revert r369927 - [DAGCombiner] Remove a bunch of redundant AddToWorklist calls. (authored by rtrieu).
Revert r369927 - [DAGCombiner] Remove a bunch of redundant AddToWorklist calls.
Aug 26 2019, 7:05 PM
rtrieu committed rL370006: Revert r369927 - [DAGCombiner] Remove a bunch of redundant AddToWorklist calls..
Revert r369927 - [DAGCombiner] Remove a bunch of redundant AddToWorklist calls.
Aug 26 2019, 7:04 PM
rtrieu added a comment to D66537: [DAGCombiner] Remove a bunch of redundant AddToWorklist calls..

I have reverted this in r370006.

Aug 26 2019, 7:04 PM · Restricted Project
rtrieu committed rGf837bb4a3443: Copy test data so tests don't traverse test directories. NFC (authored by rtrieu).
Copy test data so tests don't traverse test directories. NFC
Aug 26 2019, 3:42 PM
rtrieu committed rL369984: Copy test data so tests don't traverse test directories. NFC.
Copy test data so tests don't traverse test directories. NFC
Aug 26 2019, 3:41 PM

Aug 19 2019

rtrieu committed rG8f9e489a6658: Fix typo. "piont" => "point" (authored by rtrieu).
Fix typo. "piont" => "point"
Aug 19 2019, 5:34 PM
rtrieu committed rL369316: Fix typo. "piont" => "point".
Fix typo. "piont" => "point"
Aug 19 2019, 5:34 PM

Aug 13 2019

rtrieu added a comment to D66044: Extend -Wtautological-overlap-compare to accept negative values and integer conversions.
In D66044#1626008, @NoQ wrote:

Looks great, thanks! I'd appreciate direct CFG tests for the part that changes the CFG (cf. test/Analysis/cfg.cpp), but i don't insist. Let's make sure @jfb is happy and commit :)

Aug 13 2019, 8:12 PM · Restricted Project
rtrieu updated the diff for D66044: Extend -Wtautological-overlap-compare to accept negative values and integer conversions.
Aug 13 2019, 8:08 PM · Restricted Project
rtrieu added inline comments to D66045: Improve detection of same value in comparisons.
Aug 13 2019, 6:33 PM · Restricted Project
rtrieu updated the diff for D66045: Improve detection of same value in comparisons.
Aug 13 2019, 6:20 PM · Restricted Project
rtrieu updated the diff for D66048: Combined patch for new warning work.

Better handling of arrays in self compares.

Aug 13 2019, 4:40 PM
rtrieu added inline comments to D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:").
Aug 13 2019, 4:09 PM · Restricted Project

Aug 12 2019

rtrieu updated the diff for D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:").

Update comments to explain why bitwise-xor is treated as a logical operator.

Aug 12 2019, 7:38 PM · Restricted Project
rtrieu added inline comments to D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:").
Aug 12 2019, 7:38 PM · Restricted Project
rtrieu added inline comments to D66045: Improve detection of same value in comparisons.
Aug 12 2019, 7:29 PM · Restricted Project
rtrieu updated the diff for D66045: Improve detection of same value in comparisons.

Check array accesses.

Aug 12 2019, 7:25 PM · Restricted Project
rtrieu added inline comments to D66045: Improve detection of same value in comparisons.
Aug 12 2019, 4:40 PM · Restricted Project
rtrieu added inline comments to D66046: Add new tautological compare warning for bitwise-or with a non-zero constant.
Aug 12 2019, 4:23 PM · Restricted Project
rtrieu updated the diff for D66046: Add new tautological compare warning for bitwise-or with a non-zero constant.

Create new function isIntOrEnumConstantZero to use instead of EvaluateAsInt

Aug 12 2019, 4:19 PM · Restricted Project
rtrieu updated the summary of D66046: Add new tautological compare warning for bitwise-or with a non-zero constant.
Aug 12 2019, 3:29 PM · Restricted Project
rtrieu added inline comments to D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:").
Aug 12 2019, 3:29 PM · Restricted Project
rtrieu added a comment to D66045: Improve detection of same value in comparisons.
In D66045#1624389, @jfb wrote:

Does this work for unions as well?

Aug 12 2019, 3:17 PM · Restricted Project
rtrieu added inline comments to D66046: Add new tautological compare warning for bitwise-or with a non-zero constant.
Aug 12 2019, 2:52 PM · Restricted Project
rtrieu added inline comments to D66044: Extend -Wtautological-overlap-compare to accept negative values and integer conversions.
Aug 12 2019, 2:40 PM · Restricted Project
rtrieu added inline comments to D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:").
Aug 12 2019, 2:28 PM · Restricted Project

Aug 9 2019

rtrieu added a reviewer for D66045: Improve detection of same value in comparisons: cfe-commits.
Aug 9 2019, 7:04 PM · Restricted Project
rtrieu added a reviewer for D66046: Add new tautological compare warning for bitwise-or with a non-zero constant: cfe-commits.
Aug 9 2019, 7:04 PM · Restricted Project
rtrieu added a reviewer for D66044: Extend -Wtautological-overlap-compare to accept negative values and integer conversions: cfe-commits.
Aug 9 2019, 7:04 PM · Restricted Project
rtrieu added a reviewer for D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:"): cfe-commits.
Aug 9 2019, 7:04 PM · Restricted Project
rtrieu created D66048: Combined patch for new warning work.
Aug 9 2019, 7:04 PM
rtrieu created D66045: Improve detection of same value in comparisons.
Aug 9 2019, 6:55 PM · Restricted Project
rtrieu created D66046: Add new tautological compare warning for bitwise-or with a non-zero constant.
Aug 9 2019, 6:55 PM · Restricted Project
rtrieu created D66043: Add to -Wparentheses case of bitwise-and ("&") and bitwise-or ("|") verses conditional operator ("?:").
Aug 9 2019, 6:55 PM · Restricted Project
rtrieu created D66044: Extend -Wtautological-overlap-compare to accept negative values and integer conversions.
Aug 9 2019, 6:55 PM · Restricted Project

Aug 7 2019

rtrieu committed rG07e6798baf9a: Inline diagnostic text into .td file. NFC. (authored by rtrieu).
Inline diagnostic text into .td file. NFC.
Aug 7 2019, 6:47 PM
rtrieu committed rL368244: Inline diagnostic text into .td file. NFC..
Inline diagnostic text into .td file. NFC.
Aug 7 2019, 6:47 PM
rtrieu committed rG155b8d02c363: Update fix-it hints for std::move warnings. (authored by rtrieu).
Update fix-it hints for std::move warnings.
Aug 7 2019, 5:17 PM
rtrieu committed rL368237: Update fix-it hints for std::move warnings..
Update fix-it hints for std::move warnings.
Aug 7 2019, 5:12 PM

Jul 30 2019

rtrieu committed rG33cdbff2a78a: Change '|' to '&' in conditional. (authored by rtrieu).
Change '|' to '&' in conditional.
Jul 30 2019, 9:42 PM
rtrieu committed rL367386: Change '|' to '&' in conditional..
Change '|' to '&' in conditional.
Jul 30 2019, 9:40 PM

Jul 22 2019

rtrieu committed rG3a52c3857feb: Inline function call into assert to fix unused variable warning. (authored by rtrieu).
Inline function call into assert to fix unused variable warning.
Jul 22 2019, 8:11 PM
rtrieu committed rL366774: Inline function call into assert to fix unused variable warning..
Inline function call into assert to fix unused variable warning.
Jul 22 2019, 8:11 PM
rtrieu committed rG81a5045cd632: Move variable out from debug only section. (authored by rtrieu).
Move variable out from debug only section.
Jul 22 2019, 8:00 PM
rtrieu committed rL366773: Move variable out from debug only section..
Move variable out from debug only section.
Jul 22 2019, 8:00 PM

Jul 10 2019

rtrieu committed rG9066e5f832bf: Increase the number of parser diagnostics. (authored by rtrieu).
Increase the number of parser diagnostics.
Jul 10 2019, 7:56 PM
rtrieu committed rL365727: Increase the number of parser diagnostics..
Increase the number of parser diagnostics.
Jul 10 2019, 7:54 PM

Jun 27 2019

rtrieu accepted D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots..

LGTM

Jun 27 2019, 8:52 PM · Restricted Project, Restricted Project

Jun 26 2019

rtrieu added inline comments to D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots..
Jun 26 2019, 2:36 PM · Restricted Project, Restricted Project

Jun 25 2019

rtrieu added inline comments to D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots..
Jun 25 2019, 6:45 PM · Restricted Project, Restricted Project

Jun 21 2019

rtrieu committed rG82df97ca8e69: [ODRHash] Skip some typedef types. (authored by rtrieu).
[ODRHash] Skip some typedef types.
Jun 21 2019, 5:33 PM
rtrieu committed rL364119: [ODRHash] Skip some typedef types..
[ODRHash] Skip some typedef types.
Jun 21 2019, 5:33 PM

Jun 10 2019

rtrieu added a comment to rL290920: Extend -Wtautological-overlap-compare to more cases..
In rL290920#660685, @xbolva00 wrote:

Hello,

do you know why this warning is not on by default? :/

Jun 10 2019, 8:42 PM

May 31 2019

rtrieu committed rG4e875464df0f: Inline variable into assert to fix unused variable warning. (authored by rtrieu).
Inline variable into assert to fix unused variable warning.
May 31 2019, 8:30 PM
rtrieu committed rL362285: Inline variable into assert to fix unused variable warning..
Inline variable into assert to fix unused variable warning.
May 31 2019, 8:30 PM

May 30 2019

rtrieu committed rG30935ef0bcdc: Fix problem with r362192 (authored by rtrieu).
Fix problem with r362192
May 30 2019, 10:54 PM
rtrieu committed rL362194: Fix problem with r362192.
Fix problem with r362192
May 30 2019, 10:52 PM
rtrieu committed rGc9e27be58558: Fix off-by-one error. (authored by rtrieu).
Fix off-by-one error.
May 30 2019, 10:05 PM
rtrieu committed rL362192: Fix off-by-one error..
Fix off-by-one error.
May 30 2019, 10:04 PM
rtrieu committed rG20b80fc4842d: Fix bad go bindings test. (authored by rtrieu).
Fix bad go bindings test.
May 30 2019, 8:45 PM
rtrieu committed rL362189: Fix bad go bindings test..
Fix bad go bindings test.
May 30 2019, 8:45 PM
rtrieu committed rGd2f53af605ab: Redirect test output to /dev/null (authored by rtrieu).
Redirect test output to /dev/null
May 30 2019, 7:23 PM
rtrieu committed rL362187: Redirect test output to /dev/null.
Redirect test output to /dev/null
May 30 2019, 7:22 PM

May 29 2019

rtrieu committed rGc8f2efe065c2: Use correct format specifier to silence -Wformat warning. (authored by rtrieu).
Use correct format specifier to silence -Wformat warning.
May 29 2019, 2:23 PM
rtrieu committed rL362035: Use correct format specifier to silence -Wformat warning..
Use correct format specifier to silence -Wformat warning.
May 29 2019, 2:23 PM
rtrieu committed rLLDB362035: Use correct format specifier to silence -Wformat warning..
Use correct format specifier to silence -Wformat warning.
May 29 2019, 2:23 PM

May 28 2019

rtrieu committed rGc77aff7e170a: Inline a variable into debug section to fix unused variable warning. (authored by rtrieu).
Inline a variable into debug section to fix unused variable warning.
May 28 2019, 9:10 PM
rtrieu committed rL361927: Inline a variable into debug section to fix unused variable warning..
Inline a variable into debug section to fix unused variable warning.
May 28 2019, 9:09 PM
rtrieu committed rGe8698ead9dd1: Inline value into debug statement to avoid unused variable warning. (authored by rtrieu).
Inline value into debug statement to avoid unused variable warning.
May 28 2019, 8:42 PM
rtrieu committed rL361924: Inline value into debug statement to avoid unused variable warning..
Inline value into debug statement to avoid unused variable warning.
May 28 2019, 8:40 PM

May 16 2019

rtrieu committed rGa9a92653a303: Fix broken test case. (authored by rtrieu).
Fix broken test case.
May 16 2019, 6:16 PM
rtrieu committed rL360969: Fix broken test case..
Fix broken test case.
May 16 2019, 6:15 PM

May 14 2019

rtrieu committed rG5f7d4ab5f975: [XCore] Create a TargetInfo header. NFC (authored by rtrieu).
[XCore] Create a TargetInfo header. NFC
May 14 2019, 6:28 PM
rtrieu committed rL360738: [XCore] Create a TargetInfo header. NFC.
[XCore] Create a TargetInfo header. NFC
May 14 2019, 6:28 PM
rtrieu committed rG011638545235: [X86] Create a TargetInfo header. NFC (authored by rtrieu).
[X86] Create a TargetInfo header. NFC
May 14 2019, 6:16 PM