Page MenuHomePhabricator
People rtrieu

rtrieu (Richard Trieu)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 11 2012, 7:44 PM (361 w, 5 d)

Recent Activity
View All

Mon, Jun 10

rtrieu added a comment to rL290920: Extend -Wtautological-overlap-compare to more cases..
In rL290920#660685, @xbolva00 wrote:

Hello,

do you know why this warning is not on by default? :/

Mon, Jun 10, 8:42 PM

Fri, May 31

rtrieu committed rG4e875464df0f: Inline variable into assert to fix unused variable warning. (authored by rtrieu).
Inline variable into assert to fix unused variable warning.
Fri, May 31, 8:30 PM
rtrieu committed rL362285: Inline variable into assert to fix unused variable warning..
Inline variable into assert to fix unused variable warning.
Fri, May 31, 8:30 PM

Thu, May 30

rtrieu committed rG30935ef0bcdc: Fix problem with r362192 (authored by rtrieu).
Fix problem with r362192
Thu, May 30, 10:54 PM
rtrieu committed rL362194: Fix problem with r362192.
Fix problem with r362192
Thu, May 30, 10:52 PM
rtrieu committed rGc9e27be58558: Fix off-by-one error. (authored by rtrieu).
Fix off-by-one error.
Thu, May 30, 10:05 PM
rtrieu committed rL362192: Fix off-by-one error..
Fix off-by-one error.
Thu, May 30, 10:04 PM
rtrieu committed rG20b80fc4842d: Fix bad go bindings test. (authored by rtrieu).
Fix bad go bindings test.
Thu, May 30, 8:45 PM
rtrieu committed rL362189: Fix bad go bindings test..
Fix bad go bindings test.
Thu, May 30, 8:45 PM
rtrieu committed rGd2f53af605ab: Redirect test output to /dev/null (authored by rtrieu).
Redirect test output to /dev/null
Thu, May 30, 7:23 PM
rtrieu committed rL362187: Redirect test output to /dev/null.
Redirect test output to /dev/null
Thu, May 30, 7:22 PM

Wed, May 29

rtrieu committed rGc8f2efe065c2: Use correct format specifier to silence -Wformat warning. (authored by rtrieu).
Use correct format specifier to silence -Wformat warning.
Wed, May 29, 2:23 PM
rtrieu committed rL362035: Use correct format specifier to silence -Wformat warning..
Use correct format specifier to silence -Wformat warning.
Wed, May 29, 2:23 PM
rtrieu committed rLLDB362035: Use correct format specifier to silence -Wformat warning..
Use correct format specifier to silence -Wformat warning.
Wed, May 29, 2:23 PM

Tue, May 28

rtrieu committed rGc77aff7e170a: Inline a variable into debug section to fix unused variable warning. (authored by rtrieu).
Inline a variable into debug section to fix unused variable warning.
Tue, May 28, 9:10 PM
rtrieu committed rL361927: Inline a variable into debug section to fix unused variable warning..
Inline a variable into debug section to fix unused variable warning.
Tue, May 28, 9:09 PM
rtrieu committed rGe8698ead9dd1: Inline value into debug statement to avoid unused variable warning. (authored by rtrieu).
Inline value into debug statement to avoid unused variable warning.
Tue, May 28, 8:42 PM
rtrieu committed rL361924: Inline value into debug statement to avoid unused variable warning..
Inline value into debug statement to avoid unused variable warning.
Tue, May 28, 8:40 PM

May 16 2019

rtrieu committed rGa9a92653a303: Fix broken test case. (authored by rtrieu).
Fix broken test case.
May 16 2019, 6:16 PM
rtrieu committed rL360969: Fix broken test case..
Fix broken test case.
May 16 2019, 6:15 PM

May 14 2019

rtrieu committed rG5f7d4ab5f975: [XCore] Create a TargetInfo header. NFC (authored by rtrieu).
[XCore] Create a TargetInfo header. NFC
May 14 2019, 6:28 PM
rtrieu committed rL360738: [XCore] Create a TargetInfo header. NFC.
[XCore] Create a TargetInfo header. NFC
May 14 2019, 6:28 PM
rtrieu committed rG011638545235: [X86] Create a TargetInfo header. NFC (authored by rtrieu).
[X86] Create a TargetInfo header. NFC
May 14 2019, 6:16 PM
rtrieu committed rL360736: [X86] Create a TargetInfo header. NFC.
[X86] Create a TargetInfo header. NFC
May 14 2019, 6:16 PM
rtrieu committed rGc6c421379dd1: [WebAssembly] Create a TargetInfo header. NFC (authored by rtrieu).
[WebAssembly] Create a TargetInfo header. NFC
May 14 2019, 6:03 PM
rtrieu committed rL360735: [WebAssembly] Create a TargetInfo header. NFC.
[WebAssembly] Create a TargetInfo header. NFC
May 14 2019, 6:02 PM
rtrieu committed rG1e6f98b89dbe: [SystemZ] Create a TargetInfo header. NFC (authored by rtrieu).
[SystemZ] Create a TargetInfo header. NFC
May 14 2019, 5:46 PM
rtrieu committed rL360734: [SystemZ] Create a TargetInfo header. NFC.
[SystemZ] Create a TargetInfo header. NFC
May 14 2019, 5:45 PM
rtrieu committed rGcf82d4a483f8: [Sparc] Create a TargetInfo header. NFC (authored by rtrieu).
[Sparc] Create a TargetInfo header. NFC
May 14 2019, 5:35 PM
rtrieu committed rL360733: [Sparc] Create a TargetInfo header. NFC.
[Sparc] Create a TargetInfo header. NFC
May 14 2019, 5:35 PM
rtrieu committed rG51fc56d603b1: [RISCV] Create a TargetInfo header. NFC (authored by rtrieu).
[RISCV] Create a TargetInfo header. NFC
May 14 2019, 5:24 PM
rtrieu committed rL360732: [RISCV] Create a TargetInfo header. NFC.
[RISCV] Create a TargetInfo header. NFC
May 14 2019, 5:22 PM
rtrieu committed rGee6ced196dda: [PowerPC] Create a TargetInfo header. NFC (authored by rtrieu).
[PowerPC] Create a TargetInfo header. NFC
May 14 2019, 5:08 PM
rtrieu committed rL360731: [PowerPC] Create a TargetInfo header. NFC.
[PowerPC] Create a TargetInfo header. NFC
May 14 2019, 5:08 PM
rtrieu committed rGe8f83befd5bf: [NVPTX] Create a TargetInfo header. NFC (authored by rtrieu).
[NVPTX] Create a TargetInfo header. NFC
May 14 2019, 4:57 PM
rtrieu committed rL360729: [NVPTX] Create a TargetInfo header. NFC.
[NVPTX] Create a TargetInfo header. NFC
May 14 2019, 4:54 PM
rtrieu committed rGa57ce32effdc: [MSP430] Create a TargetInfo header. NFC (authored by rtrieu).
[MSP430] Create a TargetInfo header. NFC
May 14 2019, 4:45 PM
rtrieu committed rL360728: [MSP430] Create a TargetInfo header. NFC.
[MSP430] Create a TargetInfo header. NFC
May 14 2019, 4:45 PM
rtrieu committed rG313b78150cec: [Mips] Create a TargetInfo header. NFC (authored by rtrieu).
[Mips] Create a TargetInfo header. NFC
May 14 2019, 4:35 PM
rtrieu committed rL360727: [Mips] Create a TargetInfo header. NFC.
[Mips] Create a TargetInfo header. NFC
May 14 2019, 4:32 PM
rtrieu committed rG2e50dc78c5e2: [Lanai] Create a TargetInfo header. NFC (authored by rtrieu).
[Lanai] Create a TargetInfo header. NFC
May 14 2019, 4:16 PM
rtrieu committed rL360726: [Lanai] Create a TargetInfo header. NFC.
[Lanai] Create a TargetInfo header. NFC
May 14 2019, 4:15 PM
rtrieu committed rG7ef172998bfd: [Hexagon] Create a TargetInfo header. NFC (authored by rtrieu).
[Hexagon] Create a TargetInfo header. NFC
May 14 2019, 4:05 PM
rtrieu committed rL360724: [Hexagon] Create a TargetInfo header. NFC.
[Hexagon] Create a TargetInfo header. NFC
May 14 2019, 4:05 PM
rtrieu committed rGa68ee931e647: [BPF] Create a TargetInfo header. NFC (authored by rtrieu).
[BPF] Create a TargetInfo header. NFC
May 14 2019, 3:54 PM
rtrieu committed rL360722: [BPF] Create a TargetInfo header. NFC.
[BPF] Create a TargetInfo header. NFC
May 14 2019, 3:54 PM
rtrieu committed rGe982b42003cb: [AVR] Create a TargetInfo header. NFC (authored by rtrieu).
[AVR] Create a TargetInfo header. NFC
May 14 2019, 3:40 PM
rtrieu committed rL360721: [AVR] Create a TargetInfo header. NFC.
[AVR] Create a TargetInfo header. NFC
May 14 2019, 3:39 PM
rtrieu committed rGf3011b9b106b: [ARM] Create a TargetInfo header. NFC (authored by rtrieu).
[ARM] Create a TargetInfo header. NFC
May 14 2019, 3:28 PM
rtrieu committed rL360718: [ARM] Create a TargetInfo header. NFC.
[ARM] Create a TargetInfo header. NFC
May 14 2019, 3:27 PM
rtrieu committed rG7f9a008a2db2: [ARC] Create a TargetInfo header. NFC (authored by rtrieu).
[ARC] Create a TargetInfo header. NFC
May 14 2019, 3:07 PM
rtrieu committed rL360716: [ARC] Create a TargetInfo header. NFC.
[ARC] Create a TargetInfo header. NFC
May 14 2019, 3:03 PM
rtrieu committed rG8ce2ee9d5626: [AMDGPU] Create a TargetInfo header. NFC (authored by rtrieu).
[AMDGPU] Create a TargetInfo header. NFC
May 14 2019, 2:53 PM
rtrieu committed rL360713: [AMDGPU] Create a TargetInfo header. NFC.
[AMDGPU] Create a TargetInfo header. NFC
May 14 2019, 2:53 PM
rtrieu committed rGb26592e04d59: [AArch64] Create a TargetInfo header. NFC (authored by rtrieu).
[AArch64] Create a TargetInfo header. NFC
May 14 2019, 2:33 PM
rtrieu committed rL360709: [AArch64] Create a TargetInfo header. NFC.
[AArch64] Create a TargetInfo header. NFC
May 14 2019, 2:31 PM

May 10 2019

rtrieu committed rGd0124bd76244: [SystemZ] Move InstPrinter files to MCTargetDesc. NFC (authored by rtrieu).
[SystemZ] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 8:36 PM
rtrieu committed rL360510: [SystemZ] Move InstPrinter files to MCTargetDesc. NFC.
[SystemZ] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 8:34 PM
rtrieu committed rG03fe9d82c465: [Sparc] Move InstPrinter files to MCTargetDesc. NFC (authored by rtrieu).
[Sparc] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 7:58 PM
rtrieu committed rL360506: [Sparc] Move InstPrinter files to MCTargetDesc. NFC.
[Sparc] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 7:57 PM
rtrieu committed rG00ecf6704523: [RISCV] Move InstPrinter files to MCTargetDesc. NFC (authored by rtrieu).
[RISCV] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 7:46 PM
rtrieu committed rL360505: [RISCV] Move InstPrinter files to MCTargetDesc. NFC.
[RISCV] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 7:46 PM
rtrieu committed rG4bdb136b0f48: [PowerPC] Move InstPrinter files to MCTargetDesc. NFC (authored by rtrieu).
[PowerPC] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 7:32 PM
rtrieu committed rL360502: [PowerPC] Move InstPrinter files to MCTargetDesc. NFC.
[PowerPC] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 7:32 PM
rtrieu committed rG4b620fcf0f2d: [NVPTX] Move InstPrinter files to MCTargetDesc. NFC (authored by rtrieu).
[NVPTX] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 7:07 PM
rtrieu committed rL360500: [NVPTX] Move InstPrinter files to MCTargetDesc. NFC.
[NVPTX] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 7:07 PM
rtrieu committed rG61fb6700a569: [MSP430] Move InstPrinter files to MCTargetDesc. NFC (authored by rtrieu).
[MSP430] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 6:57 PM
rtrieu committed rL360498: [MSP430] Move InstPrinter files to MCTargetDesc. NFC.
[MSP430] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 6:56 PM
rtrieu committed rGfa29bee9d0c0: [Mips] Move InstPrinter files to MCTargetDesc. NFC (authored by rtrieu).
[Mips] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 6:39 PM
rtrieu committed rL360497: [Mips] Move InstPrinter files to MCTargetDesc. NFC.
[Mips] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 6:39 PM
rtrieu committed rG4c3890ddbf59: [Lanai] Move InstPrinter files to MCTargetDesc. NFC (authored by rtrieu).
[Lanai] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 6:27 PM
rtrieu committed rL360496: [Lanai] Move InstPrinter files to MCTargetDesc. NFC.
[Lanai] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 6:23 PM
rtrieu committed rG48803aa65c96: [BPF] Move InstPrinter files to MCTargetDesc. NFC (authored by rtrieu).
[BPF] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 6:13 PM
rtrieu committed rL360494: [BPF] Move InstPrinter files to MCTargetDesc. NFC.
[BPF] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 6:13 PM
rtrieu committed rGbf9e67b5b973: [AVR] Move InstPrinter files to MCTargetDesc. NFC (authored by rtrieu).
[AVR] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 6:01 PM
rtrieu committed rL360493: [AVR] Move InstPrinter files to MCTargetDesc. NFC.
[AVR] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 6:00 PM
rtrieu committed rG5e3ee4b84ef3: [ARM] Move InstPrinter files to MCTargetDesc. NFC (authored by rtrieu).
[ARM] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 5:32 PM
rtrieu committed rL360490: [ARM] Move InstPrinter files to MCTargetDesc. NFC.
[ARM] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 5:31 PM
rtrieu committed rGdcf1ea08e542: [ARC] Move InstPrinter files to MCTargetDesc. NFC (authored by rtrieu).
[ARC] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 5:13 PM
rtrieu committed rL360488: [ARC] Move InstPrinter files to MCTargetDesc. NFC.
[ARC] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 5:12 PM
rtrieu committed rGc0bd7bd48140: [AMDGPU] Move InstPrinter files to MCTargetDesc. NFC (authored by rtrieu).
[AMDGPU] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 5:02 PM
rtrieu committed rL360487: [AMDGPU] Move InstPrinter files to MCTargetDesc. NFC.
[AMDGPU] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 5:01 PM
rtrieu committed rG7ba060551199: [AArch64] Move InstPrinter files to MCTargetDesc. NFC (authored by rtrieu).
[AArch64] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 4:48 PM
rtrieu committed rL360486: [AArch64] Move InstPrinter files to MCTargetDesc. NFC.
[AArch64] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 4:47 PM
rtrieu committed rGf48ef2f2bacf: [XCore] Move InstPrinter files to MCTargetDesc. NFC (authored by rtrieu).
[XCore] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 4:37 PM
rtrieu committed rL360485: [XCore] Move InstPrinter files to MCTargetDesc. NFC.
[XCore] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 4:34 PM
rtrieu committed rGb28b8b7724ef: [X86] Move InstPrinter files to MCTargetDesc. NFC (authored by rtrieu).
[X86] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 4:25 PM
rtrieu committed rL360484: [X86] Move InstPrinter files to MCTargetDesc. NFC.
[X86] Move InstPrinter files to MCTargetDesc. NFC
May 10 2019, 4:25 PM

May 7 2019

rtrieu added a comment to D60169: Proposed refactoring for lib/Target/X86 to remove layering issue.

It seems that most people like the change of moving InstPrinter into MCTargetDesc better. If no one has any more comments, I'll start working on patches in that direction.

May 7 2019, 9:48 PM

May 3 2019

rtrieu committed rGcf9bd8ade753: Reduce amount of work ODR hashing does. (authored by rtrieu).
Reduce amount of work ODR hashing does.
May 3 2019, 9:21 PM
rtrieu committed rC359960: Reduce amount of work ODR hashing does..
Reduce amount of work ODR hashing does.
May 3 2019, 9:20 PM
rtrieu committed rL359960: Reduce amount of work ODR hashing does..
Reduce amount of work ODR hashing does.
May 3 2019, 9:20 PM

May 1 2019

rtrieu committed rG2efd30571bcc: Consume unexpected "template" keywords after "using" (authored by rtrieu).
Consume unexpected "template" keywords after "using"
May 1 2019, 4:32 PM
rtrieu committed rC359740: Consume unexpected "template" keywords after "using".
Consume unexpected "template" keywords after "using"
May 1 2019, 4:31 PM
rtrieu committed rL359740: Consume unexpected "template" keywords after "using".
Consume unexpected "template" keywords after "using"
May 1 2019, 4:31 PM

Apr 19 2019

rtrieu added a comment to D60169: Proposed refactoring for lib/Target/X86 to remove layering issue.
In D60169#1473057, @rnk wrote:

The change to merge them is quite large. I wonder if it would be simpler to handle this like we handle clang/Sema+Parse. Aren't those also circularly dependent?

Apr 19 2019, 3:40 PM

Apr 17 2019

rtrieu committed rG7b6192025e8f: Fix bad compare function over FusionCandidate. (authored by rtrieu).
Fix bad compare function over FusionCandidate.
Apr 17 2019, 6:38 PM
rtrieu committed rL358636: Fix bad compare function over FusionCandidate..
Fix bad compare function over FusionCandidate.
Apr 17 2019, 6:38 PM

Apr 12 2019

rtrieu added a comment to D60597: Fix lib/Target/* layering issues by merging InstPrinter into MCTargetDesc.

Phabricator is being too smart for its own good. The main discussion of this change was over on https://reviews.llvm.org/D60169 I was creating this as a separate diff so people can see different solutions to the problem.

Apr 12 2019, 2:57 PM

Apr 11 2019

rtrieu added a comment to D60169: Proposed refactoring for lib/Target/X86 to remove layering issue.

This is following Craig's suggestion to merge InstPrinter into MCTargetDesc, which Hexagon already does. Do people like this solution better?

Apr 11 2019, 8:35 PM