Page MenuHomePhabricator

[lldb][cmake] Also use local submodule visibility on Darwin
ClosedPublic

Authored by teemperor on Feb 20 2020, 4:22 AM.

Details

Summary

Currently building LLVM on macOS and on other platforms with LLVM_ENABLE_MODULES is using different module flags,
which means that a passing modules build on macOS might fail on Linux and vice versa. -fmodules-local-submodule-visibility
is the mode that has clearer semantics and is closer to the actual C++ module standard, so let's make this the default everywhere.

We can still test building without local submodule visibility on an additional bot by just changing the respective CMake flag. However,
if building without local-submodule-visibility breaks we won't revert other commits and we won't loose LLDB's/Clang's test run
information.

Diff Detail

Event Timeline

teemperor created this revision.Feb 20 2020, 4:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 20 2020, 4:22 AM
teemperor edited the summary of this revision. (Show Details)Feb 26 2020, 4:28 AM
teemperor added reviewers: aprantl, bruno, Bigcheese.
teemperor set the repository for this revision to rLLDB LLDB.
teemperor edited the summary of this revision. (Show Details)Feb 26 2020, 4:36 AM
This revision is now accepted and ready to land.Feb 26 2020, 2:54 PM

That's great progress! Is the idea to make local submodule visibility the default on Darwin at some point int the future?

This revision was automatically updated to reflect the committed changes.