[IR] Set name when inserting 'llvm::Value*'

[modocache]

Summary

I noticed a small regression in a toy project of mine after applying
D73835, in which instruction names weren't being set properly. In the
example test case included with this patch,
llvm::IRBuilderBase::CreateAdd returns an llvm::Value * that is then
passed as an argument to llvm::IRBuilderBase::Insert. The overloaded
function that is selected for that call then ignores the Name
parameter that is given. This patch addresses that issue.

[fhahn]

Looks like a straight-forward fix, thanks! LGTM. Please wait a bit until committing, in case there are additional comments.

llvm/unittests/IR/IRBuilderTest.cpp

934

Nit: variables should start with upper case? (https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly)

[nikic]

LGTM as well. Thanks for catching.

Probably didn't show up in any existing tests because it only happens with NoFolder, which we don't use often.

[modocache]

Thanks for the reviews! Good point about the variable casing, I changed it and am going to commit this shortly.

llvm/include/llvm/IR/IRBuilder.h

InstTy *Insert(InstTy *I, const Twine &Name = "") const {
     return I;
   }
 
   /// No-op overload to handle constants.
   Constant *Insert(Constant *C, const Twine& = "") const {
     return C;
   }
 
-  Value *Insert(Value *V, const Twine& = "") const {
+  Value *Insert(Value *V, const Twine &Name = "") const {
     if (Instruction *I = dyn_cast<Instruction>(V))
-      return Insert(I);
+      return Insert(I, Name);
     assert(isa<Constant>(V));
     return V;
   }
 
   //===--------------------------------------------------------------------===//
   // Builder configuration methods
   //===--------------------------------------------------------------------===//
 

llvm/unittests/IR/IRBuilderTest.cpp

TEST_F(IRBuilderTest, DIBuilderMacro) {
   EXPECT_EQ(MN1, MF1->getRawElements());
 
   Elements.clear();
   Elements.push_back(MDef2);
   auto MN2 = MDTuple::get(Ctx, Elements);
   EXPECT_EQ(MN2, MF2->getRawElements());
   EXPECT_TRUE(verifyModule(*M));
 }
+
+TEST_F(IRBuilderTest, NoFolderNames) {
+  IRBuilder<NoFolder> Builder(BB);
+  auto *Add =
+      Builder.CreateAdd(Builder.getInt32(1), Builder.getInt32(2), "add");
+  EXPECT_EQ(Add->getName(), "add");
+}
 }