This is an archive of the discontinued LLVM Phabricator instance.

Improve help text for (lldb) target symbols add
ClosedPublic

Authored by amccarth on Jan 28 2020, 3:22 PM.

Details

Summary

There were some missing words and awkward syntax. I think this is clearer.

Diff Detail

Event Timeline

amccarth created this revision.Jan 28 2020, 3:22 PM

Looks good, for the --shlib option I would get rid of the "full path or base name" language and just say "name", my two cents.

Looks good, for the --shlib option I would get rid of the "full path or base name" language and just say "name", my two cents.

I agree just "name" seems fine. Done.

This is low risk and it did get positive comments from one non-reviewer, so I'm going to land this.

This revision is now accepted and ready to land.Feb 3 2020, 1:55 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2020, 2:23 PM