This is an archive of the discontinued LLVM Phabricator instance.

Add test for spaceship operator to __config
ClosedPublic

Authored by davezarzycki on Jan 18 2020, 11:14 AM.

Download Raw Diff

Details

Reviewers

chandlerc
mclow.lists
EricWF
ldionne
CaseyCarter

Commits

rG39c349e8fc7f: Add test for spaceship operator to __config
rG5dda92fcb0ce: Add test for spaceship operator to __config

Summary

The libcxx test suite auto-detects spaceship operator, but __config does not. This means that the libcxx test suite has been broken for over a month when using top-of-tree clang. This also really ought to be fixed before 10.0.

See: bc633a42dd409dbeb456263e3388b8caa4680aa0

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

davezarzycki created this revision.Jan 18 2020, 11:14 AM

Herald added a reviewer: mclow.lists. · View Herald TranscriptJan 18 2020, 11:14 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added a subscriber: llvm-commits. · View Herald Transcript

davezarzycki added a subscriber: tstellar.Jan 18 2020, 11:19 AM

davezarzycki edited the summary of this revision. (Show Details)Jan 18 2020, 11:22 AM

davezarzycki edited the summary of this revision. (Show Details)Jan 18 2020, 11:48 AM

smeenai added reviewers: EricWF, ldionne.Jan 21 2020, 9:45 AM

Herald added a subscriber: dexonsmith. · View Herald TranscriptJan 21 2020, 9:45 AM

Ping. Feedback would be appreciated. Thanks

Eric, Marshall, what do you think?

I'm seeing these failures locally to, on the 10.x branch, and they also seem to be failing on the pre-submit bot, e.g. https://reviews.llvm.org/D73233#1836809

thakis mentioned this in D73351: [libcxx] Define _LIBCPP_HAS_NO_SPACESHIP_OPERATOR using feature test macro.Jan 24 2020, 7:16 AM

broadwaylamb added a subscriber: broadwaylamb.Jan 24 2020, 7:22 AM

I've also been experiencing these test failures and I'm very much interested in this getting landed.

(I've done this very change independently from you in D73351, so LGTM, but I am not a libc++ expert though.)

broadwaylamb added a reviewer: CaseyCarter.Jan 24 2020, 7:36 AM

LGTM.

This revision is now accepted and ready to land.Jan 24 2020, 10:22 AM

5dda92fcb0ce9206f831aa7cddf24421dcf044d7

Thanks! Cherry-picked to 10.x in 39c349e8fc7f4b334cf4b30724b28dfce44a024e
Please let me know if there are any follow-ups.

Revision Contents

Path

Size

		include/
	libcxx/	include/

__config

5 lines

Diff 238957

include/__config

	Show First 20 Lines • Show All 1,349 Lines • ▼ Show 20 Lines
	#if !__has_keyword(__is_aggregate) && (_GNUC_VER_NEW < 7001)			#if !__has_keyword(__is_aggregate) && (_GNUC_VER_NEW < 7001)
	#define _LIBCPP_HAS_NO_IS_AGGREGATE			#define _LIBCPP_HAS_NO_IS_AGGREGATE
	#endif			#endif

	#if !defined(__cpp_coroutines) \|\| __cpp_coroutines < 201703L			#if !defined(__cpp_coroutines) \|\| __cpp_coroutines < 201703L
	#define _LIBCPP_HAS_NO_COROUTINES			#define _LIBCPP_HAS_NO_COROUTINES
	#endif			#endif

	// FIXME: Correct this macro when either (A) a feature test macro for the			#if !defined(__cpp_impl_three_way_comparison) \|\| __cpp_impl_three_way_comparison < 201907L
	// spaceship operator is provided, or (B) a compiler provides a complete
	// implementation.
	#define _LIBCPP_HAS_NO_SPACESHIP_OPERATOR			#define _LIBCPP_HAS_NO_SPACESHIP_OPERATOR
				#endif

	// Decide whether to use availability macros.			// Decide whether to use availability macros.
	#if !defined(_LIBCPP_BUILDING_LIBRARY) && \			#if !defined(_LIBCPP_BUILDING_LIBRARY) && \
	!defined(_LIBCPP_DISABLE_AVAILABILITY) && \			!defined(_LIBCPP_DISABLE_AVAILABILITY) && \
	__has_feature(attribute_availability_with_strict) && \			__has_feature(attribute_availability_with_strict) && \
	__has_feature(attribute_availability_in_templates) && \			__has_feature(attribute_availability_in_templates) && \
	__has_extension(pragma_clang_attribute_external_declaration)			__has_extension(pragma_clang_attribute_external_declaration)
	# ifdef __APPLE__			# ifdef __APPLE__
	▲ Show 20 Lines • Show All 156 Lines • Show Last 20 Lines