Page MenuHomePhabricator

davezarzycki (David Zarzycki)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 28 2017, 11:01 AM (160 w, 6 d)

Recent Activity

Today

davezarzycki added a comment to D88123: Add the ability to write 'target stop-hooks' in Python.

Hi Jim, this change broke my Fedora 33 Linux (x86) box. Do you think we can get a quick fix or revert this?

Sun, Sep 27, 2:48 AM · Restricted Project

Wed, Sep 2

davezarzycki added a comment to D86497: [lldb] Add reproducer verifier.

And just to be clear, the source directory in my setup is in the home directory. My cron job / "bot" build just builds in /tmp.

Wed, Sep 2, 3:49 AM · Restricted Project, Restricted Project
davezarzycki added a comment to D86497: [lldb] Add reproducer verifier.

Line 18 fails: %lldb -x -b --replay %t.repro >> %t.txt 2>&1

error: reproducer replay failed:
warning: home directory '/home/dave' not in VFS
Wed, Sep 2, 3:43 AM · Restricted Project, Restricted Project

Tue, Sep 1

davezarzycki added a comment to D86497: [lldb] Add reproducer verifier.

Hello. I have an auto-bisecting multi-stage bot that has identified this change as breaking release (without assertions) testing on Fedora 33 x86-64. Can we get a quick fix or revert this change for now?

Tue, Sep 1, 2:31 AM · Restricted Project, Restricted Project

Aug 27 2020

davezarzycki added a comment to D86354: [ADT] Make Optional a literal type..

This seems to only allow empty optionals to be constexpr. Should the non-default constructor also be constexpr?

The reason I implemented the minimal thing was that I wasn't sure how far I should go. In a Swift PR, @davezarzycki raised the point about constexpr potentially leading to longer compile times even when not used for compile-time computation. I asked some folks internally at Apple and the response I got was along the lines of, "That's surprising... If that's actually the case, it should be reported as a Clang bug". I haven't been able to dedicate time to benchmarking the impact of constexpr on compile time... Since Optional is a currency type, I wasn't sure if people would object to more methods being marked constexpr. In principle, I don't see any reason for any method on Optional to not be constexpr.

That upstream thread doesn't look like it's talking about the impact of constexpr in non-constexpr contexts. Yes, making a variable constexpr when you don't need it to be can have negative compile time consequences - but in Clang I don't believe (again, can be bugs, but it doesn't sound like that swift thread is suggesting the existence of such bugs) a constexpr function called in a non-constexpr context is handled any differently than if it were a non-constexpr function. (GCC is different in this regard and does try to do constexpr things in non-constexpr contexts, though unclear how hard it tries before bailing out to the non-constexpr handling)

Aug 27 2020, 4:02 AM · Restricted Project

Aug 24 2020

davezarzycki added a comment to D84013: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347).

Not fighting with how lit, FileCheck, and shell input/output work would help here:

Aug 24 2020, 4:47 AM · Restricted Project
davezarzycki added a comment to D84013: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347).

I have an auto-bisecting cron job that has identified the "reland" as breaking the test suite on Fedora 32 (x86). Is there a quick fix or can we revert the reland?

Aug 24 2020, 3:52 AM · Restricted Project

Aug 20 2020

davezarzycki added a comment to D86120: [NFC][llvm] Make the constructors of `ElementCount` private..

Why were static "get" methods preferred over simply marking the constructor explicit? For example, if the constructor is marked explicit, then this is what users see:

Aug 20 2020, 2:53 AM · Restricted Project

Aug 18 2020

davezarzycki added inline comments to D82276: Make ninja smart console builds more pretty.
Aug 18 2020, 4:19 AM · Restricted Project

Aug 11 2020

davezarzycki committed rGef0c0844fef6: Add missing `-o -` to a recent test (authored by davezarzycki).
Add missing `-o -` to a recent test
Aug 11 2020, 3:00 AM

Jul 31 2020

davezarzycki added a comment to D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested.

Hello, I have a twice-daily auto-bisecting multi-stage cron job running on Fedora 32 (x86-64) that has identified this commit as failing my first stage test (release + no asserts). Is this expected? Can we get a quick fix or revert this?

Jul 31 2020, 2:16 AM · Restricted Project

Jul 22 2020

davezarzycki added a comment to D81728: [InstCombine] Add target-specific inst combining.

I have a multi-stage, auto-git-bisecting bot that has identifying this commit as the source of a regression on Fedora 32 (x86-64). This commit broke my first stage test (release, no asserts). Might a quick fix happen or do we need to revert this?

Jul 22 2020, 5:26 PM · Restricted Project, Restricted Project, Restricted Project

Jul 14 2020

GitHub <noreply@github.com> committed rG50f2644b8b61: Merge pull request #1337 from davezarzycki/read_only_source_fix (authored by davezarzycki).
Merge pull request #1337 from davezarzycki/read_only_source_fix
Jul 14 2020, 4:54 PM
davezarzycki committed rGb5e3cfa6995b: [testing] Cherry-pick part of c90d38e4b9bb84a53b65ce1c136e04df77bfd094 (authored by davezarzycki).
[testing] Cherry-pick part of c90d38e4b9bb84a53b65ce1c136e04df77bfd094
Jul 14 2020, 4:54 PM
GitHub <noreply@github.com> committed rGb0e15576aa12: Merge pull request #764 from davezarzycki/pr764 (authored by davezarzycki).
Merge pull request #764 from davezarzycki/pr764
Jul 14 2020, 4:22 PM
davezarzycki committed rG0ff636a6ec75: [Testing] Unbreak aarch64 tests that assume darwin (authored by davezarzycki).
[Testing] Unbreak aarch64 tests that assume darwin
Jul 14 2020, 4:22 PM

Jul 12 2020

davezarzycki added a comment to D82085: [TRE] allow TRE for non-capturing calls..

Hello. I have an auto-bisecting multi-stage bot that is failing on two after this change. Can we please revert this or commit a quick fix?

Jul 12 2020, 2:43 AM · Restricted Project, Restricted Project

Jul 4 2020

davezarzycki committed rGe56e96a26426: [libcxx testing] Remove ALLOW_RETRIES from another test (authored by davezarzycki).
[libcxx testing] Remove ALLOW_RETRIES from another test
Jul 4 2020, 7:32 AM
davezarzycki added a comment to D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr.

What compilers was this tested on? This seems to be failing on clang 10 (Fedora 32 x86-64). Can we revert this or commit a quick fix?

Jul 4 2020, 6:58 AM · Restricted Project

Jul 3 2020

davezarzycki committed rG8aff6891646a: [libcxx testing] Remove ALLOW_RETRIES from another test (authored by davezarzycki).
[libcxx testing] Remove ALLOW_RETRIES from another test
Jul 3 2020, 4:17 AM

Jun 27 2020

davezarzycki committed rGdab859d1bf25: Reland: [clang driver] Move default module cache from system temporary directory (authored by davezarzycki).
Reland: [clang driver] Move default module cache from system temporary directory
Jun 27 2020, 2:36 AM

Jun 26 2020

davezarzycki abandoned D82259: Deprecate error prone temporary directory APIs.

Now that my core concern is addressed (moving clang's default module cache out of /tmp), I don't have the time to push for this deprecation. Sorry.

Jun 26 2020, 8:10 AM · Restricted Project, Restricted Project, Restricted Project
davezarzycki committed rGbb26838ceffb: [clang driver] Move default module cache from system temporary directory (authored by davezarzycki).
[clang driver] Move default module cache from system temporary directory
Jun 26 2020, 4:52 AM
davezarzycki closed D82362: Move default module cache from system temporary directory.
Jun 26 2020, 4:52 AM · Restricted Project, Restricted Project

Jun 23 2020

davezarzycki added inline comments to D82362: Move default module cache from system temporary directory.
Jun 23 2020, 4:45 AM · Restricted Project, Restricted Project
davezarzycki committed rGf3f016dbaa0d: [libcxx tests] Clang is more strict now about coroutines (authored by davezarzycki).
[libcxx tests] Clang is more strict now about coroutines
Jun 23 2020, 4:13 AM
davezarzycki created D82362: Move default module cache from system temporary directory.
Jun 23 2020, 3:40 AM · Restricted Project, Restricted Project
davezarzycki updated the diff for D82259: Deprecate error prone temporary directory APIs.

Moved clang specific changes to: https://reviews.llvm.org/D82362

Jun 23 2020, 3:40 AM · Restricted Project, Restricted Project, Restricted Project

Jun 22 2020

davezarzycki updated the diff for D82259: Deprecate error prone temporary directory APIs.
  1. Respect Darwin and XDG cache directories.
  2. Drop atypical reverse DNS in the path.
  3. Make clang more robust if the default module path cannot be determined.
Jun 22 2020, 8:02 AM · Restricted Project, Restricted Project, Restricted Project
davezarzycki added a comment to D82259: Deprecate error prone temporary directory APIs.

Sure, we can honor XDG_CACHE_DIR. Maybe as a followup, somebody can wire up Darwin's cache directory (which is retrievable via a BSD specific confstr() API with _CS_DARWIN_USER_CACHE_DIR). I'm not sure about other platforms.

Jun 22 2020, 4:16 AM · Restricted Project, Restricted Project, Restricted Project
davezarzycki committed rG2a9c3eb9ec8e: Make ninja smart console builds more pretty (authored by davezarzycki).
Make ninja smart console builds more pretty
Jun 22 2020, 3:44 AM
davezarzycki closed D82276: Make ninja smart console builds more pretty.
Jun 22 2020, 3:43 AM · Restricted Project
davezarzycki added a comment to D82276: Make ninja smart console builds more pretty.

Unless I'm missing something, consolidating this logic into LLVM's CMakeLists.txt will break stand alone builds of sub-projects and external projects that depend on this logic.

Jun 22 2020, 3:43 AM · Restricted Project

Jun 21 2020

davezarzycki added a comment to D82276: Make ninja smart console builds more pretty.

“N/300” implies that you’re not building all of llvm, clang, etc otherwise thousands of files would build.

Jun 21 2020, 3:53 PM · Restricted Project
davezarzycki added a comment to D82276: Make ninja smart console builds more pretty.

Naive build output is one line per file (plus output).

Jun 21 2020, 2:18 PM · Restricted Project
davezarzycki created D82276: Make ninja smart console builds more pretty.
Jun 21 2020, 4:45 AM · Restricted Project

Jun 20 2020

davezarzycki created D82259: Deprecate error prone temporary directory APIs.
Jun 20 2020, 8:26 AM · Restricted Project, Restricted Project, Restricted Project

Jun 3 2020

davezarzycki committed rGe25f01be0c4c: [libcxx testing] Fix bot failure in my last commit (authored by davezarzycki).
[libcxx testing] Fix bot failure in my last commit
Jun 3 2020, 8:46 AM
davezarzycki committed rG6ce71d2dada6: [libcxx testing] Fix more bogus timeouts: condvarany/notify_all.pass.cpp (authored by davezarzycki).
[libcxx testing] Fix more bogus timeouts: condvarany/notify_all.pass.cpp
Jun 3 2020, 7:39 AM
davezarzycki committed rG579d6ed48cf9: [libcxx testing] Fix lingering bugs in notify_one.pass.cpp (authored by davezarzycki).
[libcxx testing] Fix lingering bugs in notify_one.pass.cpp
Jun 3 2020, 6:00 AM

May 30 2020

davezarzycki committed rG1c4238e7a00b: [libcxx testing] Stop using arbitrary timeouts in one test (authored by davezarzycki).
[libcxx testing] Stop using arbitrary timeouts in one test
May 30 2020, 3:10 AM

May 29 2020

davezarzycki added a comment to D80037: [libc++] Fix the LIBCXX_HAS_MERGED_TYPEINFO_NAMES_DEFAULT setting.

This change breaks building on Fedora 32 with clang-10 (as shipped by Fedora). Can we revert this or commit a quick fix?

May 29 2020, 8:39 AM · Restricted Project

May 18 2020

davezarzycki committed rGa675c1dee483: [libcxx testing] Remove ALLOW_RETRIES from lock_guard tests (authored by davezarzycki).
[libcxx testing] Remove ALLOW_RETRIES from lock_guard tests
May 18 2020, 4:48 AM

May 16 2020

davezarzycki committed rG3f66bb20174e: [libcxx testing] Remove ALLOW_RETRIES from last futures test (authored by davezarzycki).
[libcxx testing] Remove ALLOW_RETRIES from last futures test
May 16 2020, 4:21 AM

May 15 2020

davezarzycki abandoned D79673: Allow 32-bit pointer extensions to be used without -fms-extensions.

I'm going to abandon this change for now. The problem is that the MS extensions are not as pervasive through the language as I wanted. For example, I'd really like them to work on aggregate types. This would allow all of the pointers to said types to not need annotation, unlike the current MS model.

May 15 2020, 3:46 AM · Restricted Project

May 14 2020

davezarzycki committed rG1858953395d2: [libcxx testing] Remove ALLOW_RETRIES from two futures tests (authored by davezarzycki).
[libcxx testing] Remove ALLOW_RETRIES from two futures tests
May 14 2020, 3:43 AM

May 13 2020

davezarzycki committed rG1febe2898276: [libcxx testing] Remove ALLOW_RETRIES from wait_for futures test (authored by davezarzycki).
[libcxx testing] Remove ALLOW_RETRIES from wait_for futures test
May 13 2020, 4:16 AM

May 12 2020

davezarzycki committed rG9e32bf550d13: [libcxx testing] Remove ALLOW_RETRIES from sleep_for.pass.cpp (authored by davezarzycki).
[libcxx testing] Remove ALLOW_RETRIES from sleep_for.pass.cpp
May 12 2020, 4:16 AM

May 10 2020

davezarzycki committed rG4f4d6c81f8b7: [libcxx testing] Remove ALLOW_RETRIES from sleep_until.pass.cpp (authored by davezarzycki).
[libcxx testing] Remove ALLOW_RETRIES from sleep_until.pass.cpp
May 10 2020, 3:12 AM
davezarzycki added a comment to D66610: [libc++] ECMAScript IdentityEscape is ambiguous (2584).

I don't know of such a flag. My two stage setup actually installs the first stage and then uses the first stage to compile/test the second stage.

Fair enough. I'll try to set up a VM for testing (which I honestly should have done long ago) and install/test this weekend.

May 10 2020, 3:11 AM · Restricted Project

May 9 2020

davezarzycki added a comment to D66610: [libc++] ECMAScript IdentityEscape is ambiguous (2584).

@davezarzycki what's the configuration flag to get filecheck / lld to use the just-built libcxx? I thought it would be LLVM_ENABLE_LIBCXX but that doesn't appear to work.

May 9 2020, 5:33 PM · Restricted Project
davezarzycki added a comment to D79673: Allow 32-bit pointer extensions to be used without -fms-extensions.
In D79673#2028204, @rnk wrote:

Needs a test.

I believe these are only implemented for x86 in LLVM. What happens if you try to use this on non-x86? I wouldn't be surprised if we crash, but we should probably produce a proper error and test it.

May 9 2020, 9:01 AM · Restricted Project
davezarzycki committed rG4f4ce13944b8: [libcxx testing] Make three locking tests more reliable (authored by davezarzycki).
[libcxx testing] Make three locking tests more reliable
May 9 2020, 8:29 AM
davezarzycki closed D79406: [libcxx testing] Make three locking tests more reliable.

4f4ce13944b88bcd678e615d340c21ea1cf5d3ec

May 9 2020, 8:29 AM · Restricted Project
davezarzycki created D79673: Allow 32-bit pointer extensions to be used without -fms-extensions.
May 9 2020, 7:57 AM · Restricted Project

May 8 2020

davezarzycki added a comment to D79552: [YAMLVFSWriter][Tests][NFC] Add couple tests.

This is failing stage two testing on my Fedora 32 (x86-64) Linux box. Can we please revert this or commit a quick fix?

May 8 2020, 7:53 PM · Restricted Project
davezarzycki added a comment to D66610: [libc++] ECMAScript IdentityEscape is ambiguous (2584).
May 8 2020, 12:20 PM · Restricted Project
davezarzycki added a comment to D66610: [libc++] ECMAScript IdentityEscape is ambiguous (2584).

Great. Thanks. As a friendly reminder, you’ll need to configure the first stage to use libcxx and also have clang to prefer libcxx, otherwise lld will just use whatever CMake autodetects/decides.

May 8 2020, 9:37 AM · Restricted Project
davezarzycki added a comment to D66610: [libc++] ECMAScript IdentityEscape is ambiguous (2584).

Hello, git bisect of a private stage two builder identified this commit as breaking lld's test suite. Can we either revert this or commit a quick fix to the regular expressions in lld's test suite?

FAIL: lld :: ELF/vs-diagnostics-duplicate-split.s (63239 of 63760)
******************** TEST 'lld :: ELF/vs-diagnostics-duplicate-split.s' FAILED ********************
Script:
--
: 'RUN: at line 2';   /tmp/_update_lc/t/bin/llvm-mc -filetype=obj -triple=x86_64 /home/dave/s/lp/lld/test/ELF/vs-diagnostics-duplicate-split.s -o /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-duplicate-split.s.tmp.o
: 'RUN: at line 3';   not /tmp/_update_lc/t/bin/ld.lld --vs-diagnostics --shared /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-duplicate-split.s.tmp.o /tmp/_update_lc/t/tools/lld/test/ELF/Output/vs-diagnostics-duplicate-split.s.tmp.o -o /dev/null 2>&1 | /tmp/_update_lc/t/bin/FileCheck /home/dave/s/lp/lld/test/ELF/vs-diagnostics-duplicate-split.s
--
Exit Code: 1
May 8 2020, 6:56 AM · Restricted Project

May 7 2020

davezarzycki added a comment to D79406: [libcxx testing] Make three locking tests more reliable.

Hi @ldionne – I've looked a few more tests that use lit's ALLOW_RETRIES feature. I don't think this is a straightforward scenario. While the flawed assumptions are often the same, the fixes are not. Do you want 46 Phab requests? Personally speaking, this seems like one of those cases where the cost of code review discourages bug fixes. If I create decent enough commit messages, would you be open to post-commit review for these test fixes? After all, the tests are already buggy, and we can always revert back to the known buggy version that we have today.

May 7 2020, 5:37 AM · Restricted Project
davezarzycki abandoned D68075: Do not #error if no OS is #defined.
May 7 2020, 5:03 AM · Restricted Project, Restricted Project

May 6 2020

davezarzycki updated the diff for D79406: [libcxx testing] Make three locking tests more reliable.

Ran through git clang-format to fix formatting issues that predate these fixes.

May 6 2020, 5:52 AM · Restricted Project
davezarzycki updated the diff for D79406: [libcxx testing] Make three locking tests more reliable.

Fixed two more tests as an example of how to fix the other thread tests.

May 6 2020, 4:16 AM · Restricted Project
davezarzycki added a comment to D79406: [libcxx testing] Make three locking tests more reliable.

Hi @ldionne – Ya, it looks like a lot of those tests need fixing. The "tolerance" goal is within them is fundamentally flawed. These tests are not testing "real time" APIs where one can hopefully reason about precise timing. These APIs are best-effort APIs and on a slow and/or heavily loaded machine, best-effort can get really slow. I don't have the time to fix all of the tests but here is the gist of what needs fixing is twofold:

May 6 2020, 4:16 AM · Restricted Project

May 5 2020

davezarzycki updated the diff for D79406: [libcxx testing] Make three locking tests more reliable.

Ran the patch through clang-format and then manually fixed style problems that clang-format did not fix.

May 5 2020, 5:20 AM · Restricted Project
davezarzycki updated the summary of D79406: [libcxx testing] Make three locking tests more reliable.
May 5 2020, 5:20 AM · Restricted Project
davezarzycki created D79406: [libcxx testing] Make three locking tests more reliable.
May 5 2020, 4:48 AM · Restricted Project
davezarzycki resigned from D79328: lld: Let find_package(LLD) work.
May 5 2020, 4:48 AM

Apr 29 2020

davezarzycki committed rGe717e8744d37: [libclang] Shared libraries require PIC unless WIN32 (authored by davezarzycki).
[libclang] Shared libraries require PIC unless WIN32
Apr 29 2020, 8:33 AM

Apr 28 2020

davezarzycki committed rG8f24c4b72f3e: Revert: [libc++] Create a small DSL for defining Lit features and parameters (authored by davezarzycki).
Revert: [libc++] Create a small DSL for defining Lit features and parameters
Apr 28 2020, 5:19 AM
davezarzycki added a reverting change for rG6d58030c8c7d: [libc++] Create a small DSL for defining Lit features and parameters: rG8f24c4b72f3e: Revert: [libc++] Create a small DSL for defining Lit features and parameters.
Apr 28 2020, 5:19 AM
davezarzycki added a comment to D78381: [libc++] Create a small DSL for defining Lit features and parameters.

I'm going to go ahead and ship this now so I can see whether it breaks anything.

This breaks Fedora 32 (x86_64) building with the system clang/lld (version 10.0):

[0+1] Running all regression tests
llvm-lit: /home/dave/s/lp/libcxxabi/test/lit.cfg:64: note: Using configuration variant: libcxxabi
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:307: note: inferred use_system_cxx_lib as: None
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:333: note: inferred use_clang_verify as: True
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:342: note: enabling thread-safety annotations
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:487: note: inferred language dialect as: c++2a
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale fr_FR.UTF-8 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale ru_RU.UTF-8 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale zh_CN.UTF-8 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale fr_CA.ISO8859-1 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale cs_CZ.ISO8859-2 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:389: note: inferred long_tests as: True
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:153: note: Using compiler: /usr/bin/clang++
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:154: note: Using flags: ['-v']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:158: note: Using compile flags: ['-Werror=thread-safety', '-DLIBCXXABI_NO_TIMER', '-D_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS', '-funwind-tables', '-std=c++2a', '-nostdinc++', '-I/home/dave/s/lp/libcxx/include', '-I/home/dave/s/lp/libcxxabi/include', '-DSTDC_FORMAT_MACROS', '-DSTDC_LIMIT_MACROS', '-DSTDC_CONSTANT_MACROS', '-I/home/dave/s/lp/libcxx/test/support', '-ftemplate-depth=270']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:161: note: Using warnings: ['-Wall', '-Wextra', '-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER', '-Wuser-defined-warnings', '-Wshadow', '-Wno-unused-command-line-argument', '-Wno-attributes', '-Wno-pessimizing-move', '-Wno-c++11-extensions', '-Wno-user-defined-literals', '-Wno-noexcept-type', '-Wsign-compare', '-Wunused-variable', '-Wunused-parameter', '-Wunreachable-code', '-Wno-unused-local-typedef']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:162: note: Using link flags: ['-L/tmp/_update_lc/r/./lib64', '-Wl,-rpath,/tmp/_update_lc/r/./lib64', '-L/tmp/_update_lc/r/./lib64', '-Wl,-rpath,/tmp/_update_lc/r/./lib64', '-nodefaultlibs', '/tmp/_update_lc/r/./lib64/libc++.a', '/tmp/_update_lc/r/./lib64/libc++abi.a', '-lm', '-lgcc_s', '-lgcc', '-lpthread', '-lrt', '-lc', '-lgcc_s', '-lgcc']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:164: note: Using available_features: ['long_tests', 'fdelayed-template-parsing', 'libc++', 'c++2a', 'diagnose-if-support', 'has-fblocks', '-faligned-allocation', 'clang-10', 'clang', 'locale.en_US.UTF-8', 'linux', 'clang-10.0.0', '-fsized-deallocation', 'thread-safety', 'libcxxabi-has-system-unwinder', 'fcoroutines-ts', 'modules-support', 'clang-10.0']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:170: note: Adding environment variables: {}
llvm-lit: /home/dave/s/lp/libcxxabi/test/lit.cfg:77: note: Using the new libc++ testing format
llvm-lit: /home/dave/s/lp/libcxx/test/lit.cfg:49: note: Using configuration variant: libcxx
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:307: note: inferred use_system_cxx_lib as: None
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:333: note: inferred use_clang_verify as: True
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:342: note: enabling thread-safety annotations
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:487: note: inferred language dialect as: c++2a
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale fr_FR.UTF-8 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale ru_RU.UTF-8 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale zh_CN.UTF-8 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale fr_CA.ISO8859-1 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/target_info.py:84: warning: The locale cs_CZ.ISO8859-2 is not supported by your platform. Some tests will be unsupported.
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:389: note: inferred long_tests as: True
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:153: note: Using compiler: /usr/bin/clang++
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:154: note: Using flags: ['-v']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:158: note: Using compile flags: ['-Werror=thread-safety', '-std=c++2a', '-include', '/home/dave/s/lp/libcxx/test/support/nasty_macros.h', '-nostdinc++', '-I/home/dave/s/lp/libcxx/include', '-I/tmp/_update_lc/r/projects/libcxx/include/c++build', '-D
STDC_FORMAT_MACROS', '-DSTDC_LIMIT_MACROS', '-DSTDC_CONSTANT_MACROS', '-I/home/dave/s/lp/libcxx/test/support', '-ftemplate-depth=270']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:161: note: Using warnings: ['-Wall', '-Wextra', '-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER', '-Wuser-defined-warnings', '-Wshadow', '-Wno-unused-command-line-argument', '-Wno-attributes', '-Wno-pessimizing-move', '-Wno-c++11-extensions', '-Wno-user-defined-literals', '-Wno-noexcept-type', '-Wsign-compare', '-Wunused-variable', '-Wunused-parameter', '-Wunreachable-code', '-Wno-unused-local-typedef']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:162: note: Using link flags: ['-L/tmp/_update_lc/r/./lib64', '-Wl,-rpath,/tmp/_update_lc/r/./lib64', '-nodefaultlibs', '-lc++experimental', '/tmp/_update_lc/r/./lib64/libc++.a', '-lc++abi', '-lm', '-lgcc_s', '-lgcc', '-lpthread', '-lrt', '-lc', '-lgcc_s', '-lgcc']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:164: note: Using available_features: ['modules-support', 'clang-10.0', 'fdelayed-template-parsing', 'diagnose-if-support', 'has-fblocks', 'clang-10', 'libatomic', '-faligned-allocation', 'clang', 'locale.en_US.UTF-8', 'c++experimental', 'long_tests', 'libc++', 'c++2a', 'linux', 'clang-10.0.0', 'thread-safety', 'fcoroutines-ts', '-fsized-deallocation']
llvm-lit: /home/dave/s/lp/libcxx/utils/libcxx/test/config.py:170: note: Adding environment variables: {}
llvm-lit: /home/dave/s/lp/libcxx/test/lit.cfg:62: note: Using the new libc++ testing format
llvm-lit: /tmp/_update_lc/r/bin/../../../../home/dave/s/lp/llvm/utils/lit/lit/TestingConfig.py:100: fatal: unable to parse config file '/home/dave/s/lp/libcxx/test/libcxx/selftest/dsl/lit.local.cfg', traceback: Traceback (most recent call last):

File "/tmp/_update_lc/r/bin/../../../../home/dave/s/lp/llvm/utils/lit/lit/TestingConfig.py", line 89, in load_from_path
  exec(compile(data, path, 'exec'), cfg_globals, None)
File "/home/dave/s/lp/libcxx/test/libcxx/selftest/dsl/lit.local.cfg", line 13, in <module>
  escaped = [(k.replace('%{', '%{escaped_'), base64.b64encode(v)) for (k, v) in config.substitutions]
File "/home/dave/s/lp/libcxx/test/libcxx/selftest/dsl/lit.local.cfg", line 13, in <listcomp>
  escaped = [(k.replace('%{', '%{escaped_'), base64.b64encode(v)) for (k, v) in config.substitutions]
File "/usr/lib64/python3.8/base64.py", line 58, in b64encode
  encoded = binascii.b2a_base64(s, newline=False)

TypeError: a bytes-like object is required, not 'str'

FAILED: CMakeFiles/check-all

Just a note, this seems due to incompatibilities between python2 and python3. Python2 expects strings like given here while Python3 expects the bytes-like object.

Apr 28 2020, 5:19 AM · Restricted Project

Apr 27 2020

davezarzycki added a comment to D78381: [libc++] Create a small DSL for defining Lit features and parameters.

I'm going to go ahead and ship this now so I can see whether it breaks anything.

Apr 27 2020, 2:00 PM · Restricted Project
davezarzycki added a comment to D75068: libclang: Add static build support for Windows .

Rather than wholly reverting this, I committed a fix: 665471907a5c072c6653a38c35f35e5d54cef220

The problem is that "NOT LIBCLANG_BUILD_STATIC" does not imply PIC, so there is no point in trying to build the SHARED version. Please let me know if I somehow missed something. Thanks!

@thakis has a use case at https://reviews.llvm.org/D74907 building a SHARED libclang with LLVM_ENABLE_PIC set to OFF.

Would the variant if(LLVM_ENABLE_PIC OR (WIN32 AND NOT LIBCLANG_BUILD_STATIC)) work for the Fedora case?

Apr 27 2020, 4:15 AM · Restricted Project

Apr 26 2020

davezarzycki committed rG665471907a5c: [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC (authored by davezarzycki).
[CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC
Apr 26 2020, 4:46 AM
davezarzycki added a comment to D75068: libclang: Add static build support for Windows .

Rather than wholly reverting this, I committed a fix: 665471907a5c072c6653a38c35f35e5d54cef220

Apr 26 2020, 4:46 AM · Restricted Project

Apr 25 2020

davezarzycki added a comment to D75068: libclang: Add static build support for Windows .

This breaks building libclang on Fedora 32 with clang 10.0 and lld 10.0. Do you mind if I revert this tomorrow if a quick fix cannot be found? Here is the relevant diagnostics:

Apr 25 2020, 8:10 PM · Restricted Project

Apr 23 2020

davezarzycki accepted D78757: [libc++] Improve the detection of whether the blocks runtime is available.

LGTM

Apr 23 2020, 2:07 PM · Restricted Project

Apr 22 2020

davezarzycki committed rGb2f06bd20bde: [libc++ testing] Fix unused variable warning turned error (authored by davezarzycki).
[libc++ testing] Fix unused variable warning turned error
Apr 22 2020, 5:22 AM

Apr 16 2020

davezarzycki committed rG27e63d9b0eb7: Fix -Wdocumentation-html warning (authored by davezarzycki).
Fix -Wdocumentation-html warning
Apr 16 2020, 3:57 AM

Apr 15 2020

davezarzycki added a comment to D78059: [llvm][STLExtras] Add various type_trait utilities currently present in MLIR.

FYI – This is generating new warnings with top-of-tree clang. That being said, the warning itself might be faulty:

/usr/local/include/llvm/ADT/STLExtras.h:115:58: warning: HTML tag 'i' requires an end tag [-Wdocumentation-html]
///   * To access the type of an argument: Traits::arg_t<i>
                                                        ~^~
1 warning generated.
Apr 15 2020, 7:37 AM · Restricted Project

Apr 5 2020

davezarzycki committed rG168503773dc2: Revert "[libc++] Enable the new libc++ testing format by default" (authored by davezarzycki).
Revert "[libc++] Enable the new libc++ testing format by default"
Apr 5 2020, 4:47 AM
davezarzycki added a reverting change for rG1580c76c4a08: [libc++] Enable the new libc++ testing format by default: rG168503773dc2: Revert "[libc++] Enable the new libc++ testing format by default".
Apr 5 2020, 4:47 AM
davezarzycki committed rG2c88a485c711: [clang] Make libcxx test suite pass again after memcmp changes (authored by davezarzycki).
[clang] Make libcxx test suite pass again after memcmp changes
Apr 5 2020, 4:47 AM
davezarzycki committed rG74ab5d98d07f: Revert "Test had incorrect check for nonzero count" (authored by davezarzycki).
Revert "Test had incorrect check for nonzero count"
Apr 5 2020, 4:47 AM
davezarzycki added a reverting change for rG210f40fe9a30: Test had incorrect check for nonzero count: rG74ab5d98d07f: Revert "Test had incorrect check for nonzero count".
Apr 5 2020, 4:47 AM

Mar 29 2020

davezarzycki committed rG12f6b024f9f5: Revert "[libc++] NFC: Simplify substitutions by using lit recursive… (authored by davezarzycki).
Revert "[libc++] NFC: Simplify substitutions by using lit recursive…
Mar 29 2020, 6:12 PM
davezarzycki added a reverting change for rGcd7f9751c300: [libc++] NFC: Simplify substitutions by using lit recursive substitutions: rG12f6b024f9f5: Revert "[libc++] NFC: Simplify substitutions by using lit recursive….
Mar 29 2020, 6:12 PM

Feb 14 2020

davezarzycki abandoned D74298: Honor -finline-functions and -finline-hint-functions at -O0.

I'm abandoning this due to lack of time and the problem being more involved than I thought.

Feb 14 2020, 3:19 AM · Restricted Project

Feb 11 2020

davezarzycki committed rG11fb68abab95: [libc++] Unbreak test suite (CWG1423) (authored by davezarzycki).
[libc++] Unbreak test suite (CWG1423)
Feb 11 2020, 12:06 PM

Feb 9 2020

davezarzycki added a comment to D74298: Honor -finline-functions and -finline-hint-functions at -O0.

Hi @MaskRay – I was just looking at the source history. I didn't test the old way. As it turns out there isn't a regression, but just some unexplained code in the current clang option parsing. And the -disable-O0-optnone is a useful hint. Thanks! I've been hacking on clang and trying to get the normal inliner pass to run at -O0, but with no luck so far.

Feb 9 2020, 1:26 PM · Restricted Project
davezarzycki added a comment to D74298: Honor -finline-functions and -finline-hint-functions at -O0.

Hi @lebedev.ri – Before I add a small new test file, is there an existing one that you know of that would be good to extend?

Feb 9 2020, 9:50 AM · Restricted Project
davezarzycki created D74298: Honor -finline-functions and -finline-hint-functions at -O0.
Feb 9 2020, 9:19 AM · Restricted Project

Jan 31 2020

davezarzycki added a comment to rG01943a59f51d: Move verification of Sema::MaximumAlignment to a .cpp file.

Thanks!

Jan 31 2020, 3:13 AM

Jan 30 2020

davezarzycki added a comment to D69882: [libc++] [P0325] Implement to_array from LFTS with updates..

This breaks the test suite when built "Release" without assertions enabled (Fedora 31 on x86_64). Can we please revert this?
``
FAIL: libc++ :: std/con:q:qtainers/sequences/array/array.creation/to_array.fail.cpp (53333 of 61086)

  • TEST 'libc++ :: std/containers/sequences/array/array.creation/to_array.fail.cpp' FAILED ****

Command: ['/usr/bin/clang++', '-o', '/dev/null', '-x', 'c++', '/home/dave/s/lp/libcxx/test/std/containers/sequences/array/array.creation/to_array.fail.cpp', '-c', '-v', '-ftemplate-depth=270', '-fsyntax-only', '-Xclang', '-verify', '-Xclang', '-verify-ignore-unexpected=note', '-ferror-limit=1024', '-Werror=thread-safety', '-std=c++2a', '-include', '/home/dave/s/lp/libcxx/test/support/nasty_macros.h', '-nostdinc++', '-I/home/dave/s/lp/libcxx/include', '-I/tmp/_update_lc/r/projects/libcxx/include/c++build', '-DSTDC_FORMAT_MACROS', '-DSTDC_LIMIT_MACROS', '-D__STDC_CONSTANT_MACROS', '-I/home/dave/s/lp/libcxx/test/support', '-DLIBCXX_FILESYSTEM_STATIC_TEST_ROOT="/home/dave/s/lp/libcxx/test/std/input.output/filesystems/Inputs/static_test_env"', '-DLIBCXX_FILESYSTEM_DYNAMIC_TEST_ROOT="/tmp/_update_lc/r/projects/libcxx/test/filesystem/Output/dynamic_env"', '-DLIBCXX_FILESYSTEM_DYNAMIC_TEST_HELPER="/usr/bin/python /home/dave/s/lp/libcxx/test/support/filesystem_dynamic_test_helper.py"', '-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER', '-Wall', '-Wextra', '-Werror', '-Wuser-defined-warnings', '-Wshadow', '-Wno-unused-command-line-argument', '-Wno-attributes', '-Wno-pessimizing-move', '-Wno-c++11-extensions', '-Wno-user-defined-literals', '-Wno-noexcept-type', '-Wsign-compare', '-Wunused-variable', '-Wunused-parameter', '-Wunreachable-code', '-Wno-error=user-defined-warnings', '-c']
Exit Code: 1

Standard Error:

clang version 9.0.0 (Fedora 9.0.0-1.fc31)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-redhat-linux/9
Found candidate GCC installation: /usr/lib/gcc/x86_64-redhat-linux/9
Selected GCC installation: /usr/bin/../lib/gcc/x86_64-redhat-linux/9
Candidate multilib: .;@m64
Candidate multilib: 32;@m32
Selected multilib: .;@m64
"/usr/bin/clang-9" -cc1 -triple x86_64-unknown-linux-gnu -fsyntax-only -disable-free -disable-llvm-verifier -discard-value-names -main-file-name to_array.fail.cpp -mrelocation-model static -mthread-model posix -mdisable-fp-elim -fmath-errno -masm-verbose -mconstructor-aliases -munwind-tables -fuse-init-array -target-cpu x86-64 -dwarf-column-info -debugger-tuning=gdb -v -nostdinc++ -resource-dir /usr/lib64/clang/9.0.0 -include /home/dave/s/lp/libcxx/test/support/nasty_macros.h -I /home/dave/s/lp/libcxx/include -I /tmp/_update_lc/r/projects/libcxx/include/c++build -D STDC_FORMAT_MACROS -D STDC_LIMIT_MACROS -D __STDC_CONSTANT_MACROS -I /home/dave/s/lp/libcxx/test/support -D "LIBCXX_FILESYSTEM_STATIC_TEST_ROOT=\"/home/dave/s/lp/libcxx/test/std/input.output/filesystems/Inputs/static_test_env\"" -D "LIBCXX_FILESYSTEM_DYNAMIC_TEST_ROOT=\"/tmp/_update_lc/r/projects/libcxx/test/filesystem/Output/dynamic_env\"" -D "LIBCXX_FILESYSTEM_DYNAMIC_TEST_HELPER=\"/usr/bin/python /home/dave/s/lp/libcxx/test/support/filesystem_dynamic_test_helper.py\"" -D _LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -internal-isystem /usr/local/include -internal-isystem /usr/lib64/clang/9.0.0/include -internal-externc-isystem /include -internal-externc-isystem /usr/include -Werror=thread-safety -Wall -Wextra -Werror -Wuser-defined-warnings -Wshadow -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-error=user-defined-warnings -std=c++2a -fdeprecated-macro -fdebug-compilation-dir /tmp/_update_lc/r -ftemplate-depth 270 -ferror-limit 1024 -fmessage-length 0 -fno-implicit-modules -fobjc-runtime=gcc -fcxx-exceptions -fexceptions -fdiagnostics-show-option -verify -verify-ignore-unexpected=note -faddrsig -x c++ /home/dave/s/lp/libcxx/test/std/containers/sequences/array/array.creation/to_array.fail.cpp
clang -cc1 version 9.0.0 based upon LLVM 9.0.0 default target x86_64-unknown-linux-gnu
ignoring nonexistent directory "/include"
#include "..." search starts here:
#include <...> search starts here:
/home/dave/s/lp/libcxx/include
/tmp/_update_lc/r/projects/libcxx/include/c++build
/home/dave/s/lp/libcxx/test/support
/usr/local/include
/usr/lib64/clang/9.0.0/include
/usr/include
End of search list.
error: 'error' diagnostics expected but not seen:

File /home/dave/s/lp/libcxx/test/std/containers/sequences/array/array.creation/to_array.fail.cpp Line 20: here
File /home/dave/s/lp/libcxx/test/std/containers/sequences/array/array.creation/to_array.fail.cpp Line 25: here
File /home/dave/s/lp/libcxx/test/std/containers/sequences/array/array.creation/to_array.fail.cpp Line 30: here

error: 'error' diagnostics seen but not expected:

File /home/dave/s/lp/libcxx/include/array Line 499: static_assert failed due to requirement '!is_array_v<char [6]>' "[array.creation]/1: to_array does not accept multidimensional arrays."
File /home/dave/s/lp/libcxx/include/array Line 502: static_assert failed due to requirement 'is_constructible_v<char [6], char (&)[6]>' "[array.creation]/1: to_array requires copy constructible elements."
File /home/dave/s/lp/libcxx/include/array Line 487: cannot initialize an array element of type 'char' with an lvalue of type 'char [6]'
File /home/dave/s/lp/libcxx/include/array Line 487: cannot initialize an array element of type 'char' with an lvalue of type 'char [6]'
File /home/dave/s/lp/libcxx/include/array Line 487: cannot initialize an array element of type 'char' with an lvalue of type 'char [6]'
File /home/dave/s/lp/libcxx/include/array Line 487: suggest braces around initialization of subobject
File /home/dave/s/lp/libcxx/include/array Line 502: static_assert failed due to requirement 'is_constructible_v<MoveOnly, MoveOnly &>' "[array.creation]/1: to_array requires copy constructible elements."
File /home/dave/s/lp/libcxx/include/array Line 487: calling a private constructor of class 'MoveOnly'
File /home/dave/s/lp/libcxx/include/array Line 514: static_assert failed due to requirement 'is_move_constructible_v<const MoveOnly>' "[array.creation]/4: to_array requires move constructible elements."
Line 493: calling a private constructor of class 'MoveOnly'

13 errors generated.

Jan 30 2020, 6:05 PM · Restricted Project

Jan 24 2020

davezarzycki committed rG5dda92fcb0ce: Add test for spaceship operator to __config (authored by davezarzycki).
Add test for spaceship operator to __config
Jan 24 2020, 10:32 AM
davezarzycki closed D72980: Add test for spaceship operator to __config.

5dda92fcb0ce9206f831aa7cddf24421dcf044d7

Jan 24 2020, 10:31 AM · Restricted Project, Restricted Project
davezarzycki committed rG0d61cd25a692: Verify that clang's max alignment is <= LLVM's max alignment (authored by davezarzycki).
Verify that clang's max alignment is <= LLVM's max alignment
Jan 24 2020, 9:38 AM
davezarzycki closed D73363: Verify that clang's max alignment is <= LLVM's max alignment.
Jan 24 2020, 9:37 AM · Restricted Project, Restricted Project
davezarzycki created D73363: Verify that clang's max alignment is <= LLVM's max alignment.
Jan 24 2020, 9:00 AM · Restricted Project, Restricted Project