Page MenuHomePhabricator
People CaseyCarter

CaseyCarter (Casey Carter)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 24 2016, 4:53 PM (183 w, 1 d)

Recent Activity
View All

Tue, Jan 7

CaseyCarter resigned from D71994: SFINAE span default constructor on Extent == 0.

LGTM. (Resigning as reviewer rather than approving to avoid confusing the folks who are actually authorized to approve.)

Tue, Jan 7, 10:14 AM · Restricted Project
CaseyCarter requested changes to D71994: SFINAE span default constructor on Extent == 0.
Tue, Jan 7, 9:18 AM · Restricted Project

Nov 11 2019

CaseyCarter created D70099: [libcxx][test] Only call valarray::min and ::max on empty containers when testing libc++.
Nov 11 2019, 1:25 PM

Oct 23 2019

CaseyCarter committed rG689ce810598b: [libc++][NFC] Remove excess trailing newlines from most files (authored by CaseyCarter).
[libc++][NFC] Remove excess trailing newlines from most files
Oct 23 2019, 8:14 AM

Oct 22 2019

CaseyCarter resigned from D68952: Guard against possible overflow in span.subpan.

(I'm not sure how to withdraw my "Request Changes" without approving - I'm not an authorized approver for libc++ - so I'll "Resign as Reviewer" and see if my red X goes away.)

Oct 22 2019, 12:39 PM
CaseyCarter added inline comments to D68952: Guard against possible overflow in span.subpan.
Oct 22 2019, 12:39 PM

Oct 21 2019

CaseyCarter added inline comments to D67900: [libc++] Use builtin type traits whenever possible.
Oct 21 2019, 9:11 AM · Restricted Project

Oct 20 2019

CaseyCarter requested changes to D68952: Guard against possible overflow in span.subpan.
Oct 20 2019, 9:01 PM
CaseyCarter added inline comments to D67900: [libc++] Use builtin type traits whenever possible.
Oct 20 2019, 6:32 PM · Restricted Project

Oct 14 2019

CaseyCarter committed rG6f0768f64da3: [libc++][test] Use <version> to get config on MSVC (authored by CaseyCarter).
[libc++][test] Use <version> to get config on MSVC
Oct 14 2019, 5:28 PM
CaseyCarter committed rL374854: [libc++][test] Use <version> to get config on MSVC.
[libc++][test] Use <version> to get config on MSVC
Oct 14 2019, 5:28 PM
CaseyCarter committed rGfcad66f165a7: [libc++][test] Portability fix for std::any tests (authored by CaseyCarter).
[libc++][test] Portability fix for std::any tests
Oct 14 2019, 12:09 PM
CaseyCarter committed rL374806: [libc++][test] Portability fix for std::any tests.
[libc++][test] Portability fix for std::any tests
Oct 14 2019, 12:09 PM
CaseyCarter committed rGc86ba5818833: [libc++][test] Add license headers to test/support/archetypes.* (authored by CaseyCarter).
[libc++][test] Add license headers to test/support/archetypes.*
Oct 14 2019, 11:02 AM
CaseyCarter committed rL374797: [libc++][test] Add license headers to test/support/archetypes.*.
[libc++][test] Add license headers to test/support/archetypes.*
Oct 14 2019, 11:02 AM
CaseyCarter closed D68947: [libc++][test] Add license headers to test/support/archetypes.*.
Oct 14 2019, 11:02 AM · Restricted Project
CaseyCarter created D68947: [libc++][test] Add license headers to test/support/archetypes.*.
Oct 14 2019, 9:20 AM · Restricted Project
CaseyCarter committed rGa4f07b4d2e8d: [libc++][test] Silence more warnings in variant tests (authored by CaseyCarter).
[libc++][test] Silence more warnings in variant tests
Oct 14 2019, 7:38 AM
CaseyCarter committed rL374778: [libc++][test] Silence more warnings in variant tests.
[libc++][test] Silence more warnings in variant tests
Oct 14 2019, 7:38 AM

Oct 13 2019

CaseyCarter committed rG80e088e14171: [libc++][test] std::variant test cleanup (authored by CaseyCarter).
[libc++][test] std::variant test cleanup
Oct 13 2019, 9:52 AM
CaseyCarter committed rG1f92d8b5449f: [libc++][test] <=> now has a feature-test macro (authored by CaseyCarter).
[libc++][test] <=> now has a feature-test macro
Oct 13 2019, 9:51 AM
CaseyCarter committed rL374723: [libc++][test] std::variant test cleanup.
[libc++][test] std::variant test cleanup
Oct 13 2019, 9:51 AM
CaseyCarter committed rL374722: [libc++][test] <=> now has a feature-test macro.
[libc++][test] <=> now has a feature-test macro
Oct 13 2019, 9:51 AM

Oct 12 2019

CaseyCarter committed rGe198823b87b2: [libc++][test] Silence MSVC warning in std::optional test (authored by CaseyCarter).
[libc++][test] Silence MSVC warning in std::optional test
Oct 12 2019, 12:08 PM
CaseyCarter committed rL374684: [libc++][test] Silence MSVC warning in std::optional test.
[libc++][test] Silence MSVC warning in std::optional test
Oct 12 2019, 11:59 AM

Oct 10 2019

CaseyCarter committed rL374492: Request commit access for caseycarter.
Request commit access for caseycarter
Oct 10 2019, 6:08 PM
CaseyCarter committed rGffc83995de6d: [libc++][test] Change IsSmallObject's calculation for std::any's small object… (authored by CaseyCarter).
[libc++][test] Change IsSmallObject's calculation for std::any's small object…
Oct 10 2019, 11:13 AM
CaseyCarter closed D68756: [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer.
Oct 10 2019, 11:12 AM · Restricted Project
CaseyCarter committed rL374407: [libc++][test] Change IsSmallObject's calculation for std::any's small object….
[libc++][test] Change IsSmallObject's calculation for std::any's small object…
Oct 10 2019, 11:12 AM

Oct 9 2019

CaseyCarter added inline comments to D68756: [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer.
Oct 9 2019, 6:59 PM · Restricted Project
CaseyCarter created D68756: [libc++][test] Change IsSmallObject's calculation for std::any's small object buffer.
Oct 9 2019, 6:50 PM · Restricted Project
CaseyCarter added a comment to D68681: [libc++][test] Miscellaneous MSVC cleanups.
In D68681#1702194, @ldionne wrote:

You have commit access, right? If so, go ahead. Otherwise, LMK and I can commit this for you.

Oct 9 2019, 3:34 PM · Restricted Project
CaseyCarter committed rGb2e3c83b0d64: [libc++][test] Miscellaneous MSVC cleanups (authored by CaseyCarter).
[libc++][test] Miscellaneous MSVC cleanups
Oct 9 2019, 3:25 PM
CaseyCarter closed D68681: [libc++][test] Miscellaneous MSVC cleanups.
Oct 9 2019, 3:24 PM · Restricted Project
CaseyCarter committed rL374248: [libc++][test] Miscellaneous MSVC cleanups.
[libc++][test] Miscellaneous MSVC cleanups
Oct 9 2019, 3:24 PM
CaseyCarter updated the diff for D68681: [libc++][test] Miscellaneous MSVC cleanups.

Avoid rather than suppress truncation warnings in unordered_meow deduction guide tests.

Oct 9 2019, 10:18 AM · Restricted Project
CaseyCarter added inline comments to D68681: [libc++][test] Miscellaneous MSVC cleanups.
Oct 9 2019, 10:18 AM · Restricted Project

Oct 8 2019

CaseyCarter created D68681: [libc++][test] Miscellaneous MSVC cleanups.
Oct 8 2019, 7:00 PM · Restricted Project
CaseyCarter added inline comments to D61365: [libcxx] [test] Suppress float->int narrowing warning in vector range-construction test..
Oct 8 2019, 6:28 PM

May 7 2019

CaseyCarter added inline comments to D61365: [libcxx] [test] Suppress float->int narrowing warning in vector range-construction test..
May 7 2019, 12:03 AM

May 3 2019

CaseyCarter added inline comments to D61365: [libcxx] [test] Suppress float->int narrowing warning in vector range-construction test..
May 3 2019, 3:34 PM

May 2 2019

CaseyCarter committed rGb574e112177d: [libc++][test] Remove non-portable assumption that thread's constructor… (authored by CaseyCarter).
[libc++][test] Remove non-portable assumption that thread's constructor…
May 2 2019, 2:20 PM
CaseyCarter committed rL359827: [libc++][test] Remove non-portable assumption that thread's constructor….
[libc++][test] Remove non-portable assumption that thread's constructor…
May 2 2019, 2:20 PM
CaseyCarter committed rCXX359827: [libc++][test] Remove non-portable assumption that thread's constructor….
[libc++][test] Remove non-portable assumption that thread's constructor…
May 2 2019, 2:20 PM
CaseyCarter closed D50860: [libc++][test] Remove non-portable assumption that thread's constructor allocates with ::new.
May 2 2019, 2:19 PM

Apr 25 2019

CaseyCarter committed rG413732354d2a: [libc++][test] Fix noexcept assertions in variant's get tests (authored by CaseyCarter).
[libc++][test] Fix noexcept assertions in variant's get tests
Apr 25 2019, 11:35 AM
CaseyCarter committed rL359220: [libc++][test] Fix noexcept assertions in variant's get tests.
[libc++][test] Fix noexcept assertions in variant's get tests
Apr 25 2019, 11:34 AM
CaseyCarter committed rCXX359220: [libc++][test] Fix noexcept assertions in variant's get tests.
[libc++][test] Fix noexcept assertions in variant's get tests
Apr 25 2019, 11:34 AM
CaseyCarter closed D61033: [libc++][test] Fix noexcept assertions in variant's get tests.
Apr 25 2019, 11:34 AM

Apr 24 2019

CaseyCarter updated the diff for D61033: [libc++][test] Fix noexcept assertions in variant's get tests.

Fix pre-existing copy pasta in variant/get_type.pass.cpp.

Apr 24 2019, 10:19 AM
CaseyCarter updated the diff for D61033: [libc++][test] Fix noexcept assertions in variant's get tests.

Use Jonathan's fix, which additionally validates the existence of the bug.

Apr 24 2019, 10:13 AM

Apr 23 2019

CaseyCarter updated the diff for D61033: [libc++][test] Fix noexcept assertions in variant's get tests.

Update conditional: the bug was closed as a duplicate of a bug which has been fixed on master. Tag with the correct bug number, and disable the workaround for GCC 9.

Apr 23 2019, 1:46 PM
CaseyCarter created D61033: [libc++][test] Fix noexcept assertions in variant's get tests.
Apr 23 2019, 11:40 AM

Apr 22 2019

CaseyCarter committed rCXX358908: [libc++][test] Update some wstring_convert tests for MSVC quirks.
[libc++][test] Update some wstring_convert tests for MSVC quirks
Apr 22 2019, 12:07 PM
CaseyCarter committed rGe3f7074c7e95: [libc++][test] Update some wstring_convert tests for MSVC quirks (authored by CaseyCarter).
[libc++][test] Update some wstring_convert tests for MSVC quirks
Apr 22 2019, 12:07 PM
CaseyCarter committed rL358908: [libc++][test] Update some wstring_convert tests for MSVC quirks.
[libc++][test] Update some wstring_convert tests for MSVC quirks
Apr 22 2019, 12:06 PM
CaseyCarter closed D60950: [libc++][test] Update some wstring_convert tests for MSVC quirks.
Apr 22 2019, 12:06 PM · Restricted Project
CaseyCarter added a comment to D60950: [libc++][test] Update some wstring_convert tests for MSVC quirks.
In D60950#1474050, @mclow.lists wrote:

I think you failed to paste a bit into the description of this patch (after the first sentence, before the second).

Apr 22 2019, 6:39 AM · Restricted Project
CaseyCarter updated the summary of D60950: [libc++][test] Update some wstring_convert tests for MSVC quirks.
Apr 22 2019, 6:27 AM · Restricted Project

Apr 21 2019

CaseyCarter created D60951: [libc++][test] Add test coverage for codecvt<char(16|32)_t, char8_t, mbstate_t>.
Apr 21 2019, 10:56 AM
CaseyCarter created D60950: [libc++][test] Update some wstring_convert tests for MSVC quirks.
Apr 21 2019, 10:33 AM · Restricted Project
CaseyCarter added a comment to D50860: [libc++][test] Remove non-portable assumption that thread's constructor allocates with ::new.

Ping?

Apr 21 2019, 9:56 AM

Apr 19 2019

CaseyCarter committed rGc8eb2d0354a1: [libc++] [test] Silence C++20 deprecation warnings in the MSVC STL (authored by CaseyCarter).
[libc++] [test] Silence C++20 deprecation warnings in the MSVC STL
Apr 19 2019, 1:42 PM
CaseyCarter committed rCXX358782: [libc++] [test] Silence C++20 deprecation warnings in the MSVC STL.
[libc++] [test] Silence C++20 deprecation warnings in the MSVC STL
Apr 19 2019, 1:42 PM
CaseyCarter committed rL358782: [libc++] [test] Silence C++20 deprecation warnings in the MSVC STL.
[libc++] [test] Silence C++20 deprecation warnings in the MSVC STL
Apr 19 2019, 1:42 PM

Apr 1 2019

CaseyCarter resigned from D60023: [libcxx] [test] Fix test bugs in string.cons/copy_alloc.pass.cpp..
Apr 1 2019, 7:09 PM · Restricted Project
CaseyCarter requested changes to D60023: [libcxx] [test] Fix test bugs in string.cons/copy_alloc.pass.cpp..
Apr 1 2019, 5:53 PM · Restricted Project

Mar 27 2019

CaseyCarter requested changes to D46140: [coroutines] Add std::experimental::task<T> type.
Mar 27 2019, 11:02 AM
CaseyCarter committed rG132955fa66ec: Fix occurrences of _LIBCPP_ASSERT in span tests (authored by CaseyCarter).
Fix occurrences of _LIBCPP_ASSERT in span tests
Mar 27 2019, 10:03 AM
CaseyCarter committed rCXX357092: Fix occurrences of _LIBCPP_ASSERT in span tests.
Fix occurrences of _LIBCPP_ASSERT in span tests
Mar 27 2019, 10:03 AM
CaseyCarter committed rL357092: Fix occurrences of _LIBCPP_ASSERT in span tests.
Fix occurrences of _LIBCPP_ASSERT in span tests
Mar 27 2019, 10:03 AM

Jan 23 2019

CaseyCarter committed rL351991: [test] Define _LIBCPP_AVAILABILITY_THROW_BAD_ANY_CAST in….
[test] Define _LIBCPP_AVAILABILITY_THROW_BAD_ANY_CAST in…
Jan 23 2019, 2:49 PM
CaseyCarter committed rCXX351991: [test] Define _LIBCPP_AVAILABILITY_THROW_BAD_ANY_CAST in….
[test] Define _LIBCPP_AVAILABILITY_THROW_BAD_ANY_CAST in…
Jan 23 2019, 2:49 PM

Jan 14 2019

CaseyCarter closed D53763: [libc++] [test] Fix logic error in <compare> tests; enable for MSVC previews.

I merged this as r351148.

Jan 14 2019, 6:02 PM
CaseyCarter committed rCXX351148: [test] Fix logic error in <compare> tests; enable for MSVC Dev16.
[test] Fix logic error in <compare> tests; enable for MSVC Dev16
Jan 14 2019, 5:57 PM
CaseyCarter committed rL351148: [test] Fix logic error in <compare> tests; enable for MSVC Dev16.
[test] Fix logic error in <compare> tests; enable for MSVC Dev16
Jan 14 2019, 5:57 PM
CaseyCarter added a comment to D53763: [libc++] [test] Fix logic error in <compare> tests; enable for MSVC previews.
In D53763#1356356, @mclow.lists wrote:

I'm a bit concerned about the TEST_HAS_NO_SPACESHIP_OPERATOR and how it tracks with _LIBCPP_HAS_NO_SPACESHIP_OPERATOR, but I'm not going to hold this up for that.

Jan 14 2019, 10:25 AM

Oct 26 2018

CaseyCarter updated the diff for D50860: [libc++][test] Remove non-portable assumption that thread's constructor allocates with ::new.

Clarify use of numAllocs.

Oct 26 2018, 1:55 PM
CaseyCarter added a comment to D50860: [libc++][test] Remove non-portable assumption that thread's constructor allocates with ::new.

I'll put this explanation in the comments and push a change.

Oct 26 2018, 11:03 AM
CaseyCarter created D53763: [libc++] [test] Fix logic error in <compare> tests; enable for MSVC previews.
Oct 26 2018, 7:46 AM

Aug 16 2018

CaseyCarter created D50860: [libc++][test] Remove non-portable assumption that thread's constructor allocates with ::new.
Aug 16 2018, 11:38 AM

Jul 11 2018

CaseyCarter added inline comments to D49120: [libc++] P0898R3 2 of 12: Implement <concepts> header.
Jul 11 2018, 7:53 AM

Jul 10 2018

CaseyCarter added a comment to D49118: [libc++] P0898R3 1 of 12: changes to common_type; implement common_reference.
In D49118#1157438, @mclow.lists wrote:
I've conservatively hidden everything behind _LIBCPP_STD_VER > 17, although it could be made available in C++11 mode with some edits.

If we have a use for this in pre c++2a code, the libc++ convention would be to implement __common_reference that works most everywhere, and then have common_reference that only works > 17, but inherits from the ugly name.

That might be difficult in this case, because users can extend common_reference.

Jul 10 2018, 10:49 AM
CaseyCarter added a reviewer for D49118: [libc++] P0898R3 1 of 12: changes to common_type; implement common_reference: eric_niebler.
Jul 10 2018, 10:46 AM
CaseyCarter added a child revision for D49120: [libc++] P0898R3 2 of 12: Implement <concepts> header: D49122: [libc++] P0898R3 3 of 12: Tests for Same, DerivedFrom, ConvertibleTo, and CommonReference.
Jul 10 2018, 8:25 AM
CaseyCarter added a parent revision for D49122: [libc++] P0898R3 3 of 12: Tests for Same, DerivedFrom, ConvertibleTo, and CommonReference: D49120: [libc++] P0898R3 2 of 12: Implement <concepts> header.
Jul 10 2018, 8:25 AM
CaseyCarter added a parent revision for D49120: [libc++] P0898R3 2 of 12: Implement <concepts> header: D49118: [libc++] P0898R3 1 of 12: changes to common_type; implement common_reference.
Jul 10 2018, 8:25 AM
CaseyCarter added a child revision for D49118: [libc++] P0898R3 1 of 12: changes to common_type; implement common_reference: D49120: [libc++] P0898R3 2 of 12: Implement <concepts> header.
Jul 10 2018, 8:25 AM
CaseyCarter updated the diff for D49120: [libc++] P0898R3 2 of 12: Implement <concepts> header.

Qualify call to __invoke_constexpr in the definition of the Invocable concept.

Jul 10 2018, 6:45 AM

Jul 9 2018

CaseyCarter added inline comments to D49120: [libc++] P0898R3 2 of 12: Implement <concepts> header.
Jul 9 2018, 8:17 PM
CaseyCarter added inline comments to D49120: [libc++] P0898R3 2 of 12: Implement <concepts> header.
Jul 9 2018, 7:24 PM
CaseyCarter created D49122: [libc++] P0898R3 3 of 12: Tests for Same, DerivedFrom, ConvertibleTo, and CommonReference.
Jul 9 2018, 7:16 PM
CaseyCarter created D49120: [libc++] P0898R3 2 of 12: Implement <concepts> header.
Jul 9 2018, 7:12 PM
CaseyCarter created D49118: [libc++] P0898R3 1 of 12: changes to common_type; implement common_reference.
Jul 9 2018, 7:03 PM
CaseyCarter committed rCXX336618: [test] two small cleanups:.
[test] two small cleanups:
Jul 9 2018, 4:50 PM
CaseyCarter committed rL336618: [test] two small cleanups:.
[test] two small cleanups:
Jul 9 2018, 4:50 PM

Jul 7 2018

CaseyCarter committed rCXX336502: type_traits: aligned_union is NOT the same as __uncvref [NFC].
type_traits: aligned_union is NOT the same as __uncvref [NFC]
Jul 7 2018, 5:14 PM
CaseyCarter committed rL336502: type_traits: aligned_union is NOT the same as __uncvref [NFC].
type_traits: aligned_union is NOT the same as __uncvref [NFC]
Jul 7 2018, 5:11 PM

May 3 2018

CaseyCarter added a comment to D46140: [coroutines] Add std::experimental::task<T> type.
In D46140#1086987, @EricWF wrote:

Jeez, this is weird. Having other STL maintainers review additions to libc++ :-)

May 3 2018, 6:09 PM
CaseyCarter added inline comments to D46140: [coroutines] Add std::experimental::task<T> type.
May 3 2018, 7:01 AM