Page MenuHomePhabricator

CaseyCarter (Casey Carter)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 24 2016, 4:53 PM (164 w, 20 m)

Recent Activity

May 7 2019

CaseyCarter added inline comments to D61365: [libcxx] [test] Suppress float->int narrowing warning in vector range-construction test..
May 7 2019, 12:03 AM

May 3 2019

CaseyCarter added inline comments to D61365: [libcxx] [test] Suppress float->int narrowing warning in vector range-construction test..
May 3 2019, 3:34 PM

May 2 2019

CaseyCarter committed rGb574e112177d: [libc++][test] Remove non-portable assumption that thread's constructor… (authored by CaseyCarter).
[libc++][test] Remove non-portable assumption that thread's constructor…
May 2 2019, 2:20 PM
CaseyCarter committed rL359827: [libc++][test] Remove non-portable assumption that thread's constructor….
[libc++][test] Remove non-portable assumption that thread's constructor…
May 2 2019, 2:20 PM
CaseyCarter committed rCXX359827: [libc++][test] Remove non-portable assumption that thread's constructor….
[libc++][test] Remove non-portable assumption that thread's constructor…
May 2 2019, 2:20 PM
CaseyCarter closed D50860: [libc++][test] Remove non-portable assumption that thread's constructor allocates with ::new.
May 2 2019, 2:19 PM

Apr 25 2019

CaseyCarter committed rG413732354d2a: [libc++][test] Fix noexcept assertions in variant's get tests (authored by CaseyCarter).
[libc++][test] Fix noexcept assertions in variant's get tests
Apr 25 2019, 11:35 AM
CaseyCarter committed rL359220: [libc++][test] Fix noexcept assertions in variant's get tests.
[libc++][test] Fix noexcept assertions in variant's get tests
Apr 25 2019, 11:34 AM
CaseyCarter committed rCXX359220: [libc++][test] Fix noexcept assertions in variant's get tests.
[libc++][test] Fix noexcept assertions in variant's get tests
Apr 25 2019, 11:34 AM
CaseyCarter closed D61033: [libc++][test] Fix noexcept assertions in variant's get tests.
Apr 25 2019, 11:34 AM

Apr 24 2019

CaseyCarter updated the diff for D61033: [libc++][test] Fix noexcept assertions in variant's get tests.

Fix pre-existing copy pasta in variant/get_type.pass.cpp.

Apr 24 2019, 10:19 AM
CaseyCarter updated the diff for D61033: [libc++][test] Fix noexcept assertions in variant's get tests.

Use Jonathan's fix, which additionally validates the existence of the bug.

Apr 24 2019, 10:13 AM

Apr 23 2019

CaseyCarter updated the diff for D61033: [libc++][test] Fix noexcept assertions in variant's get tests.

Update conditional: the bug was closed as a duplicate of a bug which has been fixed on master. Tag with the correct bug number, and disable the workaround for GCC 9.

Apr 23 2019, 1:46 PM
CaseyCarter created D61033: [libc++][test] Fix noexcept assertions in variant's get tests.
Apr 23 2019, 11:40 AM

Apr 22 2019

CaseyCarter committed rCXX358908: [libc++][test] Update some wstring_convert tests for MSVC quirks.
[libc++][test] Update some wstring_convert tests for MSVC quirks
Apr 22 2019, 12:07 PM
CaseyCarter committed rGe3f7074c7e95: [libc++][test] Update some wstring_convert tests for MSVC quirks (authored by CaseyCarter).
[libc++][test] Update some wstring_convert tests for MSVC quirks
Apr 22 2019, 12:07 PM
CaseyCarter committed rL358908: [libc++][test] Update some wstring_convert tests for MSVC quirks.
[libc++][test] Update some wstring_convert tests for MSVC quirks
Apr 22 2019, 12:06 PM
CaseyCarter closed D60950: [libc++][test] Update some wstring_convert tests for MSVC quirks.
Apr 22 2019, 12:06 PM · Restricted Project
CaseyCarter added a comment to D60950: [libc++][test] Update some wstring_convert tests for MSVC quirks.

I think you failed to paste a bit into the description of this patch (after the first sentence, before the second).

Apr 22 2019, 6:39 AM · Restricted Project
CaseyCarter updated the summary of D60950: [libc++][test] Update some wstring_convert tests for MSVC quirks.
Apr 22 2019, 6:27 AM · Restricted Project

Apr 21 2019

CaseyCarter created D60951: [libc++][test] Add test coverage for codecvt<char(16|32)_t, char8_t, mbstate_t>.
Apr 21 2019, 10:56 AM
CaseyCarter created D60950: [libc++][test] Update some wstring_convert tests for MSVC quirks.
Apr 21 2019, 10:33 AM · Restricted Project
CaseyCarter added a comment to D50860: [libc++][test] Remove non-portable assumption that thread's constructor allocates with ::new.

Ping?

Apr 21 2019, 9:56 AM

Apr 19 2019

CaseyCarter committed rGc8eb2d0354a1: [libc++] [test] Silence C++20 deprecation warnings in the MSVC STL (authored by CaseyCarter).
[libc++] [test] Silence C++20 deprecation warnings in the MSVC STL
Apr 19 2019, 1:42 PM
CaseyCarter committed rCXX358782: [libc++] [test] Silence C++20 deprecation warnings in the MSVC STL.
[libc++] [test] Silence C++20 deprecation warnings in the MSVC STL
Apr 19 2019, 1:42 PM
CaseyCarter committed rL358782: [libc++] [test] Silence C++20 deprecation warnings in the MSVC STL.
[libc++] [test] Silence C++20 deprecation warnings in the MSVC STL
Apr 19 2019, 1:42 PM

Apr 1 2019

CaseyCarter resigned from D60023: [libcxx] [test] Fix test bugs in string.cons/copy_alloc.pass.cpp..
Apr 1 2019, 7:09 PM · Restricted Project
CaseyCarter requested changes to D60023: [libcxx] [test] Fix test bugs in string.cons/copy_alloc.pass.cpp..
Apr 1 2019, 5:53 PM · Restricted Project

Mar 27 2019

CaseyCarter requested changes to D46140: [coroutines] Add std::experimental::task<T> type.
Mar 27 2019, 11:02 AM
CaseyCarter committed rG132955fa66ec: Fix occurrences of _LIBCPP_ASSERT in span tests (authored by CaseyCarter).
Fix occurrences of _LIBCPP_ASSERT in span tests
Mar 27 2019, 10:03 AM
CaseyCarter committed rCXX357092: Fix occurrences of _LIBCPP_ASSERT in span tests.
Fix occurrences of _LIBCPP_ASSERT in span tests
Mar 27 2019, 10:03 AM
CaseyCarter committed rL357092: Fix occurrences of _LIBCPP_ASSERT in span tests.
Fix occurrences of _LIBCPP_ASSERT in span tests
Mar 27 2019, 10:03 AM

Jan 23 2019

CaseyCarter committed rL351991: [test] Define _LIBCPP_AVAILABILITY_THROW_BAD_ANY_CAST in….
[test] Define _LIBCPP_AVAILABILITY_THROW_BAD_ANY_CAST in…
Jan 23 2019, 2:49 PM
CaseyCarter committed rCXX351991: [test] Define _LIBCPP_AVAILABILITY_THROW_BAD_ANY_CAST in….
[test] Define _LIBCPP_AVAILABILITY_THROW_BAD_ANY_CAST in…
Jan 23 2019, 2:49 PM

Jan 14 2019

CaseyCarter closed D53763: [libc++] [test] Fix logic error in <compare> tests; enable for MSVC previews.

I merged this as r351148.

Jan 14 2019, 6:02 PM
CaseyCarter committed rCXX351148: [test] Fix logic error in <compare> tests; enable for MSVC Dev16.
[test] Fix logic error in <compare> tests; enable for MSVC Dev16
Jan 14 2019, 5:57 PM
CaseyCarter committed rL351148: [test] Fix logic error in <compare> tests; enable for MSVC Dev16.
[test] Fix logic error in <compare> tests; enable for MSVC Dev16
Jan 14 2019, 5:57 PM
CaseyCarter added a comment to D53763: [libc++] [test] Fix logic error in <compare> tests; enable for MSVC previews.

I'm a bit concerned about the TEST_HAS_NO_SPACESHIP_OPERATOR and how it tracks with _LIBCPP_HAS_NO_SPACESHIP_OPERATOR, but I'm not going to hold this up for that.

Jan 14 2019, 10:25 AM

Oct 26 2018

CaseyCarter updated the diff for D50860: [libc++][test] Remove non-portable assumption that thread's constructor allocates with ::new.

Clarify use of numAllocs.

Oct 26 2018, 1:55 PM
CaseyCarter added a comment to D50860: [libc++][test] Remove non-portable assumption that thread's constructor allocates with ::new.

I'll put this explanation in the comments and push a change.

Oct 26 2018, 11:03 AM
CaseyCarter created D53763: [libc++] [test] Fix logic error in <compare> tests; enable for MSVC previews.
Oct 26 2018, 7:46 AM

Aug 16 2018

CaseyCarter created D50860: [libc++][test] Remove non-portable assumption that thread's constructor allocates with ::new.
Aug 16 2018, 11:38 AM

Jul 11 2018

CaseyCarter added inline comments to D49120: [libc++] P0898R3 2 of 12: Implement <concepts> header.
Jul 11 2018, 7:53 AM

Jul 10 2018

CaseyCarter added a comment to D49118: [libc++] P0898R3 1 of 12: changes to common_type; implement common_reference.
I've conservatively hidden everything behind _LIBCPP_STD_VER > 17, although it could be made available in C++11 mode with some edits.

If we have a use for this in pre c++2a code, the libc++ convention would be to implement __common_reference that works most everywhere, and then have common_reference that only works > 17, but inherits from the ugly name.

That might be difficult in this case, because users can extend common_reference.

Jul 10 2018, 10:49 AM
CaseyCarter added a reviewer for D49118: [libc++] P0898R3 1 of 12: changes to common_type; implement common_reference: eric_niebler.
Jul 10 2018, 10:46 AM
CaseyCarter added a child revision for D49120: [libc++] P0898R3 2 of 12: Implement <concepts> header: D49122: [libc++] P0898R3 3 of 12: Tests for Same, DerivedFrom, ConvertibleTo, and CommonReference.
Jul 10 2018, 8:25 AM
CaseyCarter added a parent revision for D49122: [libc++] P0898R3 3 of 12: Tests for Same, DerivedFrom, ConvertibleTo, and CommonReference: D49120: [libc++] P0898R3 2 of 12: Implement <concepts> header.
Jul 10 2018, 8:25 AM
CaseyCarter added a parent revision for D49120: [libc++] P0898R3 2 of 12: Implement <concepts> header: D49118: [libc++] P0898R3 1 of 12: changes to common_type; implement common_reference.
Jul 10 2018, 8:25 AM
CaseyCarter added a child revision for D49118: [libc++] P0898R3 1 of 12: changes to common_type; implement common_reference: D49120: [libc++] P0898R3 2 of 12: Implement <concepts> header.
Jul 10 2018, 8:25 AM
CaseyCarter updated the diff for D49120: [libc++] P0898R3 2 of 12: Implement <concepts> header.

Qualify call to __invoke_constexpr in the definition of the Invocable concept.

Jul 10 2018, 6:45 AM

Jul 9 2018

CaseyCarter added inline comments to D49120: [libc++] P0898R3 2 of 12: Implement <concepts> header.
Jul 9 2018, 8:17 PM
CaseyCarter added inline comments to D49120: [libc++] P0898R3 2 of 12: Implement <concepts> header.
Jul 9 2018, 7:24 PM
CaseyCarter created D49122: [libc++] P0898R3 3 of 12: Tests for Same, DerivedFrom, ConvertibleTo, and CommonReference.
Jul 9 2018, 7:16 PM
CaseyCarter created D49120: [libc++] P0898R3 2 of 12: Implement <concepts> header.
Jul 9 2018, 7:12 PM
CaseyCarter created D49118: [libc++] P0898R3 1 of 12: changes to common_type; implement common_reference.
Jul 9 2018, 7:03 PM
CaseyCarter committed rCXX336618: [test] two small cleanups:.
[test] two small cleanups:
Jul 9 2018, 4:50 PM
CaseyCarter committed rL336618: [test] two small cleanups:.
[test] two small cleanups:
Jul 9 2018, 4:50 PM

Jul 7 2018

CaseyCarter committed rCXX336502: type_traits: aligned_union is NOT the same as __uncvref [NFC].
type_traits: aligned_union is NOT the same as __uncvref [NFC]
Jul 7 2018, 5:14 PM
CaseyCarter committed rL336502: type_traits: aligned_union is NOT the same as __uncvref [NFC].
type_traits: aligned_union is NOT the same as __uncvref [NFC]
Jul 7 2018, 5:11 PM

May 3 2018

CaseyCarter added a comment to D46140: [coroutines] Add std::experimental::task<T> type.

Jeez, this is weird. Having other STL maintainers review additions to libc++ :-)

May 3 2018, 6:09 PM
CaseyCarter added inline comments to D46140: [coroutines] Add std::experimental::task<T> type.
May 3 2018, 7:01 AM

May 2 2018

CaseyCarter added inline comments to D46140: [coroutines] Add std::experimental::task<T> type.
May 2 2018, 7:17 AM

May 1 2018

CaseyCarter added a comment to D46140: [coroutines] Add std::experimental::task<T> type.

I have posted an updated version of the code here: https://gist.github.com/lewissbaker/38ba1d8a13e4fb0906559b7aa1c413d3

I'm still trying to figure out how to get the updated revision into this review.
I'm not familiar with Phabricator and it seems to want to create a new revision (review?) when I click the 'Update diff' button.
Does the updated diff need to be relative to the previous diff?
Any tips as to what I'm doing wrong are appreciated :)

May 1 2018, 6:56 AM

Apr 26 2018

CaseyCarter added inline comments to D46140: [coroutines] Add std::experimental::task<T> type.
Apr 26 2018, 8:17 PM

Apr 9 2018

CaseyCarter committed rCXX329618: [test] [NFC] cleanup aligned_storage test.
[test] [NFC] cleanup aligned_storage test
Apr 9 2018, 1:45 PM
CaseyCarter committed rL329618: [test] [NFC] cleanup aligned_storage test.
[test] [NFC] cleanup aligned_storage test
Apr 9 2018, 1:45 PM

Apr 4 2018

CaseyCarter accepted D45121: [coroutines] Add noop_coroutine to <experimental/coroutine>.
Apr 4 2018, 10:47 AM
CaseyCarter updated subscribers of D45121: [coroutines] Add noop_coroutine to <experimental/coroutine>.
Apr 4 2018, 8:15 AM

Jan 5 2018

CaseyCarter added inline comments to D41748: [libcxx] [test] Fix Xxx_scan tests using nonstandard things and MSVC++ warnings.
Jan 5 2018, 6:32 PM

Jan 4 2018

CaseyCarter added inline comments to D41748: [libcxx] [test] Fix Xxx_scan tests using nonstandard things and MSVC++ warnings.
Jan 4 2018, 6:25 PM

Dec 12 2017

CaseyCarter committed rCXX320500: workaround PR 28385 in __find_exactly_one_checked.
workaround PR 28385 in __find_exactly_one_checked
Dec 12 2017, 9:24 AM
CaseyCarter committed rL320500: workaround PR 28385 in __find_exactly_one_checked.
workaround PR 28385 in __find_exactly_one_checked
Dec 12 2017, 9:23 AM
CaseyCarter closed D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked.
Dec 12 2017, 9:23 AM
CaseyCarter added a comment to D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked.

This new-and-improved workaround - thanks to @lichray - is unintrusive enough that I can't imagine it being unnacceptable to anyone. I'm going to go ahead and check this in.

Dec 12 2017, 9:19 AM
CaseyCarter updated the diff for D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked.

Better/simpler workaround from Zhihao.

Dec 12 2017, 9:05 AM

Dec 11 2017

CaseyCarter added a comment to D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked.

This unconditional workaround addresses Marshall's concerns about the naked version test.

Dec 11 2017, 11:41 AM
CaseyCarter updated the diff for D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked.

Make the workaround unconditional.

Dec 11 2017, 11:00 AM

Dec 10 2017

CaseyCarter added inline comments to D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked.
Dec 10 2017, 11:25 AM
CaseyCarter updated the diff for D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked.

Hide the ugly version test in <__config>, define a slightly-more-meaningful macro _LIBCPP_WORKAROUND_CLANG_28385.

Dec 10 2017, 11:25 AM
CaseyCarter added a comment to D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked.

Ah - that was the factor I was missing.
The tests pass for me with -std=c++2a, but fail for std=c++17

Casey's original post said they fail with 2a, and I'm *still* not seeing that.

Dec 10 2017, 11:23 AM
CaseyCarter added a comment to D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked.

These tests don't fail for me. (using a clang I built two days ago)

Dec 10 2017, 10:10 AM

Dec 9 2017

CaseyCarter updated the summary of D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked.
Dec 9 2017, 11:26 AM
CaseyCarter added a comment to D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked.

Test?

Dec 9 2017, 9:22 AM
CaseyCarter created D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked.
Dec 9 2017, 9:18 AM

Nov 15 2017

CaseyCarter committed rL318325: [test] Alignment must be > __STDCPP_DEFAULT_NEW_ALIGNMENT__ to call aligned new.
[test] Alignment must be > __STDCPP_DEFAULT_NEW_ALIGNMENT__ to call aligned new
Nov 15 2017, 11:15 AM
CaseyCarter closed D39221: [libcxx] [test] Alignment must be > __STDCPP_DEFAULT_NEW_ALIGNMENT__ to call aligned new by committing rL318325: [test] Alignment must be > __STDCPP_DEFAULT_NEW_ALIGNMENT__ to call aligned new.
Nov 15 2017, 11:15 AM

Oct 23 2017

CaseyCarter created D39221: [libcxx] [test] Alignment must be > __STDCPP_DEFAULT_NEW_ALIGNMENT__ to call aligned new.
Oct 23 2017, 6:45 PM

Sep 30 2017

CaseyCarter committed rL314608: [test] Allow other implementations to strengthen noexcept on deque's move….
[test] Allow other implementations to strengthen noexcept on deque's move…
Sep 30 2017, 4:17 PM

Sep 28 2017

CaseyCarter committed rL314459: [test] forwardlist.cons/move_noexcept.pass.cpp.
[test] forwardlist.cons/move_noexcept.pass.cpp
Sep 28 2017, 1:25 PM

Aug 31 2017

CaseyCarter committed rL312256: [test] Cleanup nullopt_t tests.
[test] Cleanup nullopt_t tests
Aug 31 2017, 10:57 AM
CaseyCarter closed D37024: [libcxx] [test] Cleanup nullopt_t tests by committing rL312256: [test] Cleanup nullopt_t tests.
Aug 31 2017, 10:57 AM

Aug 22 2017

CaseyCarter updated the diff for D37024: [libcxx] [test] Cleanup nullopt_t tests.

Don't unnecessarily fully qualify std::nullopt.

Aug 22 2017, 2:14 PM
CaseyCarter created D37024: [libcxx] [test] Cleanup nullopt_t tests.
Aug 22 2017, 2:04 PM

Jul 9 2017

CaseyCarter committed rL307505: optional: Implement LWG 2900 and P0602.
optional: Implement LWG 2900 and P0602
Jul 9 2017, 10:16 AM
CaseyCarter closed D32385: [libcxx] optional: Implement LWG 2900 and P0602 by committing rL307505: optional: Implement LWG 2900 and P0602.
Jul 9 2017, 10:16 AM

Jun 6 2017

CaseyCarter accepted D33955: [libcxx] [test] Remove a Clang/C2 workaround..

As the party who originally put this workaround in place, I'll happily certify that it never affected any platforms that anyone but we Microsofters care about. I'll take responsibility for any buildbot fallout - forward any nasty notices to me.

Jun 6 2017, 10:20 PM
CaseyCarter added a comment to D33965: Implement LWG 2904..

Looks good to me, although I am unfamiliar with your variant implementation. I won't approve the revision so that Eric will have to look at it, but consider me signed off.

Jun 6 2017, 5:21 PM
CaseyCarter closed D32671: [libcxx] [test] variant: test coverage for LWG2904 and P0602.
Jun 6 2017, 5:08 PM
CaseyCarter committed rL304847: [test] Test changes to accommodate LWG 2904 "Make variant move-assignment more….
[test] Test changes to accommodate LWG 2904 "Make variant move-assignment more…
Jun 6 2017, 5:06 PM
CaseyCarter updated the diff for D32385: [libcxx] optional: Implement LWG 2900 and P0602.

Incorporate the libcxx test tree special_member_gen test into the std test, making my per-SMF triviality tests unnecessary.

Jun 6 2017, 3:01 PM