Page MenuHomePhabricator
People CaseyCarter

CaseyCarter (Casey Carter)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 24 2016, 4:53 PM (347 w, 4 d)

Recent Activity
View All

Sat, Feb 25

CaseyCarter added a comment to D144775: [libc++][test] Add '-Wdeprecated-copy', '-Wdeprecated-copy-dtor' warnings to the test suite.

Guess I'll stop working on this ;)

Sat, Feb 25, 7:43 PM · Restricted Project, Restricted Project

Fri, Feb 24

CaseyCarter committed rG7d5275e0c0e4: [libc++][test] Silence MSVC deprecation warnings (authored by CaseyCarter).
[libc++][test] Silence MSVC deprecation warnings
Fri, Feb 24, 9:14 PM · Restricted Project, Restricted Project
CaseyCarter closed D144694: [libc++][test] Silence MSVC deprecation warnings.
Fri, Feb 24, 9:14 PM · Restricted Project, Restricted Project

Thu, Feb 23

CaseyCarter requested review of D144694: [libc++][test] Silence MSVC deprecation warnings.
Thu, Feb 23, 6:50 PM · Restricted Project, Restricted Project

Jan 11 2023

CaseyCarter committed rG0d91b0505214: [libc++][test] cleanup in formatter.h (authored by CaseyCarter).
[libc++][test] cleanup in formatter.h
Jan 11 2023, 12:57 PM · Restricted Project, Restricted Project
CaseyCarter closed D141453: [libc++][test] cleanup in formatter.h.
Jan 11 2023, 12:57 PM · Restricted Project, Restricted Project

Jan 10 2023

CaseyCarter requested review of D141453: [libc++][test] cleanup in formatter.h.
Jan 10 2023, 5:49 PM · Restricted Project, Restricted Project
CaseyCarter added a comment to D141334: [libc++][test] Silence allocator conversion warnings.
In D141334#4040566, @ldionne wrote:

CI issues seem unrelated. Just curious -- how did you catch that? Is there anything we can/should add to our implementation?

Jan 10 2023, 11:30 AM · Restricted Project, Restricted Project
CaseyCarter committed rG886e92c1abf1: [libc++][test] Silence allocator conversion warnings (authored by CaseyCarter).
[libc++][test] Silence allocator conversion warnings
Jan 10 2023, 11:21 AM · Restricted Project, Restricted Project
CaseyCarter closed D141334: [libc++][test] Silence allocator conversion warnings.
Jan 10 2023, 11:21 AM · Restricted Project, Restricted Project

Jan 9 2023

CaseyCarter committed rG915f2f16fbb7: [libc++][test] Avoid MSVC constexpr bug (authored by CaseyCarter).
[libc++][test] Avoid MSVC constexpr bug
Jan 9 2023, 5:48 PM · Restricted Project, Restricted Project
CaseyCarter closed D141336: [libc++][test] Avoid MSVC constexpr bug.
Jan 9 2023, 5:48 PM · Restricted Project, Restricted Project
CaseyCarter requested review of D141336: [libc++][test] Avoid MSVC constexpr bug.
Jan 9 2023, 5:17 PM · Restricted Project, Restricted Project
CaseyCarter requested review of D141334: [libc++][test] Silence allocator conversion warnings.
Jan 9 2023, 4:57 PM · Restricted Project, Restricted Project
CaseyCarter committed rG275ff33abf22: [libc++][test] _VSTD => std:: in test code (authored by CaseyCarter).
[libc++][test] _VSTD => std:: in test code
Jan 9 2023, 3:10 PM · Restricted Project, Restricted Project
CaseyCarter closed D141269: [libc++][test] _VSTD => std:: in test code.
Jan 9 2023, 3:09 PM · Restricted Project, Restricted Project
CaseyCarter committed rG96f1cd2427e4: [libc++][test] Silence MSVC warning (authored by CaseyCarter).
[libc++][test] Silence MSVC warning
Jan 9 2023, 3:06 PM · Restricted Project, Restricted Project
CaseyCarter closed D141263: [libc++][test] Silence MSVC warning.
Jan 9 2023, 3:05 PM · Restricted Project, Restricted Project
CaseyCarter added inline comments to D141263: [libc++][test] Silence MSVC warning.
Jan 9 2023, 3:04 PM · Restricted Project, Restricted Project
CaseyCarter committed rG6b90f6745ac7: [libc++][test] Make some string tests MSVC-friendly (authored by CaseyCarter).
[libc++][test] Make some string tests MSVC-friendly
Jan 9 2023, 3:00 PM · Restricted Project, Restricted Project
CaseyCarter closed D141253: [libc++][test] Make some string tests MSVC-friendly.
Jan 9 2023, 3:00 PM · Restricted Project, Restricted Project
CaseyCarter added inline comments to D141253: [libc++][test] Make some string tests MSVC-friendly.
Jan 9 2023, 2:59 PM · Restricted Project, Restricted Project
CaseyCarter requested review of D141269: [libc++][test] _VSTD => std:: in test code.
Jan 9 2023, 2:40 AM · Restricted Project, Restricted Project
CaseyCarter requested review of D141263: [libc++][test] Silence MSVC warning.
Jan 9 2023, 1:36 AM · Restricted Project, Restricted Project

Jan 8 2023

CaseyCarter updated the diff for D141004: [libc++][test] Port memory_resource tests to MSVCSTL.

Review comments.

Jan 8 2023, 11:35 PM · Restricted Project, Restricted Project
CaseyCarter added inline comments to D141004: [libc++][test] Port memory_resource tests to MSVCSTL.
Jan 8 2023, 11:34 PM · Restricted Project, Restricted Project
CaseyCarter requested review of D141253: [libc++][test] Make some string tests MSVC-friendly.
Jan 8 2023, 10:01 PM · Restricted Project, Restricted Project
CaseyCarter committed rGad41d1e26b12: [libc++][test] zip_view test cleanups (authored by CaseyCarter).
[libc++][test] zip_view test cleanups
Jan 8 2023, 3:34 PM · Restricted Project, Restricted Project
CaseyCarter closed D141216: [libc++][test] zip_view test cleanups.
Jan 8 2023, 3:34 PM · Restricted Project, Restricted Project
CaseyCarter requested review of D141216: [libc++][test] zip_view test cleanups.
Jan 8 2023, 3:09 PM · Restricted Project, Restricted Project
CaseyCarter updated the diff for D141216: [libc++][test] zip_view test cleanups.

Change return type of common_input_iterator::operator* to decltype(auto).

Jan 8 2023, 3:05 PM · Restricted Project, Restricted Project
CaseyCarter planned changes to D141216: [libc++][test] zip_view test cleanups.
Jan 8 2023, 3:02 PM · Restricted Project, Restricted Project
CaseyCarter updated the diff for D141216: [libc++][test] zip_view test cleanups.

Deal with differences due to P2165R4.

Jan 8 2023, 1:04 AM · Restricted Project, Restricted Project
CaseyCarter updated the diff for D141216: [libc++][test] zip_view test cleanups.

Add another fix.

Jan 8 2023, 12:00 AM · Restricted Project, Restricted Project

Jan 7 2023

CaseyCarter requested review of D141216: [libc++][test] zip_view test cleanups.
Jan 7 2023, 11:12 PM · Restricted Project, Restricted Project

Jan 6 2023

CaseyCarter committed rG1758a6e23bbc: [libc++][test][NFC] revert indentation damage (authored by CaseyCarter).
[libc++][test][NFC] revert indentation damage
Jan 6 2023, 8:10 PM · Restricted Project, Restricted Project
CaseyCarter closed D141157: [libc++][test][NFC] revert indentation damage.
Jan 6 2023, 8:10 PM · Restricted Project, Restricted Project
CaseyCarter added a comment to D131079: [libcxx][test] fix allocator in allocator_propagation test.
In D131079#4027290, @philnik wrote:

Please don't land unreviewed libc++ patches. If you need to land it for some reason, please ping instead of just committing.

Jan 6 2023, 1:31 PM · Restricted Project, Restricted Project
CaseyCarter requested review of D141157: [libc++][test][NFC] revert indentation damage.
Jan 6 2023, 1:29 PM · Restricted Project, Restricted Project
CaseyCarter committed rGd3933a5d75c6: [libc++][test] Add missing include (authored by CaseyCarter).
[libc++][test] Add missing include
Jan 6 2023, 11:35 AM · Restricted Project, Restricted Project
CaseyCarter removed a reviewer for D141004: [libc++][test] Port memory_resource tests to MSVCSTL: • arthur.j.odwyer.
Jan 6 2023, 10:07 AM · Restricted Project, Restricted Project
CaseyCarter closed D141108: [libc++][test] Suppress MSVC warnings in std::expected tests.

Merged as bdf7da280f624c53e6184d0410041220a9b405a7 (*sigh* someday I'll learn the right magic words to autoclose.)

Jan 6 2023, 10:05 AM · Restricted Project, Restricted Project
CaseyCarter committed rGbdf7da280f62: [libc++][test] Suppress MSVC warnings in std::expected tests (authored by CaseyCarter).
[libc++][test] Suppress MSVC warnings in std::expected tests
Jan 6 2023, 10:03 AM · Restricted Project, Restricted Project

Jan 5 2023

CaseyCarter updated the diff for D141108: [libc++][test] Suppress MSVC warnings in std::expected tests.
Jan 5 2023, 11:27 PM · Restricted Project, Restricted Project
CaseyCarter requested review of D141108: [libc++][test] Suppress MSVC warnings in std::expected tests.
Jan 5 2023, 10:05 PM · Restricted Project, Restricted Project

Jan 4 2023

CaseyCarter committed rGd65e66abb3bd: [libcxx][test] fix allocator in allocator_propagation test (authored by CaseyCarter).
[libcxx][test] fix allocator in allocator_propagation test
Jan 4 2023, 3:35 PM · Restricted Project, Restricted Project
CaseyCarter closed D131079: [libcxx][test] fix allocator in allocator_propagation test.
Jan 4 2023, 3:34 PM · Restricted Project, Restricted Project
CaseyCarter requested review of D141004: [libc++][test] Port memory_resource tests to MSVCSTL.
Jan 4 2023, 11:11 AM · Restricted Project, Restricted Project

Aug 3 2022

CaseyCarter requested review of D131079: [libcxx][test] fix allocator in allocator_propagation test.
Aug 3 2022, 9:46 AM · Restricted Project, Restricted Project
CaseyCarter committed rG3a45677467c1: [libcxx][test] Silence narrowing warning (authored by CaseyCarter).
[libcxx][test] Silence narrowing warning
Aug 3 2022, 9:11 AM · Restricted Project, Restricted Project

Aug 2 2022

CaseyCarter committed rGa1a30dc933b9: [libcxx][test] Test code should inspect `TEST_STD_VER`, not `_LIBCPP_STD_VER`. (authored by CaseyCarter).
[libcxx][test] Test code should inspect `TEST_STD_VER`, not `_LIBCPP_STD_VER`.
Aug 2 2022, 12:07 PM · Restricted Project, Restricted Project

Jun 25 2022

CaseyCarter committed rGc5ba46ea1804: [libcxx][test] MaybePOCCAAllocator should meet the Cpp17Allocator requirements (authored by CaseyCarter).
[libcxx][test] MaybePOCCAAllocator should meet the Cpp17Allocator requirements
Jun 25 2022, 11:04 AM · Restricted Project, Restricted Project
CaseyCarter closed D118279: [libcxx][test] MaybePOCCAAllocator should meet the Cpp17Allocator requirements.
Jun 25 2022, 11:04 AM · Restricted Project, Restricted Project

Jun 24 2022

CaseyCarter committed rGd3cbcc4e8990: [libcxx][test] barrier completion functions must be non-throwing (authored by CaseyCarter).
[libcxx][test] barrier completion functions must be non-throwing
Jun 24 2022, 9:07 AM · Restricted Project, Restricted Project

Jun 23 2022

CaseyCarter committed rG9aaba9d9bb4f: [libcxx][test] Suppress complex<int> warnings when testing MSVC (authored by CaseyCarter).
[libcxx][test] Suppress complex<int> warnings when testing MSVC
Jun 23 2022, 5:47 PM · Restricted Project, Restricted Project

Jun 22 2022

CaseyCarter committed rGaa5492e7b218: [GlobalISel][TableGen] Qualify calls to llvm::format that have ::std:: types as… (authored by barcharcraz).
[GlobalISel][TableGen] Qualify calls to llvm::format that have ::std:: types as…
Jun 22 2022, 9:38 PM · Restricted Project, Restricted Project
CaseyCarter closed D119213: [GlobalISel][TableGen] Fully qualify calls to llvm::format that have ::std:: types as paramters.
Jun 22 2022, 9:37 PM · Restricted Project, Restricted Project

Jun 6 2022

CaseyCarter closed D118069: [libcxx][test] Use bool allocators for vector<bool>::get_allocator test.

I landed this months ago, but failed to autolink the Differential to the commit. This is officially closed by 93230ac1d2cf32419ce88fdd850f92a02bec5553.

Jun 6 2022, 2:32 PM · Restricted Project, Restricted Project

Mar 23 2022

CaseyCarter added inline comments to D122072: [libc++][test] Adds an cpp20_output_iterator..
Mar 23 2022, 1:35 PM · Restricted Project, Restricted Project

Feb 28 2022

CaseyCarter added inline comments to D120633: [libc++] Better handling for zero-sized types.
Feb 28 2022, 12:31 PM · Restricted Project, Restricted Project

Feb 21 2022

CaseyCarter committed rG2d653b7e5b35: [libcxx][test] array and basic_string_view iterators are not portably pointers (authored by CaseyCarter).
[libcxx][test] array and basic_string_view iterators are not portably pointers
Feb 21 2022, 10:54 AM
CaseyCarter closed D117368: [libcxx][test] array and basic_string_view iterators are not portably pointers.
Feb 21 2022, 10:54 AM · Restricted Project

Feb 20 2022

CaseyCarter committed rGeb5950666b7c: [libcxx][test] Update msvc_stdlib_force_include.h for C++23 (authored by CaseyCarter).
[libcxx][test] Update msvc_stdlib_force_include.h for C++23
Feb 20 2022, 11:36 AM

Feb 17 2022

CaseyCarter committed rG8d58cb62da0f: [libcxx][test] Let the library indicate support for int128 (authored by CaseyCarter).
[libcxx][test] Let the library indicate support for int128
Feb 17 2022, 2:08 PM
CaseyCarter closed D120010: [libcxx][test] Neither MSVC nor its STL support int128.
Feb 17 2022, 2:08 PM · Restricted Project
CaseyCarter added inline comments to D117368: [libcxx][test] array and basic_string_view iterators are not portably pointers.
Feb 17 2022, 2:06 PM · Restricted Project
CaseyCarter updated the diff for D117368: [libcxx][test] array and basic_string_view iterators are not portably pointers.

More refactoring!

Feb 17 2022, 2:05 PM · Restricted Project
CaseyCarter committed rGa7b9af7872d2: [libcxx][test] Silence signed/unsigned comparison warnings (authored by CaseyCarter).
[libcxx][test] Silence signed/unsigned comparison warnings
Feb 17 2022, 12:56 PM
CaseyCarter updated the diff for D120010: [libcxx][test] Neither MSVC nor its STL support int128.

Thanks to Martin for telling me this was broken, and to Arthur for fixing it.

Feb 17 2022, 12:25 PM · Restricted Project
CaseyCarter added inline comments to D120010: [libcxx][test] Neither MSVC nor its STL support int128.
Feb 17 2022, 12:22 PM · Restricted Project
CaseyCarter updated the diff for D120010: [libcxx][test] Neither MSVC nor its STL support int128.

Update to allow clang-cl + libc++ to support int128.

Feb 17 2022, 12:08 PM · Restricted Project

Feb 16 2022

CaseyCarter requested review of D120010: [libcxx][test] Neither MSVC nor its STL support int128.
Feb 16 2022, 10:39 PM · Restricted Project
CaseyCarter updated the diff for D117368: [libcxx][test] array and basic_string_view iterators are not portably pointers.

Resolve merge conflicts.

Feb 16 2022, 10:03 PM · Restricted Project

Feb 9 2022

CaseyCarter added a comment to D116884: [libcxx][test] optional's comparisons with optional are not portably constrained.
In D116884#3308967, @Quuxplusone wrote:

LGTM now! And fairly confident the CI failure is unrelated and long-gone, although if you want to reupload to poke CI before landing, that would also be cool. :)

Feb 9 2022, 2:02 PM · Restricted Project
CaseyCarter committed rG009791e0dbc6: [libcxx][test] optional's comparisons with optional are not portably constrained (authored by CaseyCarter).
[libcxx][test] optional's comparisons with optional are not portably constrained
Feb 9 2022, 2:00 PM
CaseyCarter closed D116884: [libcxx][test] optional's comparisons with optional are not portably constrained.
Feb 9 2022, 2:00 PM · Restricted Project

Feb 8 2022

CaseyCarter committed rG0dcb370d4301: [libcxx][test] Disable bad unique_ptr<T[]> to shared_ptr<U[]> conversion test… (authored by CaseyCarter).
[libcxx][test] Disable bad unique_ptr<T[]> to shared_ptr<U[]> conversion test…
Feb 8 2022, 2:57 PM
CaseyCarter closed D117996: [libcxx][test] Disable bad unique_ptr<T[]> to shared_ptr<U[]> conversion test cases.
Feb 8 2022, 2:57 PM · Restricted Project
CaseyCarter committed rGc93a531caeae: [libcxx][test] tests for strengthened `noexcept` are non-portable (authored by CaseyCarter).
[libcxx][test] tests for strengthened `noexcept` are non-portable
Feb 8 2022, 2:54 PM
CaseyCarter closed D117966: [libcxx][test] tests for strengthened `noexcept` are non-portable.
Feb 8 2022, 2:54 PM · Restricted Project

Jan 26 2022

CaseyCarter added inline comments to D118279: [libcxx][test] MaybePOCCAAllocator should meet the Cpp17Allocator requirements.
Jan 26 2022, 2:38 PM · Restricted Project, Restricted Project
CaseyCarter updated the diff for D118279: [libcxx][test] MaybePOCCAAllocator should meet the Cpp17Allocator requirements.

Address review comments.

Jan 26 2022, 2:36 PM · Restricted Project, Restricted Project
CaseyCarter added inline comments to D118279: [libcxx][test] MaybePOCCAAllocator should meet the Cpp17Allocator requirements.
Jan 26 2022, 2:17 PM · Restricted Project, Restricted Project
CaseyCarter added a comment to D118194: [libcxx][test] Narrow XFAIL for tests that pass with `msvc && stdlib=msvc`.
In D118194#3273621, @mstorsjo wrote:

This was committed in rGb5bada6f85ce6789415d8b9844b6fd3a26d5408f. (@CaseyCarter, the magic keyword is Differential Revision: <url>, not Differential Review: ...)

Jan 26 2022, 1:45 PM · Restricted Project
CaseyCarter requested review of D118279: [libcxx][test] MaybePOCCAAllocator should meet the Cpp17Allocator requirements.
Jan 26 2022, 12:45 PM · Restricted Project, Restricted Project
CaseyCarter committed rGb5bada6f85ce: [libcxx][test] Narrow XFAIL for tests that pass with `msvc && stdlib=msvc` (authored by CaseyCarter).
[libcxx][test] Narrow XFAIL for tests that pass with `msvc && stdlib=msvc`
Jan 26 2022, 12:18 PM

Jan 25 2022

CaseyCarter added a comment to D118194: [libcxx][test] Narrow XFAIL for tests that pass with `msvc && stdlib=msvc`.
In D118194#3270797, @mstorsjo wrote:

This looks sensible to me. (I would presume that some amount of other windows/msvc specific XFAILs aren't right for stdlib=msvc - I presume you don't run all of the libc++ tests regularly in that configuration, only some subset?)

Jan 25 2022, 5:40 PM · Restricted Project
CaseyCarter requested review of D118194: [libcxx][test] Narrow XFAIL for tests that pass with `msvc && stdlib=msvc`.
Jan 25 2022, 2:14 PM · Restricted Project
CaseyCarter committed rG93230ac1d2cf: [libcxx][test] Use bool allocators for vector<bool>::get_allocator test (authored by CaseyCarter).
[libcxx][test] Use bool allocators for vector<bool>::get_allocator test
Jan 25 2022, 10:29 AM

Jan 24 2022

CaseyCarter requested review of D118069: [libcxx][test] Use bool allocators for vector<bool>::get_allocator test.
Jan 24 2022, 1:02 PM · Restricted Project, Restricted Project
CaseyCarter committed rG997e128e2a78: [libcxx][test] the domain of == for forward iterators is iterator values from… (authored by CaseyCarter).
[libcxx][test] the domain of == for forward iterators is iterator values from…
Jan 24 2022, 1:00 PM
CaseyCarter closed D118049: [libcxx][test] the domain of == for forward iterators is iterator values from the same range.
Jan 24 2022, 1:00 PM · Restricted Project
CaseyCarter updated the diff for D117996: [libcxx][test] Disable bad unique_ptr<T[]> to shared_ptr<U[]> conversion test cases.

Replace flowery comment with problem report link.

Jan 24 2022, 10:55 AM · Restricted Project
CaseyCarter added inline comments to D118049: [libcxx][test] the domain of == for forward iterators is iterator values from the same range.
Jan 24 2022, 10:00 AM · Restricted Project
CaseyCarter updated the diff for D118049: [libcxx][test] the domain of == for forward iterators is iterator values from the same range.

Review comment.

Jan 24 2022, 9:59 AM · Restricted Project
CaseyCarter added a comment to D117371: [libcxx][test] {move,reverse}_iterator cannot be instantiated for a type with no `operator*` in C++20.

Oh thanks for pointing this out and sorry for the noise.

Jan 24 2022, 9:31 AM · Restricted Project
CaseyCarter requested review of D118049: [libcxx][test] the domain of == for forward iterators is iterator values from the same range.
Jan 24 2022, 8:51 AM · Restricted Project
CaseyCarter committed rGcfe17986c952: [libcxx][test] {move,reverse}_iterator cannot be instantiated for a type with… (authored by CaseyCarter).
[libcxx][test] {move,reverse}_iterator cannot be instantiated for a type with…
Jan 24 2022, 8:35 AM
CaseyCarter closed D117371: [libcxx][test] {move,reverse}_iterator cannot be instantiated for a type with no `operator*` in C++20.
Jan 24 2022, 8:34 AM · Restricted Project

Jan 23 2022

CaseyCarter updated the summary of D117996: [libcxx][test] Disable bad unique_ptr<T[]> to shared_ptr<U[]> conversion test cases.
Jan 23 2022, 10:45 AM · Restricted Project