Page MenuHomePhabricator

CaseyCarter (Casey Carter)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 24 2016, 4:53 PM (304 w, 5 d)

Recent Activity

Mar 23 2022

CaseyCarter added inline comments to D122072: [libc++][test] Adds an cpp20_output_iterator..
Mar 23 2022, 1:35 PM · Restricted Project, Restricted Project

Feb 28 2022

CaseyCarter added inline comments to D120633: [libc++] Better handling for zero-sized types.
Feb 28 2022, 12:31 PM · Restricted Project, Restricted Project

Feb 21 2022

CaseyCarter committed rG2d653b7e5b35: [libcxx][test] array and basic_string_view iterators are not portably pointers (authored by CaseyCarter).
[libcxx][test] array and basic_string_view iterators are not portably pointers
Feb 21 2022, 10:54 AM
CaseyCarter closed D117368: [libcxx][test] array and basic_string_view iterators are not portably pointers.
Feb 21 2022, 10:54 AM · Restricted Project

Feb 20 2022

CaseyCarter committed rGeb5950666b7c: [libcxx][test] Update msvc_stdlib_force_include.h for C++23 (authored by CaseyCarter).
[libcxx][test] Update msvc_stdlib_force_include.h for C++23
Feb 20 2022, 11:36 AM

Feb 17 2022

CaseyCarter committed rG8d58cb62da0f: [libcxx][test] Let the library indicate support for int128 (authored by CaseyCarter).
[libcxx][test] Let the library indicate support for int128
Feb 17 2022, 2:08 PM
CaseyCarter closed D120010: [libcxx][test] Neither MSVC nor its STL support int128.
Feb 17 2022, 2:08 PM · Restricted Project
CaseyCarter added inline comments to D117368: [libcxx][test] array and basic_string_view iterators are not portably pointers.
Feb 17 2022, 2:06 PM · Restricted Project
CaseyCarter updated the diff for D117368: [libcxx][test] array and basic_string_view iterators are not portably pointers.

More refactoring!

Feb 17 2022, 2:05 PM · Restricted Project
CaseyCarter committed rGa7b9af7872d2: [libcxx][test] Silence signed/unsigned comparison warnings (authored by CaseyCarter).
[libcxx][test] Silence signed/unsigned comparison warnings
Feb 17 2022, 12:56 PM
CaseyCarter updated the diff for D120010: [libcxx][test] Neither MSVC nor its STL support int128.

Thanks to Martin for telling me this was broken, and to Arthur for fixing it.

Feb 17 2022, 12:25 PM · Restricted Project
CaseyCarter added inline comments to D120010: [libcxx][test] Neither MSVC nor its STL support int128.
Feb 17 2022, 12:22 PM · Restricted Project
CaseyCarter updated the diff for D120010: [libcxx][test] Neither MSVC nor its STL support int128.

Update to allow clang-cl + libc++ to support int128.

Feb 17 2022, 12:08 PM · Restricted Project

Feb 16 2022

CaseyCarter requested review of D120010: [libcxx][test] Neither MSVC nor its STL support int128.
Feb 16 2022, 10:39 PM · Restricted Project
CaseyCarter updated the diff for D117368: [libcxx][test] array and basic_string_view iterators are not portably pointers.

Resolve merge conflicts.

Feb 16 2022, 10:03 PM · Restricted Project

Feb 9 2022

CaseyCarter added a comment to D116884: [libcxx][test] optional's comparisons with optional are not portably constrained.

LGTM now! And fairly confident the CI failure is unrelated and long-gone, although if you want to reupload to poke CI before landing, that would also be cool. :)

Feb 9 2022, 2:02 PM · Restricted Project
CaseyCarter committed rG009791e0dbc6: [libcxx][test] optional's comparisons with optional are not portably constrained (authored by CaseyCarter).
[libcxx][test] optional's comparisons with optional are not portably constrained
Feb 9 2022, 2:00 PM
CaseyCarter closed D116884: [libcxx][test] optional's comparisons with optional are not portably constrained.
Feb 9 2022, 2:00 PM · Restricted Project

Feb 8 2022

CaseyCarter committed rG0dcb370d4301: [libcxx][test] Disable bad unique_ptr<T[]> to shared_ptr<U[]> conversion test… (authored by CaseyCarter).
[libcxx][test] Disable bad unique_ptr<T[]> to shared_ptr<U[]> conversion test…
Feb 8 2022, 2:57 PM
CaseyCarter closed D117996: [libcxx][test] Disable bad unique_ptr<T[]> to shared_ptr<U[]> conversion test cases.
Feb 8 2022, 2:57 PM · Restricted Project
CaseyCarter committed rGc93a531caeae: [libcxx][test] tests for strengthened `noexcept` are non-portable (authored by CaseyCarter).
[libcxx][test] tests for strengthened `noexcept` are non-portable
Feb 8 2022, 2:54 PM
CaseyCarter closed D117966: [libcxx][test] tests for strengthened `noexcept` are non-portable.
Feb 8 2022, 2:54 PM · Restricted Project

Jan 26 2022

CaseyCarter added inline comments to D118279: [libcxx][test] MaybePOCCAAllocator should meet the Cpp17Allocator requirements.
Jan 26 2022, 2:38 PM · Restricted Project
CaseyCarter updated the diff for D118279: [libcxx][test] MaybePOCCAAllocator should meet the Cpp17Allocator requirements.

Address review comments.

Jan 26 2022, 2:36 PM · Restricted Project
CaseyCarter added inline comments to D118279: [libcxx][test] MaybePOCCAAllocator should meet the Cpp17Allocator requirements.
Jan 26 2022, 2:17 PM · Restricted Project
CaseyCarter added a comment to D118194: [libcxx][test] Narrow XFAIL for tests that pass with `msvc && stdlib=msvc`.

This was committed in rGb5bada6f85ce6789415d8b9844b6fd3a26d5408f. (@CaseyCarter, the magic keyword is Differential Revision: <url>, not Differential Review: ...)

Jan 26 2022, 1:45 PM · Restricted Project
CaseyCarter requested review of D118279: [libcxx][test] MaybePOCCAAllocator should meet the Cpp17Allocator requirements.
Jan 26 2022, 12:45 PM · Restricted Project
CaseyCarter committed rGb5bada6f85ce: [libcxx][test] Narrow XFAIL for tests that pass with `msvc && stdlib=msvc` (authored by CaseyCarter).
[libcxx][test] Narrow XFAIL for tests that pass with `msvc && stdlib=msvc`
Jan 26 2022, 12:18 PM

Jan 25 2022

CaseyCarter added a comment to D118194: [libcxx][test] Narrow XFAIL for tests that pass with `msvc && stdlib=msvc`.

This looks sensible to me. (I would presume that some amount of other windows/msvc specific XFAILs aren't right for stdlib=msvc - I presume you don't run all of the libc++ tests regularly in that configuration, only some subset?)

Jan 25 2022, 5:40 PM · Restricted Project
CaseyCarter requested review of D118194: [libcxx][test] Narrow XFAIL for tests that pass with `msvc && stdlib=msvc`.
Jan 25 2022, 2:14 PM · Restricted Project
CaseyCarter committed rG93230ac1d2cf: [libcxx][test] Use bool allocators for vector<bool>::get_allocator test (authored by CaseyCarter).
[libcxx][test] Use bool allocators for vector<bool>::get_allocator test
Jan 25 2022, 10:29 AM

Jan 24 2022

CaseyCarter requested review of D118069: [libcxx][test] Use bool allocators for vector<bool>::get_allocator test.
Jan 24 2022, 1:02 PM · Restricted Project, Restricted Project
CaseyCarter committed rG997e128e2a78: [libcxx][test] the domain of == for forward iterators is iterator values from… (authored by CaseyCarter).
[libcxx][test] the domain of == for forward iterators is iterator values from…
Jan 24 2022, 1:00 PM
CaseyCarter closed D118049: [libcxx][test] the domain of == for forward iterators is iterator values from the same range.
Jan 24 2022, 1:00 PM · Restricted Project
CaseyCarter updated the diff for D117996: [libcxx][test] Disable bad unique_ptr<T[]> to shared_ptr<U[]> conversion test cases.

Replace flowery comment with problem report link.

Jan 24 2022, 10:55 AM · Restricted Project
CaseyCarter added inline comments to D118049: [libcxx][test] the domain of == for forward iterators is iterator values from the same range.
Jan 24 2022, 10:00 AM · Restricted Project
CaseyCarter updated the diff for D118049: [libcxx][test] the domain of == for forward iterators is iterator values from the same range.

Review comment.

Jan 24 2022, 9:59 AM · Restricted Project
CaseyCarter added a comment to D117371: [libcxx][test] {move,reverse}_iterator cannot be instantiated for a type with no `operator*` in C++20.

Oh thanks for pointing this out and sorry for the noise.

Jan 24 2022, 9:31 AM · Restricted Project
CaseyCarter requested review of D118049: [libcxx][test] the domain of == for forward iterators is iterator values from the same range.
Jan 24 2022, 8:51 AM · Restricted Project
CaseyCarter committed rGcfe17986c952: [libcxx][test] {move,reverse}_iterator cannot be instantiated for a type with… (authored by CaseyCarter).
[libcxx][test] {move,reverse}_iterator cannot be instantiated for a type with…
Jan 24 2022, 8:35 AM
CaseyCarter closed D117371: [libcxx][test] {move,reverse}_iterator cannot be instantiated for a type with no `operator*` in C++20.
Jan 24 2022, 8:34 AM · Restricted Project

Jan 23 2022

CaseyCarter updated the summary of D117996: [libcxx][test] Disable bad unique_ptr<T[]> to shared_ptr<U[]> conversion test cases.
Jan 23 2022, 10:45 AM · Restricted Project
CaseyCarter requested review of D117996: [libcxx][test] Disable bad unique_ptr<T[]> to shared_ptr<U[]> conversion test cases.
Jan 23 2022, 10:33 AM · Restricted Project
CaseyCarter committed rG818cfb10c574: [libcxx][test] Make MSVC `<charconv>` test compile when testing MSVC (authored by CaseyCarter).
[libcxx][test] Make MSVC `<charconv>` test compile when testing MSVC
Jan 23 2022, 10:13 AM
CaseyCarter closed D117967: [libcxx][test] Make MSVC `<charconv>` test compile when testing MSVC.
Jan 23 2022, 10:13 AM · Restricted Project

Jan 22 2022

CaseyCarter requested review of D117967: [libcxx][test] Make MSVC `<charconv>` test compile when testing MSVC.
Jan 22 2022, 12:50 PM · Restricted Project
CaseyCarter requested review of D117966: [libcxx][test] tests for strengthened `noexcept` are non-portable.
Jan 22 2022, 12:44 PM · Restricted Project

Jan 20 2022

CaseyCarter committed rGb8d38e8b4fca: [libcxx][test] view_interface need not derive from view_base (authored by CaseyCarter).
[libcxx][test] view_interface need not derive from view_base
Jan 20 2022, 12:17 PM
CaseyCarter closed D117608: [libcxx][test] view_interface need not derive from view_base.
Jan 20 2022, 12:17 PM · Restricted Project
CaseyCarter added inline comments to D117638: [libcxx] chrono::month_weekday should not be default constructible.
Jan 20 2022, 11:53 AM · Restricted Project
CaseyCarter committed rG864b5b49fd3f: [libcxx] chrono::month_weekday should not be default constructible (authored by CaseyCarter).
[libcxx] chrono::month_weekday should not be default constructible
Jan 20 2022, 11:48 AM
CaseyCarter closed D117638: [libcxx] chrono::month_weekday should not be default constructible.
Jan 20 2022, 11:48 AM · Restricted Project
CaseyCarter committed rG67d483aba23c: [libcxx][test] Use TEST_HAS_BUILTIN in test code (authored by CaseyCarter).
[libcxx][test] Use TEST_HAS_BUILTIN in test code
Jan 20 2022, 1:48 AM

Jan 19 2022

CaseyCarter added a comment to D117660: [libc++] Fix a typo in reverse_iterator::operator=.

We should be checking is_assignable<It&, ...>. is_assignable<It, ...> checks for an rvalue left-hand side, which is basically never assignable-to.

Jan 19 2022, 11:54 AM · Restricted Project
CaseyCarter committed rG3a1b178a0b8b: [libcxx][test] Portably test that `{w,}format_context` is a specialization of… (authored by CaseyCarter).
[libcxx][test] Portably test that `{w,}format_context` is a specialization of…
Jan 19 2022, 11:37 AM
CaseyCarter closed D117606: [libcxx][test] Portably test that `{w,}format_context` is a specialization of `basic_format_context`.
Jan 19 2022, 11:36 AM · Restricted Project
CaseyCarter updated the diff for D117638: [libcxx] chrono::month_weekday should not be default constructible.

Use [1, 12] uniformly for months.

Jan 19 2022, 11:33 AM · Restricted Project
CaseyCarter added inline comments to D117608: [libcxx][test] view_interface need not derive from view_base.
Jan 19 2022, 11:09 AM · Restricted Project
CaseyCarter updated the diff for D117638: [libcxx] chrono::month_weekday should not be default constructible.

Address missed review comment.

Jan 19 2022, 11:00 AM · Restricted Project
CaseyCarter added inline comments to D117638: [libcxx] chrono::month_weekday should not be default constructible.
Jan 19 2022, 10:51 AM · Restricted Project
CaseyCarter updated the diff for D117638: [libcxx] chrono::month_weekday should not be default constructible.

Address review comments.

Jan 19 2022, 10:50 AM · Restricted Project

Jan 18 2022

CaseyCarter requested review of D117638: [libcxx] chrono::month_weekday should not be default constructible.
Jan 18 2022, 10:49 PM · Restricted Project
CaseyCarter committed rGa94739985b2c: [libcxx][test] test _LIBCPP_VERSION with #ifdef, not #if (authored by CaseyCarter).
[libcxx][test] test _LIBCPP_VERSION with #ifdef, not #if
Jan 18 2022, 7:37 PM
CaseyCarter added inline comments to D117606: [libcxx][test] Portably test that `{w,}format_context` is a specialization of `basic_format_context`.
Jan 18 2022, 5:17 PM · Restricted Project
CaseyCarter updated the diff for D117606: [libcxx][test] Portably test that `{w,}format_context` is a specialization of `basic_format_context`.

Address review

Jan 18 2022, 5:16 PM · Restricted Project
CaseyCarter updated the diff for D117608: [libcxx][test] view_interface need not derive from view_base.

Review comment.

Jan 18 2022, 5:06 PM · Restricted Project
CaseyCarter requested review of D117608: [libcxx][test] view_interface need not derive from view_base.
Jan 18 2022, 2:26 PM · Restricted Project
CaseyCarter requested review of D117606: [libcxx][test] Portably test that `{w,}format_context` is a specialization of `basic_format_context`.
Jan 18 2022, 2:22 PM · Restricted Project
CaseyCarter added inline comments to D117369: [libcxx][test] `unordered_meow` iterators are not portably non-bidi.
Jan 18 2022, 12:46 PM · Restricted Project
CaseyCarter committed rGf105d9844319: [libcxx][test] `unordered_meow` iterators are not portably non-bidi (authored by CaseyCarter).
[libcxx][test] `unordered_meow` iterators are not portably non-bidi
Jan 18 2022, 11:43 AM
CaseyCarter closed D117369: [libcxx][test] `unordered_meow` iterators are not portably non-bidi.
Jan 18 2022, 11:43 AM · Restricted Project
CaseyCarter added inline comments to D117369: [libcxx][test] `unordered_meow` iterators are not portably non-bidi.
Jan 18 2022, 11:43 AM · Restricted Project
CaseyCarter committed rG4e00a1921fb1: [libcxx][test] compiler options are non-portable (authored by CaseyCarter).
[libcxx][test] compiler options are non-portable
Jan 18 2022, 11:35 AM
CaseyCarter closed D117422: [libcxx][test] compiler options are non-portable.
Jan 18 2022, 11:35 AM · Restricted Project
CaseyCarter added a comment to D117449: [libc++] Fix common_iterator for output_iterators.

LGTM, with Arthur's comments. (Although I'm fine with the extra typename requirement in __can_use_postfix_proxy.)

Jan 18 2022, 11:18 AM · Restricted Project

Jan 17 2022

CaseyCarter updated the diff for D117369: [libcxx][test] `unordered_meow` iterators are not portably non-bidi.

Address review comments.

Jan 17 2022, 9:19 PM · Restricted Project
CaseyCarter added a comment to D117422: [libcxx][test] compiler options are non-portable.

Could we include "test_macros.h" and use TEST_COMPILER_CLANG/TEST_COMPILER_C1XX instead?

Jan 17 2022, 6:00 PM · Restricted Project
CaseyCarter updated the diff for D117422: [libcxx][test] compiler options are non-portable.

Address review comments.

Jan 17 2022, 5:58 PM · Restricted Project
CaseyCarter added inline comments to D116974: [libc++] Add ranges::in_fun_result.
Jan 17 2022, 2:12 PM · Restricted Project
CaseyCarter added inline comments to D117512: [libc++][ranges] Add ranges::in_in_out_result.
Jan 17 2022, 2:09 PM · Restricted Project
CaseyCarter added inline comments to D117368: [libcxx][test] array and basic_string_view iterators are not portably pointers.
Jan 17 2022, 2:04 PM · Restricted Project
CaseyCarter updated the diff for D117368: [libcxx][test] array and basic_string_view iterators are not portably pointers.

Moar review comments

Jan 17 2022, 2:03 PM · Restricted Project
CaseyCarter added a comment to D117449: [libc++] Fix common_iterator for output_iterators.

I don't object to landing this as-is, just to fix the bug; I would also be happy to merge it into D117400. Your call.

Jan 17 2022, 11:48 AM · Restricted Project
CaseyCarter added inline comments to D117400: [libc++] Fix bugs in common_iterator; add test coverage..
Jan 17 2022, 11:37 AM · Restricted Project

Jan 16 2022

CaseyCarter updated the diff for D117368: [libcxx][test] array and basic_string_view iterators are not portably pointers.

Address some review comments.

Jan 16 2022, 9:49 PM · Restricted Project
CaseyCarter added inline comments to D117368: [libcxx][test] array and basic_string_view iterators are not portably pointers.
Jan 16 2022, 9:48 PM · Restricted Project
CaseyCarter requested review of D117449: [libc++] Fix common_iterator for output_iterators.
Jan 16 2022, 7:24 PM · Restricted Project
CaseyCarter added inline comments to D117240: [libc++] Fix bug in ranges::advance and refactor the tests.
Jan 16 2022, 6:09 AM · Restricted Project
CaseyCarter requested review of D117422: [libcxx][test] compiler options are non-portable.
Jan 16 2022, 1:55 AM · Restricted Project

Jan 15 2022

CaseyCarter added a comment to D117371: [libcxx][test] {move,reverse}_iterator cannot be instantiated for a type with no `operator*` in C++20.

I'd like @ldionne to make an executive decision about whether libc++ should continue to compile move_iterator<ToIter>, as an extension, in pre-C++20 modes. (class ToIter does not have an operator*: dereferencing such a move_iterator wouldn't compile, but merely forming the type is currently legal in libc++ pre-C++20.)
If we think our "extension" is important, then this PR is removing test coverage. If we think no sane user would ever make a move_iterator of a non-iterator type, then this PR is a great simplification.

Jan 15 2022, 1:18 PM · Restricted Project
CaseyCarter abandoned D117367: [libcxx][test] Niebloids are not portably of `final` class type.

I believe this is obsolete since D116384: all uses of is_niebloid are now guarded under LIBCPP_STATIC_ASSERT at their call sites. E.g.

Jan 15 2022, 1:05 PM · Restricted Project

Jan 14 2022

CaseyCarter requested review of D117371: [libcxx][test] {move,reverse}_iterator cannot be instantiated for a type with no `operator*` in C++20.
Jan 14 2022, 4:55 PM · Restricted Project
CaseyCarter requested review of D117369: [libcxx][test] `unordered_meow` iterators are not portably non-bidi.
Jan 14 2022, 4:52 PM · Restricted Project
CaseyCarter requested review of D117368: [libcxx][test] array and basic_string_view iterators are not portably pointers.
Jan 14 2022, 4:49 PM · Restricted Project
CaseyCarter requested review of D117367: [libcxx][test] Niebloids are not portably of `final` class type.
Jan 14 2022, 4:25 PM · Restricted Project
CaseyCarter committed rGecd64c4e1546: [libcxx][test] Properly qualify uses of std::size_t (authored by CaseyCarter).
[libcxx][test] Properly qualify uses of std::size_t
Jan 14 2022, 11:42 AM

Jan 13 2022

CaseyCarter added inline comments to D116884: [libcxx][test] optional's comparisons with optional are not portably constrained.
Jan 13 2022, 8:27 PM · Restricted Project
CaseyCarter updated the diff for D116884: [libcxx][test] optional's comparisons with optional are not portably constrained.

Address review comments.

Jan 13 2022, 8:26 PM · Restricted Project
CaseyCarter committed rGcb71d77cc8cf: [libcxx][test] Add missing includes and suppress warnings (authored by CaseyCarter).
[libcxx][test] Add missing includes and suppress warnings
Jan 13 2022, 5:34 PM
CaseyCarter closed D116878: [libcxx][test] Add missing includes and suppress warnings.
Jan 13 2022, 5:34 PM · Restricted Project