This is an archive of the discontinued LLVM Phabricator instance.

Differential D72585

[MLIR] Fixes for BUILD_SHARED_LIBS=on
AbandonedPublic

Authored by stephenneuendorffer on Jan 13 2020, 12:02 AM.

Details

Reviewers
mravishankar
antiagainst
nicolasvasilache
vchuravy
inouehrs
Summary

This patch enables the above cmake option, which builds most libraries
as DLLs instead of statically linked libraries. The main effect of this is
that incrememntal build times are greatly reduced, since usually only one
library need be relinked in response to isolated code changes.

The bulk of this patch is fixing incorrect usage of cmake, where library
dependencies are listed under add_dependencies rather than under
target_link_libraries or under the LINK_LIBS tag. Correct usage should be
like this:

add_dependencies(MLIRfoo MLIRfooIncGen)
target_link_libraries(MLIRfoo MLIRlib1 MLIRlib2)

Diff Detail

Event Timeline

stephenneuendorffer created this revision.Jan 13 2020, 12:02 AM
Herald added a reviewer: mravishankar. · View Herald TranscriptJan 13 2020, 12:02 AM
Herald added a reviewer: antiagainst. · View Herald Transcript
Herald added a reviewer: nicolasvasilache. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, liufengdb, aartbik and 14 others. · View Herald Transcript
Harbormaster completed remote builds in B43798: Diff 237583.Jan 13 2020, 12:06 AM
stephenneuendorffer added reviewers: vchuravy, inouehrs.Jan 13 2020, 12:14 AM
marbre added a subscriber: marbre.Jan 13 2020, 1:54 AM
ftynse added a subscriber: ftynse.Jan 14 2020, 11:59 PM

I think this goes into the right direction. The issue with this patch is that it removes some libraries from add_dependency for some targets, but not all of them, thus creating more inconsistency than we already have. Could you make it consistent for all targets and, if possible and in a follow up, add a doc that says how to properly set up a library for a new dialect.

nicolasvasilache accepted this revision.Jan 16 2020, 5:45 AM

Thanks! A lot of these mistakes have been carried forward by virtue of copypasta..
As Alex mentioned, would be great to have some doc and increase consistency but I see this as nice progress already.

This revision is now accepted and ready to land.Jan 16 2020, 5:45 AM
stephenneuendorffer updated this revision to Diff 238783.Jan 17 2020, 8:04 AM

Rebased. Also cleaned up the dependencies around mlir-opt. This is tested with BUILD_SHARED_LIBS=on and BUILD_SHARED_LIBS=off

merge_guards_bot added a subscriber: merge_guards_bot.Jan 17 2020, 8:10 AM

Unit tests: unknown.

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt

Harbormaster failed remote builds in B44278: Diff 238783!Jan 17 2020, 8:15 AM
mehdi_amini added a comment.Jan 18 2020, 7:41 PM

The changes overall looks fine to me, but this patch does not seem enough to build with ENABLE_SHARED_LIB right? We still have a cyclic dependency to break first I believe.

mehdi_amini added a comment.Jan 18 2020, 7:42 PM

Also, how does this patch compare to D72554 ?

stephenneuendorffer added a parent revision: D69440: [cmake] Add support for explicit STATIC libraries even when building mostly shared libraries..Jan 19 2020, 1:00 AM
stephenneuendorffer added a comment.Jan 19 2020, 1:04 AM
In D72585#1828331, @mehdi_amini wrote:

The changes overall looks fine to me, but this patch does not seem enough to build with ENABLE_SHARED_LIB right? We still have a cyclic dependency to break first I believe.

This depends on https://reviews.llvm.org/D69440. I added that as a 'parent' commit, which appears to be how phabricator represents such things.
This combined with "STATIC" annotations is enough to get BUILD_SHARED_LIB to work.

stephenneuendorffer added a comment.Jan 19 2020, 1:10 AM
In D72585#1828333, @mehdi_amini wrote:

Also, how does this patch compare to D72554 ?

D72554 seems focused on a different approach to breaking the cyclic dependency problem, which does not modify the llvm cmake environment, but has the same end result (always building the libraries with cyclic dependencies as static libraries.)
Either way could work. My way (in D69440) is simpler, but we'll need an "add_mlir_library" cmake infrastructure anyway to get to having libMLIR.so.

stephenneuendorffer updated this revision to Diff 238979.Jan 19 2020, 2:45 AM

Don't change add_dependencies lines: we'll fix those later

merge_guards_bot added a comment.Jan 19 2020, 2:55 AM

Unit tests: unknown.

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt

Harbormaster failed remote builds in B44353: Diff 238979!Jan 19 2020, 3:01 AM
stephenneuendorffer abandoned this revision.Feb 5 2020, 11:32 AM

This landed in modified form as D73653

Herald added a subscriber: Joonsoo. · View Herald TranscriptFeb 5 2020, 11:32 AM

Revision Contents

PathSize
mlir/
1 line
lib/
Conversion/
AffineToStandard/
3 lines
GPUToNVVM/
2 lines
GPUToROCDL/
1 line
LinalgToLLVM/
5 lines
LoopsToGPU/
1 line
VectorToLLVM/
1 line
VectorToLoops/
1 line
Dialect/
FxpMathOps/
14 lines
GPU/
10 lines
LLVMIR/
2 lines
LoopOps/
4 lines
QuantOps/
17 lines
SPIRV/
Serialization/
3 lines
VectorOps/
4 lines
EDSC/
24 lines
ExecutionEngine/
8 lines
Quantizer/
31 lines
Support/
3 lines
test/
lib/
IR/
5 lines
Pass/
4 lines
TestDialect/
16 lines
Transforms/
20 lines
tools/
mlir-opt/
16 lines

Diff 238783

mlir/CMakeLists.txt

Show All 36 Lines
# tablegen'd targets. # tablegen'd targets.
add_custom_target(mlir-headers) add_custom_target(mlir-headers)
set_target_properties(mlir-headers PROPERTIES FOLDER "Misc") set_target_properties(mlir-headers PROPERTIES FOLDER "Misc")
add_custom_target(mlir-doc) add_custom_target(mlir-doc)
# TODO: This is to handle the current static registration, but should be # TODO: This is to handle the current static registration, but should be
# factored out a bit. # factored out a bit.
function(whole_archive_link target) function(whole_archive_link target)
add_dependencies(${target} ${ARGN})
if("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin") if("${CMAKE_SYSTEM_NAME}" STREQUAL "Darwin")
set(link_flags "-L${CMAKE_BINARY_DIR}/lib ") set(link_flags "-L${CMAKE_BINARY_DIR}/lib ")
FOREACH(LIB ${ARGN}) FOREACH(LIB ${ARGN})
string(CONCAT link_flags ${link_flags} "-Wl,-force_load ${CMAKE_BINARY_DIR}/lib/lib${LIB}.a ") string(CONCAT link_flags ${link_flags} "-Wl,-force_load ${CMAKE_BINARY_DIR}/lib/lib${LIB}.a ")
ENDFOREACH(LIB) ENDFOREACH(LIB)
elseif(MSVC) elseif(MSVC)
FOREACH(LIB ${ARGN}) FOREACH(LIB ${ARGN})
string(CONCAT link_flags ${link_flags} "/WHOLEARCHIVE:${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib/${LIB}.lib ") string(CONCAT link_flags ${link_flags} "/WHOLEARCHIVE:${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib/${LIB}.lib ")
▲ Show 20 Lines • Show All 63 Lines • Show Last 20 Lines

mlir/lib/Conversion/AffineToStandard/CMakeLists.txt

Show All 11 Linesadd_dependencies(
MLIRIR MLIRIR
LLVMCore LLVMCore
LLVMSupport LLVMSupport
) )
target_link_libraries( target_link_libraries(
MLIRAffineToStandard MLIRAffineToStandard
MLIRAffineOps MLIRAffineOps
MLIRLoopOps
MLIRPass
MLIRStandardOps MLIRStandardOps
MLIRTransforms
MLIRIR MLIRIR
LLVMCore LLVMCore
LLVMSupport LLVMSupport
) )

mlir/lib/Conversion/GPUToNVVM/CMakeLists.txt

Show All 9 Linesadd_dependencies(MLIRGPUtoNVVMTransforms
MLIRGPUToNVVMIncGen) MLIRGPUToNVVMIncGen)
target_link_libraries(MLIRGPUtoNVVMTransforms target_link_libraries(MLIRGPUtoNVVMTransforms
LLVMSupport LLVMSupport
MLIRGPU MLIRGPU
MLIRLLVMIR MLIRLLVMIR
MLIRNVVMIR MLIRNVVMIR
MLIRPass MLIRPass
MLIRStandardToLLVM
MLIRTransformUtils
) )

mlir/lib/Conversion/GPUToROCDL/CMakeLists.txt

add_llvm_library(MLIRGPUtoROCDLTransforms add_llvm_library(MLIRGPUtoROCDLTransforms
LowerGpuOpsToROCDLOps.cpp LowerGpuOpsToROCDLOps.cpp
) )
target_link_libraries(MLIRGPUtoROCDLTransforms target_link_libraries(MLIRGPUtoROCDLTransforms
LLVMSupport LLVMSupport
MLIRGPU MLIRGPU
MLIRLLVMIR MLIRLLVMIR
MLIRROCDLIR MLIRROCDLIR
MLIRPass MLIRPass
MLIRStandardToLLVM
) )

mlir/lib/Conversion/LinalgToLLVM/CMakeLists.txt

add_llvm_library(MLIRLinalgToLLVM add_llvm_library(MLIRLinalgToLLVM
LinalgToLLVM.cpp LinalgToLLVM.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/LinalgToLLVM ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/LinalgToLLVM
) )
set(LIBS set(LIBS
MLIRAffineToStandard
MLIREDSC
MLIRIR
MLIRLinalgOps MLIRLinalgOps
MLIRLLVMIR MLIRLLVMIR
MLIRStandardToLLVM
MLIRVectorToLLVM
MLIRTransforms MLIRTransforms
LLVMCore LLVMCore
LLVMSupport LLVMSupport
) )
add_dependencies(MLIRLinalgToLLVM ${LIBS}) add_dependencies(MLIRLinalgToLLVM ${LIBS})
target_link_libraries(MLIRLinalgToLLVM ${LIBS}) target_link_libraries(MLIRLinalgToLLVM ${LIBS})

mlir/lib/Conversion/LoopsToGPU/CMakeLists.txt

set(LIBS set(LIBS
MLIRAffineOps MLIRAffineOps
MLIRAffineToStandard
MLIRGPU MLIRGPU
MLIRIR MLIRIR
MLIRLinalgOps MLIRLinalgOps
MLIRPass MLIRPass
MLIRStandardOps MLIRStandardOps
MLIRSupport MLIRSupport
MLIRTransforms MLIRTransforms
LLVMSupport LLVMSupport
Show All 11 Lines

mlir/lib/Conversion/VectorToLLVM/CMakeLists.txt

add_llvm_library(MLIRVectorToLLVM add_llvm_library(MLIRVectorToLLVM
ConvertVectorToLLVM.cpp ConvertVectorToLLVM.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/VectorToLLVM ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/VectorToLLVM
) )
set(LIBS set(LIBS
MLIRLLVMIR MLIRLLVMIR
MLIRStandardToLLVM
MLIRTransforms MLIRTransforms
LLVMCore LLVMCore
LLVMSupport LLVMSupport
) )
add_dependencies(MLIRVectorToLLVM ${LIBS}) add_dependencies(MLIRVectorToLLVM ${LIBS})
target_link_libraries(MLIRVectorToLLVM ${LIBS}) target_link_libraries(MLIRVectorToLLVM ${LIBS})

mlir/lib/Conversion/VectorToLoops/CMakeLists.txt

add_llvm_library(MLIRVectorToLoops add_llvm_library(MLIRVectorToLoops
ConvertVectorToLoops.cpp ConvertVectorToLoops.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/VectorToLoops ${MLIR_MAIN_INCLUDE_DIR}/mlir/Conversion/VectorToLoops
) )
set(LIBS set(LIBS
MLIREDSC
MLIRLLVMIR MLIRLLVMIR
MLIRTransforms MLIRTransforms
LLVMCore LLVMCore
LLVMSupport LLVMSupport
) )
add_dependencies(MLIRVectorToLoops ${LIBS}) add_dependencies(MLIRVectorToLoops ${LIBS})
target_link_libraries(MLIRVectorToLoops ${LIBS}) target_link_libraries(MLIRVectorToLoops ${LIBS})

mlir/lib/Dialect/FxpMathOps/CMakeLists.txt

add_llvm_library(MLIRFxpMathOps add_llvm_library(MLIRFxpMathOps
IR/FxpMathOps.cpp IR/FxpMathOps.cpp
IR/DialectRegistration.cpp IR/DialectRegistration.cpp
Transforms/LowerUniformRealMath.cpp Transforms/LowerUniformRealMath.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/FxpMathOps ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/FxpMathOps
)
add_dependencies(MLIRFxpMathOps LINK_LIBS
MLIRFxpMathOpsIncGen
MLIRQuantOps MLIRQuantOps
MLIRIR MLIRIR
MLIRPass MLIRPass
MLIRSupport MLIRSupport
MLIRStandardOps) MLIRStandardOps
)
add_dependencies(MLIRFxpMathOps
MLIRFxpMathOpsIncGen)

mlir/lib/Dialect/GPU/CMakeLists.txt

add_llvm_library(MLIRGPU add_llvm_library(MLIRGPU
IR/GPUDialect.cpp IR/GPUDialect.cpp
IR/DialectRegistration.cpp IR/DialectRegistration.cpp
Transforms/KernelOutlining.cpp Transforms/KernelOutlining.cpp
Transforms/MemoryPromotion.cpp Transforms/MemoryPromotion.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/GPU ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/GPU
) )
add_dependencies(MLIRGPU add_dependencies(MLIRGPU
MLIRGPUOpsIncGen MLIRGPUOpsIncGen
MLIREDSC )
MLIRIR
MLIRLLVMIR
MLIRLoopOps
MLIRSupport
MLIRTransformUtils
LLVMSupport)
target_link_libraries(MLIRGPU target_link_libraries(MLIRGPU
MLIREDSC MLIREDSC
MLIRIR MLIRIR
MLIRLLVMIR MLIRLLVMIR
MLIRLoopOps MLIRLoopOps
MLIRPass
MLIRStandardOps
MLIRSupport MLIRSupport
MLIRTransformUtils MLIRTransformUtils
LLVMSupport) LLVMSupport)

mlir/lib/Dialect/LLVMIR/CMakeLists.txt

add_llvm_library(MLIRLLVMIR add_llvm_library(MLIRLLVMIR
IR/LLVMDialect.cpp IR/LLVMDialect.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/LLVMIR ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/LLVMIR
) )
add_dependencies(MLIRLLVMIR MLIRLLVMOpsIncGen MLIRLLVMConversionsIncGen LLVMAsmParser LLVMCore LLVMSupport) add_dependencies(MLIRLLVMIR MLIRLLVMOpsIncGen MLIRLLVMConversionsIncGen LLVMAsmParser LLVMCore LLVMSupport)
target_link_libraries(MLIRLLVMIR LLVMAsmParser LLVMCore LLVMSupport MLIRIR) target_link_libraries(MLIRLLVMIR LLVMAsmParser LLVMCore LLVMSupport MLIRIR)
add_llvm_library(MLIRNVVMIR add_llvm_library(MLIRNVVMIR
IR/NVVMDialect.cpp IR/NVVMDialect.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/LLVMIR ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/LLVMIR
) )
add_dependencies(MLIRNVVMIR MLIRNVVMOpsIncGen MLIRNVVMConversionsIncGen LLVMAsmParser LLVMCore LLVMSupport) add_dependencies(MLIRNVVMIR MLIRNVVMOpsIncGen MLIRNVVMConversionsIncGen LLVMAsmParser LLVMCore LLVMSupport)
target_link_libraries(MLIRNVVMIR LLVMAsmParser LLVMCore LLVMSupport MLIRIR) target_link_libraries(MLIRNVVMIR LLVMAsmParser MLIRIR MLIRLLVMIR LLVMSupport LLVMCore)
add_llvm_library(MLIRROCDLIR add_llvm_library(MLIRROCDLIR
IR/ROCDLDialect.cpp IR/ROCDLDialect.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/LLVMIR ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/LLVMIR
) )
add_dependencies(MLIRROCDLIR MLIRROCDLOpsIncGen MLIRROCDLConversionsIncGen LLVMAsmParser LLVMCore LLVMSupport) add_dependencies(MLIRROCDLIR MLIRROCDLOpsIncGen MLIRROCDLConversionsIncGen LLVMAsmParser LLVMCore LLVMSupport)
target_link_libraries(MLIRROCDLIR LLVMAsmParser LLVMCore LLVMSupport MLIRIR) target_link_libraries(MLIRROCDLIR LLVMAsmParser LLVMCore LLVMSupport MLIRIR)

mlir/lib/Dialect/LoopOps/CMakeLists.txt

file(GLOB globbed *.c *.cpp) file(GLOB globbed *.c *.cpp)
add_llvm_library(MLIRLoopOps add_llvm_library(MLIRLoopOps
${globbed} ${globbed}
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/LoopOps ${MLIR_MAIN_INCLUDE_DIR}/mlir/LoopOps
) )
add_dependencies(MLIRLoopOps MLIRLoopLikeInterfaceIncGen MLIRLoopOpsIncGen MLIRStandardOps LLVMSupport) add_dependencies(MLIRLoopOps MLIRLoopLikeInterfaceIncGen MLIRLoopOpsIncGen)
target_link_libraries(MLIRLoopOps LLVMSupport) target_link_libraries(MLIRLoopOps MLIRStandardOps LLVMSupport MLIRIR)

mlir/lib/Dialect/QuantOps/CMakeLists.txt

add_llvm_library(MLIRQuantOps add_llvm_library(MLIRQuantOps
IR/DialectRegistration.cpp IR/DialectRegistration.cpp
IR/QuantOps.cpp IR/QuantOps.cpp
IR/QuantTypes.cpp IR/QuantTypes.cpp
IR/TypeDetail.h IR/TypeDetail.h
IR/TypeParser.cpp IR/TypeParser.cpp
Transforms/ConvertConst.cpp Transforms/ConvertConst.cpp
Transforms/ConvertSimQuant.cpp Transforms/ConvertSimQuant.cpp
Utils/QuantizeUtils.cpp Utils/QuantizeUtils.cpp
Utils/UniformSupport.cpp Utils/UniformSupport.cpp
Utils/FakeQuantSupport.cpp Utils/FakeQuantSupport.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/QuantOps ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/QuantOps
) )
add_dependencies(MLIRQuantOps add_dependencies(
MLIRQuantOps
MLIRQuantOpsIncGen
)
target_link_libraries(MLIRQuantOps
MLIRIR MLIRIR
MLIRPass MLIRPass
MLIRQuantOpsIncGen
MLIRSupport MLIRSupport
MLIRStandardOps) MLIRStandardOps
MLIRTransformUtils
)

mlir/lib/Dialect/SPIRV/Serialization/CMakeLists.txt

add_llvm_library(MLIRSPIRVSerialization add_llvm_library(MLIRSPIRVSerialization
Deserializer.cpp Deserializer.cpp
Serializer.cpp Serializer.cpp
SPIRVBinaryUtils.cpp SPIRVBinaryUtils.cpp
TranslateRegistration.cpp TranslateRegistration.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/SPIRV ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/SPIRV
) )
add_dependencies(MLIRSPIRVSerialization add_dependencies(MLIRSPIRVSerialization
MLIRSPIRVSerializationGen) MLIRSPIRVSerializationGen)
target_link_libraries(MLIRSPIRVSerialization target_link_libraries(MLIRSPIRVSerialization
MLIRIR MLIRIR
MLIRSPIRV MLIRSPIRV
MLIRSupport) MLIRSupport
MLIRTranslation)

mlir/lib/Dialect/VectorOps/CMakeLists.txt

add_llvm_library(MLIRVectorOps add_llvm_library(MLIRVectorOps STATIC
DialectRegistration.cpp DialectRegistration.cpp
VectorOps.cpp VectorOps.cpp
VectorTransforms.cpp VectorTransforms.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/VectorOps ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/VectorOps
) )
add_dependencies(MLIRVectorOps MLIRVectorOpsIncGen) add_dependencies(MLIRVectorOps MLIRVectorOpsIncGen)
add_dependencies(MLIRVectorOps MLIRVectorTransformPatternsIncGen) add_dependencies(MLIRVectorOps MLIRVectorTransformPatternsIncGen)
target_link_libraries(MLIRVectorOps MLIRIR) target_link_libraries(MLIRVectorOps MLIRAnalysis MLIRIR MLIRStandardOps)

mlir/lib/EDSC/CMakeLists.txt

Show All 9 Linesadd_llvm_library(MLIREDSC
Helpers.cpp Helpers.cpp
Intrinsics.cpp Intrinsics.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/EDSC ${MLIR_MAIN_INCLUDE_DIR}/mlir/EDSC
) )
target_link_libraries(MLIREDSC target_link_libraries(MLIREDSC
PUBLIC PUBLIC
MLIRAffineOps MLIRAffineOps
MLIRIR
MLIRLoopOps MLIRLoopOps
MLIRStandardOps MLIRStandardOps
MLIRSupport
MLIRTransformUtils MLIRTransformUtils
MLIRVectorOps MLIRVectorOps
) )
add_llvm_library(MLIREDSCInterface add_llvm_library(MLIREDSCInterface
CoreAPIs.cpp CoreAPIs.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/EDSC ${MLIR_MAIN_INCLUDE_DIR}/mlir/EDSC
) )
add_dependencies(MLIREDSCInterface MLIRIR) add_dependencies(MLIREDSCInterface MLIRIR)
target_link_libraries(MLIREDSC target_link_libraries(MLIREDSCInterface
PUBLIC PUBLIC
MLIRIR MLIRIR
MLIRSupport MLIRSupport
MLIRParser MLIRParser
) )

mlir/lib/ExecutionEngine/CMakeLists.txt

llvm_map_components_to_libnames(outlibs "nativecodegen" "IPO") llvm_map_components_to_libnames(outlibs "nativecodegen" "IPO")
add_llvm_library(MLIRExecutionEngine add_llvm_library(MLIRExecutionEngine
ExecutionEngine.cpp ExecutionEngine.cpp
OptUtils.cpp OptUtils.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/ExecutionEngine ${MLIR_MAIN_INCLUDE_DIR}/mlir/ExecutionEngine
) )
target_link_libraries(MLIRExecutionEngine target_link_libraries(MLIRExecutionEngine
MLIRLLVMIR MLIRLLVMIR
MLIRTargetLLVMIR MLIRTargetLLVMIR
LLVMBitReader LLVMBitReader
LLVMBitWriter LLVMBitWriter
LLVMExecutionEngine LLVMExecutionEngine
LLVMOrcJIT LLVMOrcJIT
LLVMJITLink
LLVMSupport LLVMSupport
LLVMAnalysis
LLVMAggressiveInstCombine
LLVMInstCombine
LLVMMC
LLVMScalarOpts
LLVMTarget
LLVMVectorize
LLVMTransformUtils LLVMTransformUtils
${outlibs}) ${outlibs})

mlir/lib/Quantizer/CMakeLists.txt

# Support. # Support.
add_llvm_library(MLIRQuantizerSupport add_llvm_library(MLIRQuantizerSupport
Support/Configuration.cpp Support/Configuration.cpp
Support/ConstraintAnalysisGraph.cpp Support/ConstraintAnalysisGraph.cpp
Support/Metadata.cpp Support/Metadata.cpp
Support/Statistics.cpp Support/Statistics.cpp
Support/TypeUtils.cpp Support/TypeUtils.cpp
Support/UniformConstraints.cpp Support/UniformConstraints.cpp
Support/UniformSolvers.cpp Support/UniformSolvers.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
)
add_dependencies(MLIRQuantizerSupport LINK_LIBS
MLIRIR MLIRIR
MLIRQuantOps MLIRQuantOps
MLIRSupport MLIRSupport
MLIRStandardOps) MLIRStandardOps
LLVMSupport
)
# Configurations. # Configurations.
add_llvm_library(MLIRQuantizerFxpMathConfig add_llvm_library(MLIRQuantizerFxpMathConfig
Configurations/FxpMathConfig.cpp Configurations/FxpMathConfig.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
LINK_LIBS
MLIRIR
MLIRFxpMathOps
MLIRQuantOps
MLIRQuantizerSupport
) )
add_dependencies(MLIRQuantizerFxpMathConfig add_dependencies(MLIRQuantizerFxpMathConfig
MLIRFxpMathOpsIncGen MLIRFxpMathOpsIncGen
MLIRQuantizerSupport) )
# Transforms. # Transforms.
add_llvm_library(MLIRQuantizerTransforms add_llvm_library(MLIRQuantizerTransforms
Transforms/AddDefaultStatsTestPass.cpp Transforms/AddDefaultStatsTestPass.cpp
Transforms/InferQuantizedTypesPass.cpp Transforms/InferQuantizedTypesPass.cpp
Transforms/RemoveInstrumentationPass.cpp Transforms/RemoveInstrumentationPass.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
) )
add_dependencies(MLIRQuantizerTransforms
MLIRQuantizerFxpMathConfig
MLIRQuantizerSupport
MLIRPass)
target_link_libraries(MLIRQuantizerTransforms target_link_libraries(MLIRQuantizerTransforms
MLIRIR
MLIRQuantizerFxpMathConfig MLIRQuantizerFxpMathConfig
MLIRQuantizerSupport MLIRQuantizerSupport
MLIRPass) MLIRQuantOps
MLIRPass
LLVMSupport)

mlir/lib/Support/CMakeLists.txt

Show All 19 Lines
add_llvm_library(MLIROptMain add_llvm_library(MLIROptMain
MlirOptMain.cpp MlirOptMain.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Support ${MLIR_MAIN_INCLUDE_DIR}/mlir/Support
) )
target_link_libraries(MLIROptMain target_link_libraries(MLIROptMain
MLIRPass MLIRPass
MLIRParser
LLVMSupport LLVMSupport
MLIRSupport MLIRSupport
) )
add_llvm_library(MLIRTranslateClParser add_llvm_library(MLIRTranslateClParser
TranslateClParser.cpp TranslateClParser.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Support ${MLIR_MAIN_INCLUDE_DIR}/mlir/Support
) )
target_link_libraries(MLIRTranslateClParser LLVMSupport) target_link_libraries(MLIRTranslateClParser LLVMSupport MLIRIR MLIRTranslation MLIRParser)
add_llvm_library(MLIRJitRunner add_llvm_library(MLIRJitRunner
JitRunner.cpp JitRunner.cpp
) )
target_link_libraries(MLIRJitRunner PRIVATE target_link_libraries(MLIRJitRunner PRIVATE
MLIRExecutionEngine MLIRExecutionEngine
MLIRIR MLIRIR
MLIRParser MLIRParser
MLIRStandardOps MLIRStandardOps
MLIRTargetLLVMIR MLIRTargetLLVMIR
MLIRTransforms MLIRTransforms
MLIRStandardToLLVM MLIRStandardToLLVM
MLIRSupport MLIRSupport
LLVMCore LLVMCore
LLVMSupport LLVMSupport
) )

mlir/test/lib/IR/CMakeLists.txt

add_llvm_library(MLIRTestIR add_llvm_library(MLIRTestIR
TestFunc.cpp TestFunc.cpp
TestMatchers.cpp TestMatchers.cpp
TestSymbolUses.cpp TestSymbolUses.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
LINK_LIBS MLIRPass
) )
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../TestDialect) include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../TestDialect)
include_directories(${CMAKE_CURRENT_BINARY_DIR}/../TestDialect) include_directories(${CMAKE_CURRENT_BINARY_DIR}/../TestDialect)
add_dependencies(MLIRTestIR add_dependencies(MLIRTestIR
MLIRTestDialect MLIRTestDialect
) )
target_link_libraries(MLIRTestIR
MLIRPass
)

mlir/test/lib/Pass/CMakeLists.txt

add_llvm_library(MLIRTestPass add_llvm_library(MLIRTestPass
TestPassManager.cpp TestPassManager.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Pass ${MLIR_MAIN_INCLUDE_DIR}/mlir/Pass
)
target_link_libraries(MLIRTestPass LINK_LIBS
MLIRIR MLIRIR
MLIRPass MLIRPass
) )

mlir/test/lib/TestDialect/CMakeLists.txt

set(LLVM_OPTIONAL_SOURCES set(LLVM_OPTIONAL_SOURCES
TestDialect.cpp TestDialect.cpp
TestPatterns.cpp TestPatterns.cpp
) )
set(LLVM_TARGET_DEFINITIONS TestOps.td) set(LLVM_TARGET_DEFINITIONS TestOps.td)
mlir_tablegen(TestOps.h.inc -gen-op-decls) mlir_tablegen(TestOps.h.inc -gen-op-decls)
mlir_tablegen(TestOps.cpp.inc -gen-op-defs) mlir_tablegen(TestOps.cpp.inc -gen-op-defs)
mlir_tablegen(TestOpEnums.h.inc -gen-enum-decls) mlir_tablegen(TestOpEnums.h.inc -gen-enum-decls)
mlir_tablegen(TestOpEnums.cpp.inc -gen-enum-defs) mlir_tablegen(TestOpEnums.cpp.inc -gen-enum-defs)
mlir_tablegen(TestPatterns.inc -gen-rewriters) mlir_tablegen(TestPatterns.inc -gen-rewriters)
add_public_tablegen_target(MLIRTestOpsIncGen) add_public_tablegen_target(MLIRTestOpsIncGen)
add_llvm_library(MLIRTestDialect add_llvm_library(MLIRTestDialect
TestDialect.cpp TestDialect.cpp
TestPatterns.cpp TestPatterns.cpp
LINK_LIBS
MLIRDialect
MLIRIR
MLIRLinalgTransforms
MLIRPass
MLIRTransforms
MLIRTransformUtils
LLVMSupport
) )
add_dependencies(MLIRTestDialect add_dependencies(MLIRTestDialect
MLIRTestOpsIncGen MLIRTestOpsIncGen
MLIRIR
LLVMSupport
MLIRTypeInferOpInterfaceIncGen MLIRTypeInferOpInterfaceIncGen
) )
target_link_libraries(MLIRTestDialect
MLIRDialect
MLIRIR
LLVMSupport
)

mlir/test/lib/Transforms/CMakeLists.txt

Show All 10 Linesadd_llvm_library(MLIRTestTransforms
TestOpaqueLoc.cpp TestOpaqueLoc.cpp
TestMemRefStrideCalculation.cpp TestMemRefStrideCalculation.cpp
TestVectorToLoopsConversion.cpp TestVectorToLoopsConversion.cpp
TestVectorTransforms.cpp TestVectorTransforms.cpp
TestVectorizationUtils.cpp TestVectorizationUtils.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${MLIR_MAIN_INCLUDE_DIR}/mlir/Transforms ${MLIR_MAIN_INCLUDE_DIR}/mlir/Transforms
)
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../TestDialect) LINK_LIBS
include_directories(${CMAKE_CURRENT_BINARY_DIR}/../TestDialect)
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../DeclarativeTransforms)
include_directories(${CMAKE_CURRENT_BINARY_DIR}/../DeclarativeTransforms)
add_dependencies(MLIRTestTransforms MLIRStandardOpsIncGen)
add_dependencies(MLIRTestTransforms MLIRTestLinalgTransformPatternsIncGen)
add_dependencies(MLIRTestTransforms MLIRTestVectorTransformPatternsIncGen)
target_link_libraries(MLIRTestTransforms
MLIRAffineOps MLIRAffineOps
MLIRAnalysis MLIRAnalysis
MLIREDSC MLIREDSC
MLIRGPU MLIRGPU
MLIRLinalgOps MLIRLinalgOps
MLIRLinalgTransforms MLIRLinalgTransforms
MLIRLoopOps MLIRLoopOps
MLIRPass MLIRPass
MLIRTestDialect MLIRTestDialect
MLIRTransformUtils
MLIRVectorToLoops
MLIRVectorOps MLIRVectorOps
) )
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../TestDialect)
include_directories(${CMAKE_CURRENT_BINARY_DIR}/../TestDialect)
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/../DeclarativeTransforms)
include_directories(${CMAKE_CURRENT_BINARY_DIR}/../DeclarativeTransforms)
add_dependencies(MLIRTestTransforms MLIRStandardOpsIncGen)
add_dependencies(MLIRTestTransforms MLIRTestLinalgTransformPatternsIncGen)
add_dependencies(MLIRTestTransforms MLIRTestVectorTransformPatternsIncGen)

mlir/tools/mlir-opt/CMakeLists.txt

set(LLVM_OPTIONAL_SOURCES set(LLVM_OPTIONAL_SOURCES
null.cpp null.cpp
) )
set(LIB_LIBS set(LIB_LIBS
MLIRAnalysis MLIRAnalysis
MLIRLLVMIR MLIRLLVMIR
MLIROptMain
MLIRParser MLIRParser
MLIRPass MLIRPass
MLIRTransforms MLIRTransforms
MLIRSupport MLIRSupport
) )
add_llvm_library(MLIRMlirOptLib add_llvm_library(MLIRMlirOptLib
mlir-opt.cpp mlir-opt.cpp
LINK_LIBS ${LIB_LIBS}
) )
target_link_libraries(MLIRMlirOptLib ${LIB_LIBS})
set(LIBS set(LIBS
MLIRAnalysis MLIRAnalysis
MLIRAffineOps MLIRAffineOps
MLIRAffineToStandard MLIRAffineToStandard
MLIRDialect
MLIRLoopsToGPU MLIRLoopsToGPU
MLIRLinalgToLLVM MLIRLinalgToLLVM
MLIRLoopToStandard MLIRLoopToStandard
MLIREDSC MLIREDSC
MLIRFxpMathOps MLIRFxpMathOps
MLIRGPU MLIRGPU
MLIRGPUtoNVVMTransforms MLIRGPUtoNVVMTransforms
MLIRGPUtoROCDLTransforms MLIRGPUtoROCDLTransforms
MLIRGPUtoSPIRVTransforms MLIRGPUtoSPIRVTransforms
MLIRLinalgOps MLIRLinalgOps
MLIRLinalgAnalysis
MLIRLinalgEDSC
MLIRLinalgTransforms
MLIRLinalgUtils
MLIRLLVMIR MLIRLLVMIR
MLIRLoopOps MLIRLoopOps
MLIRNVVMIR MLIRNVVMIR
MLIROptMain MLIROptMain
MLIRParser MLIRParser
MLIRPass MLIRPass
MLIRQuantizerFxpMathConfig
MLIRQuantizerSupport
MLIRQuantizerTransforms MLIRQuantizerTransforms
MLIRQuantOps MLIRQuantOps
MLIRROCDLIR MLIRROCDLIR
MLIRSPIRV MLIRSPIRV
MLIRStandardToSPIRVTransforms MLIRStandardToSPIRVTransforms
MLIRSPIRVTestPasses MLIRSPIRVTestPasses
MLIRSPIRVTransforms MLIRSPIRVTransforms
MLIRStandardOps MLIRStandardOps
MLIRStandardToLLVM MLIRStandardToLLVM
MLIRTransforms MLIRTransforms
MLIRTransformUtils
MLIRTestDialect MLIRTestDialect
MLIRTestIR MLIRTestIR
MLIRTestPass MLIRTestPass
MLIRTestTransforms MLIRTestTransforms
MLIRSupport MLIRSupport
MLIRVectorOps MLIRVectorOps
MLIRVectorToLLVM MLIRVectorToLLVM
MLIRVectorToLoops MLIRVectorToLoops
) )
if(MLIR_CUDA_CONVERSIONS_ENABLED) if(MLIR_CUDA_CONVERSIONS_ENABLED)
list(APPEND LIBS list(APPEND LIBS
MLIRGPUtoCUDATransforms MLIRGPUtoCUDATransforms
) )
endif() endif()
add_llvm_tool(mlir-opt add_llvm_tool(mlir-opt
mlir-opt.cpp mlir-opt.cpp
) )
llvm_update_compile_flags(mlir-opt) llvm_update_compile_flags(mlir-opt)
# It is necessary to use whole_archive_link to ensure that all static
# initializers are called. However, whole_archive_link libraries cannot
# also be target_link_libraries
whole_archive_link(mlir-opt ${LIBS}) whole_archive_link(mlir-opt ${LIBS})
target_link_libraries(mlir-opt PRIVATE MLIRIR MLIRMlirOptLib ${LIBS} LLVMSupport) target_link_libraries(mlir-opt PRIVATE MLIRIR MLIROptMain LLVMSupport LLVMCore LLVMAsmParser)