Page MenuHomePhabricator

Add -Wrange-loop-analysis changes to ReleaseNotes

Authored by Mordante on Jan 11 2020, 10:09 AM.



This reflects the recent changes done.

Diff Detail

Event Timeline

Mordante created this revision.Jan 11 2020, 10:09 AM

Unit tests: pass. 61772 tests passed, 0 failed and 780 were skipped.

clang-tidy: fail. Please fix clang-tidy findings.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

aaron.ballman accepted this revision.Jan 11 2020, 10:45 AM

LGTM with some suggestions.


small trivially copyable -> small, trivially copyable


I'd fold this in to the previous bullet.

This revision is now accepted and ready to land.Jan 11 2020, 10:45 AM
Mordante marked 2 inline comments as done.Jan 11 2020, 10:55 AM

Thanks for the review!

Mordante closed this revision.Jan 12 2020, 11:04 AM

Committed as

I accidentally forgot to add the revision id.