This is an archive of the discontinued LLVM Phabricator instance.

Differential D72287

[OpenMP] Fix incorrect property of __has_attribute() macro
ClosedPublic

Authored by kiszk on Jan 6 2020, 9:50 AM.

Details

Reviewers
jdoerfert
Commits
rG19433b199d1c: [OpenMP] Fix incorrect property of __has_attribute() macro
Summary

__has_attribute(fallthough) -> __has_attribute(fallthrough)

Diff Detail

Event Timeline

kiszk created this revision.Jan 6 2020, 9:50 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptJan 6 2020, 9:50 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: openmp-commits, guansong. · View Herald Transcript
Harbormaster completed remote builds in B43354: Diff 236400.Jan 6 2020, 9:56 AM
jdoerfert accepted this revision.Jan 6 2020, 10:31 AM

LGTM.

This revision is now accepted and ready to land.Jan 6 2020, 10:31 AM
kiszk added a comment.Jan 6 2020, 10:44 AM

Thank you.
I do not have commit rights to the repository yet. Could someone commit this change if it is OK?
Kazuaki Ishizaki <ishizaki@jp.ibm.com>

Closed by commit rG19433b199d1c: [OpenMP] Fix incorrect property of __has_attribute() macro (authored by kkwli0). · Explain WhyJan 6 2020, 12:14 PM
This revision was automatically updated to reflect the committed changes.
Hahnfeld added subscribers: mclow.lists, ldionne, EricWF, Hahnfeld.Jan 6 2020, 12:15 PM

Can you please also submit a patch to libc++ where we copied this code from?

kiszk added a comment.Jan 6 2020, 9:35 PM

Sure, I will do this today.

kiszk added a comment.Jan 6 2020, 9:51 PM

Created https://reviews.llvm.org/D72314

kiszk added a comment.Jan 7 2020, 6:45 AM

The immediate succeeding test was failed at http://lab.llvm.org:8011/builders/openmp-gcc-x86_64-linux-debian/builds/1710, but other tests were passed at http://lab.llvm.org:8011/builders/openmp-gcc-x86_64-linux-debian/builds/1711

Revision Contents

PathSize
openmp/
runtime/
src/
2 lines

Diff 236433

openmp/runtime/src/kmp_os.h

Show First 20 Lines • Show All 307 Lines • ▼ Show 20 Lines
// Define attribute that indicates that the fall through from the previous // Define attribute that indicates that the fall through from the previous
// case label is intentional and should not be diagnosed by a compiler // case label is intentional and should not be diagnosed by a compiler
// Code from libcxx/include/__config // Code from libcxx/include/__config
// Use a function like macro to imply that it must be followed by a semicolon // Use a function like macro to imply that it must be followed by a semicolon
#if __cplusplus > 201402L && __has_cpp_attribute(fallthrough) #if __cplusplus > 201402L && __has_cpp_attribute(fallthrough)
# define KMP_FALLTHROUGH() [[fallthrough]] # define KMP_FALLTHROUGH() [[fallthrough]]
#elif __has_cpp_attribute(clang::fallthrough) #elif __has_cpp_attribute(clang::fallthrough)
# define KMP_FALLTHROUGH() [[clang::fallthrough]] # define KMP_FALLTHROUGH() [[clang::fallthrough]]
#elif __has_attribute(fallthough) || __GNUC__ >= 7 #elif __has_attribute(fallthrough) || __GNUC__ >= 7
# define KMP_FALLTHROUGH() __attribute__((__fallthrough__)) # define KMP_FALLTHROUGH() __attribute__((__fallthrough__))
#else #else
# define KMP_FALLTHROUGH() ((void)0) # define KMP_FALLTHROUGH() ((void)0)
#endif #endif
// Define attribute that indicates a function does not return // Define attribute that indicates a function does not return
#if __cplusplus >= 201103L #if __cplusplus >= 201103L
#define KMP_NORETURN [[noreturn]] #define KMP_NORETURN [[noreturn]]
▲ Show 20 Lines • Show All 717 Lines • Show Last 20 Lines