This is an archive of the discontinued LLVM Phabricator instance.

[llvm/DWARF] Return section offset from DWARFUnit::get{Loc,Rng}listOffset
ClosedPublic

Authored by labath on Dec 4 2019, 5:08 AM.

Details

Summary

Currently these function return the raw content of the appropriate table
header, which means they are relative to the DW_AT_{loc,rng}list_base,
and one has to relocate them in order to do anything.

This changes the functions to perform the relocation themselves, which
seems more clearer, particularly as they are sitting right next to the
find{Rng,Loc}listFromOffset functions, but one *cannot* simply take the
result of these functions and take pass them there.

The only effect of this patch is to change what value is dumped for the
DW_AT_ranges attribute, which I think is for the better, as previously
the values appeared to point into thin air.

(The main reason I am looking at this is because I was trying to
implement equivalent functionality in lldb's DWARFUnit, and was stumped
by this behavior.

Event Timeline

labath created this revision.Dec 4 2019, 5:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 4 2019, 5:08 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
dblaikie accepted this revision.Dec 4 2019, 5:26 AM

Makes total sense - looks good.

This revision is now accepted and ready to land.Dec 4 2019, 5:26 AM
This revision was automatically updated to reflect the committed changes.