This is an archive of the discontinued LLVM Phabricator instance.

hwasan: add tag_offset DWARF attribute to optimized debug info
ClosedPublic

Authored by eugenis on Nov 26 2019, 4:39 PM.

Details

Summary

Support alloca-referencing dbg.value in hwasan instrumentation.
Update AsmPrinter to emit DW_AT_LLVM_tag_offset when location is in
loclist format.

Event Timeline

eugenis created this revision.Nov 26 2019, 4:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 26 2019, 4:39 PM
aprantl added inline comments.Dec 2 2019, 11:22 AM
llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h
121

///

llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
1049

DIExpression::prependOpcodes()?

eugenis marked 2 inline comments as done.Dec 4 2019, 4:28 PM

PTAL

Harbormaster completed remote builds in B41893: Diff 232234.
pcc accepted this revision.Dec 10 2019, 12:25 PM

LGTM

This revision is now accepted and ready to land.Dec 10 2019, 12:25 PM
This revision was automatically updated to reflect the committed changes.
dblaikie added inline comments.
llvm/test/CodeGen/AArch64/dbg-value-tag-offset.ll
6–16

Usually DWARF is tested with dwarfdump, not raw assembly - is there a reason this isn't tested that way?

eugenis marked an inline comment as done.Dec 27 2019, 2:32 PM
eugenis added inline comments.
llvm/test/CodeGen/AArch64/dbg-value-tag-offset.ll
6–16

I've cargo-culted the dbg-declare-tag-offset.ll test by @pcc .
This should not be too hard to switch to llvm-dwarfdump.