This is an archive of the discontinued LLVM Phabricator instance.

Change dbg-*-tag-offset tests to use llvm-dwarfdump.
ClosedPublic

Authored by eugenis on Dec 30 2019, 6:09 PM.

Diff Detail

Event Timeline

eugenis created this revision.Dec 30 2019, 6:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 30 2019, 6:09 PM

Unit tests: pass. 61155 tests passed, 0 failed and 728 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Might want to use CHECK-NEXT as you were before and/or maybe some CHECK-NOT: DW_TAG between the TAG/AT/AT triples, to make sure you aren't checking attributes in some unintended TAG, etc.

eugenis updated this revision to Diff 235939.Jan 2 2020, 1:34 PM

tighten the test with CHECK-NOT

Unit tests: fail. 61174 tests passed, 1 failed and 729 were skipped.

failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_class/try_lock.pass.cpp

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

dblaikie accepted this revision.Jan 2 2020, 2:09 PM
dblaikie added inline comments.
llvm/test/CodeGen/AArch64/dbg-declare-tag-offset.ll
6–13

Oh, I'd probably use "CHECK-NOT: DW_TAG", FWIW. (because you're interested in these tags being attached to a DW_TAG_variable, not some other tag)

This revision is now accepted and ready to land.Jan 2 2020, 2:09 PM
eugenis marked an inline comment as done.Jan 2 2020, 2:33 PM
eugenis added inline comments.
llvm/test/CodeGen/AArch64/dbg-declare-tag-offset.ll
6–13

right, of course

This revision was automatically updated to reflect the committed changes.

Unit tests: pass. 61175 tests passed, 0 failed and 729 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml