Adds tests necessary to properly show the impact of other patches that affect the emission of CFI directives.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
I think the two TODOs will get lost if they're in the test files, they should go near the top of a .cpp file where the missing functions are implemented.
Otherwise, two minor nits.
llvm/test/CodeGen/RISCV/frame-info.ll | ||
---|---|---|
5 | Can you add a rv64 test with frame pointers too? Given the assertions are auto-generated, more coverage is better. | |
176 | This TODO should not go into the tests, it should go into the implementation. | |
295–297 | Please can we give these functions more descriptive names? | |
llvm/test/CodeGen/RISCV/vararg.ll | ||
1766 | This TODO should go into RISCVFrameLowering.cpp, not the tests. |
llvm/test/CodeGen/RISCV/vararg.ll | ||
---|---|---|
1766 | This was actually not a split-sp issue, but a more general issue of constant materialization of stack addresses. Updated the comment. Given the broader scope, I'm letting it remain simply as a test comment. |
Can you add a rv64 test with frame pointers too? Given the assertions are auto-generated, more coverage is better.