Page MenuHomePhabricator

Prune include of DataLayout.h from include/clang/Basic/TargetInfo.h. NFC
ClosedPublic

Authored by bjope on Oct 21 2019, 7:57 AM.

Details

Summary

Use a forward declaration of DataLayout instead of including
DataLayout.h in clangs TargetInfo.h. This reduces include
dependencies toward DataLayout.h (and other headers such as
DerivedTypes.h, Type.h that is included by DataLayout.h).

Needed to move implemantation of TargetInfo::resetDataLayout
from TargetInfo.h to TargetInfo.cpp.

Diff Detail

Event Timeline

bjope created this revision.Oct 21 2019, 7:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 21 2019, 7:57 AM
rnk accepted this revision.Oct 21 2019, 9:53 AM

lgtm

It's interesting that Basic depends on IR at all.

This revision is now accepted and ready to land.Oct 21 2019, 9:53 AM
This revision was automatically updated to reflect the committed changes.