This combine showed up as needed when exploring the regression when processing the DAG in topological order.
Okay, this seems pretty unusual, but correct.
Would be good for @RKSimon to take a look, but LGTM.
I don't have comments as to the algorithm, but i find
the comments/variable names to be somewhat confusing.
|16472–16473 ↗||(On Diff #226092)|
... where shuffle operands may be CONCAT_VECTORS.
|16478 ↗||(On Diff #226092)|
I forget, by now Mask.size() == Vec.getValueType().getVectorNumElements()?
|16487 ↗||(On Diff #226092)|
This is no longer X offset, this is what was most confusing to me.
|16513–16514 ↗||(On Diff #226092)|
I think this needs a defensive/explanatory assert that by the end
Alright, this is the first time I have to commit something with the new github process, and I have to admit, I do not know how to do it - or if I can do it at all. Running git llvm push ask me for a username and password, and my old one do not work. What's the next step for me here?
Did you ever pushed anything to github before, to any other repository?
Did you clone https://github.com/llvm/llvm-project/ via HTTPS or SSH? (should be former!)
It is likely asking for your github login and password.
You may *really* want to follow https://help.github.com/en/github/authenticating-to-github/creating-a-personal-access-token-for-the-command-line to create credentials with which you can *only* commit, but do nothing else
Thanks for helping me out here. So I did commit on LLVM using the pre-github workflow (using git-svn), and did commit to github before in my own projects. I did not yet use the intersection of the two.
Here is what I'm getting when I'm trying to push that patch:
$ git llvm push `git fetch https://github.com/llvm/llvm-project.git master` printed to stderr: From https://github.com/llvm/llvm-project * branch master -> FETCH_HEAD Pushing 1 commit: 0252f080c7c [DAGCombiner] Peek through vector concats when trying to combine shuffles. Username for 'https://github.com': deadalnix Password for 'https://firstname.lastname@example.org': `git push https://github.com/llvm/llvm-project.git 0252f080c7c01e7493c7d6c9bb9ed8701469c4a8:master` returned 128 remote: Permission to llvm/llvm-project.git denied to deadalnix. fatal: unable to access 'https://github.com/llvm/llvm-project.git/': The requested URL returned error: 403
I tried to generate a token as suggested, and tried different permission settings for the token, including granting all permission to make sure there wasn't something I was missing, and I always get the same result.
I cant find your nick here: https://llvm.org/viewvc/llvm-project/meta/trunk/github-usernames.txt?view=markup .
"If you had commit access to SVN and would like to request commit access to GitHub, please email llvm-admin with your SVN username and GitHub username."