Page MenuHomePhabricator

[DAGCombiner] Peek through vector concats when trying to combine shuffles.
Needs ReviewPublic

Authored by deadalnix on Sep 29 2019, 11:01 AM.

Details

Summary

This combine showed up as needed when exploring the regression when processing the DAG in topological order.

Diff Detail

Event Timeline

deadalnix created this revision.Sep 29 2019, 11:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 29 2019, 11:01 AM

Rebase and ping.

This is desperately missing some comments explaining what is going on.

deadalnix updated this revision to Diff 226018.Tue, Oct 22, 4:03 AM

Add a few comments

xbolva00 added inline comments.
lib/CodeGen/SelectionDAG/DAGCombiner.cpp
16510

SDValue Op :

?

16512

O is similar to 0.

So ‘Op’?