Page MenuHomePhabricator

[FileCheck] Remove implementation types from API
ClosedPublic

Authored by thopre on Sep 28 2019, 3:52 PM.

Details

Summary

Remove use of FileCheckPatternContext and FileCheckString concrete types
from FileCheck API to allow moving it and the other implementation only
only declarations into a private header file.

Diff Detail

Event Timeline

thopre created this revision.Sep 28 2019, 3:52 PM
jhenderson accepted this revision.Sep 30 2019, 4:29 AM

LGTM, with a couple of minor nits.

llvm/include/llvm/Support/FileCheck.h
732

Why not C++17?

736–737

Should this be explicit?

This revision is now accepted and ready to land.Sep 30 2019, 4:29 AM
thopre updated this revision to Diff 222424.Sep 30 2019, 7:06 AM
thopre marked 2 inline comments as done.

Address feedback

This revision was automatically updated to reflect the committed changes.