Page MenuHomePhabricator

[FileCheck] Remove llvm:: prefix
ClosedPublic

Authored by thopre on May 23 2019, 8:47 AM.

Details

Summary

Remove all llvm:: prefixes in FileCheck library header and implementation except for calls to make_unique since both files already use the llvm namespace.

Diff Detail

Repository
rL LLVM

Event Timeline

thopre created this revision.May 23 2019, 8:47 AM
probinson accepted this revision.May 23 2019, 9:02 AM

LGTM, although I commonly see llvm::make_unique to document that we are specifically not using the std:: one. On occasion it is actually ambiguous.

This revision is now accepted and ready to land.May 23 2019, 9:02 AM
thopre updated this revision to Diff 200997.May 23 2019, 9:15 AM

Reintroduce llvm:: prefix for calls to make_unique

thopre edited the summary of this revision. (Show Details)May 23 2019, 9:16 AM
thopre edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.