Page MenuHomePhabricator

[FileCheck] Stop qualifying expressions as numeric
ClosedPublic

Authored by thopre on Jun 18 2019, 9:50 AM.

Details

Summary

Stop referring to "numeric expression", using simply the term
"expression" instead. Likewise for numeric operation since operations
are only used in numeric expressions.

Diff Detail

Repository
rL LLVM

Event Timeline

thopre created this revision.Jun 18 2019, 9:50 AM

I think this is a definite improvement in readability, once you fix the two places that seem to have lost a line of commentary.

llvm/docs/CommandGuide/FileCheck.rst
599 ↗(On Diff #205380)

Some sort of mis-edit here.

llvm/include/llvm/Support/FileCheck.h
472 ↗(On Diff #205380)

Looks like a line was lost by accident?

thopre updated this revision to Diff 205456.Jun 18 2019, 3:42 PM

Add back line removed in bad conflict resolution

thopre updated this revision to Diff 205482.Jun 18 2019, 5:41 PM
thopre marked an inline comment as done.

Re-add line erroneously removed in interactive git add session

This revision is now accepted and ready to land.Jun 19 2019, 6:57 AM
This revision was automatically updated to reflect the committed changes.