This is an archive of the discontinued LLVM Phabricator instance.

lld-link: Let LLD_REPRODUCE control /linkrepro:, like in ld.lld
ClosedPublic

Authored by thakis on Sep 18 2019, 6:50 AM.

Details

Summary

Also sync help texts for the option between elf and coff ports.

Decisions:

  • Do this even if /lldignoreenv is passed. /linkrepro: does not affect the main output, and this makes the env var more convenient to use. (On the other hand, it's now possible to set this env var and forget about it, and all future builds in the same shell will be much slower. That's true for ld.lld, but posix shells have an easy way to set an env var for a single command; in cmd.exe this is not possible without contortions. Then again, lld-link runs in posix shells too.)
  • Call the env var LLD_REPRODUCE like in ld.lld even though the flag is called /linkrepro: instead of --reproduce in lld-link.

Diff Detail

Event Timeline

thakis created this revision.Sep 18 2019, 6:50 AM
Herald added a project: Restricted Project. · View Herald Transcript
ruiu accepted this revision.Sep 26 2019, 4:27 AM

LGTM

This revision is now accepted and ready to land.Sep 26 2019, 4:27 AM