Page MenuHomePhabricator

[Sema] Introduce function reference conversion, NFC
Needs ReviewPublic

Authored by aaronpuchert on Sep 3 2019, 10:30 AM.

Details

Reviewers
rsmith
pcc
Summary

Technically 'noexcept' isn't a qualifier, so this should be a separate conversion.

Also add a pure AST test for the conversion.

Diff Detail

Event Timeline

aaronpuchert created this revision.Sep 3 2019, 10:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 3 2019, 10:30 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
aaronpuchert marked 2 inline comments as done.Sep 3 2019, 10:33 AM

If anyone shares my feeling that the boolean output parameters of CompareReferenceRelationship should rather move to the return value, I would be happy to do that.

clang/test/CXX/dcl.decl/dcl.init/dcl.init.ref/p4-ast.cpp
6

This is new.

16

This is also new.

Perhaps I should mention that this fixes an assertion failure.

aaronpuchert planned changes to this revision.Oct 8 2019, 12:53 PM

If anyone shares my feeling that the boolean output parameters of CompareReferenceRelationship should rather move to the return value, I would be happy to do that.

I'll do that in a separate change and then rebase this on top.

aaronpuchert abandoned this revision.Dec 5 2019, 6:25 PM

Already fixed via D66437.

aaronpuchert reclaimed this revision.Feb 26 2020, 5:12 PM
aaronpuchert removed a reviewer: riccibruno.

The diff between both changes might still be interesting.

Rebase on top of D66437.

aaronpuchert retitled this revision from [Sema] Add implicit cast for conversion of function references to [Sema] Introduce function reference conversion.Feb 26 2020, 5:53 PM
aaronpuchert edited the summary of this revision. (Show Details)
aaronpuchert added a reviewer: pcc.
aaronpuchert retitled this revision from [Sema] Introduce function reference conversion to [Sema] Introduce function reference conversion, NFC.Apr 22 2020, 5:10 PM

@rsmith, what do you think about this?