This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Implementing overflow version for XO-Form instructions
ClosedPublic

Authored by kamaub on Aug 28 2019, 1:03 PM.

Details

Summary

The Overflow version of XO-Form instruction uses the SO, OV and
OV32 special registers.

This changes modifies existing multiclasses and instruction
definitions to allow for the use of the XER register to record
the various types if overflow from possible add, subtract and
multiply instructions. It then modifies the existing instructions
as to use these multiclasses as needed.

Diff Detail

Event Timeline

kamaub created this revision.Aug 28 2019, 1:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2019, 1:03 PM
kamaub updated this revision to Diff 217706.Aug 28 2019, 1:07 PM

Adding reviewers as part of the testing for arcanist

amyk accepted this revision.Sep 3 2019, 5:29 PM
amyk added a subscriber: amyk.

I think this overall LGTM.

llvm/lib/Target/PowerPC/PPCInstrInfo.td
1033

Space after //.

llvm/test/MC/PowerPC/ppc64-encoding.s
342–347

I would say it is better to make the # encoding lines in line with the others, for consistency.

This revision is now accepted and ready to land.Sep 3 2019, 5:29 PM
kamaub updated this revision to Diff 220499.EditedSep 17 2019, 7:15 AM

Fixed the spacing issues with the mutliclass comments and in the test cases as requested @amyk

kamaub marked 2 inline comments as done.Sep 17 2019, 7:18 AM
hfinkel accepted this revision.Sep 17 2019, 8:56 AM

LGTM too.

This revision was automatically updated to reflect the committed changes.