Page MenuHomePhabricator

[ARM] Select vmla
ClosedPublic

Authored by samtebbs on Aug 15 2019, 8:17 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

samtebbs created this revision.Aug 15 2019, 8:17 AM
dmgreen added inline comments.Mon, Aug 19, 1:36 AM
llvm/lib/Target/ARM/ARMInstrMVE.td
3769 ↗(On Diff #215405)

MQPR :) Can you also try to format this line to be a little shorter.

llvm/test/CodeGen/ARM/vmla-mve.ll
1 ↗(On Diff #215405)

Can you move this to test/CodeGen/Thumb2/mve-vmla.ll

11 ↗(On Diff #215405)

Do these still select if the operands are reversed? It may be worth adding a few tests to show that.

samtebbs updated this revision to Diff 218314.Mon, Sep 2, 2:14 AM
samtebbs marked 3 inline comments as done.
samparker added inline comments.Mon, Sep 2, 5:36 AM
llvm/lib/Target/ARM/ARMInstrMVE.td
3784 ↗(On Diff #218314)

We shouldn't be restricted to just using tGPR, rGPR looks like the best fit.

samtebbs updated this revision to Diff 218347.Mon, Sep 2, 5:55 AM
samtebbs marked an inline comment as done.
samparker accepted this revision.Mon, Sep 2, 7:19 AM

I'm wondering how we'd use the signed versions... but this LGTM.

This revision is now accepted and ready to land.Mon, Sep 2, 7:19 AM
Closed by commit rL370704: [ARM] Select vmla (authored by samtebbs, committed by ). · Explain WhyTue, Sep 3, 1:19 AM
This revision was automatically updated to reflect the committed changes.