Page MenuHomePhabricator

[ARM] Select vmla

Authored by samtebbs on Aug 15 2019, 8:17 AM.

Diff Detail


Event Timeline

samtebbs created this revision.Aug 15 2019, 8:17 AM
dmgreen added inline comments.Aug 19 2019, 1:36 AM
3769 ↗(On Diff #215405)

MQPR :) Can you also try to format this line to be a little shorter.

1 ↗(On Diff #215405)

Can you move this to test/CodeGen/Thumb2/mve-vmla.ll

11 ↗(On Diff #215405)

Do these still select if the operands are reversed? It may be worth adding a few tests to show that.

samtebbs updated this revision to Diff 218314.Sep 2 2019, 2:14 AM
samtebbs marked 3 inline comments as done.
samparker added inline comments.Sep 2 2019, 5:36 AM
3784 ↗(On Diff #218314)

We shouldn't be restricted to just using tGPR, rGPR looks like the best fit.

samtebbs updated this revision to Diff 218347.Sep 2 2019, 5:55 AM
samtebbs marked an inline comment as done.
samparker accepted this revision.Sep 2 2019, 7:19 AM

I'm wondering how we'd use the signed versions... but this LGTM.

This revision is now accepted and ready to land.Sep 2 2019, 7:19 AM
This revision was automatically updated to reflect the committed changes.