This is an archive of the discontinued LLVM Phabricator instance.

Differential D64657

Fix missing use of defined() in include guard in AMDGPU target
ClosedPublic

Authored by daltenty on Jul 12 2019, 12:09 PM.

Details

Reviewers
jasonliu
andusy
hubert.reinterpretcast
sfertile
arsenm
Commits
rGae79a2c3900c: Fix missing use of defined() in include guard
rL365952: Fix missing use of defined() in include guard
Summary

Missing defined in preprocessor expression causes breakage when building with _XOPEN_SOURCE defined

Diff Detail

Event Timeline

daltenty created this revision.Jul 12 2019, 12:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 12 2019, 12:09 PM
Herald added subscribers: llvm-commits, hiraditya, nhaehnle and 2 others. · View Herald Transcript
Harbormaster completed remote builds in B34893: Diff 209557.Jul 12 2019, 12:09 PM
daltenty retitled this revision from Fix missing use of defined() in include guard to Fix missing use of defined() in include guard in AMDGPU target.Jul 12 2019, 12:14 PM
daltenty edited the summary of this revision. (Show Details)
daltenty added reviewers: jasonliu, andusy, hubert.reinterpretcast, sfertile.
Herald added subscribers: t-tye, tpr, dstuttard and 3 others. · View Herald TranscriptJul 12 2019, 12:14 PM
arsenm accepted this revision.Jul 12 2019, 12:19 PM
This revision is now accepted and ready to land.Jul 12 2019, 12:19 PM
Closed by commit rL365952: Fix missing use of defined() in include guard (authored by daltenty). · Explain WhyJul 12 2019, 1:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
2 lines

Diff 209557

llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp

Show First 20 Lines • Show All 859 Lines • ▼ Show 20 Lines if ((CF0 && CF1) || // both are constants
replaceCall(nval); replaceCall(nval);
return true; return true;
} }
return false; return false;
} }
namespace llvm { namespace llvm {
static double log2(double V) { static double log2(double V) {
#if _XOPEN_SOURCE >= 600 || _ISOC99_SOURCE || _POSIX_C_SOURCE >= 200112L #if _XOPEN_SOURCE >= 600 || defined(_ISOC99_SOURCE) || _POSIX_C_SOURCE >= 200112L
return ::log2(V); return ::log2(V);
#else #else
return log(V) / 0.693147180559945309417; return log(V) / 0.693147180559945309417;
#endif #endif
} }
} }
bool AMDGPULibCalls::fold_pow(CallInst *CI, IRBuilder<> &B, bool AMDGPULibCalls::fold_pow(CallInst *CI, IRBuilder<> &B,
▲ Show 20 Lines • Show All 931 Lines • Show Last 20 Lines