This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Lower SALU min/max to cmp+select
ClosedPublic

Authored by arsenm on Jun 28 2019, 7:40 PM.

Details

Summary

Use a change observer to apply a register bank to the newly created intermediate result register.

Diff Detail

Event Timeline

arsenm created this revision.Jun 28 2019, 7:40 PM

This change makes a pretty significant implicit design change that I don't agree with. It doesn't seem right that the legalizer routines should have to know about regbanks or how to propagate them. I think the two passes should remain separate, an opt-in change observer seems like the better approach here.

arsenm updated this revision to Diff 207282.Jul 1 2019, 5:52 AM

Use observer

arsenm retitled this revision from GlobalISel: Try to propagate the register bank in LegalizerHelper to AMDGPU/GlobalISel: Lower SALU min/max to cmp+select.Jul 1 2019, 10:43 AM
arsenm edited the summary of this revision. (Show Details)
aemerson accepted this revision.Jul 1 2019, 11:06 AM

I don't know AMDGPU but the code changes seem ok now.

This revision is now accepted and ready to land.Jul 1 2019, 11:06 AM
arsenm closed this revision.Jul 1 2019, 11:18 AM

r364827