Page MenuHomePhabricator
Differential D62691

[DAGCombine] ((c1-A)-c2) -> ((c1-c2)-A) constant-fold
ClosedPublic
Actions

Authored by lebedev.ri on May 30 2019, 10:18 AM.

Details

Reviewers
t.p.northover
RKSimon
spatel
craig.topper
Commits
rG7eb8b5b5ddb4: [DAGCombine] ((c1-A)-c2) -> ((c1-c2)-A) constant-fold
rL362135: [DAGCombine] ((c1-A)-c2) -> ((c1-c2)-A) constant-fold
Summary

https://rise4fun.com/Alive/B0A

Diff Detail

Repository
rL LLVM

Event Timeline

lebedev.ri created this revision.May 30 2019, 10:18 AM
Herald added a subscriber: javed.absar. · View Herald TranscriptMay 30 2019, 10:18 AM
lebedev.ri added a parent revision: D62689: [DAGCombine] (A-C1)-C2 -> A-(C1+C2) constant-fold.May 30 2019, 10:18 AM
lebedev.ri added a comment.May 30 2019, 10:23 AM

As far as i can tell right now, this is the last missing constant-fold for add/sub combinations.

lebedev.ri added a child revision: D62223: [DAGCombiner][X86][AArch64][AMDGPU] (x + C) - y -> (x - y) + C fold.May 30 2019, 10:26 AM
RKSimon accepted this revision.May 30 2019, 11:13 AM

LGTM

This revision is now accepted and ready to land.May 30 2019, 11:13 AM
Closed by commit rL362135: [DAGCombine] ((c1-A)-c2) -> ((c1-c2)-A) constant-fold (authored by lebedevri). · Explain WhyMay 30 2019, 12:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
llvm/
trunk/
lib/
CodeGen/
SelectionDAG/
10 lines
test/
CodeGen/
AArch64/
13 lines
X86/
37 lines

Diff 202274

View Options

llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

Loading...
View Options

llvm/trunk/test/CodeGen/AArch64/addsub-constant-folding.ll

Loading...
View Options

llvm/trunk/test/CodeGen/X86/addsub-constant-folding.ll

Loading...